@things-factory/organization 10.1.84 → 10.1.86

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@things-factory/organization",
-  "version": "10.1.84",
+  "version": "10.1.86",
   "main": "dist-server/index.js",
   "browser": "dist-client/index.js",
   "things-factory": true,
@@ -41,5 +41,5 @@
     "@things-factory/contact": "^10.1.79",
     "@things-factory/shell": "^10.1.79"
   },
-  "gitHead": "12df439ce09de2bc9aa87d4578766f46bfad48fd"
+  "gitHead": "8e56ed31b1c81934257f2938b9b1a51f1852773f"
 }

package/tests/department-selector.test.ts

@@ -0,0 +1,32 @@
+import { readFileSync } from 'fs'
+import path from 'path'
+
+/**
+ * The department picker's boxes are headed by the department code, and its popup says what is picked.
+ *
+ * ox-tree-vertical prints `id-property` as the header of every box. Set to the database id, the picker drew
+ * a UUID over each department (09-30, OA). Opened from a grid cell or a filter, the popup was titled
+ * "select item".
+ */
+const read = (file: string) => readFileSync(path.resolve(__dirname, '..', file), 'utf-8')
+
+describe('the department picker', () => {
+  it('heads each box with the department code', () => {
+    const source = read('client/component/department-selector.ts')
+    const tag = source.slice(source.indexOf('<ox-tree-vertical'), source.indexOf('</ox-tree-vertical>'))
+    expect(tag).toMatch(/\sid-property="controlNo"/)
+  })
+
+  it.each(['client/grist-editor/grist-editor-department-object.ts', 'client/filters-form/ox-filter-department-object.ts'])(
+    '%s titles the popup as picking a department',
+    file => {
+      const source = read(file)
+      expect(source.includes("i18next.t('title.select department')")).toBe(true)
+      expect(source.includes('title.select_item')).toBe(false)
+    }
+  )
+
+  it.each(['en', 'ko', 'ja', 'zh', 'ms'])('the title is translated in %s', lang => {
+    expect(JSON.parse(read(`translations/${lang}.json`))['title.select department']).toBeTruthy()
+  })
+})

package/translations/en.json

@@ -81,6 +81,7 @@
   "title.import employee": "import employees",
   "title.lookup system-user": "lookup system user",
   "title.my-approval-line template list": "my approval lines",
+  "title.select department": "select department",
   "title.organization": "organization",
   "title.recipients editor": "recipients editor",
   "title.person-membership": "membership",

package/translations/ja.json

@@ -81,6 +81,7 @@
   "title.import employee": "社員の取り込み",
   "title.lookup system-user": "システムユーザーを検索",
   "title.my-approval-line template list": "自分の決裁ライン",
+  "title.select department": "部署選択",
   "title.organization": "組織",
   "title.recipients editor": "受信者リストの編集",
   "title.person-membership": "所属",

package/translations/ko.json

@@ -81,6 +81,7 @@
   "title.import employee": "직원 가져오기",
   "title.lookup system-user": "시스템 사용자 검색",
   "title.my-approval-line template list": "내 결재선",
+  "title.select department": "부서 선택",
   "title.organization": "조직",
   "title.recipients editor": "수신자 목록 편집",
   "title.person-membership": "소속",

package/translations/ms.json

@@ -81,6 +81,7 @@
   "title.import employee": "import pekerja",
   "title.lookup system-user": "cari pengguna sistem",
   "title.my-approval-line template list": "talian kelulusan saya",
+  "title.select department": "pilih jabatan",
   "title.organization": "organisasi",
   "title.recipients editor": "penyunting penerima",
   "title.person-membership": "keanggotaan",

package/translations/zh.json

@@ -81,6 +81,7 @@
   "title.import employee": "导入员工",
   "title.lookup system-user": "查找系统用户",
   "title.my-approval-line template list": "我的审批线",
+  "title.select department": "选择部门",
   "title.organization": "组织",
   "title.recipients editor": "收件人列表编辑",
   "title.person-membership": "所属",