@things-factory/organization 10.1.233 → 10.1.236

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@things-factory/organization",
-  "version": "10.1.233",
+  "version": "10.1.236",
   "main": "dist-server/index.js",
   "browser": "dist-client/index.js",
   "things-factory": true,
@@ -37,12 +37,12 @@
     "@operato/p13n": "^10.0.0",
     "@operato/popup": "^10.15.0",
     "@operato/shell": "^10.0.0",
-    "@things-factory/auth-base": "^10.1.232",
-    "@things-factory/code-ui": "^10.1.232",
-    "@things-factory/contact": "^10.1.233",
-    "@things-factory/pdf": "^10.1.233",
-    "@things-factory/shell": "^10.1.228",
+    "@things-factory/auth-base": "^10.1.234",
+    "@things-factory/code-ui": "^10.1.234",
+    "@things-factory/contact": "^10.1.236",
+    "@things-factory/pdf": "^10.1.234",
+    "@things-factory/shell": "^10.1.234",
     "exceljs": "4.2.0"
   },
-  "gitHead": "8ce73f35075a23dafe2785eb31735b459659a757"
+  "gitHead": "1560112ae8ae5a5d296b4fce1d5a1be05e30e8c2"
 }

package/tests/assignees-editor-no-role.test.ts

@@ -14,7 +14,7 @@ describe('the assignees editor', () => {
   const source = read('client/component/assignees-editor.ts')
 
   it('does not offer Role as an assignee type', () => {
-    const options = source.match(/options: \[(''[^\]]*)\]/)?.[1] ?? ''
+    const options = source.match(/options: targetTypeOptions\(\[([^\]]*)\]/)?.[1] ?? ''
     expect(options).toMatch(/'Employee'/)
     expect(options).not.toMatch(/'Role'/)
   })
@@ -27,6 +27,6 @@ describe('the assignees editor', () => {
 
 describe('the approval-line editor', () => {
   it('keeps Role', () => {
-    expect(read('client/component/approval-line-items-editor.ts')).toMatch(/options: \['', 'Employee', 'Department', 'Role'/)
+    expect(read('client/component/approval-line-items-editor.ts')).toMatch(/options: targetTypeOptions\(\['Employee', 'Department', 'Role'/)
   })
 })

package/tests/refusals-in-korean.test.ts

@@ -0,0 +1,48 @@
+/*
+ * Inline help audit 2026-10-30: the roster and department doors threw English sentences - 「hiredOn must be a calendar
+ * day in YYYY-MM-DD format」, 「manager not found in this domain: <uuid>」, 「There is no employee <uuid>.」, 「a department
+ * cannot be placed under itself…」 - and the department resolver did not speak refusals. Each is a refusal with its
+ * Korean sentence now, naming the field instead of the property.
+ */
+import { readFileSync, readdirSync } from 'fs'
+import { join } from 'path'
+
+import { toDay } from '../server/service/employee/employee-day'
+
+const ROOT = join(__dirname, '..')
+const read = (file: string) => readFileSync(join(ROOT, file), 'utf8')
+const ko: Record<string, string> = JSON.parse(read('translations/ko.json'))
+
+const sources = (dir: string): string[] =>
+  readdirSync(dir, { withFileTypes: true }).flatMap(entry => (entry.isDirectory() ? sources(join(dir, entry.name)) : /\.ts$/.test(entry.name) && !/\.test\.ts$/.test(entry.name) ? [join(dir, entry.name)] : []))
+const text = sources(join(ROOT, 'server')).map(file => readFileSync(file, 'utf8')).join('\n')
+
+test('★ every refusal the server throws has its Korean sentence', () => {
+  const codes = new Set([...text.matchAll(/new Refusal\(\s*'([a-z0-9-]+)'/g)].map(match => match[1]))
+  for (const what of ['manager', 'supervisor', 'department']) codes.add(`${what}-not-in-domain`)
+  for (const code of ['hired-on-invalid', 'retired-on-invalid']) codes.add(code)
+  expect(codes.size).toBeGreaterThanOrEqual(15)
+  expect([...codes].filter(code => !(`error.${code}` in ko))).toEqual([])
+})
+
+test('★ the reference, day, parent and employee doors throw no English sentence', () => {
+  for (const file of [
+    'server/service/domain-reference.ts',
+    'server/service/employee/employee-day.ts',
+    'server/service/department/department-parent.ts',
+    'server/service/employee/employee-mutation.ts',
+    'server/service/employee-profile/employee-profile-query.ts'
+  ]) {
+    expect({ file, english: read(file).match(/throw new Error\(\s*['`][A-Za-z][^'`]*['`]/g) ?? [] }).toEqual({ file, english: [] })
+  }
+})
+
+test('★ a day that is not a day is refused by its field, in words', () => {
+  expect(() => toDay('hiredOn', '2026-02-30')).toThrow(expect.objectContaining({ code: 'hired-on-invalid', params: { value: '2026-02-30' } }))
+  expect(ko['error.hired-on-invalid']).toContain('입사일')
+})
+
+test('★ the department and employee-profile resolvers speak their refusals', () => {
+  expect(read('server/service/department/department-mutation.ts')).toMatch(/@Resolver\(Department\)\n@UseMiddleware\(SpeakRefusals\)/)
+  expect(read('server/service/employee-profile/employee-profile-query.ts')).toMatch(/@Resolver\(EmployeeProfile\)\n@UseMiddleware\(SpeakRefusals\)/)
+})

package/translations/en.json

@@ -194,5 +194,17 @@
   "error.employee-not-found": "The employee was not found.",
   "button.issue-employment-certificate": "Issue employment certificate",
   "button.issue-career-certificate": "Issue career certificate",
-  "text.select-one-employee": "Select one employee"
+  "text.select-one-employee": "Select one employee",
+  "error.employee-control-no-required": "Enter the employee number.",
+  "error.employee-control-no-taken": "Employee number {value} is already another employee's.",
+  "error.approval-line-approver-required": "Choose the approver on row {row}.",
+  "error.manager-not-in-domain": "The manager chosen is not in this domain. Choose again.",
+  "error.supervisor-not-in-domain": "The supervisor chosen is not in this domain. Choose again.",
+  "error.department-not-in-domain": "The department chosen is not in this domain. Choose again.",
+  "error.user-not-in-domain": "The user chosen is not a user of this domain. Choose one of this domain.",
+  "error.hired-on-invalid": "The hire date is a day written as 2026-01-31. Received: {value}",
+  "error.retired-on-invalid": "The leaving date is a day written as 2026-01-31. Received: {value}",
+  "error.department-parent-not-found": "The parent department chosen is not in this domain. Choose again.",
+  "error.department-parent-loop": "A department cannot be placed under itself or under one of its own sub-departments.",
+  "error.document-language-not-run": "The application does not run the language {language}."
 }

package/translations/es.json

@@ -194,5 +194,17 @@
   "error.employee-not-found": "No se encontró el empleado.",
   "button.issue-employment-certificate": "Emitir certificado de empleo",
   "button.issue-career-certificate": "Emitir certificado de experiencia",
-  "text.select-one-employee": "Seleccione un empleado"
+  "text.select-one-employee": "Seleccione un empleado",
+  "error.employee-control-no-required": "Introduzca el número de empleado.",
+  "error.employee-control-no-taken": "El número de empleado {value} ya lo usa otro empleado.",
+  "error.approval-line-approver-required": "Elija el aprobador de la fila {row}.",
+  "error.manager-not-in-domain": "El responsable elegido no está en este dominio. Elija de nuevo.",
+  "error.supervisor-not-in-domain": "El supervisor elegido no está en este dominio. Elija de nuevo.",
+  "error.department-not-in-domain": "El departamento elegido no está en este dominio. Elija de nuevo.",
+  "error.user-not-in-domain": "El usuario elegido no es de este dominio. Elija uno de este dominio.",
+  "error.hired-on-invalid": "La fecha de alta se escribe como 2026-01-31. Recibido: {value}",
+  "error.retired-on-invalid": "La fecha de baja se escribe como 2026-01-31. Recibido: {value}",
+  "error.department-parent-not-found": "El departamento superior elegido no está en este dominio. Elija de nuevo.",
+  "error.department-parent-loop": "Un departamento no puede ir bajo sí mismo ni bajo uno de sus subdepartamentos.",
+  "error.document-language-not-run": "La aplicación no usa el idioma {language}."
 }

package/translations/ja.json

@@ -194,5 +194,17 @@
   "error.employee-not-found": "社員が見つかりません。",
   "button.issue-employment-certificate": "在職証明書を発行",
   "button.issue-career-certificate": "経歴証明書を発行",
-  "text.select-one-employee": "社員を一人選んでください"
+  "text.select-one-employee": "社員を一人選んでください",
+  "error.employee-control-no-required": "管理番号を入力してください。",
+  "error.employee-control-no-taken": "管理番号 {value} は既に別の社員が使っています。",
+  "error.approval-line-approver-required": "{row}行目の承認者を選んでください。",
+  "error.manager-not-in-domain": "管理者に選んだ社員がこの事業所にいません。選び直してください。",
+  "error.supervisor-not-in-domain": "上司に選んだ社員がこの事業所にいません。選び直してください。",
+  "error.department-not-in-domain": "選んだ部署がこの事業所にありません。選び直してください。",
+  "error.user-not-in-domain": "紐付けるユーザーはこの事業所のユーザーではありません。この事業所のユーザーを選んでください。",
+  "error.hired-on-invalid": "入社日は 2026-01-31 のように日付で入力してください。受け取った値: {value}",
+  "error.retired-on-invalid": "退社日は 2026-01-31 のように日付で入力してください。受け取った値: {value}",
+  "error.department-parent-not-found": "上位部署に選んだ部署がこの事業所にありません。選び直してください。",
+  "error.department-parent-loop": "部署を自分自身や自分の下位部署の下に移すことはできません。",
+  "error.document-language-not-run": "このアプリケーションが使わない言語です: {language}"
 }

package/translations/ko.json

@@ -194,5 +194,17 @@
   "error.employee-not-found": "직원을 찾을 수 없습니다.",
   "button.issue-employment-certificate": "재직증명서 발급",
   "button.issue-career-certificate": "경력증명서 발급",
-  "text.select-one-employee": "직원 한 명을 고르세요"
+  "text.select-one-employee": "직원 한 명을 고르세요",
+  "error.employee-control-no-required": "관리 번호를 입력하세요.",
+  "error.employee-control-no-taken": "관리 번호 {value}은(는) 이미 다른 직원이 쓰고 있습니다.",
+  "error.approval-line-approver-required": "{row}번째 줄에 결재자를 고르세요.",
+  "error.manager-not-in-domain": "관리자로 고른 직원이 이 사업장에 없습니다. 다시 골라 주세요.",
+  "error.supervisor-not-in-domain": "상사로 고른 직원이 이 사업장에 없습니다. 다시 골라 주세요.",
+  "error.department-not-in-domain": "고른 부서가 이 사업장에 없습니다. 다시 골라 주세요.",
+  "error.user-not-in-domain": "연결할 사용자가 이 사업장의 사용자가 아닙니다. 이 사업장의 사용자를 골라 주세요.",
+  "error.hired-on-invalid": "입사일은 2026-01-31 처럼 날짜로 적어 주세요. 받은 값: {value}",
+  "error.retired-on-invalid": "퇴사일은 2026-01-31 처럼 날짜로 적어 주세요. 받은 값: {value}",
+  "error.department-parent-not-found": "상위 부서로 고른 부서가 이 사업장에 없습니다. 다시 골라 주세요.",
+  "error.department-parent-loop": "부서를 자기 자신이나 자기 하위 부서 아래로 옮길 수 없습니다.",
+  "error.document-language-not-run": "이 애플리케이션이 쓰지 않는 언어입니다: {language}"
 }

package/translations/ms.json

@@ -194,5 +194,17 @@
   "error.employee-not-found": "Pekerja tidak ditemui.",
   "button.issue-employment-certificate": "Keluarkan sijil pekerjaan",
   "button.issue-career-certificate": "Keluarkan sijil pengalaman",
-  "text.select-one-employee": "Pilih seorang pekerja"
+  "text.select-one-employee": "Pilih seorang pekerja",
+  "error.employee-control-no-required": "Masukkan nombor pekerja.",
+  "error.employee-control-no-taken": "Nombor pekerja {value} sudah digunakan oleh pekerja lain.",
+  "error.approval-line-approver-required": "Pilih pelulus pada baris {row}.",
+  "error.manager-not-in-domain": "Pengurus yang dipilih tiada dalam domain ini. Pilih semula.",
+  "error.supervisor-not-in-domain": "Penyelia yang dipilih tiada dalam domain ini. Pilih semula.",
+  "error.department-not-in-domain": "Jabatan yang dipilih tiada dalam domain ini. Pilih semula.",
+  "error.user-not-in-domain": "Pengguna yang dipilih bukan pengguna domain ini. Pilih pengguna domain ini.",
+  "error.hired-on-invalid": "Tarikh mula kerja ditulis seperti 2026-01-31. Diterima: {value}",
+  "error.retired-on-invalid": "Tarikh berhenti ditulis seperti 2026-01-31. Diterima: {value}",
+  "error.department-parent-not-found": "Jabatan induk yang dipilih tiada dalam domain ini. Pilih semula.",
+  "error.department-parent-loop": "Jabatan tidak boleh diletakkan di bawah dirinya atau sub-jabatannya sendiri.",
+  "error.document-language-not-run": "Aplikasi ini tidak menggunakan bahasa {language}."
 }

package/translations/zh.json

@@ -194,5 +194,17 @@
   "error.employee-not-found": "找不到员工。",
   "button.issue-employment-certificate": "签发在职证明",
   "button.issue-career-certificate": "签发经历证明",
-  "text.select-one-employee": "请选择一名员工"
+  "text.select-one-employee": "请选择一名员工",
+  "error.employee-control-no-required": "请输入员工编号。",
+  "error.employee-control-no-taken": "员工编号 {value} 已被其他员工使用。",
+  "error.approval-line-approver-required": "请为第 {row} 行选择审批人。",
+  "error.manager-not-in-domain": "所选管理者不在此域中。请重新选择。",
+  "error.supervisor-not-in-domain": "所选上级不在此域中。请重新选择。",
+  "error.department-not-in-domain": "所选部门不在此域中。请重新选择。",
+  "error.user-not-in-domain": "所选用户不是此域的用户。请选择此域的用户。",
+  "error.hired-on-invalid": "入职日期请按 2026-01-31 的格式填写。收到的值: {value}",
+  "error.retired-on-invalid": "离职日期请按 2026-01-31 的格式填写。收到的值: {value}",
+  "error.department-parent-not-found": "所选上级部门不在此域中。请重新选择。",
+  "error.department-parent-loop": "部门不能放在自身或其下级部门之下。",
+  "error.document-language-not-run": "此应用不支持该语言: {language}"
 }