@things-factory/organization 10.1.229 → 10.1.230

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@things-factory/organization",
-  "version": "10.1.229",
+  "version": "10.1.230",
   "main": "dist-server/index.js",
   "browser": "dist-client/index.js",
   "things-factory": true,
@@ -43,5 +43,5 @@
     "@things-factory/shell": "^10.1.228",
     "exceljs": "4.2.0"
   },
-  "gitHead": "df6361882dc166ef3f8bd54492113253c802f879"
+  "gitHead": "27f533e9f72834aac95fd6e7287e5ae1862164da"
 }

package/tests/employee-profile-db.test.ts

@@ -123,6 +123,20 @@ describe("an employee's own profile", () => {
     expect(await dataSource.getRepository(organization.EmployeeProfile).count()).toBe(1)
   })
 
+  it('★ read back newest first, as written by its end - the stored rows keep the order written', async () => {
+    const lee = await person('lee')
+    const saved = await ask(lee, SAVE, {
+      profile: {
+        projects: [{ name: 'old', startedOn: '2015-01', endedOn: '2016-01' }, { name: 'now', startedOn: '2024-01' }, { name: 'mid', startedOn: '2019-01', endedOn: '2021-06' }]
+      }
+    })
+    expect(saved.errors).toBeUndefined()
+    expect(saved.data.saveMyEmployeeProfile.projects.map((row: any) => row.name)).toEqual(['now', 'mid', 'old'])
+    expect((await ask(lee, MINE)).data.myEmployeeProfile.projects.map((row: any) => row.name)).toEqual(['now', 'mid', 'old'])
+    const [stored] = await dataSource.query(`SELECT projects FROM employee_profiles WHERE deleted_at IS NULL ORDER BY updated_at DESC LIMIT 1`)
+    expect(JSON.parse(stored.projects).map((row: any) => row.name)).toEqual(['old', 'now', 'mid'])
+  })
+
   it('★ adding from a résumé takes nothing away, and reaches only one\'s own', async () => {
     const kim = await person('kim')
     const park = await person('park')

package/tests/employee-profile-document.test.ts

@@ -10,7 +10,6 @@ import {
   taglineOf,
   dotted,
   layoutHtml,
-  newestFirst,
   periodOf,
   profileFileName,
   profileFooterHtml,
@@ -24,6 +23,7 @@ import {
   sheetNamesOf,
   type ProfileSheetWords
 } from '../server/service/employee-profile/employee-profile-document'
+import { inShowingOrder, newestFirst } from '../server/service/employee-profile/employee-profile-rules'
 
 /** The profiles a quotation attaches - one layout, painted as Excel and as HTML for PDF (ADR-0169 decision 5). */
 const COUNTS: Record<string, (...args: number[]) => string> = {
@@ -124,6 +124,15 @@ describe('one layout of a staffing profile', () => {
     expect(newestFirst([{ name: 'old', acquiredOn: '2015-05-01' }, { name: 'new', acquiredOn: '2023-01-10' }]).map(row => row.name)).toEqual(['new', 'old'])
   })
 
+  it('★ a profile is shown in that order wherever it is read - put in it as it is loaded, the stored order untouched', () => {
+    const profile = inShowingOrder({ careers: [{ company: 'old', startedOn: '2001-01', endedOn: '2005-01' }, { company: 'now', startedOn: '2010-01' }], projects: null as any, skills: ['b', 'a'] } as any)
+    expect(profile.careers.map((row: any) => row.company)).toEqual(['now', 'old'])
+    expect(profile.projects).toBeNull()
+    expect(profile.skills).toEqual(['b', 'a'])
+    const entity = require('fs').readFileSync(require('path').join(__dirname, '../server/service/employee-profile/employee-profile.ts'), 'utf8')
+    expect(entity).toMatch(/^  @AfterLoad\(\)\n  showNewestFirst\(\) \{\n    inShowingOrder\(this\)/m)
+  })
+
   it('★ every dated table of the page reads newest first', () => {
     const person = {
       ...KIM,