@things-factory/operato-wms 4.3.795 → 4.3.797

package/client/pages/outbound/picking-product.js

@@ -7,6 +7,7 @@ import '../components/worksheet-information-popup'
 import './serial-number-popup'
 import './tote-popup'
 import './vas-list-popup'
+import './picking-same-carton-popup'
 
 import gql from 'graphql-tag'
 import { css, html } from 'lit-element'
@@ -1311,14 +1312,27 @@ class PickingProduct extends connect(store)(localize(i18next)(PageView)) {
         const scannedCartonId = this.cartonInput.value.trim()
         if (scannedCartonId) {
           let candidates = (this.data?.records || []).filter(
-            rec => rec.cartonId === scannedCartonId && rec.status !== 'DONE' && rec.status !== 'MISSING'
+            rec =>
+              rec.cartonId === scannedCartonId &&
+              rec.status !== 'DONE' &&
+              rec.status !== 'MISSING' &&
+              !rec.completed &&
+              rec.pickedQty < rec.releaseQty
           )
-          candidates = this._filterCandidatesByInputQty(candidates)
-
           // Validate carton id: must have at least one candidate
           if (!candidates || candidates.length === 0) {
             this._focusOnCartonNoInput()
-            throw new Error(i18next.t('text.invalid_carton_id'))
+            const hasFullyPickedForCarton = (this.data?.records || []).some(
+              rec =>
+                rec.cartonId === scannedCartonId &&
+                rec.status !== 'DONE' &&
+                rec.status !== 'MISSING' &&
+                !rec.completed &&
+                rec.pickedQty >= rec.releaseQty
+            )
+            throw new Error(
+              i18next.t(hasFullyPickedForCarton ? 'text.qty_exceed_release_qty' : 'text.invalid_carton_id')
+            )
           }
 
           if (this._enableProductScanning) {
@@ -1328,11 +1342,14 @@ class PickingProduct extends connect(store)(localize(i18next)(PageView)) {
               throw new Error(i18next.t('text.empty_product_barcode'))
             }
 
+            this._popupCancelled = false
             const matchedRecord = await this._selectRecordByGtinFromCandidates(
               this.productBarcodeInput.value.trim(),
               candidates
             )
 
+            if (this._popupCancelled) return { value: false }
+
             if (!matchedRecord) {
               this._focusOnProductBarcodeInput()
               this.productBarcodeInput.value = ''
@@ -1345,7 +1362,7 @@ class PickingProduct extends connect(store)(localize(i18next)(PageView)) {
             }
           } else {
             // Product scanning disabled: pick a deterministic candidate
-            const matchedRecord = this._pickBestCandidate(candidates)
+            const matchedRecord = this._pickBestCandidate(this._filterCandidatesByInputQty(candidates))
             if (
               matchedRecord &&
               (!this._selectedOrderInventory || this._selectedOrderInventory.name !== matchedRecord.name)
@@ -1409,14 +1426,36 @@ class PickingProduct extends connect(store)(localize(i18next)(PageView)) {
           if (this._pageSettings.enablePickingRandomSeq == true) {
             let cartonInputValue = this.cartonInput.value
             let candidates = this.data.records.filter(
-              rec => rec.cartonId === cartonInputValue && rec.status !== 'DONE' && rec.status !== 'MISSING'
+              rec =>
+                rec.cartonId === cartonInputValue &&
+                rec.status !== 'DONE' &&
+                rec.status !== 'MISSING' &&
+                !rec.completed &&
+                rec.pickedQty < rec.releaseQty
             )
-            candidates = this._filterCandidatesByInputQty(candidates)
+            // If no candidates remain, check if it's because all matching items are already fully picked
+            if (!candidates.length) {
+              const hasFullyPickedForCarton = this.data.records.some(
+                rec =>
+                  rec.cartonId === cartonInputValue &&
+                  rec.status !== 'DONE' &&
+                  rec.status !== 'MISSING' &&
+                  !rec.completed &&
+                  rec.pickedQty >= rec.releaseQty
+              )
+              if (hasFullyPickedForCarton) {
+                this._focusOnCartonNoInput()
+                throw new Error(i18next.t('text.qty_exceed_release_qty'))
+              }
+            }
+
             if (this._enableProductScanning && this.productBarcodeInput?.value) {
+              this._popupCancelled = false
               foundRecord = await this._selectRecordByGtinFromCandidates(
                 this.productBarcodeInput.value.trim(),
                 candidates
               )
+              if (this._popupCancelled) return { value: false }
             }
             // If product barcode is provided but no GTIN match, stop without fallback
             if (this._enableProductScanning && this.productBarcodeInput?.value && !foundRecord) {
@@ -1427,7 +1466,7 @@ class PickingProduct extends connect(store)(localize(i18next)(PageView)) {
 
             // No product barcode: deterministically choose best candidate among duplicates
             if (!foundRecord && (!this._enableProductScanning || !this.productBarcodeInput?.value)) {
-              foundRecord = this._pickBestCandidate(candidates)
+              foundRecord = this._pickBestCandidate(this._filterCandidatesByInputQty(candidates))
             }
 
             if (foundRecord) {
@@ -2486,7 +2525,9 @@ class PickingProduct extends connect(store)(localize(i18next)(PageView)) {
   _filterCandidatesByInputQty(candidates) {
     const typedQty = this._getTypedQty()
     if (!typedQty || !Array.isArray(candidates) || !candidates.length) return candidates
-    const matches = candidates.filter(rec => parseFloat(rec?.releaseQty) === typedQty)
+    const matches = candidates.filter(
+      rec => (parseFloat(rec?.releaseQty) - parseFloat(rec?.pickedQty ?? 0)) === typedQty
+    )
     return matches.length ? matches : candidates
   }
 
@@ -2521,9 +2562,6 @@ class PickingProduct extends connect(store)(localize(i18next)(PageView)) {
     try {
       if (!gtin || !candidates?.length) return null
 
-      // Apply qty-based narrowing first when duplicates exist
-      candidates = this._filterCandidatesByInputQty(candidates)
-
       // Use checkGtin to resolve product-packing info to match candidate rows
       const response = await client.query({
         query: gql`
@@ -2563,16 +2601,77 @@ class PickingProduct extends connect(store)(localize(i18next)(PageView)) {
             itm.packingSize === rec.packingSize
         )
       )
-      if (exactMatches.length) return this._pickBestCandidate(exactMatches)
+      if (exactMatches.length) return await this._pickBestCandidateOrShowPopup(exactMatches)
 
       const productOnlyMatches = candidates.filter(rec => items.some(itm => itm.product?.id === rec?.product?.id))
-      if (productOnlyMatches.length) return this._pickBestCandidate(productOnlyMatches)
+      if (productOnlyMatches.length) return await this._pickBestCandidateOrShowPopup(productOnlyMatches)
 
       return null
     } catch (e) {
       return null
     }
   }
+
+  _hasDuplicateSameProduct(candidates) {
+    return this._getDuplicateSameProductRows(candidates).length > 0
+  }
+
+  _getDuplicateSameProductRows(candidates) {
+    if (!Array.isArray(candidates) || candidates.length <= 1) return []
+
+    // Group by cartonId + SKU, return only rows that belong to a duplicate group
+    const groups = {}
+    candidates.forEach(c => {
+      const key = `${c?.cartonId || ''}|${c?.product?.sku || ''}`
+      if (!groups[key]) groups[key] = []
+      groups[key].push(c)
+    })
+
+    const duplicateRows = []
+    for (const rows of Object.values(groups)) {
+      if (rows.length > 1) duplicateRows.push(...rows)
+    }
+    return duplicateRows
+  }
+
+  _showPickingSameCartonPopup(candidates) {
+    return new Promise(resolve => {
+      openPopup(
+        html`
+          <picking-same-carton-popup
+            .pickingInventories="${candidates}"
+            @selection="${e => {
+              resolve(e.detail)
+            }}"
+          ></picking-same-carton-popup>
+        `,
+        {
+          backdrop: true,
+          size: 'large',
+          title: i18next.t('title.inventory_selection')
+        }
+      )
+    })
+  }
+
+  async _pickBestCandidateOrShowPopup(candidates) {
+    if (!Array.isArray(candidates) || !candidates.length) return null
+
+    // If multiple candidates have the same cartonId + SKU, show popup for user to choose
+    const duplicateRows = this._getDuplicateSameProductRows(candidates)
+    if (duplicateRows.length) {
+      const selectedRecord = await this._showPickingSameCartonPopup(duplicateRows)
+      if (!selectedRecord) {
+        // User cancelled the popup — signal callers to do nothing
+        this._popupCancelled = true
+        return null
+      }
+      return selectedRecord
+    }
+
+    // Otherwise, use the existing logic to pick the best candidate
+    return this._pickBestCandidate(candidates)
+  }
 }
 
 window.customElements.define('picking-product', PickingProduct)

package/client/pages/outbound/picking-same-carton-popup.js

@@ -0,0 +1,217 @@
+import '@things-factory/grist-ui'
+
+import { css, html, LitElement } from 'lit-element'
+import { connect } from 'pwa-helpers/connect-mixin'
+
+import { SingleColumnFormStyles } from '@things-factory/form-ui'
+import { i18next, localize } from '@things-factory/i18n-base'
+import { store } from '@things-factory/shell'
+import { isMobileDevice } from '@things-factory/utils'
+
+class PickingSameCartonPopup extends connect(store)(localize(i18next)(LitElement)) {
+  static get properties() {
+    return {
+      config: Object,
+      data: Object,
+      pickingInventories: Array
+    }
+  }
+
+  constructor() {
+    super()
+  }
+
+  static get styles() {
+    return [
+      SingleColumnFormStyles,
+      css`
+        .button-container {
+          padding: 10px 0 12px 0;
+          text-align: center;
+        }
+        .button-container mwc-button {
+          margin: 0 5px;
+        }
+        data-grist {
+          overflow-y: hidden;
+          flex: 1;
+        }
+        .grist {
+          display: flex;
+          flex-direction: column;
+          flex: 1;
+          overflow-y: auto;
+        }
+        :host {
+          padding: 10px;
+          display: flex;
+          flex-direction: column;
+          overflow: hidden;
+          background-color: white;
+        }
+        .header {
+          padding: 10px;
+          font-weight: bold;
+          font-size: 14px;
+          color: var(--secondary-color);
+          border-bottom: 1px solid var(--secondary-color);
+          margin-bottom: 10px;
+        }
+      `
+    ]
+  }
+
+  get dataGrist() {
+    return this.shadowRoot.querySelector('data-grist')
+  }
+
+  updated(changeProps) {
+    if (changeProps.has('pickingInventories')) {
+      if (this.pickingInventories && this.pickingInventories.length) {
+        this.data = {
+          records: this.pickingInventories.map(inv => ({
+            ...inv,
+            locationName: inv.location?.name || ''
+          }))
+        }
+      }
+    }
+  }
+
+  render() {
+    return html`
+      <div class="header">
+        ${i18next.t('text.please_select_an_inventory')}
+      </div>
+
+      <div class="grist">
+        <data-grist
+          id="grist"
+          .mode=${isMobileDevice() ? 'LIST' : 'GRID'}
+          .config=${this.config}
+          .data="${this.data}"
+        ></data-grist>
+      </div>
+
+      <div class="button-container">
+        <mwc-button
+          raised
+          @click="${this._selectPickingInventory.bind(this)}"
+          label="${i18next.t('button.select')}"
+        ></mwc-button>
+        <mwc-button
+          @click="${() => {
+            this.dispatchEvent(new CustomEvent('selection', { detail: null }))
+            history.back()
+          }}"
+          label="${i18next.t('button.cancel')}"
+        ></mwc-button>
+      </div>
+    `
+  }
+
+  firstUpdated() {
+    this.config = {
+      pagination: { infinite: true },
+      rows: { selectable: { multiple: false }, appendable: false },
+      list: {
+        fields: [
+          'locationName',
+          'palletId',
+          'batchId',
+          'batchIdRef',
+          'expirationDate',
+          'qty',
+          'releaseQty',
+          'packingType'
+        ]
+      },
+      columns: [
+        { type: 'gutter', gutterName: 'sequence' },
+        { type: 'gutter', gutterName: 'row-selector', multiple: false, header: { renderer: () => '' } },
+        { name: 'name', hidden: true },
+        {
+          type: 'string',
+          name: 'locationName',
+          label: true,
+          header: i18next.t('field.location'),
+          width: 120
+        },
+        {
+          type: 'string',
+          name: 'palletId',
+          label: true,
+          header: i18next.t('field.pallet_id'),
+          width: 120
+        },
+        {
+          type: 'string',
+          name: 'batchId',
+          label: true,
+          header: i18next.t('field.batch_no'),
+          width: 100
+        },
+        {
+          type: 'string',
+          name: 'batchIdRef',
+          label: true,
+          header: i18next.t('field.lot_id'),
+          width: 100
+        },
+        {
+          type: 'date',
+          name: 'expirationDate',
+          label: true,
+          header: i18next.t('field.expiration'),
+          width: 100
+        },
+        {
+          type: 'float',
+          name: 'qty',
+          label: true,
+          header: i18next.t('field.available_qty'),
+          width: 80
+        },
+        {
+          type: 'float',
+          name: 'releaseQty',
+          label: true,
+          header: i18next.t('field.release_qty'),
+          width: 80
+        },
+        {
+          type: 'string',
+          name: 'packingType',
+          label: true,
+          header: i18next.t('field.packing_type'),
+          width: 100
+        }
+      ]
+    }
+  }
+
+  async _selectPickingInventory() {
+    try {
+      const selectedInventory = this.dataGrist.selected[0]
+      if (!selectedInventory) throw new Error(i18next.t('text.please_select_inventory'))
+
+      this.dispatchEvent(new CustomEvent('selection', { detail: selectedInventory }))
+      history.back()
+    } catch (e) {
+      this._showToast(e)
+    }
+  }
+
+  _showToast({ type, message }) {
+    document.dispatchEvent(
+      new CustomEvent('notify', {
+        detail: {
+          type,
+          message
+        }
+      })
+    )
+  }
+}
+
+window.customElements.define('picking-same-carton-popup', PickingSameCartonPopup)

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@things-factory/operato-wms",
-  "version": "4.3.795",
+  "version": "4.3.797",
   "main": "dist-server/index.js",
   "browser": "client/index.js",
   "things-factory": true,
@@ -108,7 +108,7 @@
     "@things-factory/transport-base": "^4.3.767",
     "@things-factory/tutorial-ui": "^4.3.767",
     "@things-factory/warehouse-base": "^4.3.791",
-    "@things-factory/worksheet-base": "^4.3.795"
+    "@things-factory/worksheet-base": "^4.3.797"
   },
   "devDependencies": {
     "@things-factory/builder": "^4.3.767",
@@ -117,5 +117,5 @@
     "cypress-localstorage-commands": "^1.6.1",
     "eslint-plugin-cypress": "^2.12.1"
   },
-  "gitHead": "8159de8fb17815c04d55e515316e41bb226f1450"
+  "gitHead": "1acd354f47dfc15a5670841ddfb51e338f61d15f"
 }