@things-factory/operato-wms 4.3.789 → 4.3.790

package/client/pages/inventory/inventory-adjustment.js

@@ -1304,56 +1304,107 @@ class InventoryAdjustment extends connect(store)(localize(i18next)(PageView)) {
     try {
       patches = patches.map(patch => normalizeInventoryPatch(patch))
 
-      patches.map(itm => {
+      const validAdjustmentCodes = new Set(
+        Object.values(ADJUSTMENT_CODE).map(ac => ac.value)
+      )
+
+      // Fetch fresh locations for client-side validation (avoid stale cache)
+      await this.fetchLocation()
+      const locationNameSet = new Set((this._locations || []).map(l => l.name))
+
+      patches.forEach(itm => {
+        const errors = []
+        delete itm.errMsg
+
         if (toFloatOrUndefined(itm?.uomValue) < 0) {
-          throw new Error(i18next.t('text.invalid_uom_value'))
+          errors.push(i18next.t('text.invalid_uom_value'))
         }
         if (toFloatOrUndefined(itm?.qty) < 0) {
-          throw new Error(i18next.t('text.invalid_qty'))
+          errors.push(i18next.t('text.invalid_qty'))
         }
         if (itm?.packingType?.trim() == '') {
-          throw new Error(i18next.t('text.invalid_packing_type'))
+          errors.push(i18next.t('text.invalid_packing_type'))
         }
         if (toFloatOrUndefined(itm?.unitCost) < 0) {
-          throw new Error(i18next.t('text.invalid_unit_cost'))
+          errors.push(i18next.t('text.invalid_unit_cost'))
         }
         if (new Date(itm?.manufactureDate) > new Date()) {
-          throw new Error(i18next.t('text.invalid_manufacture_date'))
+          errors.push(i18next.t('text.invalid_manufacture_date'))
         }
-        if (
-          itm?.adjustmentCode?.trim() == '' ||
-          (itm?.adjustmentCode?.trim() != ADJUSTMENT_CODE.AC01.value &&
-            itm?.adjustmentCode?.trim() != ADJUSTMENT_CODE.AC02.value &&
-            itm?.adjustmentCode?.trim() != ADJUSTMENT_CODE.AC03.value &&
-            itm?.adjustmentCode?.trim() != ADJUSTMENT_CODE.AC04.value &&
-            itm?.adjustmentCode?.trim() != ADJUSTMENT_CODE.AC05.value &&
-            itm?.adjustmentCode?.trim() != ADJUSTMENT_CODE.AC06.value &&
-            itm?.adjustmentCode?.trim() != ADJUSTMENT_CODE.AC07.value)
-        ) {
-          throw new Error(i18next.t('text.adjustment_code_is_required_kindly_fill_in_the_adjustment_code_to_continue'))
+        if (!itm?.adjustmentCode?.trim() || !validAdjustmentCodes.has(itm.adjustmentCode.trim())) {
+          errors.push(i18next.t('text.adjustment_code_is_required_kindly_fill_in_the_adjustment_code_to_continue'))
         }
         if (itm?.adjustmentNote?.trim() == '') {
-          throw new Error(i18next.t('text.invalid_adjustment_note'))
+          errors.push(i18next.t('text.invalid_adjustment_note'))
+        }
+
+        // Validate location for all rows
+        if (!itm?.location || !itm?.location?.name) {
+          errors.push(i18next.t('text.location_is_required_kindly_fill_in_the_location_to_continue'))
+        } else if (!locationNameSet.has(itm.location.name)) {
+          errors.push(`${i18next.t('text.location_not_found')}: ${itm.location.name}`)
         }
 
         if (itm.cuFlag == '+') {
-          this.validation(itm)
+          if (!itm?.batchId) {
+            errors.push(i18next.t('text.batch_no_is_required_kindly_fill_in_the_batch_no_to_continue'))
+          }
+          if (!itm?.bizplace || !itm?.bizplace?.id) {
+            errors.push(i18next.t('text.company_is_required_kindly_fill_in_the_company_to_continue'))
+          }
+          if (!itm?.qty) {
+            errors.push(i18next.t('text.qty_is_required_kindly_fill_in_the_qty_to_continue'))
+          }
+          if (!itm?.uomValue) {
+            errors.push(i18next.t('text.total_uom_value_is_required_kindly_fill_in_the_total_uom_value_to_continue'))
+          }
+          if (!itm?.adjustmentCode) {
+            // already checked above, but keep for cuFlag '+' specific check
+          }
+          if (!itm?.adjustmentNote) {
+            errors.push(i18next.t('text.adjustment_note_is_required_kindly_fill_in_the_adjustment_note_to_continue'))
+          }
 
           if (!itm.sku) {
-            throw new Error(i18next.t('text.sku_is_required_kindly_fill_in_the_sku_to_continue'))
+            errors.push(i18next.t('text.sku_is_required_kindly_fill_in_the_sku_to_continue'))
           }
 
           if (itm.qty < 0 || itm.unitCost < 0 || itm.uomValue < 0) {
-            throw new Error(i18next.t('text.invalid_value_in_list'))
+            errors.push(i18next.t('text.invalid_value_in_list'))
           }
 
           if (
             itm.manufactureDate &&
             (itm.manufactureDate.getFullYear < 1000 || itm.manufactureDate.getTime > new Date().getTime)
           ) {
-            throw new Error(i18next.t('text.invalid_value_in_list'))
+            errors.push(i18next.t('text.invalid_value_in_list'))
+          }
+        }
+
+        if (itm.serialNumbers) {
+          let serialNumbers = itm.serialNumbers
+          itm.serialNumbers = serialNumbers.replace(' ', '')
+
+          if (itm.serialNumbers.split(',').length != itm.qty) {
+            errors.push(i18next.t('text.serial_number_not_tally_with_qty'))
           }
         }
+
+        if (errors.length) {
+          itm.errMsg = errors.join('; ')
+        }
+      })
+
+      const hasErrors = patches.some(p => p.errMsg)
+      if (hasErrors) {
+        return patches
+      }
+
+      // Save original patches for error display if the server mutation fails
+      const originalPatches = patches.map(p => ({ ...p }))
+
+      // All validations passed — apply transformations and submit
+      patches.forEach(itm => {
         itm.qty = toFloatOrUndefined(itm.qty)
         itm.packingSize = toFloatOrUndefined(itm.packingSize)
         itm.uomValue = toFloatOrUndefined(itm.uomValue)
@@ -1365,19 +1416,14 @@ class InventoryAdjustment extends connect(store)(localize(i18next)(PageView)) {
         }
         if (itm.unitCost != null) {
           itm.unitCost = toFloatOrUndefined(itm.unitCost)
-          if (isNaN(itm.unitCost)) {
-            throw new Error(i18next.t('text.invalid_unit_cost'))
-          }
         }
 
-        if (itm.location.zone || itm.location.row || itm.location.column) {
-          //if user repic location after import
+        if (itm.location && (itm.location.zone || itm.location.row || itm.location.column)) {
           delete itm.location.zone
           delete itm.location.row
           delete itm.location.column
         }
 
-        //if user repick product after import
         if (itm?.product?.productId) {
           itm.product.id = itm.product.productId
           delete itm.product.productId
@@ -1399,14 +1445,7 @@ class InventoryAdjustment extends connect(store)(localize(i18next)(PageView)) {
           itm.manufactureDate = `${mdt.getFullYear()}-${mdt.getMonth() + 1}-${mdt.getDate()}`
         }
 
-        if (itm.serialNumbers) {
-          let serialNumbers = itm.serialNumbers
-          itm.serialNumbers = serialNumbers.replace(' ', '')
-
-          if (itm.serialNumbers.split(',').length != itm.qty) {
-            throw new Error(i18next.t('text.serial_number_not_tally_with_qty'))
-          }
-        }
+        delete itm.errMsg
       })
 
       const response = await client.mutate({
@@ -1419,9 +1458,15 @@ class InventoryAdjustment extends connect(store)(localize(i18next)(PageView)) {
       })
 
       if (!response.errors) {
-        history.back()
         this.dataGrist.fetch()
         this.showToast({ message: i18next.t('text.data_inventory_adjustment_has_been_submitted_for_approval') })
+      } else {
+        // Server returned errors — show in the error column on original patches
+        const errMsg = response.errors.map(e => e.message).join('; ')
+        originalPatches.forEach(p => {
+          p.errMsg = errMsg
+        })
+        return originalPatches
       }
     } catch (e) {
       this.showToast(e)
@@ -1450,6 +1495,14 @@ class InventoryAdjustment extends connect(store)(localize(i18next)(PageView)) {
         return { ...column }
       })
 
+    columns.push({
+      type: 'string',
+      name: 'errMsg',
+      header: i18next.t('field.error_message'),
+      width: 300,
+      record: { editable: false }
+    })
+
     setTimeout(() => {
       openPopup(
         html`
@@ -1459,6 +1512,7 @@ class InventoryAdjustment extends connect(store)(localize(i18next)(PageView)) {
             rows: this.config.rows,
             columns: columns
           }}
+            .enableRowErrors=${true}
             .importHandler="${this.importHandler.bind(this)}"
             @field-change="${this.fieldChange.bind(this)}"
           ></import-pop-up>

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@things-factory/operato-wms",
-  "version": "4.3.789",
+  "version": "4.3.790",
   "main": "dist-server/index.js",
   "browser": "client/index.js",
   "things-factory": true,
@@ -66,7 +66,7 @@
     "@things-factory/attachment-ui": "^4.3.767",
     "@things-factory/auth-ui": "^4.3.767",
     "@things-factory/barcode-ui": "^4.3.767",
-    "@things-factory/biz-ui": "^4.3.770",
+    "@things-factory/biz-ui": "^4.3.790",
     "@things-factory/board-service": "^4.3.767",
     "@things-factory/board-ui": "^4.3.770",
     "@things-factory/code-ui": "^4.3.770",
@@ -81,8 +81,8 @@
     "@things-factory/help": "^4.3.767",
     "@things-factory/i18n-base": "^4.3.767",
     "@things-factory/id-rule-base": "^4.3.770",
-    "@things-factory/import-ui": "^4.3.770",
-    "@things-factory/import-ui-excel": "^4.3.776",
+    "@things-factory/import-ui": "^4.3.790",
+    "@things-factory/import-ui-excel": "^4.3.790",
     "@things-factory/menu-ui": "^4.3.770",
     "@things-factory/more-ui": "^4.3.767",
     "@things-factory/notification": "^4.3.767",
@@ -90,8 +90,8 @@
     "@things-factory/print-proxy-service": "^4.3.767",
     "@things-factory/print-ui": "^4.3.767",
     "@things-factory/product-base": "^4.3.788",
-    "@things-factory/resource-ui": "^4.3.770",
-    "@things-factory/sales-ui": "^4.3.789",
+    "@things-factory/resource-ui": "^4.3.790",
+    "@things-factory/sales-ui": "^4.3.790",
     "@things-factory/scene-data-transform": "^4.3.767",
     "@things-factory/scene-excel": "^4.3.767",
     "@things-factory/scene-firebase": "^4.3.767",
@@ -107,8 +107,8 @@
     "@things-factory/system-ui": "^4.3.767",
     "@things-factory/transport-base": "^4.3.767",
     "@things-factory/tutorial-ui": "^4.3.767",
-    "@things-factory/warehouse-base": "^4.3.789",
-    "@things-factory/worksheet-base": "^4.3.789"
+    "@things-factory/warehouse-base": "^4.3.790",
+    "@things-factory/worksheet-base": "^4.3.790"
   },
   "devDependencies": {
     "@things-factory/builder": "^4.3.767",
@@ -117,5 +117,5 @@
     "cypress-localstorage-commands": "^1.6.1",
     "eslint-plugin-cypress": "^2.12.1"
   },
-  "gitHead": "f2c0983c5b5bae151d242f2d0267e800d6be318e"
+  "gitHead": "aac8be0c440911f309204b31d37d0b9fabd0c451"
 }