@things-factory/meta-ui 10.1.37 → 10.1.39

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@things-factory/meta-ui",
-  "version": "10.1.37",
+  "version": "10.1.39",
   "main": "dist-server/index.js",
   "browser": "dist-client/index.js",
   "things-factory": true,
@@ -41,24 +41,24 @@
     "@operato/styles": "^10.0.0",
     "@operato/time-calculator": "^10.0.0",
     "@operato/utils": "^10.0.0",
-    "@things-factory/auth-base": "^10.1.37",
-    "@things-factory/code-base": "^10.1.37",
+    "@things-factory/auth-base": "^10.1.39",
+    "@things-factory/code-base": "^10.1.39",
     "@things-factory/env": "^10.1.20",
-    "@things-factory/export-base": "^10.1.37",
+    "@things-factory/export-base": "^10.1.39",
     "@things-factory/form-ui": "^10.1.29",
-    "@things-factory/id-rule-base": "^10.1.37",
-    "@things-factory/import-base": "^10.1.37",
-    "@things-factory/import-ui": "^10.1.37",
-    "@things-factory/integration-base": "^10.1.37",
-    "@things-factory/lite-menu": "^10.1.37",
-    "@things-factory/menu-base": "^10.1.37",
-    "@things-factory/more-base": "^10.1.37",
-    "@things-factory/personalization": "^10.1.37",
-    "@things-factory/resource-base": "^10.1.37",
-    "@things-factory/shell": "^10.1.37",
+    "@things-factory/id-rule-base": "^10.1.39",
+    "@things-factory/import-base": "^10.1.39",
+    "@things-factory/import-ui": "^10.1.39",
+    "@things-factory/integration-base": "^10.1.39",
+    "@things-factory/lite-menu": "^10.1.39",
+    "@things-factory/menu-base": "^10.1.39",
+    "@things-factory/more-base": "^10.1.39",
+    "@things-factory/personalization": "^10.1.39",
+    "@things-factory/resource-base": "^10.1.39",
+    "@things-factory/shell": "^10.1.39",
     "@things-factory/utils": "^10.1.20",
-    "@things-factory/worklist": "^10.1.37",
+    "@things-factory/worklist": "^10.1.39",
     "moment-timezone": "^0.5.45"
   },
-  "gitHead": "d8a69e5c8803a4b9d3289df0cf38e161a207db61"
+  "gitHead": "fe5257ad8995fe7e79275e287f36e95b5fd32d1c"
 }

package/tests/delete-meta-activities.test.ts

@@ -0,0 +1,49 @@
+import { join } from 'path'
+
+import { buildSchema } from 'type-graphql'
+
+/**
+ * deleteMetaActivities deletes activity definitions in bulk. Its neighbour updateMultipleMetaActivity
+ * asked the activity privilege and it did not; closed 2026-09-24 (architect ruling).
+ *
+ * Measured from the schema meta-ui boots from, walked by auth-base's privilege directive - the
+ * compiled output, since the entities need emitDecoratorMetadata (auth-base tests/compiled.ts).
+ */
+
+const { schema: declared } = require(join(__dirname, '..', 'dist-server', 'service', 'index.js'))
+const { privilegeDirectiveResolver, privilegeOfField } = require(
+  join(__dirname, '..', '..', 'auth-base', 'dist-server', 'service', 'privilege', 'privilege-directive.js')
+)
+
+beforeAll(async () => {
+  const schema = await buildSchema({
+    resolvers: declared.resolverClasses,
+    validate: false,
+    pubSub: { publish() {}, subscribe() {} } as any
+  })
+
+  privilegeDirectiveResolver(schema)
+})
+
+it('asks the same privilege as the other activity definition writes', () => {
+  expect(privilegeOfField('Mutation', 'deleteMetaActivities')).toEqual({
+    known: true,
+    gate: { category: 'activity', privilege: 'mutation', owner: true, super: false }
+  })
+  expect(privilegeOfField('Mutation', 'updateMultipleMetaActivity')).toEqual(privilegeOfField('Mutation', 'deleteMetaActivities'))
+})
+
+it('looks each activity up in the caller\'s domain only', () => {
+  /*
+   * Unnarrowed, an id from another tenant removed that tenant's template from the process-wide
+   * installations. Read off the compiled body: the lookup runs inside a transaction this test cannot
+   * stand up without a database.
+   */
+  const body = require('fs').readFileSync(
+    join(__dirname, '..', 'dist-server', 'service', 'meta-activity', 'meta-activity-mutation.js'),
+    'utf8'
+  )
+  const deleteBody = body.slice(body.indexOf('async deleteMetaActivities('), body.indexOf('async installActivityTemplate('))
+
+  expect(deleteBody).toMatch(/findOne\(\{\s*where: \{ domain: \{ id: domain\.id \}, id: ids\[i\] \}/)
+})

package/tests/meta-activity-domain.test.ts

@@ -0,0 +1,122 @@
+import { join } from 'path'
+
+import { buildSchema } from 'type-graphql'
+
+/**
+ * meta-ui's activity writes stay in the caller's domain. Ruled 2026-09-24.
+ *
+ * installActivityTemplate asks the activity privilege, as the other writes do - measured from the
+ * schema. And an id from another tenant, for an activity or for the menu it embeds, is not reached:
+ * the compiled resolver is called with a transaction whose repositories answer only rows of the
+ * domain they are asked for.
+ */
+
+const DIST = join(__dirname, '..', 'dist-server')
+const { schema: declared } = require(join(DIST, 'service', 'index.js'))
+const { MetaActivityMutation } = require(join(DIST, 'service', 'meta-activity', 'meta-activity-mutation.js'))
+const { privilegeDirectiveResolver, privilegeOfField } = require(
+  join(__dirname, '..', '..', 'auth-base', 'dist-server', 'service', 'privilege', 'privilege-directive.js')
+)
+
+beforeAll(async () => {
+  const schema = await buildSchema({
+    resolvers: declared.resolverClasses,
+    validate: false,
+    pubSub: { publish() {}, subscribe() {} } as any
+  })
+
+  privilegeDirectiveResolver(schema)
+})
+
+it('installActivityTemplate asks the same privilege as the other activity writes', () => {
+  expect(privilegeOfField('Mutation', 'installActivityTemplate')).toEqual({
+    known: true,
+    gate: { category: 'activity', privilege: 'mutation', owner: true, super: false }
+  })
+})
+
+/* Rows by entity name; a lookup that names no domain gets nothing, so an unnarrowed query shows. */
+function transaction(rows: Record<string, any[]>, saved: any[], asked: any[]) {
+  return {
+    getRepository: (entity: any) => ({
+      findOne: async ({ where }: any) => {
+        asked.push({ entity: entity.name, where })
+        return (rows[entity.name] || []).find(one => one.id === where?.id && one.domainId === where?.domain?.id) || null
+      },
+      find: async ({ where }: any) => {
+        asked.push({ entity: entity.name, where })
+        return (rows[entity.name] || []).filter(one => one.domainId === where?.domain?.id)
+      },
+      save: async (row: any) => (saved.push(row), row)
+    })
+  }
+}
+
+const context = (tx: any) =>
+  ({
+    state: { domain: { id: 'd-here' }, user: { id: 'u-me' }, tx },
+    t: (key: string) => key
+  }) as any
+
+const rows = {
+  Activity: [
+    { id: 'act-here', domainId: 'd-here', name: 'Mine' },
+    { id: 'act-other', domainId: 'd-other', name: 'Theirs' }
+  ],
+  Menu: [
+    { id: 'menu-here', domainId: 'd-here', name: 'mine', routing: 'mine' },
+    { id: 'menu-other', domainId: 'd-other', name: 'theirs', routing: 'theirs' }
+  ]
+}
+
+describe('updateMultipleMetaActivity', () => {
+  it("another tenant's activity id is refused by name, and nothing is saved", async () => {
+    const saved: any[] = []
+    const tx = transaction(rows, saved, [])
+
+    await expect(
+      new MetaActivityMutation().updateMultipleMetaActivity([{ id: 'act-other', cuFlag: 'M' }], context(tx))
+    ).rejects.toThrow('error.meta-activity not in this domain')
+    expect(saved).toEqual([])
+  })
+
+  it("this domain's activity is updated", async () => {
+    const saved: any[] = []
+    const tx = transaction(rows, saved, [])
+
+    await new MetaActivityMutation().updateMultipleMetaActivity([{ id: 'act-here', cuFlag: 'M', name: 'Mine2' }], context(tx))
+    expect(saved.map(one => one.id)).toEqual(['act-here'])
+  })
+
+  it("another tenant's menu is not embedded in the model", async () => {
+    const saved: any[] = []
+    const tx = transaction(rows, saved, [])
+
+    await new MetaActivityMutation().updateMultipleMetaActivity(
+      [{ id: 'act-here', cuFlag: 'M', menu: { id: 'menu-other' } }],
+      context(tx)
+    )
+    expect(JSON.stringify(saved[0].model)).not.toContain('theirs')
+  })
+
+  it("this domain's menu is embedded", async () => {
+    const saved: any[] = []
+    const tx = transaction(rows, saved, [])
+
+    await new MetaActivityMutation().updateMultipleMetaActivity(
+      [{ id: 'act-here', cuFlag: 'M', menu: { id: 'menu-here' } }],
+      context(tx)
+    )
+    expect(JSON.stringify(saved[0].model)).toContain('mine')
+  })
+})
+
+describe('installActivityTemplate', () => {
+  it("installs from this domain's released activities only", async () => {
+    const asked: any[] = []
+    const tx = transaction(rows, [], asked)
+
+    await new MetaActivityMutation().installActivityTemplate(context(tx))
+    expect(asked.filter(one => one.entity === 'Activity').every(one => one.where?.domain?.id === 'd-here')).toBe(true)
+  })
+})

package/translations/en.json

@@ -1,4 +1,5 @@
 {
+  "error.meta-activity not in this domain": "activity {id} is not in this domain.",
   "menu.my_job": "My Job",
   "menu.todo_list": "My Todo List",
   "menu.approval_pending_list": "My Approval Pending List",

package/translations/ko.json

@@ -1,4 +1,5 @@
 {
+  "error.meta-activity not in this domain": "업무 {id} 는 이 사업장의 것이 아닙니다.",
   "menu.my_job": "나의 업무",
   "menu.todo_list": "내 업무함",
   "menu.approval_pending_list": "내 결재함",

package/translations/ms.json

@@ -1,4 +1,5 @@
 {
+  "error.meta-activity not in this domain": "tugas {id} bukan milik domain ini.",
   "menu.my_job": "My Job",
   "menu.todo_list": "My Todo List",
   "menu.approval_pending_list": "My Approval Pending List",

package/translations/zh.json

@@ -1,4 +1,5 @@
 {
+  "error.meta-activity not in this domain": "业务 {id} 不属于此站点。",
   "menu.my_job": "My Job",
   "menu.todo_list": "My Todo List",
   "menu.approval_pending_list": "My Approval Pending List",