@things-factory/marketplace-base 4.3.15 → 4.3.16

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@things-factory/marketplace-base",
-  "version": "4.3.15",
+  "version": "4.3.16",
   "main": "dist-server/index.js",
   "browser": "client/index.js",
   "things-factory": true,
@@ -29,5 +29,5 @@
     "@things-factory/product-base": "^4.3.14",
     "@things-factory/shell": "^4.3.14"
   },
-  "gitHead": "df335351b9bbb891dc6c4eb81dc9cafecc9c39bb"
+  "gitHead": "62892327e53288b479a13a53043067c678cd9bfc"
 }

package/server/graphql/resolvers/marketplace-order/split-orders-by-batch.ts

@@ -91,15 +91,9 @@ export const splitOrdersByBatch = {
         let marketplaceOrderShippingItem: MarketplaceOrderShippingItem = newMarketplaceOrderShippingItems[a]
         const product: Product = marketplaceOrderShippingItem.product
         const marketplaceOrderItem: MarketplaceOrderItem = marketplaceOrderShippingItem.marketplaceOrderItem
-        const marketplaceProductVariations: MarketplaceProductVariation[] = await tx
-          .getRepository(MarketplaceProductVariation)
-          .find({
-            where: { domain: marketplaceOrder.domain, sku: product.sku },
-            relations: ['marketplaceProduct', 'marketplaceProduct.marketplaceStore']
-          })
-        const marketplaceProductVariation: MarketplaceProductVariation = marketplaceProductVariations.filter(
-          mpv => mpv.marketplaceProduct.marketplaceStore.id == marketplaceOrder.marketplaceStore.id
-        )[0]
+
+        const marketplaceProductVariation: MarketplaceProductVariation =
+          marketplaceOrderItem.marketplaceProductVariation
 
         if (!marketplaceProductVariation?.primaryUnitValue)
           throw new Error(marketplaceProductVariation.variationSku + ' weight is empty')

package/server/graphql/resolvers/marketplace-order/sync-marketplace-order.ts

@@ -381,20 +381,26 @@ export const syncMarketplaceOrder = {
             let foundVariations = []
             for (var j = 0; j < order.orderItems.length; j++) {
               var item = order.orderItems[j]
-              let foundVariationsQuery = await tx.getRepository(MarketplaceProductVariation).find({
-                where: { domain: marketplaceStore.domain, variationId: item.variationId },
-                relations: ['domain', 'marketplaceProduct', 'marketplaceProduct.marketplaceStore']
-              })
 
-              let foundVariation = foundVariationsQuery.find(
-                fv => fv.marketplaceProduct && fv.marketplaceProduct.marketplaceStore.id == marketplaceStore.id
-              )
+              const qb: SelectQueryBuilder<MarketplaceProductVariation> = await tx
+                .getRepository(MarketplaceProductVariation)
+                .createQueryBuilder('mpv')
+                .leftJoin('mpv.marketplaceProduct', 'mp')
+                .leftJoin('mp.marketplaceStore', 'ms')
+                .where('mpv.domain_id = :domainId')
+                .andWhere('mpv.variation_id = :variationId')
+                .andWhere('ms.id = :marketplaceStoreId')
+                .setParameters({
+                  domainId: marketplaceStore.domain,
+                  variationId: item.variationId,
+                  marketplaceStoreId: marketplaceStore.id
+                })
+
+              let foundVariation: MarketplaceProductVariation = await qb.getOne()
 
               if (foundVariation) {
                 foundVariations.push(foundVariation)
-              }
-
-              if (!foundVariation) {
+              } else {
                 let newVariation: any = {
                   variationId: item.variationId,
                   name: item.variationName,