@things-factory/figure-ui 10.1.170 → 10.1.172

package/client/modeller/editor.ts

@@ -1358,7 +1358,7 @@ export class FigureEditor extends LitElement {
     return version > 0 ? i18next.t('figure.text.release-state-draft-over', { version: String(version) }) : i18next.t('figure.text.release-state-draft-new')
   }
   /** The findings that block release, under the bar beside 「발행」, each with the way out the verdict tab offers for it. */
-  private renderReleaseBlockers(asset: FigureAsset | undefined, unavailable: boolean) {
+  private renderReleaseBlockers(blockers: FigureGateFinding[], asset: FigureAsset | undefined, unavailable: boolean) {
     const parts = (asset?.appearance ?? []).map(look => look.target)
     const way = (code: string) =>
       (code === 'occupancy-undeclared' || code === 'part-outside-occupancy') && asset && parts.length
@@ -1369,7 +1369,7 @@ export class FigureEditor extends LitElement {
     return html`<div release-blockers role="dialog" aria-label=${i18next.t('figure.text.must-fix-to-release')} @keydown=${(e: KeyboardEvent) => e.key === 'Escape' && (this.blockersOpen = false)}>
       <ul gate>
         <li head>${i18next.t('figure.text.must-fix-to-release')}</li>
-        ${this.releaseBlockers.map(finding => renderGateFinding(finding, true, way(finding.code), parts))}
+        ${blockers.map(finding => renderGateFinding(finding, true, way(finding.code), parts))}
       </ul>
     </div>`
   }
@@ -1659,6 +1659,12 @@ export class FigureEditor extends LitElement {
         : view.dirty || !view.id
           ? 'figure.text.unsaved-changes'
           : 'figure.text.saved'
+    /*
+      A figure with no parts yet is not one that failed: what blocks its release is said once it has something to
+      release (first 15 minutes, 2026-10-16 evening -- red from the first click read as a failure). The verdict tab
+      still says it.
+    */
+    const blockers = view.geometry.length ? this.releaseBlockers : []
     const tab = this.tab
     const live = this.liveParts(shown)
     return html`<ox-canvas-bar
@@ -1683,15 +1689,15 @@ export class FigureEditor extends LitElement {
         <span slot="status" class="status" role="status" ?dirty=${status === 'figure.text.unsaved-changes'}>${i18next.t(status)}</span>
         <span slot="status" release-state>${this.releaseWords(view)}</span>
         ${this.renderOverlayButton('history', 'history', 'figure.label.history', 'commit')}
-        ${this.releaseBlockers.length
+        ${blockers.length
           ? html`<button slot="commit" release-blocked aria-expanded=${String(this.blockersOpen)} @click=${() => (this.blockersOpen = !this.blockersOpen)}>
-              <md-icon>error</md-icon>${i18next.t('figure.button.release-blocked', { count: this.releaseBlockers.length })}
+              <md-icon>error</md-icon>${i18next.t('figure.button.release-blocked', { count: blockers.length })}
             </button>`
           : nothing}
         <button slot="commit" publish ?disabled=${!view.id} title=${view.id ? '' : i18next.t('figure.text.save-the-figure-before-releasing')} @click=${this.goRelease}>${i18next.t('figure.button.release')}</button>
         <button slot="commit" save ?disabled=${unavailable || (!view.dirty && !!view.id)} @click=${this.save}>${i18next.t('figure.button.save')}</button>
       </ox-canvas-bar>
-      ${this.blockersOpen && this.releaseBlockers.length ? this.renderReleaseBlockers(asset, unavailable) : nothing}
+      ${this.blockersOpen && blockers.length ? this.renderReleaseBlockers(blockers, asset, unavailable) : nothing}
       ${this.catalogOpen
         ? html`<figure-recipe-catalog
             .templates=${this.templates}

package/client/modeller/figure-preview.ts

@@ -10,7 +10,7 @@ import { DEFAULT_VIEW, previewBoardDepth, sceneLook, WORKBENCH, type ViewSetting
 import { dialShape } from './angle-dial.js'
 import { domainOf, motionWrittenByData, typedValueOf, valueRowsOf } from './data-interface.js'
 import { derivedOf, type FigureRevision } from './revision.js'
-import { authoredSizeOf, PREVIEW_FACTOR, PREVIEW_WAYS, previewClampsOf, previewInstances, previewOneInstance, previewTypeOf, setupPartOf, sizeRangeOf, sizeWithinRange } from '@things-factory/figure-viewer/dist-client/preview-model.js'
+import { authoredSizeOf, occupancyAtSize, PREVIEW_FACTOR, PREVIEW_WAYS, previewClampsOf, previewInstances, previewOneInstance, previewTypeOf, setupPartOf, sizeRangeOf, sizeWithinRange } from '@things-factory/figure-viewer/dist-client/preview-model.js'
 import { previewSizeWordsOf } from './preview-size.js'
 
 /**
@@ -353,6 +353,8 @@ export class FigurePreview extends localize(i18next)(LitElement) {
     if (way === this.way) return
     this.way = way
     this.standUp()
+    /* The content is made again inside the scene standing, which keeps the camera: from one figure to eight it stood inside them. */
+    requestAnimationFrame(() => this.fitView())
   }
 
   /** The one figure at another size on an axis, held to what the figure declares, its centre kept on the board's. */
@@ -362,7 +364,9 @@ export class FigurePreview extends localize(i18next)(LitElement) {
     if (used === undefined || !this.trying) return
     this.trying = { ...this.trying, [axis]: used }
     const instance = this.scene?.root?.components?.[0] as { model?: { width?: number; height?: number }; set(props: Record<string, unknown>): void } | undefined
-    instance?.set(axis === 'x' ? { width: used } : axis === 'y' ? { depth: used } : { height: used })
+    /* The instance's box is the space the figure takes at the sizes tried, not the sizes (occupancyAtSize). */
+    const box = occupancyAtSize(asset!, this.trying) ?? this.trying
+    instance?.set({ width: box.x, depth: box.y, height: box.z })
     const { width = 0, height = 0 } = instance?.model ?? {}
     instance?.set({ left: this.board.width / 2 - width / 2, top: this.board.height / 2 - height / 2 })
   }
@@ -596,7 +600,9 @@ export class FigurePreview extends localize(i18next)(LitElement) {
       this.valuing = {}
       registerFigure(type, asset)
       this.registered = type
-      const { components, board } = this.way === 'one' ? previewOneInstance(type, size) : previewInstances(type, size)
+      /* Each instance stands in the space the figure takes at the size it is asked (occupancyAtSize), as a board reads it. */
+      const boxOf = (asked: { x: number; y: number; z: number }) => occupancyAtSize(asset, asked) ?? asked
+      const { components, board } = this.way === 'one' ? previewOneInstance(type, boxOf(size)) : previewInstances(type, size, boxOf)
       this.board = board
       this.trying = this.way === 'one' ? { ...size } : undefined
       const model = {

package/dist-client/modeller/editor.js

@@ -1369,7 +1369,7 @@ let FigureEditor = class FigureEditor extends LitElement {
         return version > 0 ? i18next.t('figure.text.release-state-draft-over', { version: String(version) }) : i18next.t('figure.text.release-state-draft-new');
     }
     /** The findings that block release, under the bar beside 「발행」, each with the way out the verdict tab offers for it. */
-    renderReleaseBlockers(asset, unavailable) {
+    renderReleaseBlockers(blockers, asset, unavailable) {
         const parts = (asset?.appearance ?? []).map(look => look.target);
         const way = (code) => (code === 'occupancy-undeclared' || code === 'part-outside-occupancy') && asset && parts.length
             ? html `<button act ?disabled=${unavailable} @click=${() => this.linkCommand(occupancyFromParts(asset))}>
@@ -1379,7 +1379,7 @@ let FigureEditor = class FigureEditor extends LitElement {
         return html `<div release-blockers role="dialog" aria-label=${i18next.t('figure.text.must-fix-to-release')} @keydown=${(e) => e.key === 'Escape' && (this.blockersOpen = false)}>
       <ul gate>
         <li head>${i18next.t('figure.text.must-fix-to-release')}</li>
-        ${this.releaseBlockers.map(finding => renderGateFinding(finding, true, way(finding.code), parts))}
+        ${blockers.map(finding => renderGateFinding(finding, true, way(finding.code), parts))}
       </ul>
     </div>`;
     }
@@ -1679,6 +1679,12 @@ let FigureEditor = class FigureEditor extends LitElement {
                 : view.dirty || !view.id
                     ? 'figure.text.unsaved-changes'
                     : 'figure.text.saved';
+        /*
+          A figure with no parts yet is not one that failed: what blocks its release is said once it has something to
+          release (first 15 minutes, 2026-10-16 evening -- red from the first click read as a failure). The verdict tab
+          still says it.
+        */
+        const blockers = view.geometry.length ? this.releaseBlockers : [];
         const tab = this.tab;
         const live = this.liveParts(shown);
         return html `<ox-canvas-bar
@@ -1701,15 +1707,15 @@ let FigureEditor = class FigureEditor extends LitElement {
         <span slot="status" class="status" role="status" ?dirty=${status === 'figure.text.unsaved-changes'}>${i18next.t(status)}</span>
         <span slot="status" release-state>${this.releaseWords(view)}</span>
         ${this.renderOverlayButton('history', 'history', 'figure.label.history', 'commit')}
-        ${this.releaseBlockers.length
+        ${blockers.length
             ? html `<button slot="commit" release-blocked aria-expanded=${String(this.blockersOpen)} @click=${() => (this.blockersOpen = !this.blockersOpen)}>
-              <md-icon>error</md-icon>${i18next.t('figure.button.release-blocked', { count: this.releaseBlockers.length })}
+              <md-icon>error</md-icon>${i18next.t('figure.button.release-blocked', { count: blockers.length })}
             </button>`
             : nothing}
         <button slot="commit" publish ?disabled=${!view.id} title=${view.id ? '' : i18next.t('figure.text.save-the-figure-before-releasing')} @click=${this.goRelease}>${i18next.t('figure.button.release')}</button>
         <button slot="commit" save ?disabled=${unavailable || (!view.dirty && !!view.id)} @click=${this.save}>${i18next.t('figure.button.save')}</button>
       </ox-canvas-bar>
-      ${this.blockersOpen && this.releaseBlockers.length ? this.renderReleaseBlockers(asset, unavailable) : nothing}
+      ${this.blockersOpen && blockers.length ? this.renderReleaseBlockers(blockers, asset, unavailable) : nothing}
       ${this.catalogOpen
             ? html `<figure-recipe-catalog
             .templates=${this.templates}