@things-factory/figure-ui 10.1.168 → 10.1.169

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@things-factory/figure-ui",
-  "version": "10.1.168",
+  "version": "10.1.169",
   "publishConfig": {
     "access": "public",
     "@things-factory:registry": "https://registry.npmjs.org"
@@ -27,7 +27,7 @@
     "clean": "npm run clean:server && npm run clean:client"
   },
   "dependencies": {
-    "@hatiolab/figure-model": "^0.7.0",
+    "@hatiolab/figure-model": "^0.7.1",
     "@hatiolab/things-scene": "^10.1.90",
     "@material/web": "^2.0.0",
     "@operato/data-grist": "^10.0.0",
@@ -41,11 +41,11 @@
     "@operato/slot-layout-editor": "^10.29.25",
     "@operato/styles": "^10.0.0",
     "@operato/utils": "^10.0.0",
-    "@things-factory/ai-assistant": "^10.1.168",
-    "@things-factory/figure-service": "^10.1.168",
-    "@things-factory/figure-viewer": "^10.1.168",
+    "@things-factory/ai-assistant": "^10.1.169",
+    "@things-factory/figure-service": "^10.1.169",
+    "@things-factory/figure-viewer": "^10.1.169",
     "@things-factory/setting-base": "^10.1.167",
     "three": "^0.185.1"
   },
-  "gitHead": "fe067ff11d90effffc2523374453d9b8313b489f"
+  "gitHead": "9d71d02b443f3e0080b25de1768b982c51a64111"
 }

package/test/ai-proposal.test.ts

@@ -10,7 +10,7 @@ import { createFigureAsset, addFigureBox, serializeFigureAsset } from '@hatiolab
 
 import { createFigureProductSession } from '../client/modeller/product-session.js'
 import type { FigureProposalStep } from '@hatiolab/figure-model'
-import { pendNewFigure, runFigureProposal, takeFigureOffer, takePendingNewFigure, type FigureApplyDetail } from '../client/modeller/ai-proposal.js'
+import { askingToLeave, pendNewFigure, runFigureProposal, takeFigureOffer, takePendingNewFigure, type FigureApplyDetail } from '../client/modeller/ai-proposal.js'
 
 const ko = JSON.parse(readFileSync(fileURLToPath(new URL('../translations/ko.json', import.meta.url)), 'utf8'))
 const say = (key: string, params: Record<string, string> = {}) => {
@@ -82,12 +82,26 @@ test('applied: said with how many commands, and the card carries the version to
   assert.equal(target.offered[0]!.revision, 3)
 })
 
+test('a revision carries the figure it was made for, and only a revision does (audit N3)', async () => {
+  const target = taker({ applied: true })
+  await runFigureProposal({ steps, figureId: 'a', context: 'c', revision: 0 }, target, say)
+  assert.equal(target.offered[0]!.figureId, 'a')
+  const fresh = taker({ applied: true })
+  await runFigureProposal({ steps, create: true, figureId: 'a' }, fresh, say)
+  assert.equal(fresh.offered[0]!.figureId, undefined)
+})
+
 test('refused: a stale version is said as what happened; any other refusal carries its reason', async () => {
   const stale = await runFigureProposal({ steps }, taker({ applied: false, code: 'REVISION_CONFLICT', error: 'editor changed' }), say)
   assert.equal(stale.verdict, 'refused')
   assert.match(stale.note!, /모델이 바뀌어/)
   const other = await runFigureProposal({ steps }, taker({ applied: false, code: 'ATTACH_FACE', error: 'faces along x' }), say)
-  assert.match(other.note!, /적용하지 않았습니다: faces along x/)
+  /* Said from the code in the reader's words, as the modeller says an edit it refuses -- never the kernel's English (audit N6). */
+  assert.match(other.note!, /적용하지 않았습니다: 이 편집은 할 수 없습니다\. \(ATTACH_FACE\)/)
+  assert.doesNotMatch(other.note!, /faces along x/)
+  const busy = await runFigureProposal({ steps }, taker({ applied: false, code: 'SESSION_SAVING', error: 'save first' }), say)
+  assert.match(busy.note!, /저장이 끝난 뒤/)
+  assert.doesNotMatch(busy.note!, /save first/)
 })
 
 test('a revision with no modeller to take it is not applied anywhere else', async () => {
@@ -165,8 +179,10 @@ test('the same new figure\'s card in another tab before the first save makes a s
   assert.notEqual(ids[0], ids[1], 'two figures')
 })
 
-test('an empty card is not applied', async () => {
-  assert.equal((await runFigureProposal({ steps: [] }, taker({ applied: true }), say)).verdict, 'unavailable')
+test('an empty card is not applied, and says so (audit N7)', async () => {
+  const out = await runFigureProposal({ steps: [] }, taker({ applied: true }), say)
+  assert.equal(out.verdict, 'unavailable')
+  assert.match(out.note ?? '', /명령이 없어/)
 })
 
 test('a new figure\'s steps wait for the page once, and lapse if no page takes them', async () => {
@@ -181,3 +197,26 @@ test('a new figure\'s steps wait for the page once, and lapse if no page takes t
   assert.deepEqual(await lapsing, { applied: false, code: 'not-opened' })
   assert.equal(takePendingNewFigure(), undefined, 'a later new figure does not receive them')
 })
+
+/*
+  A new figure's card run from a modeller with unsaved edits waits behind the question whether to leave them (figure
+  audit 2026-10-16 N4). Its clock stopped for that question: before, a person who took longer than it to say leave lost
+  their edits and got a blank new figure, the steps gone; one who said stay got "could not be opened" ten seconds later.
+*/
+test('a new figure waiting behind the question whether to leave: no clock while asked, said at once when the person stays', async () => {
+  const leaving = pendNewFigure(steps, undefined, 10)
+  const answer = askingToLeave()!
+  await new Promise(resolve => setTimeout(resolve, 40))
+  answer(true)
+  const taken = takePendingNewFigure()
+  assert.ok(taken, 'still waiting for the page that opens')
+  taken!.settle({ applied: true })
+  assert.deepEqual(await leaving, { applied: true })
+
+  const staying = pendNewFigure(steps, undefined, 10_000)
+  askingToLeave()!(false)
+  assert.deepEqual(await staying, { applied: false, code: 'not-opened' })
+  assert.equal(takePendingNewFigure(), undefined)
+
+  assert.equal(askingToLeave(), undefined, 'nothing waiting: nothing to hold')
+})

package/test/figure-assistant-surface.test.ts

@@ -43,6 +43,44 @@ test('the dock applies a proposal through the page, on the version the model saw
   assert.equal(create.applied, undefined)
 })
 
+/*
+  The dock reads the draft when the person sends (figure audit 2026-10-16 N5). A save in flight is no edit: reading the
+  draft then was refused with the edit guard's Korean "save first" line, which the dock showed as the turn's error.
+*/
+test('the draft is read while a save is in flight', async () => {
+  const source = serializeFigureAsset(addFigureBox(createFigureAsset('A'), { id: 'body', size: { x: 100, y: 100, z: 100 }, position: { x: 0, y: 50, z: 0 } }))
+  let finish: (value: { id: string; source: string }) => void = () => {}
+  const session = createFigureProductSession({
+    load: async (id: string) => ({ id, source }),
+    save: (q: { id?: string; source: string }) => new Promise(resolve => (finish = () => resolve({ id: q.id ?? 'a', source: q.source })))
+  })
+  await session.open('a')
+  session.command({ kind: 'rename', name: 'B' } as never)
+  const saving = session.save()
+  assert.equal(session.read().saving, true)
+  assert.equal(JSON.parse(session.source()).name, 'B')
+  finish({ id: 'a', source })
+  await saving
+})
+
+/*
+  A revision is for the figure the model read, and a page with another figure open leaves it untaken (figure audit
+  2026-10-16 N3): the handler then says it needs that figure open. The version alone did not tell them apart -- two
+  figures opened in two page loads were both at their first context and revision 0.
+*/
+test('a revision made for another figure is left untaken, whatever version it names', async () => {
+  const source = serializeFigureAsset(addFigureBox(createFigureAsset('A'), { id: 'body', size: { x: 100, y: 100, z: 100 }, position: { x: 0, y: 50, z: 0 } }))
+  const session = createFigureProductSession({ load: async (id: string) => ({ id, source }), save: async (q: { id?: string; source: string }) => ({ id: q.id ?? 'a', source: q.source }) })
+  await session.open('a')
+  const now = session.read()
+  const other: FigureApplyDetail = { key: K1, steps: lid, create: false, figureId: 'b', context: now.context, revision: now.revision }
+  assert.equal(takeFigureOffer(session, other, { onSavedFigure: true, say }), false)
+  assert.equal(other.applied, undefined)
+  assert.equal(session.read().revision, now.revision)
+  const mine: FigureApplyDetail = { key: K1, steps: lid, create: false, figureId: 'a', context: now.context, revision: now.revision }
+  assert.equal(takeFigureOffer(session, mine, { onSavedFigure: true, say }), true)
+})
+
 /*
   A figure not saved yet is a subject too (ADR-0061 decision 3): its conversation is anchored on the creation id the
   first save inserts the row under, so the anchor is the same before and after that save. Taking a new figure's

package/translations/en.json

@@ -712,6 +712,7 @@
   "figure.text.proposal-applied": "applied {n} commands as one step.",
   "figure.text.proposal-saved-into": "Saved into: {names}",
   "figure.text.proposal-needs-modeller": "this proposal can be applied only while its figure is open in the modeller.",
+  "figure.text.proposal-empty": "this proposal has no commands, so nothing was applied. ask again.",
   "figure.text.proposal-new-figure-unsaved": "a new figure is being made, so the proposal was not applied. save or discard it, then run it again.",
   "figure.text.proposal-not-opened": "a new figure could not be opened in the modeller, so the proposal was not applied.",
   "figure.text.proposal-refused": "the modeller did not apply the proposal: {reason}",
@@ -754,6 +755,11 @@
   "figure.text.removal-bindings": "{places} went with it.",
   "figure.text.removal-mounting-face": "The mounting face is released.",
   "figure.text.edit-refused": "This edit cannot be made. ({code})",
+  "figure.text.session-not-open": "open the model first.",
+  "figure.text.session-saving": "wait for the save to finish, then edit.",
+  "figure.text.session-version-missing": "an AI edit needs the model version it was asked on.",
+  "figure.text.session-new-figure-touched": "this can be used only on a new model not yet edited.",
+  "figure.text.session-proposal-key": "the proposal's identifier is not valid.",
   "figure.text.edit-refused-node-limit": "The figure is too large to add more. It holds up to {max} nodes.",
   "figure.text.document-too-large": "The figure is {at} KiB, over the {max} KiB it can be saved at.",
   "figure.text.document-too-large-unmeasured": "The figure is over the {max} KiB it can be saved at.",

package/translations/es.json

@@ -712,6 +712,7 @@
   "figure.text.proposal-applied": "se aplicaron {n} comandos como un solo paso.",
   "figure.text.proposal-saved-into": "Guardado en: {names}",
   "figure.text.proposal-needs-modeller": "esta propuesta solo se puede aplicar mientras su figura esté abierta en el modelador.",
+  "figure.text.proposal-empty": "esta propuesta no tiene comandos, por lo que no se aplicó. vuelva a pedirla.",
   "figure.text.proposal-new-figure-unsaved": "se está creando una nueva figura, por lo que no se aplicó la propuesta. guárdela o descártela y vuelva a ejecutarla.",
   "figure.text.proposal-not-opened": "no se pudo abrir una nueva figura en el modelador, por lo que no se aplicó la propuesta.",
   "figure.text.proposal-refused": "el modelador no aplicó la propuesta: {reason}",
@@ -754,6 +755,11 @@
   "figure.text.removal-bindings": "{places} se eliminaron con ella.",
   "figure.text.removal-mounting-face": "La cara de montaje se ha liberado.",
   "figure.text.edit-refused": "No se puede realizar esta edición. ({code})",
+  "figure.text.session-not-open": "abra primero el modelo.",
+  "figure.text.session-saving": "espere a que termine de guardarse y luego edite.",
+  "figure.text.session-version-missing": "una edición de IA necesita la versión del modelo en la que se pidió.",
+  "figure.text.session-new-figure-touched": "solo se puede usar en un modelo nuevo que aún no se ha editado.",
+  "figure.text.session-proposal-key": "el identificador de la propuesta no es válido.",
   "figure.text.edit-refused-node-limit": "La figura es demasiado grande para añadir más. Admite hasta {max} nodos.",
   "figure.text.document-too-large": "La figura ocupa {at} KiB, más que los {max} KiB con los que se puede guardar.",
   "figure.text.document-too-large-unmeasured": "La figura supera los {max} KiB con los que se puede guardar.",

package/translations/ja.json

@@ -712,6 +712,7 @@
   "figure.text.proposal-applied": "{n} 個のコマンドを 1 ステップとして適用しました。",
   "figure.text.proposal-saved-into": "保存された図形に含まれています: {names}",
   "figure.text.proposal-needs-modeller": "この提案は、その図形がモデラーで開いているときだけ適用できます。",
+  "figure.text.proposal-empty": "この提案にはコマンドがないため、適用しませんでした。もう一度依頼してください。",
   "figure.text.proposal-new-figure-unsaved": "作成中の新しい図形があるため、提案を適用しませんでした。保存または破棄してから、もう一度実行してください。",
   "figure.text.proposal-not-opened": "新しい図形をモデラーで開けなかったため、提案を適用しませんでした。",
   "figure.text.proposal-refused": "モデラーは提案を適用しませんでした: {reason}",
@@ -754,6 +755,11 @@
   "figure.text.removal-bindings": "{places} も一緒に削除しました。",
   "figure.text.removal-mounting-face": "取付面が外れました。",
   "figure.text.edit-refused": "この編集はできません。({code})",
+  "figure.text.session-not-open": "先にモデルを正しく開いてください。",
+  "figure.text.session-saving": "保存が終わってから編集してください。",
+  "figure.text.session-version-missing": "AI の編集には、依頼した時点のモデルのバージョンが必要です。",
+  "figure.text.session-new-figure-touched": "まだ編集していない新しいモデルにだけ使えます。",
+  "figure.text.session-proposal-key": "提案の識別子が正しくありません。",
   "figure.text.edit-refused-node-limit": "図形が大きいためこれ以上追加できません。ノードは {max} 個までです。",
   "figure.text.document-too-large": "図形が {at} KiB で、保存できる上限 {max} KiB を超えています。",
   "figure.text.document-too-large-unmeasured": "図形が保存できる上限 {max} KiB を超えています。",

package/translations/ko.json

@@ -712,6 +712,7 @@
   "figure.text.proposal-applied": "명령 {n}개를 한 단계로 적용했습니다.",
   "figure.text.proposal-saved-into": "저장된 도형에 들어 있습니다: {names}",
   "figure.text.proposal-needs-modeller": "이 제안은 모델러에 그 도형이 열려 있을 때만 적용할 수 있습니다.",
+  "figure.text.proposal-empty": "이 제안에는 명령이 없어 적용하지 않았습니다. 다시 요청해 주세요.",
   "figure.text.proposal-new-figure-unsaved": "만들고 있는 새 Figure가 있어 제안을 적용하지 않았습니다. 저장하거나 버린 뒤 다시 실행해 주세요.",
   "figure.text.proposal-not-opened": "새 Figure를 모델러에 열지 못해 제안을 적용하지 않았습니다.",
   "figure.text.proposal-refused": "모델러가 제안을 적용하지 않았습니다: {reason}",
@@ -754,6 +755,11 @@
   "figure.text.removal-bindings": "{places} 도 함께 지웠습니다.",
   "figure.text.removal-mounting-face": "장착면이 풀렸습니다.",
   "figure.text.edit-refused": "이 편집은 할 수 없습니다. ({code})",
+  "figure.text.session-not-open": "먼저 모델을 정상적으로 열어 주세요.",
+  "figure.text.session-saving": "저장이 끝난 뒤 편집해 주세요.",
+  "figure.text.session-version-missing": "AI 편집에는 요청 당시의 모델 문맥과 리비전이 필요합니다.",
+  "figure.text.session-new-figure-touched": "손대지 않은 새 모델에만 쓸 수 있습니다.",
+  "figure.text.session-proposal-key": "제안 식별자가 올바르지 않습니다.",
   "figure.text.edit-refused-node-limit": "노드 수 제한으로 부품을 더 추가할 수 없습니다. 최대 노드 수는 {max}개입니다.",
   "figure.text.document-too-large": "도형이 {at} KiB 로 저장 한도 {max} KiB 를 넘습니다.",
   "figure.text.document-too-large-unmeasured": "도형이 저장 한도 {max} KiB 를 넘습니다.",

package/translations/ms.json

@@ -712,6 +712,7 @@
   "figure.text.proposal-applied": "{n} arahan digunakan sebagai satu langkah.",
   "figure.text.proposal-saved-into": "Disimpan ke dalam: {names}",
   "figure.text.proposal-needs-modeller": "cadangan ini hanya boleh digunakan semasa rajahnya dibuka dalam pemodel.",
+  "figure.text.proposal-empty": "cadangan ini tiada arahan, jadi tiada apa-apa digunakan. minta sekali lagi.",
   "figure.text.proposal-new-figure-unsaved": "rajah baharu sedang dibuat, jadi cadangan tidak digunakan. simpan atau buang dahulu, kemudian jalankan semula.",
   "figure.text.proposal-not-opened": "rajah baharu tidak dapat dibuka dalam pemodel, jadi cadangan tidak digunakan.",
   "figure.text.proposal-refused": "pemodel tidak menggunakan cadangan: {reason}",
@@ -754,6 +755,11 @@
   "figure.text.removal-bindings": "{places} turut dipadam.",
   "figure.text.removal-mounting-face": "Muka pemasangan dilepaskan.",
   "figure.text.edit-refused": "Suntingan ini tidak boleh dibuat. ({code})",
+  "figure.text.session-not-open": "buka model terlebih dahulu.",
+  "figure.text.session-saving": "tunggu sehingga simpanan selesai, kemudian sunting.",
+  "figure.text.session-version-missing": "suntingan AI memerlukan versi model semasa ia diminta.",
+  "figure.text.session-new-figure-touched": "ini hanya boleh digunakan pada model baharu yang belum disunting.",
+  "figure.text.session-proposal-key": "pengecam cadangan tidak sah.",
   "figure.text.edit-refused-node-limit": "Rajah terlalu besar untuk ditambah. Ia memuatkan sehingga {max} nod.",
   "figure.text.document-too-large": "Rajah ini {at} KiB, melebihi had simpanan {max} KiB.",
   "figure.text.document-too-large-unmeasured": "Rajah ini melebihi had simpanan {max} KiB.",

package/translations/zh.json

@@ -712,6 +712,7 @@
   "figure.text.proposal-applied": "已将 {n} 条命令作为一步应用。",
   "figure.text.proposal-saved-into": "已保存到图形: {names}",
   "figure.text.proposal-needs-modeller": "只有在建模器中打开该图形时才能应用此提案。",
+  "figure.text.proposal-empty": "此提案没有任何命令，因此未应用。请重新请求。",
   "figure.text.proposal-new-figure-unsaved": "正在制作一个新图形，因此未应用该提案。请保存或放弃后再运行。",
   "figure.text.proposal-not-opened": "无法在建模器中打开新图形，因此未应用该提案。",
   "figure.text.proposal-refused": "建模器未应用该提案：{reason}",
@@ -754,6 +755,11 @@
   "figure.text.removal-bindings": "{places} 也一并删除。",
   "figure.text.removal-mounting-face": "安装面已解除。",
   "figure.text.edit-refused": "无法进行此编辑。({code})",
+  "figure.text.session-not-open": "请先正常打开模型。",
+  "figure.text.session-saving": "请在保存完成后再编辑。",
+  "figure.text.session-version-missing": "AI 编辑需要提出请求时的模型版本。",
+  "figure.text.session-new-figure-touched": "只能用于尚未编辑的新模型。",
+  "figure.text.session-proposal-key": "提案标识符无效。",
   "figure.text.edit-refused-node-limit": "图形过大，无法再添加。节点上限为 {max} 个。",
   "figure.text.document-too-large": "图形为 {at} KiB，超过可保存的上限 {max} KiB。",
   "figure.text.document-too-large-unmeasured": "图形超过可保存的上限 {max} KiB。",