@things-factory/figure-ui 10.1.150 → 10.1.151

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@things-factory/figure-ui",
-  "version": "10.1.150",
+  "version": "10.1.151",
   "publishConfig": {
     "access": "public",
     "@things-factory:registry": "https://registry.npmjs.org"
@@ -18,7 +18,7 @@
   "scripts": {
     "build": "npm run build:server && npm run build:client",
     "test": "FIGURE_FREEZE_COMPILED=1 node --import ./test/resolve-ts-siblings.mjs --test test/*.test.ts",
-    "test:browser": "node --test test/browser/build.check.mjs test/browser/modeller.check.mjs test/browser/modeller-revision.check.mjs test/browser/editing.check.mjs test/browser/links.check.mjs test/browser/section.check.mjs test/browser/screen.check.mjs test/browser/product-page.check.mjs test/browser/parts.check.mjs test/browser/places-mesh.check.mjs",
+    "test:browser": "node --test test/browser/build.check.mjs test/browser/modeller.check.mjs test/browser/modeller-revision.check.mjs test/browser/editing.check.mjs test/browser/links.check.mjs test/browser/section.check.mjs test/browser/screen.check.mjs test/browser/product-page.check.mjs test/browser/parts.check.mjs test/browser/places-mesh.check.mjs test/browser/part-ids.check.mjs",
     "copy:files": "copyfiles -e \"./client/**/*.{ts,js,json}\" -u 1 \"./client/**/*\" dist-client",
     "build:client": "npm run copy:files && npx tsc --p ./client/tsconfig.json",
     "build:server": "npx tsc --p ./server/tsconfig.json",
@@ -27,8 +27,8 @@
     "clean": "npm run clean:server && npm run clean:client"
   },
   "dependencies": {
-    "@hatiolab/figure-model": "^0.5.2",
-    "@hatiolab/things-scene": "^10.1.82",
+    "@hatiolab/figure-model": "^0.6.0",
+    "@hatiolab/things-scene": "^10.1.83",
     "@material/web": "^2.0.0",
     "@operato/data-grist": "^10.0.0",
     "@operato/graphql": "^10.0.0",
@@ -42,8 +42,8 @@
     "@operato/styles": "^10.0.0",
     "@operato/utils": "^10.0.0",
     "@things-factory/ai-assistant": "^10.1.150",
-    "@things-factory/figure-service": "^10.1.150",
+    "@things-factory/figure-service": "^10.1.151",
     "three": "^0.185.1"
   },
-  "gitHead": "39c135863f5f7455dcd80b8907550a1c91a86118"
+  "gitHead": "495d06ef9ecf4d19fc9bf45ebc3cff4fdfefca53"
 }

package/test/browser/part-ids.check.mjs

@@ -0,0 +1,86 @@
+/*
+ * A new part's id, in a real browser, on a figure with a row: the palette's box, a copy from the parts list. A row's
+ * copies are drawn under ids of their own; the part made into the row still holds its id, and the next part is not
+ * offered it (on :3300, 2026-10-11, a box added after a row was refused with DUPLICATE_PART).
+ *
+ * Run:  node --test test/browser/part-ids.check.mjs
+ */
+import { test, describe, before, after } from 'node:test'
+import assert from 'node:assert/strict'
+
+import { addFigureBox, applyFigureAuthoring, createFigureAsset, serializeFigureAsset } from '@hatiolab/figure-model'
+
+import { buildPage } from './build.mjs'
+import { openPage } from './serve.mjs'
+
+const sleep = ms => new Promise(done => setTimeout(done, ms))
+
+let opened
+before(async () => {
+  opened = await openPage(await buildPage('places-mesh-page.js'))
+})
+after(async () => {
+  await opened?.close()
+})
+
+const page = () => opened.page
+const read = (fn, ...args) => page().evaluate(fn, ...args)
+const state = () => read(() => probe.state())
+/** The parts as authored, one per part as the parts list shows them. */
+const parts = () => read(() => probe.source().appearance.map(look => look.target))
+
+async function until(fn, args, what, ms = 8000) {
+  const deadline = Date.now() + ms
+  for (;;) {
+    if (await read(fn, ...args)) return
+    if (Date.now() > deadline) assert.fail(`waited for ${what}`)
+    await sleep(50)
+  }
+}
+const settled = () => read(() => document.querySelector('figure-editor').updateComplete)
+async function click(selector, options = {}, what = selector) {
+  const element = await page().evaluateHandle((s, o) => findDeep(s, o), selector, options)
+  assert.ok(await element.evaluate(e => !!e), `${what} is on the page`)
+  await element.evaluate(e => e.scrollIntoView({ block: 'center' }))
+  await element.click()
+  await settled()
+}
+
+/* box-1 on the floor, box-2 on it made into a row 300 apart: box-2's id is drawn nowhere as it is. */
+function rowed() {
+  let a = addFigureBox(createFigureAsset('Rowed'), { id: 'box-1', size: { x: 1000, y: 100, z: 400 }, position: { x: 0, y: 50, z: 0 } })
+  a = applyFigureAuthoring(a, { kind: 'attach', part: 'box-1', face: 'bottom', to: { plane: 'mounting-plane' } })
+  a = addFigureBox(a, { id: 'box-2', size: { x: 100, y: 100, z: 100 }, position: { x: 0, y: 150, z: 0 } })
+  a = applyFigureAuthoring(a, { kind: 'attach', part: 'box-2', face: 'bottom', to: { part: 'box-1', face: 'top' } })
+  return applyFigureAuthoring(a, { kind: 'make-repeat', part: 'box-2', axis: 'x', pitch: 300 })
+}
+
+describe('a new part on a figure with a row takes an id no part holds', () => {
+  before(async () => {
+    await read(text => harness.mount('given', text), serializeFigureAsset(rowed()))
+    await until(() => look.drawn().length > 0, [], 'the board is drawn')
+    assert.equal((await read(() => probe.ids())).includes('box-2'), false, 'the row is drawn under its copies\' ids')
+  })
+
+  test('a box from the palette: added as box-3, one step, selected', async () => {
+    const start = await state()
+    await click('button[shape]', { has: 'figure.label.primitive-cube' }, 'the palette\'s box')
+    await until(() => probe.state().selected === 'box-3', [], 'box-3 selected')
+    const after = await state()
+    assert.equal(after.error, '')
+    assert.equal(after.revision, start.revision + 1)
+    assert.deepEqual(await parts(), ['box-1', 'box-2', 'box-3'])
+  })
+
+  test('the row\'s part copied from the list: the copy is a part, and it is what is selected', async () => {
+    const at = await read(() => probe.row('box-2'))
+    await page().mouse.click(at.x, at.y)
+    await until(() => probe.state().selected === 'box-2', [], 'box-2 selected')
+    const before = await parts()
+    await click('button[op="duplicate-part"]')
+    await until(n => probe.source().appearance.length === n, [before.length + 1], 'the copy')
+    const copy = (await parts()).find(id => !before.includes(id))
+    assert.equal((await state()).selected, copy)
+    assert.equal((await state()).error, '')
+  })
+})