@things-factory/figure-ui 10.1.125 → 10.1.127

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@things-factory/figure-ui",
-  "version": "10.1.125",
+  "version": "10.1.127",
   "publishConfig": {
     "access": "public",
     "@things-factory:registry": "https://registry.npmjs.org"
@@ -27,7 +27,7 @@
     "clean": "npm run clean:server && npm run clean:client"
   },
   "dependencies": {
-    "@hatiolab/figure-model": "^0.4.0",
+    "@hatiolab/figure-model": "^0.4.1",
     "@hatiolab/things-scene": "^10.1.74",
     "@material/web": "^2.0.0",
     "@operato/data-grist": "^10.0.0",
@@ -40,9 +40,9 @@
     "@operato/shell": "^10.0.0",
     "@operato/styles": "^10.0.0",
     "@operato/utils": "^10.0.0",
-    "@things-factory/ai-assistant": "^10.1.125",
+    "@things-factory/ai-assistant": "^10.1.127",
     "@things-factory/figure-service": "^10.1.123",
     "three": "^0.185.1"
   },
-  "gitHead": "74e02381ea5f179dca2b7516078eb2709ac28ffe"
+  "gitHead": "1a224d9f1cbf56697a739e505b97333dd090d473"
 }

package/test/evaluated.test.ts

@@ -0,0 +1,40 @@
+/*
+ * One selection asks several questions of the same figure; the figure is evaluated once for them
+ * (`evaluatedGeometryOf`), and asked again when the asset object or the values are not the same.
+ */
+import { test } from 'node:test'
+import assert from 'node:assert/strict'
+
+import { addFigureBox, createFigureAsset } from '@hatiolab/figure-model'
+import { compileFigureAsset } from '@hatiolab/figure-model'
+import { evaluatedGeometryOf, seedEvaluatedGeometry } from '../client/modeller/evaluated.ts'
+
+const asset = () => addFigureBox(createFigureAsset('Held'), { id: 'a', size: { x: 100, y: 100, z: 100 }, position: { x: 0, y: 50, z: 0 } })
+
+test('the same asset under the same values is evaluated once', () => {
+  const a = asset()
+  assert.equal(evaluatedGeometryOf(a), evaluatedGeometryOf(a))
+  const values = { ...a.designInputs }
+  assert.equal(evaluatedGeometryOf(a, values), evaluatedGeometryOf(a, { ...values }))
+})
+
+test('another asset object, or other values, is evaluated afresh and says what it now is', () => {
+  const a = asset()
+  const first = evaluatedGeometryOf(a)
+  assert.notEqual(evaluatedGeometryOf(asset()), first)
+  const input = Object.keys(a.designInputs).find(id => id.endsWith('position.y'))!
+  const moved = evaluatedGeometryOf(a, { ...a.designInputs, [input]: 500 })
+  assert.notEqual(moved, first)
+  const y = (g: typeof first) => (g.find(o => o.id === 'a') as unknown as { pose: { t: number[] } }).pose.t[1]
+  assert.equal(y(first), 50)
+  assert.equal(y(moved), 500)
+})
+
+test('an answer the session already has is seeded, and answers the same question however its values are listed', () => {
+  const a = asset()
+  const values = { ...a.designInputs }
+  const seeded = compileFigureAsset(a).evaluate().geometry
+  seedEvaluatedGeometry(a, values, seeded)
+  assert.equal(evaluatedGeometryOf(a, Object.fromEntries(Object.entries(values).reverse())), seeded)
+  assert.notEqual(evaluatedGeometryOf(asset(), values), seeded)
+})

package/test/gizmo.test.ts

@@ -168,7 +168,7 @@ test('크기 칸과 손잡이 — 배치가 지키는 면을 지킨다, 커널
   hung = applyFigureAuthoring(hung, { kind: 'declare-occupancy', proposal: proposeFigureOccupancy(hung), placement: 'ceiling' })
   assert.equal(centreY(grow(hung, 'lamp', gizmoReachOf(hung, 'lamp').sizes![1], 300), 'lamp') + 300 / 2, 0, '천장 도형: 윗면이 천장에')
   const editor = read('../client/modeller/editor.ts')
-  assert.ok(editor.includes('figureSizeEditChanges(parseFigureAsset(this.session!.source()), part, [change])'), '숫자 칸이 부른다')
+  assert.ok(editor.includes('figureSizeEditChanges(this.parsedAsset(), part, [change])'), '숫자 칸이 부른다')
   assert.ok(editor.includes('figureSizeEditChanges(asset, ownerOf(id), written)'), '손잡이도 부른다')
   assert.ok(!read('../client/modeller/gizmo.ts').includes('keepBottomChanges'), '화면의 제 산수는 없다')
 })

package/test/mode-switch.test.ts

@@ -0,0 +1,41 @@
+/*
+ * Going from the preview back to editing does not build the edit canvas again: a 3D scene costs about a third of a
+ * second to make, and the canvas keeps its selection, gizmo and camera while the preview is in front. The preview is the
+ * other way round -- it is taken down when it is left, because a preview left standing behind the canvas made every edit
+ * dearer (a box added went from 240 ms to over a second, 2026-10-08).
+ */
+import { test } from 'node:test'
+import assert from 'node:assert/strict'
+import { readFileSync } from 'node:fs'
+import { fileURLToPath } from 'node:url'
+
+const read = (path: string) => readFileSync(fileURLToPath(new URL(path, import.meta.url)), 'utf-8')
+
+test('the edit canvas stays standing, out of sight, while the preview is in front', () => {
+  const editor = read('../client/modeller/editor.ts')
+  assert.ok(editor.includes("<div middle ?hidden=${this.middle === 'preview'}>"), 'the edit area is hidden, not removed')
+  assert.ok(/div\[middle\]\[hidden\]\s*\{\s*display: none;/.test(editor), 'and hidden by the stylesheet, which `display: flex` would otherwise override')
+})
+
+test('the preview is only there while it is in front', () => {
+  const editor = read('../client/modeller/editor.ts')
+  assert.ok(editor.includes("${this.middle === 'preview'\n          ? html`<figure-preview"), 'it is made when asked for and taken down when left')
+})
+
+test('a canvas out of sight is not resized to nothing and takes no picture', () => {
+  const canvas = read('../client/modeller/canvas.ts')
+  assert.ok(canvas.includes('this.checkVisibility?.() !== false') && canvas.includes('this.scene?.resize?.()'), 'resize only when visible')
+  assert.ok(canvas.includes('if (this.checkVisibility?.() === false) return undefined'), 'no picture while hidden, as when there was no canvas')
+})
+
+/*
+ * A value typed beside the preview changes the figure; the preview used to take its 3D scene down and make another, and
+ * the new scene's first drawing compiled the shaders again: five frames of 570 to 960 ms for one number (2026-10-09). The
+ * content is made again inside the scene that stands, keeping the renderer and the camera, as undo does.
+ */
+test('the preview makes its content again inside the scene that stands, and makes a new scene only when it cannot', () => {
+  const preview = read('../client/modeller/figure-preview.ts')
+  assert.ok(preview.includes('rebuildContentModel!(model, { preserveThreeD: true })'), 'rebuilt in place, keeping the 3D runtime')
+  assert.ok(preview.includes('this.registered === type'), 'only for the same figure')
+  assert.ok(/catch \{\s*this\.teardown\(\)/.test(preview), 'and a scene made anew when the content cannot be made again in place')
+})