@things-factory/figure-service 10.1.64 → 10.1.65

package/server/service/figure/figure-quality.ts

@@ -1,98 +0,0 @@
-import { sizingReport, topViewEvidence } from '@hatiolab/figure-model'
-import type { FigureBlueprint, FigureCost, FigureScore, FigureSource } from '@hatiolab/figure-model'
-
-/**
- * A deterministic design review for an AI candidate.
- *
- * This deliberately does not claim to recognise beauty from JSON. It reports
- * only what the Figure model can prove: stable part names, palette focus,
- * declared runtime budget, and whether the assembly survives resizing.
- */
-export type FigureQualityStatus = 'ready' | 'review'
-export type FigureQualityDimension = 'identity' | 'silhouette' | 'palette' | 'performance' | 'resilience'
-
-export interface FigureQualityFinding {
-  dimension: FigureQualityDimension
-  code: string
-  message: string
-}
-
-export interface FigureQualityReview {
-  /** Clear measurable checks, not an aesthetic certificate. */
-  status: FigureQualityStatus
-  summary: string
-  findings: FigureQualityFinding[]
-  /** Reproducible top-view evidence for a later render/vision critique loop. */
-  visual: ReturnType<typeof topViewEvidence>
-}
-
-const PLACEHOLDER_PART_NAME = /^(?:part|item|shape|cube|box)[-_]?\d+$/
-
-/**
- * Reviews a valid, compiled source. It never rejects a candidate: a crate can
- * intentionally be a set of boxes, so the author retains the decision.
- */
-export function reviewFigureQuality(
-  source: FigureSource,
-  blueprint: FigureBlueprint,
-  score: FigureScore,
-  cost: FigureCost
-): FigureQualityReview {
-  const findings: FigureQualityFinding[] = []
-  const visual = topViewEvidence(source)
-  const placeholderNames = source.parts.filter(part => PLACEHOLDER_PART_NAME.test(part.name)).map(part => part.name)
-
-  if (placeholderNames.length > 0) {
-    findings.push({
-      dimension: 'identity',
-      code: 'generic-part-name',
-      message: `Rename ${placeholderNames.join(', ')} for the real component; part names are stable binding identifiers.`
-    })
-  }
-
-  const primitives = new Set(source.parts.map(part => part.primitive))
-  if (source.parts.length >= 4 && [...primitives].every(primitive => primitive === 'cube' || primitive === 'wall' || primitive === 'rect')) {
-    findings.push({
-      dimension: 'silhouette',
-      code: 'box-only-silhouette',
-      message: 'This candidate is built only from rectangular primitives. Confirm that its top-view silhouette remains recognisable at board scale.'
-    })
-  }
-
-  const tokens = new Set(source.parts.map(part => part.material.token))
-  if (tokens.size > 3) {
-    findings.push({
-      dimension: 'palette',
-      code: 'palette-too-broad',
-      message: `The candidate uses ${tokens.size} material tokens. Confirm each colour carries meaning; low-poly figures usually read better with a focused palette.`
-    })
-  }
-
-  if (score.grade === 'C' || score.grade === 'D') {
-    findings.push({
-      dimension: 'performance',
-      code: 'budget-tight',
-      message: `Runtime budget grade ${score.grade}: ${score.tightest.label} uses ${score.tightest.used}/${score.tightest.limit}. Simplify before broad placement if possible.`
-    })
-  }
-
-  for (const finding of sizingReport(blueprint).findings) {
-    findings.push({ dimension: 'resilience', code: finding.code, message: finding.message })
-  }
-
-  if (findings.length === 0) {
-    return {
-      status: 'ready',
-      summary: `Model-grounded review is clear: grade ${score.grade}, ${cost.triangles} triangles, ${cost.drawCalls} draw calls per instance.`,
-      findings,
-      visual
-    }
-  }
-
-  return {
-    status: 'review',
-    summary: `Needs author review: ${findings.length} measurable design consideration${findings.length === 1 ? '' : 's'} found.`,
-    findings,
-    visual
-  }
-}