@things-factory/figure-service 10.1.170 → 10.1.171

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@things-factory/figure-service",
-  "version": "10.1.170",
+  "version": "10.1.171",
   "publishConfig": {
     "access": "public",
     "@things-factory:registry": "https://registry.npmjs.org"
@@ -38,5 +38,5 @@
     "jszip": "^3.10.1",
     "koa-router": "^7.4.0"
   },
-  "gitHead": "1956b73789eace6376f1d79443306e1bb8e61908"
+  "gitHead": "e88536db0bc3cbb759fe58f9efeef66a67fef2c3"
 }

package/server/service/figure/figure-propose-steps.test.ts

@@ -8,7 +8,7 @@
 import { FIGURE_PROPOSAL_GRAMMAR, addFigureBox, applyFigureAuthoring, applyFigureProposal, createFigureAsset, inspectFigureAsset, proposeFigureOccupancy } from '@hatiolab/figure-model'
 import { AIAnswerNotJSON, type AIClient } from '@things-factory/ai-client-base'
 
-import { ProposeFigureFailure, judgeFigureAnswer, proposalFailureForPerson, proposeFigureSteps, rulesPromptFigure } from './figure-propose-steps'
+import { ProposeFigureFailure, WORKED_EXAMPLE, judgeFigureAnswer, proposalFailureForPerson, proposeFigureSteps, rulesPromptFigure } from './figure-propose-steps'
 
 function stubClient(answers: unknown[]): AIClient & { calls: number; sent: any[][]; system?: string } {
   const client = {
@@ -61,6 +61,23 @@ describe('the model is told the kernel\'s commands and the open draft', () => {
     frame rail by hand, sixty steps, and fastened a rail twice (ATTACH_REPLACED at steps[59]); another named a part it
     had not added. Both are rules of writing, so they are taught with the rules.
   */
+  /*
+    Three walks on :3300 (2026-10-16) stopped at three fastening rules in turn -- a part not added, flush on the mounting
+    plane, a face that does not meet -- each refusal saying what to do, and none put right in three tries. A rule a line
+    at a time did not end it; one whole answer the kernel takes shows the rules together. It is held to the kernel here,
+    on the path an answer takes, so it cannot teach what the kernel refuses.
+  */
+  it('shows one whole answer, and that answer is one the kernel and the gate take', () => {
+    expect(rulesPromptFigure()).toContain(JSON.stringify({ steps: WORKED_EXAMPLE }))
+    const judged = judgeFigureAnswer(createFigureAsset('Roller conveyor'), { steps: WORKED_EXAMPLE }, false)
+    expect(judged.reasons).toEqual([])
+    expect(judged.source!.appearance.map(a => a.target)).toEqual(['frame', 'support', 'roller'])
+    const kinds = WORKED_EXAMPLE.map(step => step.kind)
+    expect(kinds).toContain('make-repeat')
+    expect(kinds.at(-1)).toBe('fit-room')
+    expect(WORKED_EXAMPLE.filter(step => step.kind === 'attach' && 'plane' in (step as any).to).every(step => !('facing' in step))).toBe(true)
+  })
+
   it('teaches a row of the same part as one part repeated, and each part fastened once', () => {
     const rules = rulesPromptFigure()
     expect(rules).toMatch(/same part .*make-repeat/)

package/server/service/figure/figure-propose-steps.ts

@@ -77,6 +77,25 @@ export function proposalFailureForPerson(failure: ProposeFigureFailure, t: (key:
   return [t('error.figure-proposal-failed', { defaultValue: failure.message }), ...failure.reasons].join('\n')
 }
 
+/**
+ * One whole answer the kernel and the gate take: a roller conveyor on two end supports. Three walks on :3300
+ * (2026-10-16) stopped at three fastening rules in turn, each refusal saying what to do and none put right; one answer
+ * shows them together -- the plane taken without facing, a part fastened under another, a row made once. Held to the
+ * kernel by its test, on the path an answer takes.
+ */
+export const WORKED_EXAMPLE: FigureProposalStep[] = [
+  { kind: 'add-part', part: { id: 'frame', kind: 'box', dimensions: { width: 2000, height: 100, depth: 600 } } },
+  { kind: 'attach', part: 'frame', face: 'bottom', to: { plane: 'mounting-plane' }, gap: 700 },
+  { kind: 'add-part', part: { id: 'support', kind: 'box', dimensions: { width: 80, height: 700, depth: 560 } } },
+  { kind: 'attach', part: 'support', face: 'top', to: { part: 'frame', face: 'bottom' }, align: { x: 'min' } },
+  { kind: 'make-repeat', part: 'support', axis: 'x', pitch: 1920, count: 2 },
+  { kind: 'add-part', part: { id: 'roller', kind: 'box', dimensions: { width: 60, height: 60, depth: 560 } } },
+  { kind: 'attach', part: 'roller', face: 'bottom', to: { part: 'frame', face: 'top' } },
+  { kind: 'make-repeat', part: 'roller', axis: 'x', pitch: 160 },
+  { kind: 'set-material', target: 'frame', material: { token: 'palette.frame' }, palette: { 'palette.frame': '#5b6770' } },
+  { kind: 'fit-room', placement: 'floor' }
+] as FigureProposalStep[]
+
 /** The rules and the words, all from figure-model's constants. */
 export function rulesPromptFigure(): string {
   return [
@@ -100,7 +119,12 @@ export function rulesPromptFigure(): string {
     'When revising, write only the commands the request needs. Everything not touched stays as it is.',
     '',
     'The commands (shape, then what it means):',
-    ...FIGURE_PROPOSAL_GRAMMAR.map(word => `- ${word.shape}\n  ${word.means}`)
+    ...FIGURE_PROPOSAL_GRAMMAR.map(word => `- ${word.shape}\n  ${word.means}`),
+    '',
+    'One whole answer the modeller takes, for a new roller conveyor -- an example of the form, not of the figure asked for:',
+    'the frame stands 700 mm up on the mounting plane, a support is fastened under it at one end and repeated to two, a',
+    'roller is fastened on top and repeated along it.',
+    JSON.stringify({ steps: WORKED_EXAMPLE })
   ].join('\n')
 }