@things-factory/dataset 6.0.27 → 6.0.29

package/server/service/data-ooc/data-ooc.ts

@@ -85,6 +85,18 @@ export class DataOoc {
   @Field({ nullable: true })
   state?: DataOocStatus
 
+  @Column({
+    nullable: true,
+    type:
+      DATABASE_TYPE == 'mysql' || DATABASE_TYPE == 'mariadb'
+        ? 'longtext'
+        : DATABASE_TYPE == 'oracle'
+        ? 'clob'
+        : 'varchar'
+  })
+  @Field({ nullable: true })
+  correctiveInstruction?: string
+
   @Column({
     nullable: true,
     type:
@@ -178,6 +190,10 @@ export class DataOoc {
   @Field({ nullable: true })
   collectedAt?: Date
 
+  @Column({ nullable: true })
+  @Field({ nullable: true })
+  reviewedAt?: Date
+
   @Column({ nullable: true })
   @Field({ nullable: true })
   correctedAt?: Date
@@ -190,6 +206,13 @@ export class DataOoc {
   @Field({ nullable: true })
   updatedAt?: Date
 
+  @ManyToOne(type => User, { nullable: true })
+  @Field({ nullable: true })
+  reviewer?: User
+
+  @RelationId((dataOoc: DataOoc) => dataOoc.reviewer)
+  reviewerId?: string
+
   @ManyToOne(type => User, { nullable: true })
   @Field({ nullable: true })
   corrector?: User

package/server/service/data-set/data-set-mutation.ts

@@ -2,6 +2,7 @@ import { Arg, Ctx, Directive, Mutation, Resolver } from 'type-graphql'
 import { In } from 'typeorm'
 
 import { createAttachment, deleteAttachmentsByRef } from '@things-factory/attachment-base'
+import { registerSchedule, unregisterSchedule } from '@things-factory/scheduler-client'
 
 import { DataSet } from './data-set'
 import { DataSetPatch, NewDataSet } from './data-set-type'
@@ -129,6 +130,7 @@ export class DataSetMutation {
 
     await tx.getRepository(DataSet).delete({ domain: { id: domain.id }, id })
     await deleteAttachmentsByRef(null, { refBys: [`report-${id}`] }, context)
+
     return true
   }
 
@@ -148,6 +150,101 @@ export class DataSetMutation {
     return true
   }
 
+  @Directive('@transaction')
+  @Mutation(returns => DataSet, { description: 'To start data collection schedule for the given dataset' })
+  async startDataCollectionSchedule(
+    @Arg('dataSetId') dataSetId: string,
+    @Ctx() context: ResolverContext
+  ): Promise<DataSet> {
+    const { domain, tx } = context.state
+
+    var repository = tx.getRepository(DataSet)
+    var dataSet = await repository.findOne({
+      where: { domain: { id: domain.id }, id: dataSetId }
+    })
+
+    if (!dataSet) {
+      throw new Error(
+        context.t('error.data-set not found', {
+          dataSet: dataSetId
+        })
+      )
+    }
+
+    try {
+      var handle = await registerSchedule({
+        name: dataSet.name,
+        client: {
+          application: 'operato-dataset',
+          group: `${domain.id}`,
+          key: dataSet.id
+        },
+        type: 'cron',
+        schedule: dataSet.schedule,
+        task: {
+          type: 'rest',
+          connection: {
+            host: 'http://localhost:3000/callback-schedule-for-dataset',
+            headers: {
+              'Content-Type': 'application/json',
+              accept: '*/*'
+            }
+          },
+          data: {
+            application: 'dataset',
+            id: dataSet.id
+          },
+          history_check: true,
+          failed_policy: 'retry_dlq',
+          max_retry_count: 3
+        }
+      })
+
+      return await repository.save({
+        ...dataSet,
+        schedulerHandle: handle
+      })
+    } catch (err) {
+      console.error('stopDataCollectionSchedule', err)
+    }
+  }
+
+  @Directive('@transaction')
+  @Mutation(returns => DataSet, {
+    nullable: true,
+    description: 'To stop data collection schedule for the given dataset'
+  })
+  async stopDataCollectionSchedule(
+    @Arg('dataSetId') dataSetId: string,
+    @Ctx() context: ResolverContext
+  ): Promise<DataSet | undefined> {
+    const { domain, tx } = context.state
+
+    var repository = tx.getRepository(DataSet)
+    var dataSet = await repository.findOne({
+      where: { domain: { id: domain.id }, id: dataSetId }
+    })
+
+    if (!dataSet) {
+      throw new Error(
+        context.t('error.data-set not found', {
+          dataSet: dataSetId
+        })
+      )
+    }
+
+    try {
+      await unregisterSchedule(dataSet.schedulerHandle)
+
+      return await repository.save({
+        ...dataSet,
+        schedulerHandle: null
+      })
+    } catch (err) {
+      console.error('stopDataCollectionSchedule', err)
+    }
+  }
+
   @Directive('@privilege(category: "data-set", privilege: "mutation", domainOwnerGranted: true)')
   @Directive('@transaction')
   @Mutation(returns => Boolean, { description: 'To import multiple data-sets' })

package/server/service/data-set/data-set-query.ts

@@ -8,7 +8,7 @@ import { Domain, getQueryBuilderFromListParams, getRepository, ListParam } from
 import { DataKeySet } from '../data-key-set/data-key-set'
 import { DataSample } from '../data-sample/data-sample'
 import { DataItem } from './data-item-type'
-import { DataSet } from './data-set'
+import { DataSet, DataSetState } from './data-set'
 import { DataSetList } from './data-set-type'
 
 var parser = require('cron-parser')
@@ -43,6 +43,27 @@ export class DataSetQuery {
     return { items, total }
   }
 
+  // @Directive('@privilege(category: "data-set", privilege: "query", domainOwnerGranted: true)')
+  // @Query(returns => DataSetStateList, { description: 'To fetch multiple status of DataSets' })
+  // async dataSetsStatus(@Args() params: ListParam, @Ctx() context: ResolverContext): Promise<DataSetStateList> {
+  //   const { domain } = context.state
+
+  //   // scheduler server에 group내 schedule list를 조회한다.
+  //   const queryBuilder = getQueryBuilderFromListParams({
+  //     repository: getRepository(DataSet),
+  //     params,
+  //     domain,
+  //     alias: 'dataset',
+  //     searchables: ['name', 'description', 'supervisoryRole']
+  //   })
+
+  //   const [items, total] = await queryBuilder.getManyAndCount()
+
+  //   return { items: [{
+
+  //   }], total }
+  // }
+
   @Query(returns => DataSetList, { description: 'To fetch multiple DataSets for data entry manually' })
   async dataSetsForEntry(@Args() params: ListParam, @Ctx() context: ResolverContext): Promise<DataSetList> {
     var { domain, user } = context.state
@@ -101,6 +122,18 @@ export class DataSetQuery {
     return { items, total }
   }
 
+  @FieldResolver(type => DataSetState)
+  async status(@Root() dataSet: DataSet): Promise<DataSetState> {
+    // get information from scheduler service
+    return {
+      id: '',
+      schedulerHandle: '',
+      state: '',
+      startedAt: new Date(),
+      nextSchedule: new Date()
+    }
+  }
+
   @FieldResolver(type => [DataItem])
   async dataItems(@Root() dataSet: DataSet): Promise<DataItem[]> {
     if (dataSet.dataItems instanceof Array) {

package/server/service/data-set/data-set-type.ts

@@ -3,6 +3,8 @@ import GraphQLUpload from 'graphql-upload/GraphQLUpload.js'
 import { Field, ID, InputType, Int, ObjectType } from 'type-graphql'
 
 import { ObjectRef, ScalarObject } from '@things-factory/shell'
+import { ApprovalLineItem } from '@things-factory/organization'
+import { AssigneeItem } from '@things-factory/worklist'
 
 import { DataItemPatch } from './data-item-type'
 import { DataSet, DataSetEntryType, DataSetMonitorType, DataSetReportType } from './data-set'
@@ -24,6 +26,12 @@ export class NewDataSet {
   @Field(type => ObjectRef, { nullable: true })
   supervisoryRole?: ObjectRef
 
+  @Field(type => ScalarObject, { nullable: true })
+  assignees?: AssigneeItem[]
+
+  @Field(type => ScalarObject, { nullable: true })
+  approvalLine?: ApprovalLineItem[]
+
   @Field({ nullable: true })
   active?: boolean
 
@@ -87,6 +95,12 @@ export class DataSetPatch {
   @Field(type => ObjectRef, { nullable: true })
   entryRole?: ObjectRef
 
+  @Field(type => ScalarObject, { nullable: true })
+  assignees?: AssigneeItem[]
+
+  @Field(type => ScalarObject, { nullable: true })
+  approvalLine?: ApprovalLineItem[]
+
   @Field({ nullable: true })
   active?: boolean
 

package/server/service/data-set/data-set.ts

@@ -13,6 +13,8 @@ import {
 
 import { Role, User } from '@things-factory/auth-base'
 import { Domain, ScalarObject } from '@things-factory/shell'
+import { ApprovalLineItem } from '@things-factory/organization'
+import { AssigneeItem } from '@things-factory/worklist'
 
 import { DataKeySet } from '../data-key-set/data-key-set'
 import { DataItem } from './data-item-type'
@@ -58,6 +60,24 @@ registerEnumType(DataSetReportType, {
   description: 'report type enumeration for data-set'
 })
 
+@ObjectType()
+export class DataSetState {
+  @Field()
+  id: string
+
+  @Field()
+  schedulerHandle: string
+
+  @Field()
+  state: string
+
+  @Field()
+  startedAt: Date
+
+  @Field()
+  nextSchedule: Date
+}
+
 @Entity()
 @Index('ix_data_set_0', (dataSet: DataSet) => [dataSet.domain, dataSet.name], { unique: true })
 @ObjectType({ description: 'Entity for DataSet' })
@@ -97,19 +117,33 @@ export class DataSet {
   dataKeySetId?: string
 
   @ManyToOne(type => Role, { nullable: true })
-  @Field(type => Role, { nullable: true })
+  @Field(type => Role, {
+    nullable: true,
+    description: 'The person responsible for manually entering the data for that dataset'
+  })
   entryRole?: Role
 
   @RelationId((dataSet: DataSet) => dataSet.entryRole)
   entryRoleId?: string
 
   @ManyToOne(type => Role, { nullable: true })
-  @Field(type => Role, { nullable: true })
+  @Field(type => Role, { nullable: true, description: 'The final authority on issues related to that dataset.' })
   supervisoryRole?: Role
 
   @RelationId((dataSet: DataSet) => dataSet.supervisoryRole)
   supervisoryRoleId?: string
 
+  @Column('simple-json', { nullable: true })
+  @Field(type => [AssigneeItem], { nullable: true, description: 'Who to contact for OOC issues' })
+  assignees?: AssigneeItem[]
+
+  @Column('simple-json', { nullable: true })
+  @Field(type => [ApprovalLineItem], {
+    nullable: true,
+    description: 'Approval line for handling OOC issues for that dataset'
+  })
+  approvalLine?: ApprovalLineItem[]
+
   @Column({ nullable: true })
   @Field({ nullable: true })
   type?: 'manual' | 'automatic' | string
@@ -161,6 +195,10 @@ export class DataSet {
   @Field({ nullable: true })
   timezone?: string
 
+  @Column({ nullable: true })
+  @Field({ nullable: true })
+  schedulerHandle?: string
+
   @CreateDateColumn()
   @Field({ nullable: true })
   createdAt?: Date

package/things-factory.config.js

@@ -20,6 +20,10 @@ export default {
       tagname: 'data-sample-search-page',
       page: 'data-sample-search'
     },
+    {
+      tagname: 'data-ooc-view-page',
+      page: 'data-ooc'
+    },
     {
       tagname: 'data-ooc-list-page',
       page: 'data-ooc-list'

package/translations/en.json

@@ -3,6 +3,8 @@
   "button.request-archive": "request archive",
   "button.reviewed": "reviewed",
   "field.appliance": "appliance",
+  "field.approval-line": "approval line",
+  "field.assignees": "assignees",
   "field.collected_at": "collected at",
   "field.corrective-action": "corrective action",
   "field.corrector": "corrector",

package/translations/ko.json

@@ -3,6 +3,8 @@
   "button.reviewed": "검토완료",
   "button.request-archive": "자료보관 신규 요청",
   "field.appliance": "어플라이언스",
+  "field.approval-line": "결재라인",
+  "field.assignees": "할당자 목록",
   "field.collected_at": "수집일시",
   "field.corrected-at": "조치 시간",
   "field.corrective-action": "조치 활동",

package/translations/ms.json

@@ -3,6 +3,8 @@
   "button.request-archive": "request archive",
   "button.reviewed": "reviewed",
   "field.appliance": "appliance",
+  "field.approval-line": "approval line",
+  "field.assignees": "assignees",
   "field.collected_at": "collected at",
   "field.corrective-action": "corrective action",
   "field.corrector": "corrector",

package/translations/zh.json

@@ -3,6 +3,8 @@
   "button.request-archive": "request archive",
   "button.reviewed": "reviewed",
   "field.appliance": "appliance",
+  "field.approval-line": "approval line",
+  "field.assignees": "assignees",
   "field.collected_at": "collected at",
   "field.corrective-action": "corrective action",
   "field.corrector": "corrector",

package/server/controllers/activity-template/activity-ooc.ts

@@ -1,55 +0,0 @@
-export const ActivityOoc = {
-  name: 'OOC Review',
-  description: 'Task to take remedial action based on Out Of Control data',
-  release: '1.0.0',
-  provider: 'hatiolab.com',
-  category: 'quality',
-  activityType: 'user',
-  startable: true,
-  model: [
-    {
-      name: 'dataOocId',
-      description: 'OOC id',
-      tag: 'dataOocId',
-      hidden: true,
-      mandatory: true,
-      inout: 'in',
-      type: 'string',
-      options: {},
-      unit: null,
-      quantifier: [1],
-      spec: {}
-    },
-    {
-      name: 'Instruction',
-      description: 'Instructions for preventing OOC',
-      tag: 'instruction',
-      hidden: false,
-      mandatory: true,
-      inout: 'in',
-      type: 'textarea',
-      options: {},
-      unit: null,
-      quantifier: [1],
-      spec: {}
-    },
-    {
-      name: 'action',
-      description: 'Action Description',
-      tag: 'action',
-      hidden: false,
-      mandatory: true,
-      inout: 'out',
-      type: 'textarea',
-      options: {},
-      unit: null,
-      quantifier: [1],
-      spec: {}
-    }
-  ],
-  uiType: 'custom-element',
-  uiSource: 'data-ooc-activity-view',
-  reportType: 'page',
-  reportSource: 'data-ooc-report-page',
-  thumbnail: '/assets/images/ooc.png'
-}