@things-factory/board-ai 10.1.52 → 10.1.53

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@things-factory/board-ai",
-  "version": "10.1.52",
+  "version": "10.1.53",
   "main": "dist-server/index.js",
   "browser": "dist-client/client/index.js",
   "things-factory": true,
@@ -32,10 +32,10 @@
     "@operato/i18n": "^10.0.0",
     "@operato/scene-ops": "^10.14.1",
     "@operato/styles": "^10.0.0",
-    "@things-factory/ai-assistant": "^10.1.52",
-    "@things-factory/ai-client-base": "^10.1.39",
+    "@things-factory/ai-assistant": "^10.1.53",
+    "@things-factory/ai-client-base": "^10.1.53",
     "@things-factory/auth-base": "^10.1.47",
-    "@things-factory/board-import": "^10.1.47",
+    "@things-factory/board-import": "^10.1.53",
     "@things-factory/env": "^10.1.20",
     "@things-factory/shell": "^10.1.47",
     "dompurify": "^3.0.0",
@@ -47,5 +47,5 @@
     "copyfiles": "^2.4.1",
     "rimraf": "^5.0.0"
   },
-  "gitHead": "b3ec4f0a38f0759d396f49b1f47c547bff4657be"
+  "gitHead": "1bdb0c604614735fd5a5467aee1e56f53be6b89e"
 }

package/server/service/assistant.ts

@@ -118,6 +118,18 @@ export interface BoardAIAssistantOptions {
   categories?: ComponentCategory[]
 }
 
+/**
+ * Said to the model when the person's rights turned the editing tools off (`boardToolsWithheld`). The editing
+ * guide above still describes the tools, so without this the model calls them anyway, fails on each, and
+ * writes the calls out as its answer.
+ */
+export const BOARD_EDIT_WITHHELD =
+  '==== BOARD EDITING IS OFF FOR THIS PERSON ====\n' +
+  'This person has no permission to change boards (board-ai mutation), so this conversation has no editing tool - ' +
+  'the editing instructions above do not apply. Never call an editing tool and never write a tool call out as text. ' +
+  'When asked to change the board, say it cannot be changed from this conversation because changing boards needs the ' +
+  'board edit permission, which an administrator can grant. You can still answer questions about the board.'
+
 export class DefaultBoardAIAssistant implements BoardAIAssistant {
   readonly id: string
   constructor(private base: AIClient, private options: BoardAIAssistantOptions = {}) {
@@ -183,7 +195,8 @@ export class DefaultBoardAIAssistant implements BoardAIAssistant {
     const systemPrompt =
       this.buildSystemPromptForTools(knownTypes, categories, schemas) +
       (surface ? `\n\n==== THIS SURFACE (declared by the app) ====\n${surface}` : '') +
-      (guidance.length ? `\n\n==== TOOL USE RULES (from the tools exposed to this conversation) ====\n${guidance.join('\n')}` : '')
+      (guidance.length ? `\n\n==== TOOL USE RULES (from the tools exposed to this conversation) ====\n${guidance.join('\n')}` : '') +
+      (!gate.coreOn && options.boardToolsWithheld ? `\n\n${BOARD_EDIT_WITHHELD}` : '')
 
     const selectedRefids = (options.selectedRefids ?? []).filter(
       (n): n is number => typeof n === 'number' && Number.isFinite(n)

package/server/service/board-ai-resolver.ts

@@ -439,13 +439,18 @@ export class BoardAIChatResolver {
       }))
     }
 
+    /* The surface wanted board editing and the person's rights took it away - the model is told, so it says so. */
+    const boardTools = await effectiveBoardTools(input.boardTools, context)
+    const boardToolsWithheld = input.boardTools !== false && boardTools === false
+
     const r = await assistant.chat(llmMessages, input.currentBoard ?? undefined, {
       scopes: input.scopes,
       hostContext: input.hostContext ?? undefined,
       surfacePrompt: modeSettings?.systemPrompt,
       /* 대화면별 도구 노출 — 모드가 있으면 서버 선언(빈 목록 = 외부 도구 없음), 없으면 호출자 값(미지정 = 전부). */
       toolCategories: modeSettings ? modeSettings.toolCategories ?? [] : input.toolCategories ?? undefined,
-      boardTools: await effectiveBoardTools(input.boardTools, context),
+      boardTools,
+      boardToolsWithheld,
       requireGroundingTools: modeSettings ? modeSettings.requireToolOnFirstTurn : input.requireGroundingTools ?? undefined,
       knownTypes: input.knownTypes,
       categories: input.categories as ComponentCategory[] | undefined,

package/server/service/dock-contract.test.ts

@@ -16,7 +16,7 @@
 import type { AIClient } from '@things-factory/ai-client-base'
 import { registerToolCategory, clearToolRegistry } from '@things-factory/ai-client-base'
 
-import { DefaultBoardAIAssistant } from './assistant'
+import { BOARD_EDIT_WITHHELD, DefaultBoardAIAssistant } from './assistant'
 
 /** 스크립트된 턴을 돌려주는 가짜 provider — 호출 옵션도 기록한다(toolChoice 확인용). */
 function mockClient(turns: Array<{ text?: string; toolCalls: any[] }>) {
@@ -306,3 +306,28 @@ describe('도크 계약 — 도구 사용 규율이 프롬프트에 실린다',
     expect(calls[0].options.systemPrompt).not.toContain('OTHER-RULE')
   })
 })
+
+describe('dock contract - board editing withheld by rights', () => {
+  it('the model is told editing is off when the rights took the tools away', async () => {
+    const { client, calls } = mockClient([{ text: 'I cannot change the board here.', toolCalls: [] }])
+    await new DefaultBoardAIAssistant(client).chat([{ role: 'user', content: 'add a title' }], { components: [] } as any, {
+      boardTools: false,
+      boardToolsWithheld: true
+    })
+    expect(calls[0].options.systemPrompt).toContain(BOARD_EDIT_WITHHELD)
+  })
+
+  it('a surface that turned the tools off itself is not told about rights', async () => {
+    const { client, calls } = mockClient([{ text: 'ok', toolCalls: [] }])
+    await new DefaultBoardAIAssistant(client).chat([{ role: 'user', content: 'status?' }], undefined, { boardTools: false })
+    expect(calls[0].options.systemPrompt).not.toContain(BOARD_EDIT_WITHHELD)
+  })
+
+  it('with the tools on, nothing is said', async () => {
+    const { client, calls } = mockClient([{ text: 'ok', toolCalls: [] }])
+    await new DefaultBoardAIAssistant(client).chat([{ role: 'user', content: 'add a title' }], { components: [] } as any, {
+      boardToolsWithheld: true
+    })
+    expect(calls[0].options.systemPrompt).not.toContain(BOARD_EDIT_WITHHELD)
+  })
+})

package/server/service/types.ts

@@ -37,6 +37,12 @@ export interface ChatOptions {
    * 되돌릴 수 있는 편집이 한 대화에 섞이지 않게 한다.
    */
   boardTools?: boolean
+  /**
+   * The surface asked for board editing but the person has no board-ai:mutation, so the editing tools are off.
+   * The model is told in so many words - otherwise the editing guide in the prompt leads it to call tools that
+   * are not there and to write the calls out as text.
+   */
+  boardToolsWithheld?: boolean
   /**
    * **첫 턴에 도구 호출을 강제**한다. 라이브 상태를 다루는 대화면(운영 협의)에서 켠다.
    *