@things-factory/board-ai 10.1.24 → 10.1.26

package/server/service/assistant.test.ts

@@ -2,13 +2,13 @@
  * assistant.ts 의 pure helper 회귀 방지.
  *
  * 핵심 보호:
- *  - LLM tool call → BoardEditOp 매핑이 잘못된 인자에서도 안전
+ *  - LLM tool call → SceneEditOp 매핑이 잘못된 인자에서도 안전
  *  - JSON fallback 응답 정규화: 망가진 ops, 빠진 confidence, 잘못된 타입에서도 적절히 무시
  *  - summarizeBoard: 토큰 절감 — 컴포넌트 수 제한, 필요 속성만 노출
  */
 import {
-  toolCallToBoardEditOp,
-  toolCallToBoardActionOp,
+  toolCallToSceneEditOp,
+  toolCallToSceneActionOp,
   toolResultToChatResponse,
   isReadTool,
   isWriteTool,
@@ -21,9 +21,9 @@ import {
 } from './assistant'
 import { isGroundedAnalysisContract } from '@things-factory/ai-client-base'
 
-describe('toolCallToBoardEditOp', () => {
+describe('toolCallToSceneEditOp', () => {
   test('addComponent: 정상 인자', () => {
-    const r = toolCallToBoardEditOp({
+    const r = toolCallToSceneEditOp({
       id: '1',
       name: 'addComponent',
       arguments: { id: 'a', type: 'rect', left: 0, top: 0 }
@@ -32,12 +32,12 @@ describe('toolCallToBoardEditOp', () => {
   })
 
   test('addComponent: type 누락 → null', () => {
-    const r = toolCallToBoardEditOp({ id: '1', name: 'addComponent', arguments: { id: 'a' } } as any)
+    const r = toolCallToSceneEditOp({ id: '1', name: 'addComponent', arguments: { id: 'a' } } as any)
     expect(r).toBeNull()
   })
 
   test('removeComponentByRefid: 정상', () => {
-    const r = toolCallToBoardEditOp({
+    const r = toolCallToSceneEditOp({
       id: '1',
       name: 'removeComponentByRefid',
       arguments: { refid: 35 }
@@ -46,7 +46,7 @@ describe('toolCallToBoardEditOp', () => {
   })
 
   test('removeComponentByRefid: refid 누락 → null', () => {
-    const r = toolCallToBoardEditOp({
+    const r = toolCallToSceneEditOp({
       id: '1',
       name: 'removeComponentByRefid',
       arguments: {}
@@ -55,7 +55,7 @@ describe('toolCallToBoardEditOp', () => {
   })
 
   test('removeComponentByRefid: refid 가 number 아니면 null (id 로는 targeting 안 함)', () => {
-    const r = toolCallToBoardEditOp({
+    const r = toolCallToSceneEditOp({
       id: '1',
       name: 'removeComponentByRefid',
       arguments: { refid: 'AGV-1' }
@@ -64,7 +64,7 @@ describe('toolCallToBoardEditOp', () => {
   })
 
   test('modifyComponentByRefid: 정상', () => {
-    const r = toolCallToBoardEditOp({
+    const r = toolCallToSceneEditOp({
       id: '1',
       name: 'modifyComponentByRefid',
       arguments: { refid: 35, patch: { left: 100 } }
@@ -73,7 +73,7 @@ describe('toolCallToBoardEditOp', () => {
   })
 
   test('modifyComponentByRefid: patch 가 객체가 아니면 null', () => {
-    const r = toolCallToBoardEditOp({
+    const r = toolCallToSceneEditOp({
       id: '1',
       name: 'modifyComponentByRefid',
       arguments: { refid: 35, patch: 'string' }
@@ -82,7 +82,7 @@ describe('toolCallToBoardEditOp', () => {
   })
 
   test('modifyComponentByRefid: refid 누락 → null', () => {
-    const r = toolCallToBoardEditOp({
+    const r = toolCallToSceneEditOp({
       id: '1',
       name: 'modifyComponentByRefid',
       arguments: { patch: { left: 100 } }
@@ -92,52 +92,52 @@ describe('toolCallToBoardEditOp', () => {
 
   test('legacy 이름 (removeComponent / modifyComponent / getComponent) → null', () => {
     // 이름이 refid 기반으로 명시 변경됐다 — legacy 이름은 invalid 로 거부.
-    expect(toolCallToBoardEditOp({ id: '1', name: 'removeComponent', arguments: { id: 'a' } } as any)).toBeNull()
+    expect(toolCallToSceneEditOp({ id: '1', name: 'removeComponent', arguments: { id: 'a' } } as any)).toBeNull()
     expect(
-      toolCallToBoardEditOp({ id: '1', name: 'modifyComponent', arguments: { id: 'a', patch: {} } } as any)
+      toolCallToSceneEditOp({ id: '1', name: 'modifyComponent', arguments: { id: 'a', patch: {} } } as any)
     ).toBeNull()
   })
 
-  test('modifyBoard: patch 객체 정상 — root 속성 변경', () => {
-    const r = toolCallToBoardEditOp({
+  test('modifyScene: patch 객체 정상 — root 속성 변경', () => {
+    const r = toolCallToSceneEditOp({
       id: '1',
-      name: 'modifyBoard',
+      name: 'modifyScene',
       arguments: { patch: { fillStyle: '#0a1929' } }
     } as any)
-    expect(r).toEqual({ op: 'modifyBoard', patch: { fillStyle: '#0a1929' } })
+    expect(r).toEqual({ op: 'modifyScene', patch: { fillStyle: '#0a1929' } })
   })
 
-  test('modifyBoard: patch 누락 → null', () => {
+  test('modifyScene: patch 누락 → null', () => {
     expect(
-      toolCallToBoardEditOp({ id: '1', name: 'modifyBoard', arguments: {} } as any)
+      toolCallToSceneEditOp({ id: '1', name: 'modifyScene', arguments: {} } as any)
     ).toBeNull()
   })
 
-  test('modifyBoard: patch 가 array 면 null (object 만 허용)', () => {
+  test('modifyScene: patch 가 array 면 null (object 만 허용)', () => {
     expect(
-      toolCallToBoardEditOp({
+      toolCallToSceneEditOp({
         id: '1',
-        name: 'modifyBoard',
+        name: 'modifyScene',
         arguments: { patch: [1, 2] }
       } as any)
     ).toBeNull()
   })
 
-  test('modifyBoard: 다중 root 속성 변경', () => {
-    const r = toolCallToBoardEditOp({
+  test('modifyScene: 다중 root 속성 변경', () => {
+    const r = toolCallToSceneEditOp({
       id: '1',
-      name: 'modifyBoard',
+      name: 'modifyScene',
       arguments: { patch: { fillStyle: '#0a1929', name: 'Production', width: 1920 } }
     } as any)
     expect(r).toEqual({
-      op: 'modifyBoard',
+      op: 'modifyScene',
       patch: { fillStyle: '#0a1929', name: 'Production', width: 1920 }
     })
   })
 
   // Phase 2 — Scene 조작 tool dispatcher
   test('alignComponents: 정상', () => {
-    const r = toolCallToBoardEditOp({
+    const r = toolCallToSceneEditOp({
       id: '1',
       name: 'alignComponents',
       arguments: { refids: [1, 2, 3], direction: 'left' }
@@ -147,7 +147,7 @@ describe('toolCallToBoardEditOp', () => {
 
   test('alignComponents: 잘못된 direction → null', () => {
     expect(
-      toolCallToBoardEditOp({
+      toolCallToSceneEditOp({
         id: '1',
         name: 'alignComponents',
         arguments: { refids: [1, 2], direction: 'sideways' }
@@ -157,7 +157,7 @@ describe('toolCallToBoardEditOp', () => {
 
   test('alignComponents: refids 비어있음 → null', () => {
     expect(
-      toolCallToBoardEditOp({
+      toolCallToSceneEditOp({
         id: '1',
         name: 'alignComponents',
         arguments: { refids: [], direction: 'left' }
@@ -166,7 +166,7 @@ describe('toolCallToBoardEditOp', () => {
   })
 
   test('alignComponents: refids 안의 non-number 무시', () => {
-    const r = toolCallToBoardEditOp({
+    const r = toolCallToSceneEditOp({
       id: '1',
       name: 'alignComponents',
       arguments: { refids: [1, 'foo', 2, null], direction: 'center' }
@@ -175,7 +175,7 @@ describe('toolCallToBoardEditOp', () => {
   })
 
   test('distributeComponents: 정상', () => {
-    const r = toolCallToBoardEditOp({
+    const r = toolCallToSceneEditOp({
       id: '1',
       name: 'distributeComponents',
       arguments: { refids: [1, 2, 3], axis: 'horizontal' }
@@ -185,7 +185,7 @@ describe('toolCallToBoardEditOp', () => {
 
   test('distributeComponents: 잘못된 axis → null', () => {
     expect(
-      toolCallToBoardEditOp({
+      toolCallToSceneEditOp({
         id: '1',
         name: 'distributeComponents',
         arguments: { refids: [1, 2, 3], axis: 'diagonal' }
@@ -195,14 +195,14 @@ describe('toolCallToBoardEditOp', () => {
 
   test('groupComponents: 2개 이상 필수', () => {
     expect(
-      toolCallToBoardEditOp({
+      toolCallToSceneEditOp({
         id: '1',
         name: 'groupComponents',
         arguments: { refids: [1] }
       } as any)
     ).toBeNull()
     expect(
-      toolCallToBoardEditOp({
+      toolCallToSceneEditOp({
         id: '1',
         name: 'groupComponents',
         arguments: { refids: [1, 2] }
@@ -212,14 +212,14 @@ describe('toolCallToBoardEditOp', () => {
 
   test('ungroupComponent: refid number 필수', () => {
     expect(
-      toolCallToBoardEditOp({
+      toolCallToSceneEditOp({
         id: '1',
         name: 'ungroupComponent',
         arguments: { refid: 5 }
       } as any)
     ).toEqual({ op: 'ungroup', refid: 5 })
     expect(
-      toolCallToBoardEditOp({
+      toolCallToSceneEditOp({
         id: '1',
         name: 'ungroupComponent',
         arguments: {}
@@ -229,7 +229,7 @@ describe('toolCallToBoardEditOp', () => {
 
   test('changeZorder: 4 direction 모두', () => {
     for (const d of ['front', 'back', 'forward', 'backward'] as const) {
-      const r = toolCallToBoardEditOp({
+      const r = toolCallToSceneEditOp({
         id: '1',
         name: 'changeZorder',
         arguments: { refid: 1, direction: d }
@@ -240,7 +240,7 @@ describe('toolCallToBoardEditOp', () => {
 
   test('changeZorder: 잘못된 direction → null', () => {
     expect(
-      toolCallToBoardEditOp({
+      toolCallToSceneEditOp({
         id: '1',
         name: 'changeZorder',
         arguments: { refid: 1, direction: 'sideways' }
@@ -248,9 +248,9 @@ describe('toolCallToBoardEditOp', () => {
     ).toBeNull()
   })
 
-  // C-1 — ephemeral action tool dispatcher (toolCallToBoardActionOp 별도)
-  test('toolCallToBoardActionOp — selectComponents 정상', () => {
-    const r = toolCallToBoardActionOp({
+  // C-1 — ephemeral action tool dispatcher (toolCallToSceneActionOp 별도)
+  test('toolCallToSceneActionOp — selectComponents 정상', () => {
+    const r = toolCallToSceneActionOp({
       id: '1',
       name: 'selectComponents',
       arguments: { refids: [1, 2, 3] }
@@ -258,8 +258,8 @@ describe('toolCallToBoardEditOp', () => {
     expect(r).toEqual({ action: 'selectComponents', refids: [1, 2, 3] })
   })
 
-  test('toolCallToBoardActionOp — selectComponents 빈 배열도 OK (deselect)', () => {
-    const r = toolCallToBoardActionOp({
+  test('toolCallToSceneActionOp — selectComponents 빈 배열도 OK (deselect)', () => {
+    const r = toolCallToSceneActionOp({
       id: '1',
       name: 'selectComponents',
       arguments: { refids: [] }
@@ -267,8 +267,8 @@ describe('toolCallToBoardEditOp', () => {
     expect(r).toEqual({ action: 'selectComponents', refids: [] })
   })
 
-  test('toolCallToBoardActionOp — selectComponents non-number 무시', () => {
-    const r = toolCallToBoardActionOp({
+  test('toolCallToSceneActionOp — selectComponents non-number 무시', () => {
+    const r = toolCallToSceneActionOp({
       id: '1',
       name: 'selectComponents',
       arguments: { refids: [1, 'foo', 2] }
@@ -276,9 +276,9 @@ describe('toolCallToBoardEditOp', () => {
     expect(r).toEqual({ action: 'selectComponents', refids: [1, 2] })
   })
 
-  test('toolCallToBoardActionOp — centerToComponent + animated', () => {
+  test('toolCallToSceneActionOp — centerToComponent + animated', () => {
     expect(
-      toolCallToBoardActionOp({
+      toolCallToSceneActionOp({
         id: '1',
         name: 'centerToComponent',
         arguments: { refid: 7, animated: false }
@@ -286,9 +286,9 @@ describe('toolCallToBoardEditOp', () => {
     ).toEqual({ action: 'centerToComponent', refid: 7, animated: false })
   })
 
-  test('toolCallToBoardActionOp — centerToComponent refid 누락 → null', () => {
+  test('toolCallToSceneActionOp — centerToComponent refid 누락 → null', () => {
     expect(
-      toolCallToBoardActionOp({
+      toolCallToSceneActionOp({
         id: '1',
         name: 'centerToComponent',
         arguments: {}
@@ -296,15 +296,15 @@ describe('toolCallToBoardEditOp', () => {
     ).toBeNull()
   })
 
-  test('toolCallToBoardActionOp — fitToView 인자 없음 OK', () => {
+  test('toolCallToSceneActionOp — fitToView 인자 없음 OK', () => {
     expect(
-      toolCallToBoardActionOp({ id: '1', name: 'fitToView', arguments: {} } as any)
+      toolCallToSceneActionOp({ id: '1', name: 'fitToView', arguments: {} } as any)
     ).toEqual({ action: 'fitToView' })
   })
 
-  test('toolCallToBoardActionOp — fitToView 잘못된 mode 는 무시', () => {
+  test('toolCallToSceneActionOp — fitToView 잘못된 mode 는 무시', () => {
     expect(
-      toolCallToBoardActionOp({
+      toolCallToSceneActionOp({
         id: '1',
         name: 'fitToView',
         arguments: { mode: 'diagonal' }
@@ -312,16 +312,16 @@ describe('toolCallToBoardEditOp', () => {
     ).toEqual({ action: 'fitToView' }) // mode 키 자체가 빠짐
   })
 
-  test('toolCallToBoardActionOp — setSceneMode edit/view 만', () => {
+  test('toolCallToSceneActionOp — setSceneMode edit/view 만', () => {
     expect(
-      toolCallToBoardActionOp({
+      toolCallToSceneActionOp({
         id: '1',
         name: 'setSceneMode',
         arguments: { mode: 'edit' }
       } as any)
     ).toEqual({ action: 'setSceneMode', mode: 'edit' })
     expect(
-      toolCallToBoardActionOp({
+      toolCallToSceneActionOp({
         id: '1',
         name: 'setSceneMode',
         arguments: { mode: 'something' }
@@ -330,26 +330,26 @@ describe('toolCallToBoardEditOp', () => {
   })
 
   test('replaceBoard: 정상', () => {
-    const r = toolCallToBoardEditOp({
+    const r = toolCallToSceneEditOp({
       id: '1',
       name: 'replaceBoard',
       arguments: { width: 1920, height: 1080, components: [{ type: 'rect' }] }
     } as any)
     expect(r?.op).toBe('replace')
     if (r && r.op === 'replace') {
-      expect(r.board.width).toBe(1920)
-      expect(r.board.components).toHaveLength(1)
+      expect(r.model.width).toBe(1920)
+      expect(r.model.components).toHaveLength(1)
     }
   })
 
   test('replaceBoard: components 누락 → null', () => {
-    const r = toolCallToBoardEditOp({ id: '1', name: 'replaceBoard', arguments: {} } as any)
+    const r = toolCallToSceneEditOp({ id: '1', name: 'replaceBoard', arguments: {} } as any)
     expect(r).toBeNull()
   })
 
   // Sugar layout — arrangeInGrid/Row/Column dispatcher
   test('arrangeInGrid: 정상 — refids + cols + 기본값', () => {
-    const r = toolCallToBoardEditOp({
+    const r = toolCallToSceneEditOp({
       id: '1',
       name: 'arrangeInGrid',
       arguments: { refids: [1, 2, 3, 4], cols: 2 }
@@ -362,7 +362,7 @@ describe('toolCallToBoardEditOp', () => {
   })
 
   test('arrangeInGrid: gap + anchor 반영', () => {
-    const r = toolCallToBoardEditOp({
+    const r = toolCallToSceneEditOp({
       id: '1',
       name: 'arrangeInGrid',
       arguments: {
@@ -380,14 +380,14 @@ describe('toolCallToBoardEditOp', () => {
 
   test('arrangeInGrid: cols 누락 / refids 부족 → null', () => {
     expect(
-      toolCallToBoardEditOp({
+      toolCallToSceneEditOp({
         id: '1',
         name: 'arrangeInGrid',
         arguments: { refids: [1, 2] }
       } as any)
     ).toBeNull()
     expect(
-      toolCallToBoardEditOp({
+      toolCallToSceneEditOp({
         id: '1',
         name: 'arrangeInGrid',
         arguments: { refids: [1], cols: 2 }
@@ -397,7 +397,7 @@ describe('toolCallToBoardEditOp', () => {
 
   test('arrangeInGrid: cols 가 1 미만 → null', () => {
     expect(
-      toolCallToBoardEditOp({
+      toolCallToSceneEditOp({
         id: '1',
         name: 'arrangeInGrid',
         arguments: { refids: [1, 2], cols: 0 }
@@ -406,7 +406,7 @@ describe('toolCallToBoardEditOp', () => {
   })
 
   test('arrangeInRow: 정상 — refids 만 있어도 OK', () => {
-    const r = toolCallToBoardEditOp({
+    const r = toolCallToSceneEditOp({
       id: '1',
       name: 'arrangeInRow',
       arguments: { refids: [1, 2, 3] }
@@ -418,7 +418,7 @@ describe('toolCallToBoardEditOp', () => {
   })
 
   test('arrangeInRow: align + gap', () => {
-    const r = toolCallToBoardEditOp({
+    const r = toolCallToSceneEditOp({
       id: '1',
       name: 'arrangeInRow',
       arguments: { refids: [1, 2], align: 'center', gap: 30 }
@@ -430,7 +430,7 @@ describe('toolCallToBoardEditOp', () => {
   })
 
   test('arrangeInRow: 잘못된 align 은 무시 (drop)', () => {
-    const r = toolCallToBoardEditOp({
+    const r = toolCallToSceneEditOp({
       id: '1',
       name: 'arrangeInRow',
       arguments: { refids: [1, 2], align: 'top' }
@@ -441,7 +441,7 @@ describe('toolCallToBoardEditOp', () => {
   })
 
   test('arrangeInColumn: 정상', () => {
-    const r = toolCallToBoardEditOp({
+    const r = toolCallToSceneEditOp({
       id: '1',
       name: 'arrangeInColumn',
       arguments: { refids: [1, 2], align: 'end', gap: 5 }
@@ -453,14 +453,14 @@ describe('toolCallToBoardEditOp', () => {
 
   test('arrangeInRow/Column: refids < 2 → null', () => {
     expect(
-      toolCallToBoardEditOp({
+      toolCallToSceneEditOp({
         id: '1',
         name: 'arrangeInRow',
         arguments: { refids: [1] }
       } as any)
     ).toBeNull()
     expect(
-      toolCallToBoardEditOp({
+      toolCallToSceneEditOp({
         id: '1',
         name: 'arrangeInColumn',
         arguments: { refids: [] }
@@ -476,7 +476,7 @@ describe('toolCallToBoardEditOp', () => {
 
   // Prefab — addPrefab dispatcher
   test('addPrefab: 정상 — registry 의 build 호출 + add op 으로 매핑', () => {
-    const r = toolCallToBoardEditOp({
+    const r = toolCallToSceneEditOp({
       id: '1',
       name: 'addPrefab',
       arguments: {
@@ -500,7 +500,7 @@ describe('toolCallToBoardEditOp', () => {
   })
 
   test('addPrefab: width/height override', () => {
-    const r = toolCallToBoardEditOp({
+    const r = toolCallToSceneEditOp({
       id: '1',
       name: 'addPrefab',
       arguments: { name: 'monitor-card', left: 0, top: 0, width: 300, height: 180 }
@@ -512,7 +512,7 @@ describe('toolCallToBoardEditOp', () => {
   })
 
   test('addPrefab: 등록되지 않은 name → null', () => {
-    const r = toolCallToBoardEditOp({
+    const r = toolCallToSceneEditOp({
       id: '1',
       name: 'addPrefab',
       arguments: { name: 'no-such-prefab', left: 0, top: 0 }
@@ -522,7 +522,7 @@ describe('toolCallToBoardEditOp', () => {
 
   test('addPrefab: name 누락 → null', () => {
     expect(
-      toolCallToBoardEditOp({
+      toolCallToSceneEditOp({
         id: '1',
         name: 'addPrefab',
         arguments: { left: 0, top: 0 }
@@ -532,14 +532,14 @@ describe('toolCallToBoardEditOp', () => {
 
   test('addPrefab: 좌표 누락 → null', () => {
     expect(
-      toolCallToBoardEditOp({
+      toolCallToSceneEditOp({
         id: '1',
         name: 'addPrefab',
         arguments: { name: 'monitor-card' }
       } as any)
     ).toBeNull()
     expect(
-      toolCallToBoardEditOp({
+      toolCallToSceneEditOp({
         id: '1',
         name: 'addPrefab',
         arguments: { name: 'monitor-card', left: 0 }
@@ -548,12 +548,12 @@ describe('toolCallToBoardEditOp', () => {
   })
 
   test('알 수 없는 tool name → null', () => {
-    const r = toolCallToBoardEditOp({ id: '1', name: 'unknownTool', arguments: {} } as any)
+    const r = toolCallToSceneEditOp({ id: '1', name: 'unknownTool', arguments: {} } as any)
     expect(r).toBeNull()
   })
 
   test('arguments 누락도 안전', () => {
-    const r = toolCallToBoardEditOp({ id: '1', name: 'addComponent' } as any)
+    const r = toolCallToSceneEditOp({ id: '1', name: 'addComponent' } as any)
     expect(r).toBeNull()
   })
 })
@@ -863,8 +863,8 @@ describe('buildBoardEditTools — refid 기반 tool 이름 (식별자 정책 회
       'importBoardAsync',
       'listImportAdapters',
       'materializeImportSession',
-      'modifyBoard',
       'modifyComponentByRefid',
+      'modifyScene',
       'removeComponentByRefid',
       'replaceBoard',
       'selectComponents',
@@ -951,15 +951,15 @@ describe('buildBoardEditTools — refid 기반 tool 이름 (식별자 정책 회
     expect(t.parameters.properties.mode.enum).toEqual(['edit', 'view'])
   })
 
-  test('modifyBoard 는 patch (object) 필수', () => {
+  test('modifyScene 는 patch (object) 필수', () => {
     const tools = buildBoardEditTools([])
-    const t = tools.find(x => x.name === 'modifyBoard')!
+    const t = tools.find(x => x.name === 'modifyScene')!
     expect(t.parameters.required).toEqual(['patch'])
     expect(t.parameters.properties.patch.type).toBe('object')
   })
 
-  test('isWriteTool 가 modifyBoard 인식', () => {
-    expect(isWriteTool('modifyBoard')).toBe(true)
+  test('isWriteTool 가 modifyScene 인식', () => {
+    expect(isWriteTool('modifyScene')).toBe(true)
   })
 
   test('getSelection 은 인자 없음', () => {
@@ -1554,7 +1554,7 @@ describe('executeReadTool — getAtmosphereGuide (3D 분위기 합성 primer)',
     expect(r.archetypes).toHaveProperty('surreal')
   })
 
-  test('각 archetype 은 description + patch 보유 (modifyBoard patch 그대로 사용 가능)', () => {
+  test('각 archetype 은 description + patch 보유 (modifyScene patch 그대로 사용 가능)', () => {
     const r = executeReadTool(
       { id: '1', name: 'getAtmosphereGuide', arguments: {} } as any,
       null,