@things-factory/biz-base 10.1.241 → 10.1.243

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@things-factory/biz-base",
-  "version": "10.1.241",
+  "version": "10.1.243",
   "main": "dist-server/index.js",
   "browser": "client/index.js",
   "exports": {
@@ -44,5 +44,5 @@
     "@things-factory/attachment-base": "^10.1.241",
     "@things-factory/auth-base": "^10.1.241"
   },
-  "gitHead": "d7fe2e1a1eb7c02cb21b897da26d385df014f908"
+  "gitHead": "70a77f8a032f297a9d756ad530d3072e7a6c4bed"
 }

package/tests/counterparty.test.mjs

@@ -76,3 +76,46 @@ test('a module that keeps names hears every save, in the same transaction', asyn
   await save([{ name: '니어솔루션', aliases: '니어\n제이투-니어' }])
   assert.deepEqual(heard, ['니어솔루션'])
 })
+
+test('four kinds - a business, an institution, a person, our own company - by the words people write', async () => {
+  const saved = await save([
+    { name: '성남세무서', kind: '기관' },
+    { name: '김직원', kind: '개인' },
+    { name: '개인사업자 상점', kind: '사업자' }
+  ])
+  assert.deepEqual(saved.map(one => one.kind), ['INSTITUTION', 'PERSON', 'COMPANY'])
+  await assert.rejects(save([{ name: '무엇', kind: '외국회사' }]), { code: 'counterparty-kind-invalid' })
+})
+
+test('our own company is one counterparty, and it keeps none of the facts 「우리 회사」 keeps', async () => {
+  await assert.rejects(save([{ name: '(주)우리', kind: '자사', businessNumber: '3334455555' }]), { code: 'counterparty-self-facts' })
+  const [self] = await save([{ name: '(주)우리', kind: '자사', aliases: '（주）우리\n주식회사우리' }])
+  assert.equal(self.kind, 'SELF')
+  await assert.rejects(save([{ name: '우리 둘째', kind: 'SELF' }]), { code: 'counterparty-self-taken' })
+  await assert.rejects(save([{ id: self.id, cuFlag: 'M', address: '성남시' }]), { code: 'counterparty-self-facts' })
+
+  const [other] = await save([{ name: '주소 있는 곳', address: '서울' }])
+  await assert.rejects(save([{ id: other.id, cuFlag: 'M', kind: '자사' }]), { code: 'counterparty-self-facts' }, 'a row turned into our company brings its facts')
+  await save([{ id: self.id, cuFlag: 'M', notes: '자기 계좌 사이' }])
+  await save([{ id: self.id, cuFlag: '-' }])
+  const [again] = await save([{ name: '(주)우리', kind: 'SELF' }])
+  assert.equal(again.kind, 'SELF', 'a deleted one frees the place')
+})
+
+test('a country is two letters, home is empty, and a number abroad is kept as written', async () => {
+  const [home] = await save([{ name: '국내', country: 'kr', businessNumber: '4445566666' }])
+  assert.equal(home.country, null, 'home is written one way')
+  assert.equal(home.businessNumber, '444-55-66666')
+  assert.equal(home.zeroRated, false)
+
+  const [abroad] = await save([{ name: 'SK AX USA', country: 'us', businessNumber: '12-3456789' }])
+  assert.equal(abroad.country, 'US')
+  assert.equal(abroad.businessNumber, '12-3456789', 'its form is not checked')
+  assert.equal(abroad.zeroRated, true, 'sales abroad are zero-rated unless said')
+  const [said] = await save([{ name: 'Torch', country: 'JP', zeroRated: false }])
+  assert.equal(said.zeroRated, false)
+
+  const [moved] = await save([{ id: abroad.id, cuFlag: 'M', businessNumber: 'EIN 98 765' }])
+  assert.equal(moved.businessNumber, 'EIN98765', 'a changed number takes the stored country')
+  await assert.rejects(save([{ name: '어디', country: 'USA' }]), { code: 'counterparty-country-invalid' })
+})

package/translations/en.json

@@ -13,7 +13,7 @@
   "error.counterparty-name-required": "Give the counterparty a name.",
   "error.counterparty-number-clash": "Business number {number} already belongs to '{existing}'. Edit that counterparty instead.",
   "error.counterparty-not-found": "The counterparty was not found. Reload it.",
-  "error.counterparty-kind-invalid": "'{text}' is neither a company nor a person.",
+  "error.counterparty-kind-invalid": "'{text}' is not a counterparty kind. Choose a business, an institution, a person or our company.",
   "error.business-number-invalid": "'{text}' is not a business registration number. It has 10 digits.",
   "error.counterparty-account-number-required": "Give the account number.",
   "error.counterparty-account-clash": "Account {number} is already registered to '{existing}'.",
@@ -27,5 +27,8 @@
   "error.company-name-taken": "Trade name {value} is already another company's in this workspace.",
   "error.counterparty-account-number-letters": "Account number '{value}' has characters other than digits and hyphens. Enter digits and hyphens only.",
   "error.counterparty-account-counterparty-required": "Choose the account's counterparty.",
-  "error.bizplace-not-accessible": "The bizplace was not found, or it is not yours to see. Reload the list."
+  "error.bizplace-not-accessible": "The bizplace was not found, or it is not yours to see. Reload the list.",
+  "error.counterparty-self-facts": "'{name}' is our own company. Its business number, branch number, representative, addresses, business type and item are kept in Our company only. Clear those fields.",
+  "error.counterparty-self-taken": "There is one own-company counterparty. '{existing}' already is.",
+  "error.counterparty-country-invalid": "'{text}' is not a country code. Write two letters such as US or JP, and leave it empty for one at home."
 }

package/translations/es.json

@@ -13,7 +13,7 @@
   "error.counterparty-name-required": "Asigne un nombre a la contraparte.",
   "error.counterparty-number-clash": "El número de empresa {number} ya pertenece a '{existing}'. Edite esa contraparte en su lugar.",
   "error.counterparty-not-found": "No se encontró la contraparte. Vuelva a cargarla.",
-  "error.counterparty-kind-invalid": "'{text}' no es ni una empresa ni una persona.",
+  "error.counterparty-kind-invalid": "'{text}' no es una clase de contraparte. Elija empresa, institución, persona o nuestra empresa.",
   "error.business-number-invalid": "'{text}' no es un número de registro empresarial. Debe tener 10 dígitos.",
   "error.counterparty-account-number-required": "Indique el número de cuenta.",
   "error.counterparty-account-clash": "La cuenta {number} ya está registrada a '{existing}'.",
@@ -27,5 +27,8 @@
   "error.company-name-taken": "La razón social {value} ya la usa otra empresa de este espacio de trabajo.",
   "error.counterparty-account-number-letters": "El número de cuenta '{value}' tiene caracteres que no son dígitos ni guiones. Introduzca solo dígitos y guiones.",
   "error.counterparty-account-counterparty-required": "Elija la contraparte de la cuenta.",
-  "error.bizplace-not-accessible": "No se encontró el centro o no puede verlo. Vuelva a cargar la lista."
+  "error.bizplace-not-accessible": "No se encontró el centro o no puede verlo. Vuelva a cargar la lista.",
+  "error.counterparty-self-facts": "'{name}' es nuestra propia empresa. Su número fiscal, sucursal, representante, direcciones, actividad y rubro se guardan solo en Nuestra empresa. Vacíe esos campos.",
+  "error.counterparty-self-taken": "Solo hay una contraparte de nuestra empresa. '{existing}' ya lo es.",
+  "error.counterparty-country-invalid": "'{text}' no es un código de país. Escriba dos letras como US o JP, y déjelo vacío si es nacional."
 }

package/translations/ko.json

@@ -13,7 +13,7 @@
   "error.counterparty-name-required": "거래처 이름을 입력해 주세요.",
   "error.counterparty-number-clash": "사업자번호 {number}은(는) 이미 거래처 '{existing}'의 번호입니다. 그 거래처를 수정해 주세요.",
   "error.counterparty-not-found": "거래처를 찾을 수 없습니다. 다시 불러오세요.",
-  "error.counterparty-kind-invalid": "'{text}'은(는) 회사도 개인도 아닙니다.",
+  "error.counterparty-kind-invalid": "'{text}'은(는) 거래처 구분이 아닙니다. 사업자 · 기관 · 개인 · 자사 가운데 하나를 고르세요.",
   "error.business-number-invalid": "'{text}'은(는) 사업자등록번호가 아닙니다. 사업자등록번호는 숫자 10자리입니다.",
   "error.counterparty-account-number-required": "계좌번호를 입력해 주세요.",
   "error.counterparty-account-clash": "계좌 {number}은(는) 이미 거래처 '{existing}'의 계좌입니다.",
@@ -27,5 +27,8 @@
   "error.company-name-taken": "상호 {value}은(는) 이 사업장의 다른 회사가 쓰고 있습니다.",
   "error.counterparty-account-number-letters": "계좌번호 '{value}'에 숫자와 하이픈(-) 아닌 글자가 있습니다. 숫자와 하이픈만 입력하세요.",
   "error.counterparty-account-counterparty-required": "계좌의 거래처를 고르세요.",
-  "error.bizplace-not-accessible": "사업장을 찾을 수 없거나 볼 수 없는 사업장입니다. 목록을 새로 불러오세요."
+  "error.bizplace-not-accessible": "사업장을 찾을 수 없거나 볼 수 없는 사업장입니다. 목록을 새로 불러오세요.",
+  "error.counterparty-self-facts": "'{name}'은(는) 자사입니다. 사업자번호 · 종사업장번호 · 대표자 · 주소 · 청구 주소 · 업태 · 종목은 「우리 회사」에만 둡니다. 이 칸들을 비워 주세요.",
+  "error.counterparty-self-taken": "자사는 하나뿐입니다. 이미 '{existing}'이(가) 자사입니다.",
+  "error.counterparty-country-invalid": "'{text}'은(는) 나라 코드가 아닙니다. US · JP 처럼 영문 두 글자로 적고, 국내면 비워 두세요."
 }