@things-factory/biz-base 10.1.228 → 10.1.232

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@things-factory/biz-base",
-  "version": "10.1.228",
+  "version": "10.1.232",
   "main": "dist-server/index.js",
   "browser": "client/index.js",
   "exports": {
@@ -41,8 +41,8 @@
     "test": "npm run build && node --test tests/*.test.mjs tests/*.test.cjs"
   },
   "dependencies": {
-    "@things-factory/attachment-base": "^10.1.228",
-    "@things-factory/auth-base": "^10.1.228"
+    "@things-factory/attachment-base": "^10.1.232",
+    "@things-factory/auth-base": "^10.1.232"
   },
-  "gitHead": "fc4ede44617418df8701e83b83d177db4142a8f3"
+  "gitHead": "9307e1db833f13018e3f0ca9b1050f947cbefd68"
 }

package/tests/our-company.test.mjs

@@ -0,0 +1,75 @@
+import { test, before, after } from 'node:test'
+import assert from 'node:assert/strict'
+import { createRequire } from 'node:module'
+import { readFileSync } from 'node:fs'
+
+/*
+ * 「우리 회사」 (ADR-0176 decision 4): a domain's own company row - made on its first save, kept under `company`, its seal
+ * an attachment only its keepers open, and printed with the domain's name until a name is kept. An in-memory SQLite
+ * source; no application database is opened.
+ */
+
+const require = createRequire(import.meta.url)
+const { DataSource } = require('typeorm')
+const shell = require('@things-factory/shell')
+const auth = require('@things-factory/auth-base')
+const attachment = require('@things-factory/attachment-base')
+const biz = require('../dist-server/index.js')
+const { companySealReader } = require('../dist-server/service/company/company-seal-reader.js')
+
+let db, domain, other, user
+before(async () => {
+  db = await new DataSource({
+    type: 'sqlite',
+    database: ':memory:',
+    synchronize: true,
+    entities: [...new Set([...shell.entities, ...auth.entities, ...attachment.entities, ...biz.entities])],
+    namingStrategy: new shell.NamingStrategy()
+  }).initialize()
+  domain = await db.getRepository(shell.Domain).save({ name: 'hatiolab', subdomain: 'our-one', description: '(주)하티오랩' })
+  other = await db.getRepository(shell.Domain).save({ name: 'other', subdomain: 'our-two' })
+  user = await db.getRepository(auth.User).save({ name: 'admin', email: 'admin@example.test', status: 'activated', domains: [domain] })
+})
+after(async () => {
+  await db?.destroy()
+})
+
+const save = (patch, into = domain) => db.transaction(tx => biz.saveOurCompany(patch, into, user, tx))
+
+test('★ a domain with no company row prints its own name, and nothing else', async () => {
+  assert.equal(await biz.ourCompanyOf(domain, db), null)
+  const printed = await biz.printedCompanyOf(domain, { manager: db })
+  assert.deepEqual(printed, { name: '(주)하티오랩', representative: '', brn: '', corporateRegistrationNumber: '', address: '', phone: '' })
+  assert.equal((await biz.printedCompanyOf(other, { manager: db })).name, 'other')
+})
+
+test('★ the first save makes the row, later saves change it - one row a domain, its words trimmed', async () => {
+  await assert.rejects(save({ representative: '홍길동' }), /a company needs a name/)
+  const made = await save({ name: ' 주식회사 하티오랩 ', representative: '홍길동', brn: '123-45-67890', corporateRegistrationNumber: '110111-1234567', address: '서울', phone: '02-000-0000' })
+  const changed = await save({ representative: '김대표', status: 'X' })
+  assert.equal(changed.id, made.id)
+  assert.equal((await db.getRepository(biz.Company).find({ where: { domain: { id: domain.id } } })).length, 1)
+  const printed = await biz.printedCompanyOf(domain, { manager: db })
+  assert.deepEqual(printed, { name: '주식회사 하티오랩', representative: '김대표', brn: '123-45-67890', corporateRegistrationNumber: '110111-1234567', address: '서울', phone: '02-000-0000' })
+  assert.equal((await biz.ourCompanyOf(domain, db)).status, null, 'a save keeps only the words of 「우리 회사」')
+  assert.equal(await biz.ourCompanyOf(other, db), null, "another domain's company is its own")
+})
+
+test('★ without a seal a print carries none; the seal opens by its path only for whoever keeps the company', async () => {
+  assert.equal((await biz.printedCompanyOf(domain, { seal: true, manager: db })).seal, undefined)
+  const asked = []
+  const check = async (privilege, ...rest) => (asked.push(privilege), privilege.category === 'company' && privilege.privilege === 'mutation' && rest[0] === 'keeper')
+  assert.equal(await companySealReader({}, { state: { user: 'keeper' } }, check), true)
+  assert.equal(await companySealReader({}, { state: { user: 'clerk' } }, check), false)
+  assert.deepEqual(asked[0], { category: 'company', privilege: 'mutation', owner: true })
+  assert.equal(attachment.attachmentReaderOf(biz.COMPANY_SEAL_REF_TYPE) !== undefined, true, 'its reader is registered')
+})
+
+test('★ keeping 「우리 회사」 is audited by the company it names, and needs company:mutation', () => {
+  const text = readFileSync(new URL('../server/service/company/company-mutation.ts', import.meta.url), 'utf8')
+  for (const door of ['saveCompany', 'attachCompanySeal']) {
+    const above = text.split(`async ${door}(`)[0].split('\n').slice(-6).join('\n')
+    assert.match(above, /@privilege\(category: "company", privilege: "mutation"/, door)
+    assert.match(above, /@auditTarget\(kind: "Company"/, door)
+  }
+})

package/translations/en.json

@@ -21,5 +21,7 @@
   "task.biz-base.counterparty-keeping.name": "Keeping counterparties",
   "task.biz-base.counterparty-keeping.description": "Reads and changes counterparties whole - address, representative, notes and their accounts' full numbers.",
   "task.biz-base.company-keeping.name": "Keeping our company and sites",
-  "task.biz-base.company-keeping.description": "Reads and changes our company, its business sites and the business options."
+  "task.biz-base.company-keeping.description": "Reads and changes our company, its business sites and the business options.",
+  "error.company-not-found": "Save the company first",
+  "error.company-name-required": "A company needs a name"
 }

package/translations/es.json

@@ -21,5 +21,7 @@
   "task.biz-base.counterparty-keeping.name": "Mantener contrapartes",
   "task.biz-base.counterparty-keeping.description": "Lee y modifica las contrapartes completas: dirección, representante, notas y números de cuenta completos.",
   "task.biz-base.company-keeping.name": "Mantener la empresa y sus sedes",
-  "task.biz-base.company-keeping.description": "Lee y modifica nuestra empresa, sus sedes y las opciones de negocio."
+  "task.biz-base.company-keeping.description": "Lee y modifica nuestra empresa, sus sedes y las opciones de negocio.",
+  "error.company-not-found": "Guarde primero la empresa",
+  "error.company-name-required": "La empresa necesita un nombre"
 }

package/translations/ja.json

@@ -17,5 +17,7 @@
   "task.biz-base.counterparty-keeping.name": "取引先の管理",
   "task.biz-base.counterparty-keeping.description": "取引先のすべての項目（住所・代表者・メモ・口座番号全体）を読み、変更する。",
   "task.biz-base.company-keeping.name": "会社・事業所の管理",
-  "task.biz-base.company-keeping.description": "自社・事業所・事業オプションを読み、変更する。"
+  "task.biz-base.company-keeping.description": "自社・事業所・事業オプションを読み、変更する。",
+  "error.company-not-found": "先に会社情報を保存してください",
+  "error.company-name-required": "商号を入力してください"
 }

package/translations/ko.json

@@ -21,5 +21,7 @@
   "task.biz-base.counterparty-keeping.name": "거래처 관리",
   "task.biz-base.counterparty-keeping.description": "거래처의 주소·대표자·메모·계좌번호 전체를 포함한 모든 항목을 조회하고 수정합니다.",
   "task.biz-base.company-keeping.name": "회사·사업장 관리",
-  "task.biz-base.company-keeping.description": "우리 회사·사업장·사업 옵션을 읽고 바꾼다."
+  "task.biz-base.company-keeping.description": "우리 회사·사업장·사업 옵션을 읽고 바꾼다.",
+  "error.company-not-found": "회사 정보를 먼저 저장하세요",
+  "error.company-name-required": "상호를 적어 주세요"
 }

package/translations/ms.json

@@ -17,5 +17,7 @@
   "task.biz-base.counterparty-keeping.name": "Menyelenggara rakan niaga",
   "task.biz-base.counterparty-keeping.description": "Membaca dan mengubah rakan niaga sepenuhnya: alamat, wakil, nota dan nombor akaun penuh.",
   "task.biz-base.company-keeping.name": "Menyelenggara syarikat dan tapak",
-  "task.biz-base.company-keeping.description": "Membaca dan mengubah syarikat kita, tapak perniagaannya dan pilihan perniagaan."
+  "task.biz-base.company-keeping.description": "Membaca dan mengubah syarikat kita, tapak perniagaannya dan pilihan perniagaan.",
+  "error.company-not-found": "Simpan syarikat dahulu",
+  "error.company-name-required": "Syarikat memerlukan nama"
 }

package/translations/zh.json

@@ -17,5 +17,7 @@
   "task.biz-base.counterparty-keeping.name": "管理往来单位",
   "task.biz-base.counterparty-keeping.description": "读取并修改往来单位的全部字段（地址、代表人、备注、完整账号）。",
   "task.biz-base.company-keeping.name": "管理公司与营业场所",
-  "task.biz-base.company-keeping.description": "读取并修改本公司、营业场所和业务选项。"
+  "task.biz-base.company-keeping.description": "读取并修改本公司、营业场所和业务选项。",
+  "error.company-not-found": "请先保存公司信息",
+  "error.company-name-required": "请填写公司名称"
 }