@things-factory/biz-base 10.1.154 → 10.1.156

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@things-factory/biz-base",
-  "version": "10.1.154",
+  "version": "10.1.156",
   "main": "dist-server/index.js",
   "browser": "client/index.js",
   "exports": {
@@ -41,7 +41,8 @@
     "test": "npm run build && node --test tests/*.test.mjs tests/*.test.cjs"
   },
   "dependencies": {
-    "@things-factory/auth-base": "^10.1.154"
+    "@things-factory/attachment-base": "^10.1.156",
+    "@things-factory/auth-base": "^10.1.155"
   },
-  "gitHead": "f28579aa7131cbb282eb8813f8b285d9d29bb525"
+  "gitHead": "641146444c8ac4e510854c40824457ffad5cf3f1"
 }

package/tests/counterparty-bank-account.test.mjs

@@ -0,0 +1,117 @@
+import { test, before, after } from 'node:test'
+import assert from 'node:assert/strict'
+import { createRequire } from 'node:module'
+
+/*
+ * The accounts counterparties are paid into (ADR-0134): kept as digits, one counterparty's in the domain, gone with
+ * their counterparty, heard by the module that links bank lines, and their files read only by who may read
+ * counterparties. An in-memory SQLite source; no application database is opened.
+ */
+
+const require = createRequire(import.meta.url)
+const { DataSource } = require('typeorm')
+const shell = require('@things-factory/shell')
+const auth = require('@things-factory/auth-base')
+const biz = require('../dist-server/index.js')
+const { counterpartyDocumentReader } = require('../dist-server/service/counterparty/counterparty-document-readers.js')
+
+let db, domain, other, user, hanbit, nuri, theirs
+before(async () => {
+  db = await new DataSource({
+    type: 'sqlite',
+    database: ':memory:',
+    synchronize: true,
+    entities: [...new Set([...shell.entities, ...auth.entities, ...biz.entities])],
+    namingStrategy: new shell.NamingStrategy()
+  }).initialize()
+  domain = await db.getRepository(shell.Domain).save({ name: 'one', subdomain: 'account-one' })
+  other = await db.getRepository(shell.Domain).save({ name: 'two', subdomain: 'account-two' })
+  user = await db.getRepository(auth.User).save({ name: 'clerk', email: 'clerk@example.test', status: 'activated', domains: [domain] })
+  ;[hanbit, nuri] = await db.transaction(tx => biz.saveCounterparties(tx, domain, user, [{ name: '(주)한빛' }, { name: '누리' }]))
+  ;[theirs] = await db.transaction(tx => biz.saveCounterparties(tx, other, user, [{ name: '남의 거래처' }]))
+})
+after(async () => {
+  await db?.destroy()
+})
+
+const save = (patches, into = domain) => db.transaction(tx => biz.saveCounterpartyBankAccounts(tx, into, user, patches))
+const accountsOf = party => db.getRepository(biz.CounterpartyBankAccount).find({ where: { counterparty: { id: party.id } } })
+
+test('an account number is its digits - the hyphens a bank prints do not make another account', () => {
+  assert.equal(biz.accountKey('110-123-456789'), '110123456789')
+  assert.equal(biz.accountKey(' 110 123 456789 '), '110123456789')
+  assert.equal(biz.accountKey(null), '')
+  assert.equal(biz.accountKey('없음'), '')
+})
+
+test('an account is registered with its bank, number and holder - the number kept as digits', async () => {
+  const [one] = await save([{ counterpartyId: hanbit.id, bankName: ' 기업은행 ', accountNumber: '026-123456-01-017', holderName: '(주)한빛' }])
+  assert.equal(one.accountNumber, '02612345601017')
+  assert.equal(one.bankName, '기업은행')
+  assert.equal(one.holderName, '(주)한빛')
+  assert.equal(one.counterpartyId, hanbit.id)
+  await assert.rejects(save([{ counterpartyId: hanbit.id, accountNumber: '-' }]), { code: 'counterparty-account-number-required' })
+  await assert.rejects(save([{ accountNumber: '1234' }]), { code: 'counterparty-not-found' })
+})
+
+test('a number is one counterparty account in the domain - the refusal names who holds it', async () => {
+  await assert.rejects(save([{ counterpartyId: nuri.id, accountNumber: '02612345601017' }]), error => {
+    assert.equal(error.code, 'counterparty-account-clash')
+    assert.equal(error.params.existing, '(주)한빛')
+    return true
+  })
+  await assert.rejects(save([{ counterpartyId: hanbit.id, accountNumber: '026-1234-5601-017' }]), { code: 'counterparty-account-clash' }, 'the same digits, written another way')
+  const [two] = await save([{ counterpartyId: nuri.id, accountNumber: '333-3333-3333' }])
+  await assert.rejects(save([{ id: two.id, cuFlag: 'M', accountNumber: '02612345601017' }]), { code: 'counterparty-account-clash' })
+})
+
+test('the database holds a number to one live account, whatever writes it', async () => {
+  const repo = db.getRepository(biz.CounterpartyBankAccount)
+  await assert.rejects(repo.save({ domain, counterparty: { id: nuri.id }, accountNumber: '02612345601017' }), /UNIQUE/)
+})
+
+test('another domain cannot use my counterparty, nor change or delete my accounts', async () => {
+  const [mine] = await accountsOf(hanbit)
+  await assert.rejects(save([{ counterpartyId: hanbit.id, accountNumber: '999' }], other), { code: 'counterparty-not-found' })
+  await assert.rejects(save([{ counterpartyId: theirs.id, accountNumber: '998' }]), { code: 'counterparty-not-found' })
+  await assert.rejects(save([{ id: mine.id, cuFlag: 'M', notes: 'x' }], other), { code: 'counterparty-account-not-found' })
+  await assert.rejects(save([{ id: mine.id, cuFlag: '-' }], other), { code: 'counterparty-account-not-found' })
+  const [same] = await save([{ counterpartyId: theirs.id, accountNumber: '02612345601017' }], other)
+  assert.equal(same.accountNumber, '02612345601017', 'another domain keeps its own list')
+})
+
+test('a deleted account frees its number; a deleted counterparty takes its accounts with it', async () => {
+  const [mine] = await accountsOf(nuri)
+  await save([{ id: mine.id, cuFlag: '-' }])
+  const [again] = await save([{ counterpartyId: hanbit.id, accountNumber: '333-3333-3333' }])
+  assert.equal(again.counterpartyId, hanbit.id)
+
+  const [gone] = await db.transaction(tx => biz.saveCounterparties(tx, domain, user, [{ name: '곧 지울 곳' }]))
+  await save([{ counterpartyId: gone.id, accountNumber: '777-7777' }])
+  await db.transaction(tx => biz.saveCounterparties(tx, domain, user, [{ id: gone.id, cuFlag: '-' }]))
+  assert.deepEqual(await accountsOf(gone), [])
+  const [taken] = await save([{ counterpartyId: nuri.id, accountNumber: '7777777' }])
+  assert.equal(taken.counterpartyId, nuri.id, 'the number is free for whoever holds it next')
+})
+
+test('the module that links bank lines hears every save, with each account\'s counterparty, in the same transaction', async () => {
+  const heard = []
+  biz.onCounterpartyBankAccountsSaved(async (tx, into, saved, by) => {
+    heard.push(...saved.map(one => [one.accountNumber, one.counterpartyId, by.id]))
+    assert.ok(tx.queryRunner, 'the transaction of the save')
+  })
+  await save([{ counterpartyId: nuri.id, accountNumber: '555-55' }])
+  assert.deepEqual(heard, [['55555', nuri.id, user.id]])
+})
+
+test('a business registration and a passbook copy are read only by who may query counterparties', async () => {
+  const asked = []
+  const check = async (privilege, ...rest) => (asked.push(privilege), privilege.category === 'counterparty' && rest[0]?.id === 'reader')
+  const context = id => ({ state: { domain, user: { id } } })
+  assert.equal(await counterpartyDocumentReader({}, context('reader'), check), true)
+  assert.equal(await counterpartyDocumentReader({}, context('stranger'), check), false)
+  assert.deepEqual(asked[0], { category: 'counterparty', privilege: 'query', owner: true })
+
+  const access = require('@things-factory/attachment-base')
+  for (const refType of [biz.BUSINESS_REGISTRATION_REF_TYPE, biz.PASSBOOK_REF_TYPE]) assert.ok(access.attachmentReaderOf(refType), `${refType} has its reader`)
+})

package/translations/en.json

@@ -14,5 +14,8 @@
   "error.counterparty-number-clash": "Business number {number} already belongs to '{existing}'. Edit that counterparty instead.",
   "error.counterparty-not-found": "The counterparty was not found. Reload it.",
   "error.counterparty-kind-invalid": "'{text}' is neither a company nor a person.",
-  "error.business-number-invalid": "'{text}' is not a business registration number. It has 10 digits."
+  "error.business-number-invalid": "'{text}' is not a business registration number. It has 10 digits.",
+  "error.counterparty-account-number-required": "Give the account number.",
+  "error.counterparty-account-clash": "Account {number} is already registered to '{existing}'.",
+  "error.counterparty-account-not-found": "The account was not found. Reload it."
 }

package/translations/es.json

@@ -14,5 +14,8 @@
   "error.counterparty-number-clash": "El número de empresa {number} ya pertenece a '{existing}'. Edite esa contraparte en su lugar.",
   "error.counterparty-not-found": "No se encontró la contraparte. Vuelva a cargarla.",
   "error.counterparty-kind-invalid": "'{text}' no es ni una empresa ni una persona.",
-  "error.business-number-invalid": "'{text}' no es un número de registro empresarial. Debe tener 10 dígitos."
+  "error.business-number-invalid": "'{text}' no es un número de registro empresarial. Debe tener 10 dígitos.",
+  "error.counterparty-account-number-required": "Indique el número de cuenta.",
+  "error.counterparty-account-clash": "La cuenta {number} ya está registrada a '{existing}'.",
+  "error.counterparty-account-not-found": "No se encontró la cuenta. Vuelva a cargarla."
 }

package/translations/ja.json

@@ -10,5 +10,8 @@
   "field.latlng": "緯度/経度",
   "field.company": "会社",
   "error.counterparty-number-clash": "事業者番号 {number} はすでに取引先 '{existing}' の番号です。その取引先を編集してください。",
-  "error.no x found": "{x}が見つかりません"
+  "error.no x found": "{x}が見つかりません",
+  "error.counterparty-account-number-required": "口座番号を入力してください。",
+  "error.counterparty-account-clash": "口座 {number} はすでに取引先 '{existing}' の口座です。",
+  "error.counterparty-account-not-found": "口座が見つかりません。再読み込みしてください。"
 }

package/translations/ko.json

@@ -14,5 +14,8 @@
   "error.counterparty-number-clash": "사업자번호 {number}은(는) 이미 거래처 '{existing}'의 번호입니다. 그 거래처를 고치세요.",
   "error.counterparty-not-found": "거래처를 찾을 수 없습니다. 다시 불러오세요.",
   "error.counterparty-kind-invalid": "'{text}'은(는) 회사도 개인도 아닙니다.",
-  "error.business-number-invalid": "'{text}'은(는) 사업자등록번호가 아닙니다. 사업자등록번호는 숫자 10자리입니다."
+  "error.business-number-invalid": "'{text}'은(는) 사업자등록번호가 아닙니다. 사업자등록번호는 숫자 10자리입니다.",
+  "error.counterparty-account-number-required": "계좌번호를 넣으세요.",
+  "error.counterparty-account-clash": "계좌 {number}은(는) 이미 거래처 '{existing}'의 계좌입니다.",
+  "error.counterparty-account-not-found": "계좌를 찾을 수 없습니다. 다시 불러오세요."
 }

package/translations/ms.json

@@ -10,5 +10,8 @@
   "field.latlng": "latitud/longitud",
   "field.company": "syarikat",
   "error.counterparty-number-clash": "Nombor pendaftaran perniagaan {number} sudah milik '{existing}'. Sunting rakan niaga itu sahaja.",
-  "error.no x found": "tiada {x} yang dijumpai"
+  "error.no x found": "tiada {x} yang dijumpai",
+  "error.counterparty-account-number-required": "Masukkan nombor akaun.",
+  "error.counterparty-account-clash": "Akaun {number} sudah didaftarkan kepada '{existing}'.",
+  "error.counterparty-account-not-found": "Akaun tidak dijumpai. Muat semula."
 }

package/translations/zh.json

@@ -10,5 +10,8 @@
   "field.latlng": "纬度/经度",
   "field.company": "公司",
   "error.counterparty-number-clash": "营业登记号 {number} 已属于往来单位 '{existing}'。请改为编辑该往来单位。",
-  "error.no x found": "没有找到{x}"
+  "error.no x found": "没有找到{x}",
+  "error.counterparty-account-number-required": "请输入账号。",
+  "error.counterparty-account-clash": "账户 {number} 已登记在往来单位 '{existing}' 名下。",
+  "error.counterparty-account-not-found": "找不到该账户。请重新加载。"
 }