@things-factory/ai-assistant 10.1.47 → 10.1.50

package/client/components/assistant-chat.ts

@@ -32,6 +32,7 @@ import {
   injectMentionUserIds,
   stripMentionRefids
 } from './markdown.js'
+import { acceptOf, chatAttachmentUrl, refuseAttachments } from '../utils/attachment-policy.js'
 import { buildAssistantChatInput, buildChatMutationInput } from './chat-input-builder.js'
 import { receiveRemoteMessage, reconcileSentLine, remoteMessageToLine } from './chat-echo-dedup.js'
 import './mention-popup.js'
@@ -116,6 +117,8 @@ interface ChatLine {
    */
   groundingWarnings?: string[]
   attachments?: Array<{
+    /** A stored file of the conversation (shared dock §9) - opened by its route, not carried inline. */
+    id?: string
     name: string
     size: number
     type: string
@@ -168,6 +171,18 @@ const BOARD_AI_CHAT_MUTATION = gql`
  * front of the model this turn, so a surface that granted a category and sees it missing knows
  * the registration never happened, instead of reading a vague answer as a refusal.
  */
+/* Files go to the conversation first; the turn then names them (design/ai/shared-dock.md §9). */
+const ATTACH_TO_CONVERSATION_MUTATION = gql`
+  mutation AttachToConversation($sessionId: String!, $files: [Upload!]!, $kind: String) {
+    attachToConversation(sessionId: $sessionId, files: $files, kind: $kind) {
+      id
+      name
+      mimetype
+      size
+    }
+  }
+`
+
 const ASSISTANT_CHAT_MUTATION = gql`
   mutation AssistantChat($input: AssistantChatInput!) {
     assistantChat(input: $input) {
@@ -223,6 +238,7 @@ const ASSISTANT_MODE_QUERY = gql`
       examples
       footerNotice
       stagedNotice
+      attachments
     }
   }
 `
@@ -265,6 +281,7 @@ const CHAT_MESSAGES_QUERY = gql`
       relatedPatchId
       toolUsagesJson
       groundingWarningsJson
+      attachmentsJson
       createdAt
       redacted
       creator {
@@ -286,6 +303,7 @@ const CHAT_MESSAGE_SUBSCRIPTION = gql`
       relatedPatchId
       toolUsagesJson
       groundingWarningsJson
+      attachmentsJson
       createdAt
       redacted
       creator {
@@ -595,9 +613,36 @@ export class OxAssistantChat extends LitElement {
    * `attachments` 짐 자체는 그대로 둔다: figure 의 도구가 거기서 이미지를 찾는다
    * (`figure-tools.ts` — `ctx.host.image` 가 없을 때의 갈래).
    */
+  /** This conversation talks to the neutral door - its attachments follow the mode's policy (§9). */
+  private get usesAttachmentPolicy(): boolean {
+    return this.conversation.chatEndpoint === 'assistantChat'
+  }
+
+  /** Whether the attach button stands: a mode that declares nothing takes nothing (the board door keeps its images). */
+  private get acceptsAttachments(): boolean {
+    return !this.usesAttachmentPolicy || !!this.modeView?.attachments?.kinds?.length
+  }
+
+  /** A refusal in the reader's words - the same keys the door uses. */
+  private attachmentRefusalText(refusal: NonNullable<ReturnType<typeof refuseAttachments>>): string {
+    const params: any = { ...refusal }
+    if (refusal.code === 'attachment-too-large') params.max = Math.round(refusal.maxBytes / 1024 / 1024)
+    if (refusal.code === 'too-many-attachments') params.max = refusal.maxFiles
+    if (refusal.code === 'attachment-kind-not-accepted') params.kinds = refusal.kinds.join(', ')
+    return String(i18next.t(`ai-assistant.text.${refusal.code}`, { ...params, defaultValue: refusal.code }))
+  }
+
   private async onAttachFiles(files: FileList | File[] | null | undefined) {
     if (!files || files.length === 0) return
     const list = Array.from(files)
+    if (this.usesAttachmentPolicy) {
+      /* Said before anything is sent - never cut silently (§9-1). */
+      const refusal = refuseAttachments(this.modeView?.attachments, [...this.attachments, ...list].map(f => ({ name: f.name, type: f.type, size: f.size })))
+      if (refusal) {
+        this.errorMessage = this.attachmentRefusalText(refusal)
+        return
+      }
+    }
     const newAttachments: ChatAttachment[] = []
 
     for (const file of list) {
@@ -2889,21 +2934,24 @@ export class OxAssistantChat extends LitElement {
                 ${line.attachments && line.attachments.length > 0
                   ? html`
                       <div class="msg-attachments">
-                        ${line.attachments.map(att =>
-                          att.type?.startsWith('image/') || att.url?.startsWith('data:image/') || att.base64
+                        ${line.attachments.map(att => {
+                          /* A stored file opens through the conversation's own route (§9-3); a fresh one shows its local copy. */
+                          const href = att.url || att.base64 || (att.id && this.sessionId ? chatAttachmentUrl(this.sessionId, att.id) : '')
+                          /* By type - a text file carries base64 too, and drew as a broken image (found on :3700). */
+                          return att.type?.startsWith('image/') || att.url?.startsWith('data:image/') || att.base64?.startsWith('data:image/')
                             ? html`
-                                <div class="msg-attachment-img-wrap" title=${att.name}>
-                                  <img src=${att.url || att.base64} alt=${att.name} />
+                                <a class="msg-attachment-img-wrap" title=${att.name} href=${href} target="_blank" rel="noopener">
+                                  <img src=${href} alt=${att.name} />
                                   <span class="msg-attachment-label">${att.name}</span>
-                                </div>
+                                </a>
                               `
                             : html`
-                                <div class="msg-attachment-file-chip" title=${att.name}>
+                                <a class="msg-attachment-file-chip" title=${att.name} href=${href || nothing} target="_blank" rel="noopener">
                                   <md-icon>description</md-icon>
                                   <span>${att.name}</span>
-                                </div>
+                                </a>
                               `
-                        )}
+                        })}
                       </div>
                     `
                   : nothing}
@@ -2976,7 +3024,7 @@ export class OxAssistantChat extends LitElement {
             id="chat-file-input"
             type="file"
             multiple
-            accept="image/*"
+            accept=${this.usesAttachmentPolicy ? acceptOf(this.modeView?.attachments) : 'image/*'}
             style="display: none"
             @change=${(e: Event) => {
               const input = e.target as HTMLInputElement
@@ -2986,14 +3034,16 @@ export class OxAssistantChat extends LitElement {
               }
             }}
           />
-          <button
-            type="button"
-            class="action"
-            @click=${() => this.renderRoot.querySelector<HTMLInputElement>('#chat-file-input')?.click()}
-            title=${i18next.t('ai-assistant.tooltip.attach-file', { defaultValue: 'attach an image (drag & drop or paste supported)' })}>
-            <md-icon>attach_file</md-icon>
-            ${i18next.t('ai-assistant.button.attach', { defaultValue: 'Attach' })}
-          </button>
+          ${this.acceptsAttachments
+            ? html`<button
+                type="button"
+                class="action"
+                @click=${() => this.renderRoot.querySelector<HTMLInputElement>('#chat-file-input')?.click()}
+                title=${i18next.t('ai-assistant.tooltip.attach-file', { defaultValue: 'attach an image (drag & drop or paste supported)' })}>
+                <md-icon>attach_file</md-icon>
+                ${i18next.t('ai-assistant.button.attach', { defaultValue: 'Attach' })}
+              </button>`
+            : nothing}
           ${hasMessages
             ? html`
                 <button
@@ -4420,6 +4470,33 @@ export class OxAssistantChat extends LitElement {
       this.busy = false
     }
 
+    /* The neutral door takes stored files by id: upload them to the conversation first (§9-2). */
+    let attachmentIds: string[] | undefined
+    if (attachmentsToSend.length > 0 && this.usesAttachmentPolicy) {
+      if (!this.sessionId) {
+        this.errorMessage = i18next.t('ai-assistant.text.attachments-need-session', { defaultValue: 'attachments need a saved conversation.' })
+        this.attachments = attachmentsToSend
+        return
+      }
+      this.busy = true
+      try {
+        const uploaded = await client.mutate({
+          mutation: ATTACH_TO_CONVERSATION_MUTATION,
+          variables: { sessionId: this.sessionId, files: attachmentsToSend.map(a => a.file), kind: this.conversation.kind },
+          /* The shell's client sends multipart only when asked - without it a File travels as {} and is refused. */
+          context: { hasUpload: true }
+        })
+        if (uploaded.errors?.length) throw new Error(uploaded.errors.map(error => error.message).join('\n'))
+        attachmentIds = (uploaded.data?.attachToConversation ?? []).map((file: any) => file.id)
+      } catch (error) {
+        this.errorMessage = error instanceof Error ? error.message : String(error)
+        this.attachments = attachmentsToSend
+        this.busy = false
+        return
+      }
+      this.busy = false
+    }
+
     let requestContext: AssistantRequestContext
     let liveBoard: any
     let requestBase: any
@@ -4475,7 +4552,7 @@ export class OxAssistantChat extends LitElement {
     this.lines = [...this.lines, { role: 'assistant', content: '', pending: true, _localId: asstLocalId }]
 
     try {
-      if (attachmentsToSend.length > 0) {
+      if (attachmentsToSend.length > 0 && !attachmentIds) {
         requestContext.hostContext = {
           ...requestContext.hostContext,
           attachments: attachmentsToSend.map(a => ({
@@ -4512,7 +4589,8 @@ export class OxAssistantChat extends LitElement {
                 history,
                 mode: { kind: this.conversation.kind!, target: this.conversation.target },
                 truncateAfterMessageId: this._truncateAfterId,
-                hostContext: requestContext.hostContext
+                hostContext: requestContext.hostContext,
+                attachmentIds
               })
             : buildChatMutationInput({
                 sessionId: this.sessionId,