@things-factory/ai-assistant 10.1.40 → 10.1.42

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@things-factory/ai-assistant",
-  "version": "10.1.40",
+  "version": "10.1.42",
   "main": "dist-server/index.js",
   "things-factory": true,
   "author": "heartyoh",
@@ -44,5 +44,5 @@
     "copyfiles": "^2.4.1",
     "rimraf": "^5.0.0"
   },
-  "gitHead": "51c5d804c14ad8fcc6d4707e6ef80c9deede2766"
+  "gitHead": "982aa01403b979c4e348fd207a3fb4d1a7b5f521"
 }

package/server/service/assistant-capability-resolver.ts

@@ -52,7 +52,7 @@ export class AssistantCapabilityResolver {
   @Query(() => AiCapabilityView, {
     description: 'Whether this deployment has an AI configured, and which registrations are incomplete. Read this before offering to ask the assistant — do not find out by failing.'
   })
-  @Directive('@privilege(category: "ai-assistant", privilege: "query")')
+  @Directive('@privilege(category: "ai-assistant", privilege: "query", domainOwnerGranted: true)')
   async aiCapability(@Ctx() _context: any): Promise<AiCapabilityView> {
     const capability = aiCapability()
     const warnings = [...getToolRegistryWarnings(), ...getAssistantModeWarnings()].map(warning => ({

package/server/service/assistant-chat-resolver.ts

@@ -200,7 +200,7 @@ export class AssistantChatResolver {
    * 2026-09-10. No `legacy` alias: this operation is new, so no one was ever passing under an old
    * name, and declaring an alias would open a second name that nothing needs.
    */
-  @Directive('@privilege(category: "ai-assistant", privilege: "mutation")')
+  @Directive('@privilege(category: "ai-assistant", privilege: "mutation", domainOwnerGranted: true)')
   async assistantChat(@Arg('input') input: AssistantChatInput, @Ctx() context: any): Promise<AssistantChatOutput> {
     const client = resolveAIClient()
     if (!client) {

package/server/service/assistant-mode/assistant-mode-resolver.ts

@@ -83,7 +83,7 @@ export class AssistantModeResolver {
     description:
       'Conversations that stand for this kind of subject, the default first. A screen showing one subject opens the head of this list and offers the rest; a single entry means there is nothing to choose.'
   })
-  @Directive('@privilege(category: "ai-assistant", privilege: "query")')
+  @Directive('@privilege(category: "ai-assistant", privilege: "query", domainOwnerGranted: true)')
   async assistantModes(@Arg('subject') subject: string, @Ctx() context: any): Promise<AssistantModeChoice[]> {
     const t = requestTranslator(context)
 
@@ -101,7 +101,7 @@ export class AssistantModeResolver {
     description: 'What this conversation offers on screen — `/` sentences, the `@` catalog and the notices, translated.'
   })
   /* Reading what a conversation offers is reading, and the same door the session list uses. */
-  @Directive('@privilege(category: "ai-assistant", privilege: "query")')
+  @Directive('@privilege(category: "ai-assistant", privilege: "query", domainOwnerGranted: true)')
   async assistantMode(@Arg('kind') kind: string, @Ctx() context: any): Promise<AssistantModeView> {
     return assistantModeView(kind, requestTranslator(context)) as AssistantModeView
   }

package/server/service/chat-session/session-visibility.test.ts

@@ -50,3 +50,50 @@ describe("'none' is not an anchor", () => {
     expect(initialVisibility({ anchorType: 'space' })).toBe('open')
   })
 })
+
+/*
+ * Calling a door is not reading a conversation (ruled 2026-09-24).
+ *
+ * Every ai-assistant door now admits the domain owner (`test/open-doors.test.ts`), so the owner may
+ * open the dock anywhere in the domain. That says who may *call* — not whose private conversation they
+ * may read. The room rule is asked with two things only, the visibility and whether the caller sits in
+ * the room, and neither place that reads a room asks anything about ownership. If one ever did, a domain
+ * owner would read every private conversation in the domain, and nothing on the screen would say so.
+ */
+describe('the domain owner still reads a private conversation only as a participant', () => {
+  const { readFileSync } = require('fs')
+  const { join } = require('path')
+  const source = (path: string) => readFileSync(join(__dirname, '..', path), 'utf8') as string
+
+  /** The body of `chatMessages` — the stored path. The stream's path is the room lookup and `mayHearRoom`. */
+  const storedPath = () => {
+    const resolver = source('chat-session-resolver.ts')
+    const start = resolver.indexOf('async chatMessages(')
+    expect(start).toBeGreaterThan(0)
+    const end = resolver.indexOf('\n  @', start)
+    return resolver.slice(start, end > start ? end : undefined)
+  }
+  const streamPath = () => {
+    const broadcast = source('chat-message/chat-message-broadcast.ts')
+    return source('chat-message/chat-message-room.ts') + broadcast.slice(broadcast.indexOf('export interface ChatRoomLookup'))
+  }
+
+  const OWNERSHIP = /owner|superUser|checkPermission|hasPrivilege|privilege/i
+
+  it('★ the rule has no input for ownership — visibility and participation, nothing else', () => {
+    expect(mayReadSession.length).toBe(2)
+    expect(mayReadSession('private', false)).toBe(false)
+  })
+
+  it('★ the stored path asks the rule, and asks nothing about ownership', () => {
+    const body = storedPath()
+    expect(body).toMatch(/mayReadSession\(/)
+    expect(body).not.toMatch(OWNERSHIP)
+  })
+
+  it('★ the stream asks the same rule, and asks nothing about ownership', () => {
+    const body = streamPath()
+    expect(body).toMatch(/mayReadSession\(/)
+    expect(body).not.toMatch(OWNERSHIP)
+  })
+})

package/server/service/chat-session-resolver.ts

@@ -100,7 +100,7 @@ class ChatSessionInboxEntry {
 @Resolver()
 export class ChatSessionResolver {
   @Query(() => ChatSession, { nullable: true, description: 'Get AI chat session by id.' })
-  @Directive('@privilege(category: "ai-assistant", privilege: "query")')
+  @Directive('@privilege(category: "ai-assistant", privilege: "query", domainOwnerGranted: true)')
   async chatSession(
     @Arg('id') id: string,
     @Ctx() context: ResolverContext
@@ -113,7 +113,7 @@ export class ChatSessionResolver {
     description:
       'List AI chat sessions anchored to a target (oldest first). Anchor decides the nature and the history boundary of the conversation: board = authoring, space = the site and the twins running there. Board anchor also matches legacy rows that only have boardId.'
   })
-  @Directive('@privilege(category: "ai-assistant", privilege: "query")')
+  @Directive('@privilege(category: "ai-assistant", privilege: "query", domainOwnerGranted: true)')
   async chatSessionsByAnchor(
     @Arg('anchorType') anchorType: string,
     @Arg('anchorId') anchorId: string,
@@ -135,7 +135,7 @@ export class ChatSessionResolver {
     description:
       "List sessions anchored to a target with this viewer's unread state, most recent activity first. Supports free-text search over name and last preview, a mine-only filter, hidden inclusion, and paging. Uses the denormalized last-activity timestamp compared against the viewer's read point — no per-session aggregation."
   })
-  @Directive('@privilege(category: "ai-assistant", privilege: "query")')
+  @Directive('@privilege(category: "ai-assistant", privilege: "query", domainOwnerGranted: true)')
   async chatSessionInbox(
     @Arg('anchorType') anchorType: string,
     @Arg('anchorId') anchorId: string,
@@ -164,7 +164,7 @@ export class ChatSessionResolver {
     description:
       'Total number of sessions matching the same filters as chatSessionInbox (before paging). Request it alongside the list so the UI can tell "end of page" from "end of data".'
   })
-  @Directive('@privilege(category: "ai-assistant", privilege: "query")')
+  @Directive('@privilege(category: "ai-assistant", privilege: "query", domainOwnerGranted: true)')
   async chatSessionInboxTotal(
     @Arg('anchorType') anchorType: string,
     @Arg('anchorId') anchorId: string,
@@ -199,7 +199,7 @@ export class ChatSessionResolver {
     description:
       "Number of sessions on this anchor that the caller has hidden and that have had no activity since. Meant to be requested alongside chatSessionInbox in the same operation so the filter can say how many are folded away."
   })
-  @Directive('@privilege(category: "ai-assistant", privilege: "query")')
+  @Directive('@privilege(category: "ai-assistant", privilege: "query", domainOwnerGranted: true)')
   async hiddenSessionCount(
     @Arg('anchorType') anchorType: string,
     @Arg('anchorId') anchorId: string,
@@ -270,7 +270,7 @@ export class ChatSessionResolver {
     description:
       'Delete a chat session — creator only, since a shared deliberation cannot be un-deleted from the UI. Participants who are not the creator can hide it from their own list instead (hideAISession). Soft delete; broadcast as meta activity so every list drops it.'
   })
-  @Directive('@privilege(category: "ai-assistant", privilege: "mutation")')
+  @Directive('@privilege(category: "ai-assistant", privilege: "mutation", domainOwnerGranted: true)')
   async deleteAISession(@Arg('sessionId') sessionId: string, @Ctx() context: ResolverContext): Promise<boolean> {
     const { domain, user } = context.state
     const repo = getRepository(ChatSession)
@@ -302,7 +302,7 @@ export class ChatSessionResolver {
     description:
       'Hide (or unhide) a session from the calling user\'s own list. Per-user and reversible — the session and other participants are unaffected. Activity newer than the hide makes it reappear; the inbox filter (showHidden) reveals hidden ones.'
   })
-  @Directive('@privilege(category: "ai-assistant", privilege: "mutation")')
+  @Directive('@privilege(category: "ai-assistant", privilege: "mutation", domainOwnerGranted: true)')
   async hideAISession(
     @Arg('sessionId') sessionId: string,
     @Ctx() context: ResolverContext,
@@ -357,7 +357,7 @@ export class ChatSessionResolver {
     description:
       "Open this conversation to everyone in the domain, or close it to its participants. Only the owner may change it. Opening exposes what is already written — the screen says so before asking. Door checks on assistant answers are unaffected (ADR-0073)."
   })
-  @Directive('@privilege(category: "ai-assistant", privilege: "mutation")')
+  @Directive('@privilege(category: "ai-assistant", privilege: "mutation", domainOwnerGranted: true)')
   async setSessionVisibility(
     @Arg('sessionId') sessionId: string,
     @Arg('visibility') visibility: string,
@@ -394,7 +394,7 @@ export class ChatSessionResolver {
     description:
       'Rename a chat session. Any participant may rename it — the name is the topic label of a shared deliberation and the change is reversible. Broadcast as meta activity so every participant sees it without raising unread badges.'
   })
-  @Directive('@privilege(category: "ai-assistant", privilege: "mutation")')
+  @Directive('@privilege(category: "ai-assistant", privilege: "mutation", domainOwnerGranted: true)')
   async renameAISession(
     @Arg('sessionId') sessionId: string,
     @Arg('name') name: string,
@@ -429,7 +429,7 @@ export class ChatSessionResolver {
     description:
       "Mark a session as read up to now for the current user. Idempotent. Distinct from presence (lastSeenAt) — a window can be open without being read."
   })
-  @Directive('@privilege(category: "ai-assistant", privilege: "mutation")')
+  @Directive('@privilege(category: "ai-assistant", privilege: "mutation", domainOwnerGranted: true)')
   async markSessionRead(
     @Arg('sessionId') sessionId: string,
     @Ctx() context: ResolverContext
@@ -449,7 +449,7 @@ export class ChatSessionResolver {
     description:
       'List users in the current domain for the `@` mention popup. Anyone with the chat privilege may search here; this is separate from the admin-only users().'
   })
-  @Directive('@privilege(category: "ai-assistant", privilege: "query")')
+  @Directive('@privilege(category: "ai-assistant", privilege: "query", domainOwnerGranted: true)')
   async domainUsersForMention(
     @Arg('query', { nullable: true, description: 'Substring to match against name/email (case-insensitive). Empty → all.' }) query: string | undefined,
     @Arg('limit', () => Int, { nullable: true, defaultValue: 50 }) limit: number,
@@ -468,7 +468,7 @@ export class ChatSessionResolver {
   @Query(() => [ChatSessionParticipant], {
     description: 'List participants of a ChatSession (members / owner).'
   })
-  @Directive('@privilege(category: "ai-assistant", privilege: "query")')
+  @Directive('@privilege(category: "ai-assistant", privilege: "query", domainOwnerGranted: true)')
   async chatSessionParticipants(
     @Arg('sessionId') sessionId: string,
     @Ctx() context: ResolverContext
@@ -488,7 +488,7 @@ export class ChatSessionResolver {
   @Mutation(() => Boolean, {
     description: 'Presence heartbeat — bump current user\'s lastSeenAt in the session (online indicator).'
   })
-  @Directive('@privilege(category: "ai-assistant", privilege: "mutation")')
+  @Directive('@privilege(category: "ai-assistant", privilege: "mutation", domainOwnerGranted: true)')
   async touchPresence(@Arg('sessionId') sessionId: string, @Ctx() context: ResolverContext): Promise<boolean> {
     const { domain, user } = context.state
     const repo = getRepository(ChatSessionParticipant)
@@ -501,7 +501,7 @@ export class ChatSessionResolver {
   }
 
   @Query(() => [ChatMessage], { description: 'List chat messages of a session, oldest first.' })
-  @Directive('@privilege(category: "ai-assistant", privilege: "query")')
+  @Directive('@privilege(category: "ai-assistant", privilege: "query", domainOwnerGranted: true)')
   async chatMessages(
     @Arg('sessionId') sessionId: string,
     @Arg('limit', () => Int, { nullable: true, defaultValue: 100 }) limit: number,
@@ -547,7 +547,7 @@ export class ChatSessionResolver {
     description:
       'Start (or get existing) AI chat session anchored to a target. Idempotent — returns first existing or creates one. Use anchorType board for board authoring, space for a site (its co-located twins).'
   })
-  @Directive('@privilege(category: "ai-assistant", privilege: "mutation")')
+  @Directive('@privilege(category: "ai-assistant", privilege: "mutation", domainOwnerGranted: true)')
   async startAISession(
     @Arg('anchorType') anchorType: string,
     @Arg('anchorId') anchorId: string,
@@ -584,7 +584,7 @@ export class ChatSessionResolver {
     description:
       'Always create a new AI chat session anchored to a target (no idempotent reuse). For multi-session UX — opening another tab.'
   })
-  @Directive('@privilege(category: "ai-assistant", privilege: "mutation")')
+  @Directive('@privilege(category: "ai-assistant", privilege: "mutation", domainOwnerGranted: true)')
   async createAISession(
     @Arg('anchorType') anchorType: string,
     @Arg('anchorId') anchorId: string,
@@ -626,7 +626,7 @@ export class ChatSessionResolver {
   @Mutation(() => Boolean, {
     description: 'Rename a ChatSession (tab label).'
   })
-  @Directive('@privilege(category: "ai-assistant", privilege: "mutation")')
+  @Directive('@privilege(category: "ai-assistant", privilege: "mutation", domainOwnerGranted: true)')
   async renameChatSession(
     @Arg('sessionId') sessionId: string,
     @Arg('name') name: string,
@@ -645,7 +645,7 @@ export class ChatSessionResolver {
     description:
       "What the host did with a proposal the assistant made. The host calls this once per card it was asked to run; the server records it as a system row, so the panel shows it, a refreshed panel still shows it, and the model reads on its next turn that its proposal was refused instead of assuming it landed (ADR-0070)."
   })
-  @Directive('@privilege(category: "ai-assistant", privilege: "mutation")')
+  @Directive('@privilege(category: "ai-assistant", privilege: "mutation", domainOwnerGranted: true)')
   async reportProposalOutcome(
     @Arg('sessionId') sessionId: string,
     @Arg('proposalKey') proposalKey: string,
@@ -695,7 +695,7 @@ export class ChatSessionResolver {
     description:
       "Say something to the people in this session. The turn is stored as the speaker's, addressed to the room, and the assistant is not called — it reads the line as context the next time someone asks it something. Returns the stored message id, or null when there was nothing to say (ADR-0070)."
   })
-  @Directive('@privilege(category: "ai-assistant", privilege: "mutation")')
+  @Directive('@privilege(category: "ai-assistant", privilege: "mutation", domainOwnerGranted: true)')
   async sayToRoom(
     @Arg('sessionId') sessionId: string,
     @Arg('content') content: string,
@@ -763,7 +763,7 @@ export class ChatSessionResolver {
     description:
       'Append a system note to a session — context that did not come from a participant typing (e.g. a conversation carried over from another surface, an external state change). The AI sees it as part of the shared history.'
   })
-  @Directive('@privilege(category: "ai-assistant", privilege: "mutation")')
+  @Directive('@privilege(category: "ai-assistant", privilege: "mutation", domainOwnerGranted: true)')
   async appendSessionNote(
     @Arg('sessionId') sessionId: string,
     @Arg('content') content: string,
@@ -813,7 +813,7 @@ export class ChatSessionResolver {
     description:
       "Carry a conversation from another surface into this session as its own turns, preserving order. A person's turns are stored as theirs, addressed to the room. An assistant turn is stored as the assistant's only when it names its original (sourceSessionId, sourceMessageId) and the server can read it; otherwise it is kept as a quotation on a system row — roles are the server's to write (ADR-0070)."
   })
-  @Directive('@privilege(category: "ai-assistant", privilege: "mutation")')
+  @Directive('@privilege(category: "ai-assistant", privilege: "mutation", domainOwnerGranted: true)')
   async appendSessionTurns(
     @Arg('sessionId') sessionId: string,
     @Arg('turns', () => GraphQLJSON) turns: { role?: string; content?: string }[],

package/test/open-doors.test.ts

@@ -108,6 +108,22 @@ describe('every open door has a written reason', () => {
   })
 })
 
+describe('the domain owner may call every door (ruled 2026-09-24)', () => {
+  /*
+   * The conversation doors did not admit domain owners, and warehouse has no role that grants
+   * ai-assistant — so on :3500 nobody could open the AI dock, the owner included. Every business door
+   * of the apps admits the owner; these now do too. Calling a door is not reading a conversation:
+   * private ones stay with their participants (`session-visibility.test.ts`).
+   */
+  it.each(['Query', 'Mutation'] as const)('%s — every declared door admits the owner', typeName => {
+    const notForOwners = fieldsOf(typeName).filter(field => {
+      const gate: any = privilegeOfField(typeName, field)
+      return gate.known && gate.gate && gate.gate.owner !== true
+    })
+    expect(notForOwners).toEqual([])
+  })
+})
+
 describe('what the walk itself has to be true for', () => {
   it('reaches the whole schema, not a handful of fields', () => {
     /* If the resolver list shrank to nothing, the lists above would pass by having nothing to look at. */