@things-factory/ai-assistant 10.1.39 → 10.1.40

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@things-factory/ai-assistant",
-  "version": "10.1.39",
+  "version": "10.1.40",
   "main": "dist-server/index.js",
   "things-factory": true,
   "author": "heartyoh",
@@ -30,9 +30,9 @@
     "@operato/i18n": "^10.0.0",
     "@operato/styles": "^10.0.0",
     "@things-factory/ai-client-base": "^10.1.39",
-    "@things-factory/auth-base": "^10.1.39",
+    "@things-factory/auth-base": "^10.1.40",
     "@things-factory/env": "^10.1.20",
-    "@things-factory/shell": "^10.1.39",
+    "@things-factory/shell": "^10.1.40",
     "dompurify": "^3.0.0",
     "graphql-scalars": "^1.22.0",
     "graphql-tag": "^2.12.6",
@@ -44,5 +44,5 @@
     "copyfiles": "^2.4.1",
     "rimraf": "^5.0.0"
   },
-  "gitHead": "fe5257ad8995fe7e79275e287f36e95b5fd32d1c"
+  "gitHead": "51c5d804c14ad8fcc6d4707e6ef80c9deede2766"
 }

package/server/service/chat-session/chat-session.ts

@@ -80,7 +80,7 @@ export class ChatSession {
   @Field({
     nullable: true,
     description:
-      "What this conversation is anchored to: 'board' | 'figure' (authoring a Figure) | 'space' | 'instance' | 'domain' | 'none'. Absent on legacy rows — treated as 'board' when boardId is present."
+      "What this conversation is anchored to: 'board' | 'figure' (authoring a Figure) | 'application' | 'space' | 'instance' | 'domain' | 'subject' (one subject in a 360, '<axis>:<itemId>') | 'none'. Absent on legacy rows — treated as 'board' when boardId is present."
   })
   anchorType?: string
 

package/server/service/chat-session/session-anchor.ts

@@ -50,11 +50,15 @@
  *   space     공간 운영 대화 — 사이트와 그 공간에서 도는 트윈들
  *   instance  트윈 하나에 대한 대화
  *   domain    테넌트 전체가 주제인 대화 — 공장 전체 문답처럼 더 좁게 가리킬 것이 없을 때
+ *   subject   one subject in a 360 — `<axis>:<itemId>`: the 360 frame's axis word (ADR-0067, the shared
+ *             frame; no new words are made here) and that row's uuid. Anchoring to `domain` instead
+ *             would put every subject's conversations in one bucket and lose the per-subject list and
+ *             history boundary (ruled 2026-09-24).
  *   none      앵커로 찾을 수 없는 대화. 「아직 아무것도 고르지 않았다」는 화면 상태다
  */
 // Figure-specific history requested explicitly: reuse the existing varchar
 // anchor columns, without writing Figure ids into the legacy boardId column.
-export const SESSION_ANCHOR_TYPES = ['board', 'figure', 'application', 'space', 'instance', 'domain', 'none'] as const
+export const SESSION_ANCHOR_TYPES = ['board', 'figure', 'application', 'space', 'instance', 'domain', 'subject', 'none'] as const
 
 export type SessionAnchorType = (typeof SESSION_ANCHOR_TYPES)[number]
 
@@ -76,6 +80,25 @@ function assertAnchorType(anchorType: string | undefined, where: string): Sessio
   return type
 }
 
+/**
+ * A `subject` anchor id is `<axis>:<itemId>`, the item being that row's uuid (ruled 2026-09-24).
+ *
+ * Checked because the shape is the whole contract: a screen that passes what it shows — an EPC like
+ * `urn:epc:id:sgtin:…`, or an order's name — would store a pointer to nothing stable. A name changes
+ * and the conversation is orphaned; an EPC splits on its own colons. Refused here, on write and on
+ * read, rather than stored and never found.
+ */
+const SUBJECT_ANCHOR_ID = /^[a-z][a-z0-9-]*:[0-9a-f]{8}-[0-9a-f]{4}-[0-9a-f]{4}-[0-9a-f]{4}-[0-9a-f]{12}$/i
+
+function assertSubjectAnchorId(type: SessionAnchorType, id: string | undefined, where: string): void {
+  if (type !== 'subject' || !id || SUBJECT_ANCHOR_ID.test(id)) return
+  throw new Error(
+    `[ai-assistant/session-anchor] ${where}: '${id}' is not a subject anchor. ` +
+      "A subject anchor is '<axis>:<itemId>' — the 360 frame's axis word and the row's uuid, " +
+      "for example 'items:6f1c…'. Resolve what the screen shows (an EPC, a name) to the row's uuid first."
+  )
+}
+
 /** 앵커 → 저장할 컬럼 값. 보드 앵커는 boardId 에도 같은 값을 넣어 기존 조회가 그대로 동작하게 한다. */
 export function anchorColumns(
   anchorType: string | undefined,
@@ -91,6 +114,7 @@ export function anchorColumns(
         "Use 'none' for a conversation that is deliberately not addressable by anchor."
     )
   }
+  assertSubjectAnchorId(type, id, 'anchorColumns')
   return { anchorType: type, anchorId: id, boardId: type === 'board' ? id : undefined }
 }
 
@@ -112,6 +136,7 @@ export function anchorColumns(
  */
 export function anchorWhere(domainId: string, anchorType: string, anchorId: string, kind?: string): any {
   const type = assertAnchorType(anchorType, 'anchorWhere')
+  assertSubjectAnchorId(type, anchorId, 'anchorWhere')
   const where = type === 'board' ? { boardId: anchorId, domain: { id: domainId } } : { anchorType: type, anchorId, domain: { id: domainId } }
   return kind ? { ...where, kind } : where
 }

package/server/service/session-anchor.test.ts

@@ -12,6 +12,9 @@
  *  ③ 공간·인스턴스 앵커는 boardId 를 오염시키지 않는다(보드 조회에 섞이면 이력 경계가 무너진다).
  */
 import { anchorColumns, anchorWhere, isSessionAnchorType, SESSION_ANCHOR_TYPES } from './chat-session/session-anchor'
+import { initialVisibility } from './chat-session/session-visibility'
+
+const SUBJECT_ID = 'items:6f1c2a90-3b4d-4e5f-8a6b-7c8d9e0f1a2b'
 
 describe('앵커 저장 값 (anchorColumns)', () => {
   it('board 앵커는 anchorId 와 boardId 에 같은 값을 쓴다 — 기존 조회 하위호환', () => {
@@ -134,7 +137,9 @@ describe('앵커 조회 조건 (anchorWhere)', () => {
 
   it('모든 조회에 domain 조건이 포함된다 — 빠지면 남의 테넌트 대화가 보인다', () => {
     for (const type of SESSION_ANCHOR_TYPES) {
-      expect(anchorWhere('dom-9', type, 'X').domain).toEqual({ id: 'dom-9' })
+      /* A subject anchor has a shape of its own (below); every other type takes any id. */
+      const id = type === 'subject' ? SUBJECT_ID : 'X'
+      expect(anchorWhere('dom-9', type, id).domain).toEqual({ id: 'dom-9' })
     }
   })
 
@@ -142,3 +147,52 @@ describe('앵커 조회 조건 (anchorWhere)', () => {
     expect(anchorWhere('dom-1', 'space', 'busan').boardId).toBeUndefined()
   })
 })
+
+/*
+ * The subject anchor — one subject in a 360 (ruled 2026-09-24).
+ *
+ * `<axis>:<itemId>`: the 360 frame's axis word and that row's uuid. Tested on both sides the ruling
+ * split: without an id it throws, and with one it is stored as given and finds its own list again.
+ */
+describe('the subject anchor', () => {
+  it('★ without an id it throws — a pointer to nothing would never be found again', () => {
+    expect(() => anchorColumns('subject', '')).toThrow(/was given no id/)
+    expect(() => anchorColumns('subject', undefined)).toThrow(/was given no id/)
+  })
+
+  it('★ `<axis>:<itemId>` is stored as given, and the lookup for that subject finds it', () => {
+    const stored = anchorColumns('subject', SUBJECT_ID)
+    expect(stored).toEqual({ anchorType: 'subject', anchorId: SUBJECT_ID, boardId: undefined })
+
+    const where = anchorWhere('dom-1', 'subject', SUBJECT_ID)
+    expect(where).toEqual({ anchorType: stored.anchorType, anchorId: stored.anchorId, domain: { id: 'dom-1' } })
+  })
+
+  it("another subject, another axis or another domain is another list", () => {
+    const other = 'items:0a1b2c3d-4e5f-4a6b-8c7d-9e0f1a2b3c4d'
+    const sameRowOtherAxis = SUBJECT_ID.replace('items:', 'locations:')
+
+    expect(anchorWhere('dom-1', 'subject', other)).not.toEqual(anchorWhere('dom-1', 'subject', SUBJECT_ID))
+    expect(anchorWhere('dom-1', 'subject', sameRowOtherAxis)).not.toEqual(anchorWhere('dom-1', 'subject', SUBJECT_ID))
+    expect(anchorWhere('dom-2', 'subject', SUBJECT_ID)).not.toEqual(anchorWhere('dom-1', 'subject', SUBJECT_ID))
+  })
+
+  it.each([
+    ['an EPC, as the screen shows a pallet', 'items:urn:epc:id:sgtin:0614141.107346.2017'],
+    ['a name, as the screen shows an order', 'orders:SO-A887417'],
+    ['a uuid with no axis', '6f1c2a90-3b4d-4e5f-8a6b-7c8d9e0f1a2b'],
+    ['an axis with no item', 'items:']
+  ])('★ refuses %s — on write and on read', (_what, id) => {
+    expect(() => anchorColumns('subject', id)).toThrow(/is not a subject anchor/)
+    expect(() => anchorWhere('dom-1', 'subject', id)).toThrow(/is not a subject anchor/)
+  })
+
+  it('the shape rule is the subject anchor\'s alone — other anchors keep taking the ids they take', () => {
+    expect(anchorColumns('space', 'busan').anchorId).toBe('busan')
+    expect(anchorColumns('application', 'operato-figure').anchorId).toBe('operato-figure')
+  })
+
+  it('★ a subject conversation is born open — an anchored conversation is about a shared thing (ADR-0073 decision 2)', () => {
+    expect(initialVisibility({ anchorType: 'subject' })).toBe('open')
+  })
+})

package/test/assistant-request-context.test.ts

@@ -1,7 +1,7 @@
 import assert from 'node:assert/strict'
 import { readFileSync } from 'node:fs'
 import { join } from 'node:path'
-import { assistantAutoAskKey, assistantModelFingerprint, assistantRecentSessions } from '../client/utils/assistant-request-context.ts'
+import { assistantAutoAskKey, assistantDraftDecision, assistantModelFingerprint, assistantRecentSessions } from '../client/utils/assistant-request-context.ts'
 
 test('model signature ignores object key order but detects nested edits and array order', () => {
   assert.equal(assistantModelFingerprint({ b: 2, a: { y: 3, x: 1 } }), assistantModelFingerprint({ a: { x: 1, y: 3 }, b: 2 }))
@@ -28,3 +28,43 @@ test('send captures current context before optimistic input and attaches request
   assert.match(send, /detail: \{ actions: out.actions, sessionId: out.sessionId, requestBase \}/)
   assert.match(send, /requestContext\.hostContext/)
 })
+
+/*
+ * The draft — a sentence placed in the input for the person to edit and send (twin's "new twin → AI").
+ */
+test('★ a draft fills an empty input once per request, and a re-render does not fill it again', () => {
+  const first = assistantDraftDecision({ draft: 'make a twin of line 3', draftRequestId: 'r1', typed: '' })
+  assert.deepEqual(first, { fill: true, consumed: assistantAutoAskKey('make a twin of line 3', 'r1') })
+
+  const again = assistantDraftDecision({ draft: 'make a twin of line 3', draftRequestId: 'r1', drafted: first.consumed, typed: '' })
+  assert.equal(again.fill, false)
+
+  const next = assistantDraftDecision({ draft: 'make a twin of line 3', draftRequestId: 'r2', drafted: first.consumed, typed: '' })
+  assert.equal(next.fill, true, 'the same sentence under a new request is a new draft')
+})
+
+test('★ a draft never overwrites what the person is typing — and does not surface later', () => {
+  const out = assistantDraftDecision({ draft: 'make a twin', draftRequestId: 'r1', typed: 'how many forklifts' })
+  assert.equal(out.fill, false)
+  assert.ok(out.consumed, 'skipped, and remembered as consumed')
+})
+
+test('★ when autoAsk comes for the same request, autoAsk wins', () => {
+  const out = assistantDraftDecision({ draft: 'edit me', draftRequestId: 'r1', typed: '', autoAsk: 'send me', autoAskRequestId: 'r1' })
+  assert.equal(out.fill, false)
+
+  const otherRequest = assistantDraftDecision({ draft: 'edit me', draftRequestId: 'r2', typed: '', autoAsk: 'send me', autoAskRequestId: 'r1' })
+  assert.equal(otherRequest.fill, true)
+})
+
+test('no draft, nothing to do', () => {
+  assert.deepEqual(assistantDraftDecision({ typed: '' }), { fill: false })
+})
+
+test('the component places the draft and never sends it', () => {
+  const chat = readFileSync(join(__dirname, '../client/components/assistant-chat.ts'), 'utf8')
+  const updated = chat.slice(chat.indexOf('  updated(changed'), chat.indexOf('if (changed.has(\'subject\'))'))
+  const draftPart = updated.slice(updated.indexOf('assistantDraftDecision('))
+  assert.match(draftPart, /this\.input = this\.draft!/)
+  assert.doesNotMatch(draftPart, /this\.send\(\)/)
+})