@things-factory/ai-assistant 10.1.227 → 10.1.229

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@things-factory/ai-assistant",
-  "version": "10.1.227",
+  "version": "10.1.229",
   "main": "dist-server/index.js",
   "things-factory": true,
   "author": "heartyoh",
@@ -30,18 +30,18 @@
     "@operato/graphql": "^10.29.39",
     "@operato/i18n": "^10.0.0",
     "@operato/input": "^10.29.39",
-    "@operato/layout": "^10.29.49",
+    "@operato/layout": "^10.29.60",
     "@operato/popup": "^10.29.39",
     "@operato/shell": "^10.29.39",
     "@operato/styles": "^10.0.0",
     "@operato/utils": "^10.29.39",
-    "@things-factory/ai-client-base": "^10.1.227",
-    "@things-factory/apptool-base": "^10.1.227",
-    "@things-factory/attachment-base": "^10.1.227",
-    "@things-factory/auth-base": "^10.1.227",
+    "@things-factory/ai-client-base": "^10.1.228",
+    "@things-factory/apptool-base": "^10.1.228",
+    "@things-factory/attachment-base": "^10.1.228",
+    "@things-factory/auth-base": "^10.1.228",
     "@things-factory/env": "^10.1.149",
-    "@things-factory/setting-base": "^10.1.227",
-    "@things-factory/shell": "^10.1.227",
+    "@things-factory/setting-base": "^10.1.228",
+    "@things-factory/shell": "^10.1.228",
     "dompurify": "^3.0.0",
     "exceljs": "4.2.0",
     "graphql-scalars": "^1.22.0",
@@ -57,5 +57,5 @@
     "copyfiles": "^2.4.1",
     "rimraf": "^5.0.0"
   },
-  "gitHead": "f66591e3864aab08a6fb93fb1fcf1c9de6b546ac"
+  "gitHead": "df6361882dc166ef3f8bd54492113253c802f879"
 }

package/server/service/assistant-mode/index.ts

@@ -14,6 +14,8 @@ export {
 export { resolveModeSettings, assistantModeView } from './resolve.js'
 /* A category another package opens in every conversation, in front on the pages it names (ADR-0160 decision 9). */
 export { registerConversationCategory, conversationCategoriesOf, turnSystemPrompt, type ConversationCategory } from './mode-categories.js'
+/* The record an open 360 is about, named by the module that owns it (screen-pattern §2-1). */
+export { recordSubjectDescriber, registerRecordSubject, type RecordSubject } from './record-subject.js'
 export { ABSENCE_RULE, FINISH_RULE, NEXT_REQUEST_RULE, SELECTION_RULE, SPEAKER_RULE, conversationPrompt, isPersonRequest, splitNextRequest } from './screen-rules.js'
 export type { AssistantModeSpec, AssistantModeSlash, AssistantModeWarning, UnattendedLimits } from './types.js'
 export type { AssistantModeRef, ModeSettings, AssistantModeView, AssistantModeSlashView, Translate } from './resolve.js'

package/server/service/assistant-mode/record-subject.test.ts

@@ -0,0 +1,41 @@
+/*
+ * An open 360's record is named by its owner, behind the door its 360 reads it by (screen-pattern §2-1).
+ */
+import { recordSubjectDescriber } from './record-subject'
+
+const ROW = { id: 'r1', name: 'Q4 renewal' }
+
+const subject = {
+  axis: 'opportunity',
+  noun: 'sales opportunity',
+  door: 'Query.opportunity',
+  read: async (rowId: string, domainId: string) => (rowId === 'r1' && domainId === 'd1' ? ROW : null),
+  nameOf: (row: any) => row.name
+}
+
+const asked: string[] = []
+const open = () => async (door: string) => (asked.push(door), true)
+const closed = () => async (door: string) => (asked.push(door), false)
+
+describe('a record subject', () => {
+  beforeEach(() => (asked.length = 0))
+
+  it('★ names the record of its axis, asking the 360 read\'s door', async () => {
+    const describer = recordSubjectDescriber(subject, open)
+    expect(describer).toMatchObject({ anchorType: 'subject', axis: 'opportunity' })
+    expect(await describer.describe({ anchorId: 'opportunity:r1', domain: { id: 'd1' }, state: {} })).toEqual({ noun: 'sales opportunity', name: 'Q4 renewal' })
+    expect(asked).toEqual(['Query.opportunity'])
+  })
+
+  it('★ names nothing for someone the door does not let through', async () => {
+    expect(await recordSubjectDescriber(subject, closed).describe({ anchorId: 'opportunity:r1', domain: { id: 'd1' }, state: {} })).toBeUndefined()
+  })
+
+  it('names nothing of another axis, another domain or no row', async () => {
+    const describer = recordSubjectDescriber(subject, open)
+    expect(await describer.describe({ anchorId: 'invoice:r1', domain: { id: 'd1' } })).toBeUndefined()
+    expect(await describer.describe({ anchorId: 'opportunity:', domain: { id: 'd1' } })).toBeUndefined()
+    expect(await describer.describe({ anchorId: 'opportunity:r1', domain: { id: 'd2' } })).toBeUndefined()
+    expect(await describer.describe({ anchorId: 'opportunity:r9', domain: { id: 'd1' } })).toBeUndefined()
+  })
+})

package/server/service/assistant-mode/record-subject.ts

@@ -0,0 +1,44 @@
+/**
+ * A record whose 360 is open, named for the AI each turn (operato-application design/ai/screen-pattern.md §2-1).
+ *
+ * A 360 kind with `assistantSubject` (@operato/layout) anchors its conversation to `subject` · `<kind>:<row uuid>`. The
+ * module that owns the record says here what to call it: the kind is the axis, and the door is the GraphQL field its
+ * 360 reads the record by (`Query.invoice`). The record is named only for someone that door lets through - asked of
+ * AUTH's field table as a tool's door is asked (`tool-access.ts`), so the declaration is the door's, never a copy.
+ * A row of another domain, or one that is gone, is not named.
+ */
+import { registerAssistantSubject, type AssistantSubjectDescriber } from '@things-factory/ai-client-base'
+
+import { toolAccessFor } from '../tool-access.js'
+
+export interface RecordSubject {
+  /** The 360 kind - the anchor's `<axis>:` part. */
+  axis: string
+  /** `invoice`, `sales opportunity` - English, a word the model can use in a sentence. */
+  noun: string
+  /** The root field the 360 reads the record by, `Query.<field>` - whoever may not pass it is told no name. */
+  door: string
+  /** The row of this domain, `null` when there is none there. */
+  read(rowId: string, domainId: string): Promise<any | null>
+  /** The name the 360 shows. */
+  nameOf(row: any): string
+}
+
+export function recordSubjectDescriber(subject: RecordSubject, accessFor = toolAccessFor): AssistantSubjectDescriber {
+  return {
+    anchorType: 'subject',
+    axis: subject.axis,
+    async describe({ anchorId, domain, state }) {
+      const rowId = anchorId.slice(subject.axis.length + 1)
+      if (!anchorId.startsWith(`${subject.axis}:`) || !rowId) return undefined
+      if (!(await accessFor({ state })(subject.door))) return undefined
+      const row = await subject.read(rowId, domain.id)
+      const name = row ? subject.nameOf(row) : ''
+      return name ? { noun: subject.noun, name } : undefined
+    }
+  }
+}
+
+export function registerRecordSubject(subject: RecordSubject): void {
+  registerAssistantSubject(recordSubjectDescriber(subject))
+}

package/server/service/chat-session/attachment-tool-result.test.ts

@@ -4,7 +4,10 @@
 /* The source, not the built package - the two land together and the test must see the change before a build. */
 import { takeToolImages } from '../../../../ai-client-base/server/service/agentic-loop/agentic-loop'
 
-import { attachmentToolResult, NO_SUCH_ATTACHMENT } from './attachment-tool-result'
+import { readFileSync } from 'fs'
+import { join } from 'path'
+
+import { attachmentIdOf, attachmentToolResult, NO_SUCH_ATTACHMENT } from './attachment-tool-result'
 
 describe('a file opened again in a later turn', () => {
   const png = Buffer.from([0x89, 0x50, 0x4e, 0x47, 9])
@@ -32,3 +35,29 @@ describe('an id that names no file', () => {
     expect(NO_SUCH_ATTACHMENT).toMatch(/Do not ask for it again/)
   })
 })
+
+describe('the file id in what the model wrote', () => {
+  const ID = '0f3c2a9e-1b2d-4c5e-8f90-a1b2c3d4e5f6'
+
+  it('★ the whole history line is read as the id it begins with (office.hatiolab.com, 2026-10-29: postgres 22P02)', () => {
+    expect(attachmentIdOf(`${ID}: 기술개발인력 이력서.pdf.txt (text/plain, 6429 bytes) - readChatAttachment to open it`)).toBe(ID)
+    expect(attachmentIdOf(`[attachment ${ID}: 영수증.png]`)).toBe(ID)
+    expect(attachmentIdOf(`  ${ID.toUpperCase()}  `)).toBe(ID.toUpperCase())
+  })
+
+  it('★ anything else names no file - a record key, a cut id, words', () => {
+    expect(attachmentIdOf(`contract:${ID}`)).toBeUndefined()
+    expect(attachmentIdOf(ID.slice(0, 33))).toBeUndefined()
+    expect(attachmentIdOf(`${ID}0`)).toBeUndefined()
+    expect(attachmentIdOf('unknown')).toBeUndefined()
+    expect(attachmentIdOf(undefined)).toBeUndefined()
+  })
+
+  it('★ both readers ask the database only for the id read out of it', () => {
+    const tool = readFileSync(join(__dirname, 'attachment-tools.ts'), 'utf8')
+    expect(tool).toMatch(/const id = attachmentIdOf\(given\)\n\s+if \(!id\) return \{ absent: 'not-found'/)
+    expect(tool.indexOf('attachmentIdOf(given)')).toBeLessThan(tool.indexOf('getRepository(Attachment).findOne'))
+    const sources = readFileSync(join(__dirname, '..', 'data-entry', 'entry-sources.ts'), 'utf8')
+    expect(sources).toMatch(/const fileId = attachmentIdOf\(id\)\n\s+if \(!fileId\) continue\n\s+const row: any = await getRepository\(Attachment\)\.findOne\(\{ where: \{ id: fileId,/)
+  })
+})

package/server/service/chat-session/attachment-tool-result.ts

@@ -23,3 +23,15 @@ export function attachmentToolResult(attachmentId: string, file: FileForModel) {
  */
 export const NO_SUCH_ATTACHMENT =
   'there is no file with this id in a conversation here - it is not an attachment. Do not ask for it again; a record is read with its own read tool.'
+
+/*
+ * The file's id in what the model wrote (2026-10-29, office.hatiolab.com): it passed the whole history line -
+ * 「<id>: 이력서.pdf.txt (text/plain, 1547 bytes) - readChatAttachment to open it」 - and postgres refused the text as a
+ * uuid (22P02). The id is the uuid the text begins with, after an optional "[attachment "; anything else - a record's
+ * key, a cut id - names no file and is not asked of the database.
+ */
+const LEADING_ID = /^\[?(?:attachment\s+)?([0-9a-f]{8}-[0-9a-f]{4}-[0-9a-f]{4}-[0-9a-f]{4}-[0-9a-f]{12})(?![0-9a-f-])/i
+
+export function attachmentIdOf(text: unknown): string | undefined {
+  return typeof text === 'string' ? LEADING_ID.exec(text.trim())?.[1] : undefined
+}

package/server/service/chat-session/attachment-tools.ts

@@ -18,7 +18,7 @@ import { isSessionParticipant } from '../chat-session-participant/participant-lo
 import { attachmentForModel, CHAT_ATTACHMENT_REF } from './session-attachments.js'
 import { textCharsOf } from './attachment-policy.js'
 import { getAssistantMode } from '../assistant-mode/registry.js'
-import { attachmentToolResult, NO_SUCH_ATTACHMENT } from './attachment-tool-result.js'
+import { attachmentIdOf, attachmentToolResult, NO_SUCH_ATTACHMENT } from './attachment-tool-result.js'
 
 export const CHAT_ATTACHMENT_CATEGORY = 'chat-attachments'
 
@@ -36,8 +36,10 @@ const readChatAttachment: ToolSpec = {
   },
   builder: async (args: any, context: any) => {
     const { domain, user } = context?.state ?? {}
-    const id = typeof args?.attachmentId === 'string' ? args.attachmentId.trim() : ''
-    if (!domain?.id || !id) return { absent: 'no-attachment', message: 'no attachment id was given.' }
+    const given = typeof args?.attachmentId === 'string' ? args.attachmentId.trim() : ''
+    if (!domain?.id || !given) return { absent: 'no-attachment', message: 'no attachment id was given.' }
+    const id = attachmentIdOf(given)
+    if (!id) return { absent: 'not-found', attachmentId: given, message: NO_SUCH_ATTACHMENT }
 
     const row: any = await getRepository(Attachment).findOne({ where: { id, domain: { id: domain.id }, refType: CHAT_ATTACHMENT_REF } as any })
     const session: any = row && (await getRepository(ChatSession).findOne({ where: { id: row.refBy, domain: { id: domain.id } } as any }))

package/server/service/data-entry/data-entry.test.ts

@@ -6,6 +6,8 @@ import { readFieldValue, recordIdOfKey, resolveReferences, offsetAt, zonedDateTi
 import { entryCategoryOf, proposeEntries } from './entry-tools'
 import { applyEntryProposal, entryProposalAnswered, findEntryProposal, type EntryApplyDeps } from './entry-apply'
 import { modeToolCategories } from '../assistant-mode/resolve'
+import { clearReadTargets, declareReadTarget } from '../data-read/read-target'
+import { listReadTarget } from '../data-read/list-read'
 
 const written: any[] = []
 
@@ -128,6 +130,22 @@ describe('proposing', () => {
     const result: any = await proposeEntries(expense, { rows: [] }, { state: {} })
     expect(result).toMatchObject({ rejected: true, error: 'no-rows' })
   })
+
+  it("★ carries the screen where the records are seen - the target's own, else its list read's, else none", async () => {
+    const one = { rows: [{ values: { spentOn: '2026-09-12', amount: 1 }, sources: [{ where: 'x' }] }] }
+    clearReadTargets()
+    expect((await proposeEntries(expense, one, { state: {} }, async () => new Map()) as any).screen).toBeUndefined()
+
+    declareReadTarget(listReadTarget({ key: 'office.expense-line', title: 't', name: 'expense lines', listQuery: 'expenseLines', selection: 'id amount', columns: [{ name: 'amount', type: 'number' }], route: 'expense-line-list', screenQuery: true }))
+    expect(await proposeEntries(expense, one, { state: {} }, async () => new Map())).toMatchObject({ screen: 'expense-line-list', screenLists: true })
+    /* A screen the target declares shows other records (a parent's, a workspace) - its address is not narrowed by these ids. */
+    const own: any = await proposeEntries({ ...expense, screen: 'my-expense-page' }, one, { state: {} }, async () => new Map())
+    expect(own.screen).toBe('my-expense-page')
+    expect(own.screenLists).toBeUndefined()
+    /* The records it is about besides its own - their 360s read again once it is applied. */
+    expect(((await proposeEntries({ ...expense, axes: ['contract'] }, one, { state: {} }, async () => new Map())) as any).axes).toEqual(['contract'])
+    clearReadTargets()
+  })
 })
 
 describe('entering what the person pressed', () => {

package/server/service/data-entry/entry-screen.ts

@@ -0,0 +1,14 @@
+import { readTargetOf } from '../data-read/read-target.js'
+import type { EntryTarget } from './entry-target.js'
+
+/**
+ * Where the records of a card are seen once they went in - the target's own screen, else the list screen of the read
+ * target with the same key. Carried on the card, so it is there after a refresh. `screenLists` says that screen lists
+ * these very records and takes conditions in its address, so the card may open it narrowed to them.
+ */
+export function entryScreenOf(target: EntryTarget): { screen: string; screenLists?: true } | {} {
+  if (target.screen) return { screen: target.screen }
+  const screen = readTargetOf(target.key)?.screen
+  if (!screen?.route) return {}
+  return { screen: screen.route, ...(screen.queryState ? { screenLists: true as const } : {}) }
+}

package/server/service/data-entry/entry-sources.ts

@@ -11,6 +11,7 @@ import { mayReadSession } from '../chat-session/session-visibility.js'
 import { isSessionParticipant } from '../chat-session-participant/participant-lookup.js'
 import { CHAT_ATTACHMENT_REF } from '../chat-session/session-attachments.js'
 import { attachmentKindOf } from '../chat-session/attachment-policy.js'
+import { attachmentIdOf } from '../chat-session/attachment-tool-result.js'
 
 /** The whole text is read - the check must see every line, not the part the model was shown. */
 const MAX_CHARS = 2_000_000
@@ -20,7 +21,10 @@ export async function loadSourceTexts(ids: string[], context: any): Promise<Map<
   const texts = new Map<string, string>()
   if (!domain?.id) return texts
   for (const id of [...new Set(ids)].slice(0, 20)) {
-    const row: any = await getRepository(Attachment).findOne({ where: { id, domain: { id: domain.id }, refType: CHAT_ATTACHMENT_REF } as any })
+    /* Keyed by the id as cited; a citation that names no file is not asked of the database. */
+    const fileId = attachmentIdOf(id)
+    if (!fileId) continue
+    const row: any = await getRepository(Attachment).findOne({ where: { id: fileId, domain: { id: domain.id }, refType: CHAT_ATTACHMENT_REF } as any })
     const session: any = row && (await getRepository(ChatSession).findOne({ where: { id: row.refBy, domain: { id: domain.id } } as any }))
     if (!row || !session) continue
     if (!mayReadSession(session.visibility, await isSessionParticipant(domain.id, session.id, user?.id))) continue

package/server/service/data-entry/entry-target.ts

@@ -173,6 +173,12 @@ export interface EntryTarget {
     variables(rows: EntryRow[]): Record<string, unknown>
     appliedOf?(data: any, rows: EntryRow[]): EntryApplied | undefined
   }
+  /**
+   * The application's route where the entered or changed records are seen - the card offers it once they went in.
+   * Left out, the list screen of the read target with the same key; declared where that is none (a parent's screen,
+   * a workspace).
+   */
+  screen?: string
   /** At most this many rows in one proposal. Default 200. */
   maxRows?: number
   /**

package/server/service/data-entry/entry-tools.ts

@@ -10,6 +10,7 @@
 import { registerToolCategory, type ToolCategory, type ToolSpec } from '@things-factory/ai-client-base'
 
 import { findRecords, proposeChanges, changeableFields, type GraphqlRunner } from './entry-update.js'
+import { entryScreenOf } from './entry-screen.js'
 import {
   changeToolName,
   findToolName,
@@ -113,6 +114,8 @@ export async function proposeEntries(target: EntryTarget, args: any, context: an
     rows,
     counts: { rows: rows.length, ready: rows.length - blocked, blocked, cut, verified, unmatched, ...groupCounts },
     ...(target.group ? { groupBy: target.group.by } : {}),
+    ...entryScreenOf(target),
+    ...(target.axes?.length ? { axes: target.axes } : {}),
     ...(totals.length ? { totals } : {}),
     ...(typeof args?.note === 'string' && args.note.trim() ? { reason: args.note.trim().slice(0, 300) } : {}),
     ...(checkFailed ? { checkFailed } : {}),

package/server/service/data-entry/entry-update.ts

@@ -22,6 +22,7 @@ import {
   type EntryRecord,
   type EntryTarget
 } from './entry-target.js'
+import { entryScreenOf } from './entry-screen.js'
 
 /** Runs one of the application's queries or mutations as the person. */
 export type GraphqlRunner = (document: string, variables: Record<string, unknown>) => Promise<{ data?: any; errors?: readonly { message: string }[] }>
@@ -169,6 +170,8 @@ export async function proposeChanges(target: EntryTarget, args: any, context: an
     columns: changedColumns(target, rows),
     rows,
     counts: { rows: rows.length, ready: rows.length - blocked, blocked, cut: 0 },
+    ...entryScreenOf(target),
+    ...(target.axes?.length ? { axes: target.axes } : {}),
     ...(typeof args?.note === 'string' && args.note.trim() ? { reason: args.note.trim().slice(0, 300) } : {}),
     message:
       `proposed ${rows.length} changes (${rows.length - blocked} ready, ${blocked} blocked). Nothing changes until the person presses the card. ` +

package/server/service/data-read/data-read.test.ts

@@ -6,6 +6,7 @@
 import { modeToolCategories } from '../assistant-mode/resolve'
 import { clearReadTargets, declareDetailRead, declareReadTarget, detailToolName, groupsOf, MAX_DETAIL_CHARS, MAX_READ_ROWS, queryToolName, readCategoryName, screenAddress, screenToolName, type DetailRead, type ReadTarget } from './read-target'
 import { detailCategoryOf, openScreen, queryDetail, queryRecords, readCategoryOf } from './read-tools'
+import { decodeListQuery } from '@operato/utils/list-query.js'
 
 /* The application, as a fake: a bank ledger behind a list query that pages and filters like ListParam. */
 let ledger: any[]
@@ -224,7 +225,8 @@ describe('a list declared in one line', () => {
     expect(query.has('year')).toBe(false)
     expect(query.has('month')).toBe(false)
     expect(query.has('flow')).toBe(false)
-    expect(JSON.parse(query.get('filters')!)).toEqual([
+    /* the address layer writes its own list form (json5), so the test reads it back the way the screen does */
+    expect(decodeListQuery(address.href.split('?')[1]).filters).toEqual([
       { name: 'transactionDate', operator: 'gte', value: '2026-01-01' },
       { name: 'year', operator: 'eq', value: 2026 },
       { name: 'month', operator: 'eq', value: 9 },

package/test/applied-screens.test.ts

@@ -0,0 +1,65 @@
+/*
+ * What an applied card wrote is read again by the screens that show it, and only by them (applied-screens.ts).
+ */
+import { refreshAppliedScreens } from '../client/utils/applied-screens'
+
+function deps(page: { name?: string; dirty?: boolean; refresh?: boolean } = {}, shown?: { kind: string; id: string }) {
+  const asked: any[] = []
+  let read360 = false
+  return {
+    asked,
+    read360: () => read360,
+    deps: {
+      page: () => ({
+        name: page.name,
+        element: page.refresh === false ? {} : { refresh: async (options?: any) => (asked.push(options), !page.dirty) }
+      }),
+      refresh360: (about: (subject: { kind: string; id: string }) => boolean) => (read360 = !!shown && about(shown))
+    }
+  }
+}
+
+const card = { target: 'office.counterparty', screen: 'counterparty-list' }
+
+describe('the screens behind the dock after a card is applied', () => {
+  it('★ the page that is the card\'s screen reads again, never asking about unsaved edits', async () => {
+    const one = deps({ name: 'counterparty-list' })
+    await refreshAppliedScreens(card, ['a'], one.deps)
+    expect(one.asked).toEqual([{ ask: false }])
+  })
+
+  it('★ a page with unsaved edits is left as it is, and that is said', async () => {
+    const one = deps({ name: 'counterparty-list', dirty: true })
+    expect(await refreshAppliedScreens(card, ['a'], one.deps)).toBe('kept-edits')
+    expect(await refreshAppliedScreens(card, ['a'], deps({ name: 'counterparty-list' }).deps)).toBeUndefined()
+  })
+
+  it('★ another page keeps its rows and its scroll', async () => {
+    const one = deps({ name: 'contract-list' })
+    await refreshAppliedScreens(card, ['a'], one.deps)
+    expect(one.asked).toEqual([])
+  })
+
+  it('a shell without the page refresh leaves the page as it is', async () => {
+    await expect(refreshAppliedScreens(card, ['a'], deps({ name: 'counterparty-list', refresh: false }).deps)).resolves.toBeUndefined()
+  })
+
+  it('★ the shown 360 reads again when it is one of the records, or a record the card is about', async () => {
+    const own = deps({}, { kind: 'counterparty', id: 'a' })
+    await refreshAppliedScreens(card, ['a'], own.deps)
+    expect(own.read360()).toBe(true)
+
+    const other = deps({}, { kind: 'counterparty', id: 'z' })
+    await refreshAppliedScreens(card, ['a'], other.deps)
+    expect(other.read360()).toBe(false)
+
+    const about = deps({}, { kind: 'contract', id: 'c' })
+    await refreshAppliedScreens({ target: 'office.collection-match', axes: ['cash-transaction', 'contract'] }, ['l'], about.deps)
+    expect(about.read360()).toBe(true)
+  })
+
+  it('a refresh that throws keeps the screen and the card', async () => {
+    const failing = { page: () => ({ name: 'counterparty-list', element: { refresh: async () => { throw new Error('x') } } }), refresh360: () => { throw new Error('y') } }
+    await expect(refreshAppliedScreens(card, ['a'], failing as any)).resolves.toBeUndefined()
+  })
+})

package/test/assistant-dock.test.ts

@@ -57,7 +57,12 @@ describe('every request the chat makes is taken', () => {
 
 describe('every proposal ends in one reported outcome', () => {
   it('the dock reports whatever the handler returned', () => {
-    assert.match(dock, /const outcome: ProposalOutcome =[\s\S]*await runProposal\(proposal, this\.proposalContext\(sessionId\)\)[\s\S]*await this\.report\(sessionId, proposalKey, outcome\)/)
+    assert.match(dock, /const outcome: ProposalOutcome =[\s\S]*await runProposal\(proposal, this\.proposalContext\(sessionId\)\)[\s\S]*const \{ records, \.\.\.reported \} = outcome\s*await this\.report\(sessionId, proposalKey, reported\)/)
+  })
+
+  it('★ an applied card has the screens that show its records read them again - not a refused one', () => {
+    assert.match(dock, /if \(outcome\.verdict === 'accepted' && \(outcome\.applied \?\? 1\) > 0\)\s*void refreshAppliedScreens\(proposal, records, APPLIED_SCREENS\)\.then\(kept => \{\s*if \(kept\) notify\(\{ level: 'info', message: t\('screen-kept-edits'/)
+    assert.match(dock, /page: \(\) => \{\s*const route = \(store\.getState\(\) as any\)\?\.route \?\? \{\}\s*return \{ name: route\.page, element: route\.activePage \}/)
   })
 
   it('a kind nobody handles is unavailable, by name', async () => {

package/test/entry-proposal.test.ts

@@ -9,9 +9,13 @@ const mockNotify = jest.fn()
 jest.mock('@operato/layout', () => ({ notify: (...args: any[]) => mockNotify(...args) }))
 
 import { runProposal, setEntryProposalHandler } from '../client/utils/assistant-proposals'
+import { entryWentIn } from '../client/components/proposal-outcome-line'
+import { noteForDisplay } from '../client/utils/assistant-selection'
 import {
   entryGroupOf,
   entryOutcomeNote,
+  entryRecordsOf,
+  entryScreenAddress,
   entryProposalHandler,
   entryReadyCount,
   entryTitle,
@@ -68,6 +72,48 @@ describe('the entry card', () => {
     expect(entryOutcomeNote(answer, t)).toBe('entered 2 rows.\nrow 2: closed period')
   })
 
+  it('★ names the records that went in - once per record, ten at most', () => {
+    const rows = Array.from({ length: 12 }, (_, index) => ({ index, ok: true, label: `R${index}` }))
+    const lines = [{ index: 0, ok: true, id: 'a', label: 'order A' }, { index: 1, ok: true, id: 'a', label: 'order A' }, { index: 2, ok: true }]
+    expect(entryOutcomeNote({ verdict: 'accepted', applied: 3, missed: 0, rows: lines }, t)).toBe('entered 3 rows.\norder A')
+    expect(entryOutcomeNote({ verdict: 'accepted', applied: 12, missed: 0, rows }, t)).toBe('entered 12 rows.\nR0, R1, R2, R3, R4, R5, R6, R7, R8, R9 and 2 more')
+  })
+
+  it('★ the card offers the screen where its records are seen only once something went in', () => {
+    const answered = (verdict: any, applied?: number) => ({ state: 'answered' as const, outcome: { key: 'k', verdict, applied } })
+    expect(entryWentIn(answered('accepted', 2))).toBe(true)
+    expect(entryWentIn(answered('accepted', 0))).toBe(false)
+    expect(entryWentIn(answered('refused', 1))).toBe(false)
+    expect(entryWentIn({ state: 'ready' })).toBe(false)
+    const chat = readFileSync(join(__dirname, '../client/components/assistant-chat.ts'), 'utf8')
+    /* In the card's row beside its outcome, a button of its own - not a quiet link under the table. */
+    expect(chat).toMatch(/entry && entryWentIn\(card\) && isAppAddress\(p\.screen\)\s*\? html`<button class="run see" @click=\$\{\(\) => this\.openEntryScreen\(p, key, records\)\}>/)
+    expect(chat).toMatch(/entryScreenAddress\(p, records\.get\(key\), entity360KindRegistered\)[\s\S]{0,80}'assistant-open-page', \{ detail: \{ href \}/)
+  })
+
+  it('★ the note keeps which records a card entered - hidden from the person, and never as the selection', () => {
+    const note = entryOutcomeNote({ verdict: 'accepted', applied: 2, missed: 0, key: 'k1', target: 'office.counterparty', rows: [{ index: 0, ok: true, id: 'a', label: 'A' }, { index: 1, ok: true, id: 'b', label: 'B' }] }, t)
+    expect(note).toBe('entered 2 rows.\nA, B\n[records] k1 office.counterparty a b')
+    expect(entryRecordsOf(note)).toEqual({ key: 'k1', target: 'office.counterparty', ids: ['a', 'b'] })
+    expect(noteForDisplay(note)).toBe('entered 2 rows.\nA, B')
+    expect(note).not.toMatch(/^\[keys\]/m)
+    /* Nothing went in, or no ids came back: no line. */
+    expect(entryOutcomeNote({ verdict: 'accepted', applied: 1, missed: 0, key: 'k1', target: 'office.x', rows: [{ index: 0, ok: true }] }, t)).not.toContain('[records]')
+  })
+
+  it('★ "see on the screen" opens one record\'s 360, narrows a list of the same records, or opens the screen as it is', () => {
+    const has360 = (kind: string) => kind === 'counterparty'
+    const p = { target: 'office.counterparty', screen: 'counterparty-list', screenLists: true }
+    expect(entryScreenAddress(p, ['a'], has360)).toBe('counterparty-list?f=counterparty%3Aa')
+    expect(decodeURIComponent(entryScreenAddress(p, ['a', 'b'], has360))).toBe("counterparty-list?filters=[{name:'id',operator:'in',value:['a','b']}]")
+    /* A screen of other records (a contract's rounds on the contract list) is not narrowed by their ids. */
+    expect(entryScreenAddress({ target: 'office.contract-round', screen: 'contract-list' }, ['a', 'b'], has360)).toBe('contract-list')
+    expect(entryScreenAddress({ target: 'office.contract-round', screen: 'contract-list' }, ['a'], has360)).toBe('contract-list')
+    /* Too many for an address, or none known (a card from before): the screen as it is. */
+    expect(entryScreenAddress(p, Array.from({ length: 51 }, (_, i) => `id${i}`), has360)).toBe('counterparty-list')
+    expect(entryScreenAddress(p, undefined, has360)).toBe('counterparty-list')
+  })
+
   it('★ every entry card runs the one framework handler, whatever record it enters - no app registers one', async () => {
     const asked: string[] = []
     setEntryProposalHandler(

package/translations/en.json

@@ -165,6 +165,7 @@
   "ai-assistant.dock.confirm": "OK",
   "ai-assistant.dock.cancel": "Cancel",
   "ai-assistant.dock.proposal-not-runnable": "this proposal cannot be run on this screen.",
+  "ai-assistant.dock.screen-kept-edits": "the list was not read again - it has unsaved edits. save them, then refresh it to see what went in.",
   "ai-assistant.dock.patch-missed": "{missed} of the changes could not be applied.",
   "ai-assistant.dock.not-configured": "no AI is set up for this site. an administrator can set one up in the AI settings.",
   "ai-assistant.dock.capability-unknown": "whether AI is set up here could not be read.",
@@ -203,6 +204,8 @@
   "ai-assistant.entry.entered-none": "no row was entered.",
   "ai-assistant.entry.row-refused": "row {n}: {reason}",
   "ai-assistant.entry.more-refused": "{count} more rows were not entered.",
+  "ai-assistant.entry.more-applied": "and {count} more",
+  "ai-assistant.entry.see-on-screen": "see on the screen",
   "ai-assistant.entry.issue.required": "no value",
   "ai-assistant.entry.issue.not-a-number": "not a number",
   "ai-assistant.entry.issue.not-an-integer": "not a whole number",

package/translations/es.json

@@ -165,6 +165,7 @@
   "ai-assistant.dock.confirm": "Aceptar",
   "ai-assistant.dock.cancel": "Cancelar",
   "ai-assistant.dock.proposal-not-runnable": "esta propuesta no se puede ejecutar en esta pantalla.",
+  "ai-assistant.dock.screen-kept-edits": "la lista no se volvió a leer porque tiene cambios sin guardar. guárdelos y actualícela para ver lo introducido.",
   "ai-assistant.dock.patch-missed": "no se pudieron aplicar {missed} de los cambios.",
   "ai-assistant.dock.not-configured": "no hay ninguna IA configurada para este sitio. un administrador puede configurarla en la configuración de IA.",
   "ai-assistant.dock.capability-unknown": "no se pudo comprobar si la IA está configurada aquí.",
@@ -203,6 +204,8 @@
   "ai-assistant.entry.entered-none": "no se introdujo ninguna fila.",
   "ai-assistant.entry.row-refused": "fila {n}: {reason}",
   "ai-assistant.entry.more-refused": "no se introdujeron {count} filas más.",
+  "ai-assistant.entry.more-applied": "y {count} más",
+  "ai-assistant.entry.see-on-screen": "ver en la pantalla",
   "ai-assistant.entry.issue.required": "sin valor",
   "ai-assistant.entry.issue.not-a-number": "no es un número",
   "ai-assistant.entry.issue.not-an-integer": "no es un número entero",

package/translations/ja.json

@@ -165,6 +165,7 @@
   "ai-assistant.dock.confirm": "OK",
   "ai-assistant.dock.cancel": "キャンセル",
   "ai-assistant.dock.proposal-not-runnable": "この提案はこの画面では実行できません。",
+  "ai-assistant.dock.screen-kept-edits": "保存していない編集があるため、一覧を読み直しませんでした。保存してから再読み込みすると入力した記録が表示されます。",
   "ai-assistant.dock.patch-missed": "変更のうち {missed} 件を適用できませんでした。",
   "ai-assistant.dock.not-configured": "この現場には AI が設定されていません。管理者が AI 設定で接続できます。",
   "ai-assistant.dock.capability-unknown": "AI が設定されているか読み取れませんでした。",
@@ -203,6 +204,8 @@
   "ai-assistant.entry.entered-none": "入力された行はありません。",
   "ai-assistant.entry.row-refused": "{n}行目: {reason}",
   "ai-assistant.entry.more-refused": "さらに{count}行が入力されませんでした。",
+  "ai-assistant.entry.more-applied": "ほか{count}件",
+  "ai-assistant.entry.see-on-screen": "画面で見る",
   "ai-assistant.entry.issue.required": "値がありません",
   "ai-assistant.entry.issue.not-a-number": "数値ではありません",
   "ai-assistant.entry.issue.not-an-integer": "整数ではありません",

package/translations/ko.json

@@ -165,6 +165,7 @@
   "ai-assistant.dock.confirm": "확인",
   "ai-assistant.dock.cancel": "취소",
   "ai-assistant.dock.proposal-not-runnable": "이 제안은 이 화면에서 실행할 수 없습니다.",
+  "ai-assistant.dock.screen-kept-edits": "저장하지 않은 편집이 있어 목록을 다시 읽지 않았습니다. 저장한 뒤 새로 고침하면 들어간 기록이 보입니다.",
   "ai-assistant.dock.patch-missed": "변경 중 {missed} 개를 적용하지 못했습니다.",
   "ai-assistant.dock.not-configured": "이 현장에는 AI 가 설정되어 있지 않습니다. 관리자가 AI 설정에서 연결할 수 있습니다.",
   "ai-assistant.dock.capability-unknown": "AI 설정 여부를 읽지 못했습니다.",
@@ -203,6 +204,8 @@
   "ai-assistant.entry.entered-none": "입력한 행이 없습니다.",
   "ai-assistant.entry.row-refused": "{n}행: {reason}",
   "ai-assistant.entry.more-refused": "{count}행이 더 입력되지 않았습니다.",
+  "ai-assistant.entry.more-applied": "외 {count}건",
+  "ai-assistant.entry.see-on-screen": "화면에서 보기",
   "ai-assistant.entry.issue.required": "값이 없습니다",
   "ai-assistant.entry.issue.not-a-number": "숫자가 아닙니다",
   "ai-assistant.entry.issue.not-an-integer": "정수가 아닙니다",

package/translations/ms.json

@@ -165,6 +165,7 @@
   "ai-assistant.dock.confirm": "OK",
   "ai-assistant.dock.cancel": "Batal",
   "ai-assistant.dock.proposal-not-runnable": "cadangan ini tidak boleh dijalankan pada skrin ini.",
+  "ai-assistant.dock.screen-kept-edits": "senarai tidak dibaca semula kerana ada suntingan belum disimpan. simpan dahulu, kemudian muat semula untuk melihat rekod yang dimasukkan.",
   "ai-assistant.dock.patch-missed": "{missed} daripada perubahan tidak dapat digunakan.",
   "ai-assistant.dock.not-configured": "tiada AI disediakan untuk tapak ini. pentadbir boleh menyediakannya dalam tetapan AI.",
   "ai-assistant.dock.capability-unknown": "sama ada AI disediakan di sini tidak dapat dibaca.",
@@ -203,6 +204,8 @@
   "ai-assistant.entry.entered-none": "tiada baris dimasukkan.",
   "ai-assistant.entry.row-refused": "baris {n}: {reason}",
   "ai-assistant.entry.more-refused": "{count} baris lagi tidak dimasukkan.",
+  "ai-assistant.entry.more-applied": "dan {count} lagi",
+  "ai-assistant.entry.see-on-screen": "lihat pada skrin",
   "ai-assistant.entry.issue.required": "tiada nilai",
   "ai-assistant.entry.issue.not-a-number": "bukan nombor",
   "ai-assistant.entry.issue.not-an-integer": "bukan nombor bulat",

package/translations/zh.json

@@ -165,6 +165,7 @@
   "ai-assistant.dock.confirm": "确定",
   "ai-assistant.dock.cancel": "取消",
   "ai-assistant.dock.proposal-not-runnable": "此提案无法在此界面运行。",
+  "ai-assistant.dock.screen-kept-edits": "列表有未保存的编辑，因此未重新读取。保存后刷新即可看到录入的记录。",
   "ai-assistant.dock.patch-missed": "有 {missed} 项更改未能应用。",
   "ai-assistant.dock.not-configured": "此现场尚未设置 AI。管理员可以在 AI 设置中进行设置。",
   "ai-assistant.dock.capability-unknown": "无法读取此处是否已设置 AI。",
@@ -203,6 +204,8 @@
   "ai-assistant.entry.entered-none": "未录入任何行。",
   "ai-assistant.entry.row-refused": "第{n}行：{reason}",
   "ai-assistant.entry.more-refused": "另有{count}行未录入。",
+  "ai-assistant.entry.more-applied": "等另外{count}项",
+  "ai-assistant.entry.see-on-screen": "在页面中查看",
   "ai-assistant.entry.issue.required": "缺少值",
   "ai-assistant.entry.issue.not-a-number": "不是数字",
   "ai-assistant.entry.issue.not-an-integer": "不是整数",