@things-factory/ai-assistant 10.1.178 → 10.1.181

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@things-factory/ai-assistant",
-  "version": "10.1.178",
+  "version": "10.1.181",
   "main": "dist-server/index.js",
   "things-factory": true,
   "author": "heartyoh",
@@ -27,20 +27,21 @@
   "dependencies": {
     "@apollo/client": "^3.13.0",
     "@material/web": "^2.0.0",
-    "@operato/graphql": "^10.0.0",
+    "@operato/graphql": "^10.29.39",
     "@operato/i18n": "^10.0.0",
-    "@operato/input": "^10.0.0",
-    "@operato/layout": "^10.20.0",
-    "@operato/popup": "^10.16.0",
-    "@operato/shell": "^10.0.0",
+    "@operato/input": "^10.29.39",
+    "@operato/layout": "^10.29.39",
+    "@operato/popup": "^10.29.39",
+    "@operato/shell": "^10.29.39",
     "@operato/styles": "^10.0.0",
-    "@things-factory/ai-client-base": "^10.1.178",
-    "@things-factory/apptool-base": "^10.1.178",
-    "@things-factory/attachment-base": "^10.1.178",
-    "@things-factory/auth-base": "^10.1.178",
+    "@operato/utils": "^10.29.39",
+    "@things-factory/ai-client-base": "^10.1.181",
+    "@things-factory/apptool-base": "^10.1.179",
+    "@things-factory/attachment-base": "^10.1.181",
+    "@things-factory/auth-base": "^10.1.181",
     "@things-factory/env": "^10.1.149",
-    "@things-factory/setting-base": "^10.1.178",
-    "@things-factory/shell": "^10.1.178",
+    "@things-factory/setting-base": "^10.1.181",
+    "@things-factory/shell": "^10.1.179",
     "dompurify": "^3.0.0",
     "exceljs": "4.2.0",
     "graphql-scalars": "^1.22.0",
@@ -54,5 +55,5 @@
     "copyfiles": "^2.4.1",
     "rimraf": "^5.0.0"
   },
-  "gitHead": "d57448d3f3045f72a9f24b877a3e306eb34cbaf1"
+  "gitHead": "a4387dbc9c5be49ac7bd0e85a59fbcd650f47138"
 }

package/server/service/chat-session/attachment-policy.test.ts

@@ -23,7 +23,7 @@ describe('attachment policy', () => {
   it('each limit refuses by name, before sending', () => {
     expect(refuseAttachments(policy, [{ name: 'a.pdf', type: 'application/pdf', size: 1 }])).toMatchObject({ code: 'attachment-kind-not-accepted', name: 'a.pdf' })
     expect(refuseAttachments(policy, [{ name: 'big.png', type: 'image/png', size: 1001 }])).toMatchObject({ code: 'attachment-too-large', name: 'big.png', maxBytes: 1000 })
-    expect(refuseAttachments(policy, [{}, {}, {}] as any)).toEqual({ code: 'too-many-attachments', maxFiles: 2 })
+    expect(refuseAttachments(policy, [{ name: 'a.png', type: 'image/png', size: 1 }, { name: 'b.png', type: 'image/png', size: 1 }, { name: 'c.png', type: 'image/png', size: 1 }])).toEqual({ code: 'too-many-attachments', maxFiles: 2 })
   })
 
   it('a kind outside the declared ones is refused', () => {

package/server/service/chat-session/attachment-policy.ts

@@ -64,16 +64,21 @@ export function refuseAttachments(
   if (!files.length) return null
   if (!policy || !policy.kinds?.length) return { code: 'attachments-not-accepted' }
 
+  /*
+   * File by file, in the order sent: its kind, then its size, then whether it is one too many. The screen's picking
+   * rule (@operato/utils sortPickedFiles) says them in this order, so the same batch hears the same "no" from both.
+   */
   const maxFiles = policy.maxFiles ?? DEFAULT_MAX_FILES
-  if (files.length > maxFiles) return { code: 'too-many-attachments', maxFiles }
-
   const maxBytes = policy.maxBytes ?? DEFAULT_MAX_BYTES
+  let taken = 0
   for (const file of files) {
     const kind = attachmentKindOf(file)
     if (!kind || !takes(policy, kind)) {
       return { code: 'attachment-kind-not-accepted', name: file.name || '', kinds: policy.kinds }
     }
     if ((file.size ?? 0) > maxBytes) return { code: 'attachment-too-large', name: file.name || '', maxBytes }
+    if (taken >= maxFiles) return { code: 'too-many-attachments', maxFiles }
+    taken++
   }
   return null
 }

package/server/service/data-read/data-read.test.ts

@@ -58,7 +58,7 @@ beforeEach(() => {
 })
 
 describe('reading a list', () => {
-  it('★ the conditions become the application\'s filters - the model never names the query\'s columns', async () => {
+  it("★ the conditions become the application's filters - the model never names the query's columns", async () => {
     const result: any = await queryRecords(target, { from: '2026-04-01', to: '2026-09-30', flow: 'EXPENSE' }, {}, run)
     expect(calls[0].filters).toEqual([
       { name: 'transactionDate', operator: 'gte', value: '2026-04-01' },
@@ -124,7 +124,7 @@ describe('the screen card', () => {
 })
 
 describe('declaring and offering', () => {
-  it('★ the tools are locked by the list query\'s door, and a mode opens them by key', () => {
+  it("★ the tools are locked by the list query's door, and a mode opens them by key", () => {
     const category = readCategoryOf(target, () => run)
     expect(category.name).toBe(readCategoryName(target.key))
     expect(category.specs.map(spec => spec.name)).toEqual([queryToolName(target.key), screenToolName(target.key)])
@@ -196,7 +196,7 @@ describe('a list declared in one line', () => {
     narrowing: { year: 'year', month: 'month', flow: 'type' },
     search: 'memo and counterparty',
     route: 'cash-transaction-list',
-    screenTakes: ['year', 'month', 'flow', 'text']
+    screenQuery: true
   }
 
   it('★ becomes a target with the conditions its fields allow - and only those', async () => {
@@ -207,22 +207,44 @@ describe('a list declared in one line', () => {
     const bare: ReadTarget = listReadTarget({ ...line, key: 'office.bare', narrowing: undefined, dateField: undefined, search: undefined, columns: [{ name: 'name', type: 'string' }] })
     expect(bare.criteria).toEqual([])
     expect(bare.query).not.toContain('$search')
-    expect(bare.screen!.takes).toEqual([])
+    expect(bare.screen!.takes).toEqual(['id'])
   })
 
-  it('★ the to day takes the whole day of a date-time, and the screen gets only what it reads', () => {
+  it('the screen uses the same predicates as a read, including ranges outside its filter form', () => {
     const made: ReadTarget = listReadTarget(line)
     const to = made.criteria.find(one => one.name === 'to')!
-    expect(to.filter('2026-09-30')).toEqual({ name: 'transactionDate', operator: 'lte', value: '2026-09-30T23:59:59.999' })
-    expect(made.screen!.params({ year: 2026, month: 9, flow: 'EXPENSE', text: '외주', from: '2026-01-01' })).toEqual({ year: 2026, month: 9, flow: 'EXPENSE', search: '외주' })
-    expect(made.screen!.params({ month: 9 })).toEqual({})
-    const plain: ReadTarget = listReadTarget({ ...line, key: 'plant.x', screenTakes: undefined })
+    expect(to.filter('2026-09-30')).toEqual({
+      name: 'transactionDate',
+      operator: 'lte',
+      value: '2026-09-30T23:59:59.999'
+    })
+    const criteria = { year: 2026, month: 9, flow: 'EXPENSE', text: '외주', from: '2026-01-01', minAmount: 100000 }
+    const address = screenAddress(made, criteria)!
+    const query = new URLSearchParams(address.href.split('?')[1])
+    expect(query.has('year')).toBe(false)
+    expect(query.has('month')).toBe(false)
+    expect(query.has('flow')).toBe(false)
+    expect(JSON.parse(query.get('filters')!)).toEqual([
+      { name: 'transactionDate', operator: 'gte', value: '2026-01-01' },
+      { name: 'year', operator: 'eq', value: 2026 },
+      { name: 'month', operator: 'eq', value: 9 },
+      { name: 'type', operator: 'eq', value: 'EXPENSE' },
+      { name: 'amount', operator: 'gte', value: 100000 }
+    ])
+    expect(query.get('search')).toBe('외주')
+    expect(address.notApplied).toEqual([])
+    const plain: ReadTarget = listReadTarget({ ...line, key: 'plant.x', screenQuery: false })
     expect(plain.screen!.takes).toEqual([])
-    expect(plain.screen!.params({ year: 2026 })).toEqual({})
+    expect(screenAddress(plain, { year: 2026 })!.notApplied).toEqual(['year'])
   })
 
-  it('★ a fixed filter is on every read, out of the model\'s reach - a condition narrows the list, never widens it', async () => {
-    const made: ReadTarget = listReadTarget({ ...line, key: 'office.spending', listQuery: 'cashTransactions', fixedFilters: [{ name: 'type', operator: 'eq', value: 'EXPENSE' }] })
+  it("★ a fixed filter is on every read, out of the model's reach - a condition narrows the list, never widens it", async () => {
+    const made: ReadTarget = listReadTarget({
+      ...line,
+      key: 'office.spending',
+      listQuery: 'cashTransactions',
+      fixedFilters: [{ name: 'type', operator: 'eq', value: 'EXPENSE' }]
+    })
     declareReadTarget(made)
     expect(made.criteria.map(one => one.name)).not.toContain('type')
     const all: any = await queryRecords(made, {}, {}, run)
@@ -246,7 +268,12 @@ describe('amounts in more than one currency', () => {
     ...target,
     key: 'office.fx-transaction',
     query: target.query.replace('customerName account', 'customerName currency account'),
-    columns: [...target.columns.map(one => (one.name === 'amount' ? { ...one, labelKey: 'field.amount', currency: 'currency' } : one)), { name: 'currency', type: 'string' }]
+    columns: [
+      ...target.columns.map(one =>
+        one.name === 'amount' ? { ...one, labelKey: 'field.amount', currency: 'currency' } : one
+      ),
+      { name: 'currency', type: 'string' }
+    ]
   }
   const fxt = (i: number, amount: number, currency: string | null, customerName: string) => ({ ...tx(i, '2026-06-01', 'INCOME', amount, customerName), currency })
 
@@ -257,7 +284,7 @@ describe('amounts in more than one currency', () => {
     expect(JSON.stringify(result.sums)).not.toMatch(/1100/)
   })
 
-  it('a line without its currency is summed as unknown, never as the domain\'s own', async () => {
+  it("a line without its currency is summed as unknown, never as the domain's own", async () => {
     ledger = [fxt(1, 1000, 'KRW', 'A'), fxt(2, 7, null, 'B')]
     const result: any = await queryRecords(fx, {}, {}, run)
     expect(result.sums.amount).toEqual({ KRW: 1000, unknown: 7 })

package/server/service/data-read/list-read.ts

@@ -31,8 +31,8 @@ export interface ListRead {
   search?: string
   /** The screen's route. Left out, the list has no screen card. */
   route?: string
-  /** The conditions the screen reads from its address - `year`, `month`, `flow` and `text` (as `search`). Empty: it opens as it is. */
-  screenTakes?: ('year' | 'month' | 'flow' | 'text')[]
+  /** The route has a URL-bound grid. Otherwise conditions are disclosed as not applied on its screen card. */
+  screenQuery?: boolean
 }
 
 /** The money column a minimum or maximum amount means - `amount` when there is one, else the first summed column. */
@@ -70,7 +70,9 @@ export function listReadTarget(list: ListRead): ReadTarget {
       : [])
   ] as ReadCriterion[]
 
-  const takes = (list.screenTakes ?? []).filter(name => (name === 'text' ? search : !!narrowing[name]))
+  const takes = list.screenQuery
+    ? ['id', ...criteria.map(criterion => criterion.name), ...(search ? ['text'] : [])]
+    : []
   return {
     key: list.key,
     labelKey: list.title,
@@ -90,12 +92,8 @@ export function listReadTarget(list: ListRead): ReadTarget {
             route: list.route,
             labelKey: list.title,
             takes,
-            params: (c: Record<string, any>) => ({
-              ...(takes.includes('year') ? { year: c.year } : {}),
-              ...(takes.includes('month') && c.year ? { month: c.month } : {}),
-              ...(takes.includes('flow') ? { flow: c.flow } : {}),
-              ...(takes.includes('text') ? { search: c.text } : {})
-            })
+            queryState: !!list.screenQuery,
+            params: () => ({})
           }
         }
       : {})

package/server/service/data-read/read-target.ts

@@ -10,6 +10,7 @@
  * Pure but for the GraphQL runner, which comes in as an argument - the rules are tested without a server.
  */
 import { readFieldValue, rootFieldOf, type EntryField } from '../data-entry/entry-target.js'
+import { encodeListQuery } from '@operato/utils/list-query.js'
 import type { GraphqlRunner } from '../data-entry/entry-update.js'
 import { parse } from 'graphql'
 
@@ -41,6 +42,8 @@ export interface ReadColumn {
 }
 
 export interface ReadScreen {
+  /** A URL-bound grid accepts the same predicates used by readRows, including conditions outside its form. */
+  queryState?: boolean
   /** The application's route of the list screen (`cash-transaction-list`). */
   route: string
   /** The conditions the screen takes, as its address's query arguments. A condition left out is said on the card. */
@@ -109,7 +112,7 @@ export function declareReadTarget(target: ReadTarget): void {
     if (!column.total || column.type !== 'number') throw new Error(`column '${column.name}' of '${target.key}' names a currency but is not a summed number`)
     if (target.columns.find(one => one.name === column.currency)?.type !== 'string') throw new Error(`column '${column.name}' of '${target.key}' takes its currency from '${column.currency}', which is no string column`)
   }
-  const names = new Set<string>()
+  const names = new Set<string>(['id'])
   for (const criterion of target.criteria) {
     if (criterion.name === 'id') throw new Error(`read target '${target.key}' declares 'id' - every target takes it`)
     if (criterion.name === 'text' && target.search) throw new Error(`read target '${target.key}' declares 'text' and search - search is the text condition`)
@@ -213,7 +216,9 @@ export function readCriteria(target: ReadTarget, args: any): { criteria: Record<
 export function filtersOf(target: ReadTarget, criteria: Record<string, unknown>): ReadFilter[] {
   return [
     ...(typeof criteria.id === 'string' ? [{ name: 'id', operator: 'eq', value: criteria.id }] : []),
-    ...target.criteria.flatMap(criterion => (criterion.name in criteria ? [criterion.filter(criteria[criterion.name])].flat() : []))
+    ...target.criteria.flatMap(criterion =>
+      criterion.name in criteria ? [criterion.filter(criteria[criterion.name])].flat() : []
+    )
   ]
 }
 
@@ -331,7 +336,14 @@ export function screenAddress(target: ReadTarget, criteria: Record<string, unkno
   const params = new URLSearchParams()
   for (const [name, value] of Object.entries(screen.params(criteria))) if (value !== undefined && value !== null && value !== '') params.set(name, String(value))
   const given = Object.keys(criteria)
-  const query = params.toString()
+  const applicable = Object.fromEntries(Object.entries(criteria).filter(([name]) => screen.takes.includes(name)))
+  const query = screen.queryState
+    ? encodeListQuery({
+        filters: filtersOf(target, applicable),
+        search: typeof applicable.text === 'string' ? applicable.text : undefined,
+        sorters: target.sortings
+      })
+    : params.toString()
   return {
     href: query ? `${screen.route}?${query}` : screen.route,
     applied: given.filter(name => screen.takes.includes(name)),

package/test/assistant-dock.test.ts

@@ -139,7 +139,7 @@ describe('attachments in the chat follow the mode', () => {
   })
 
   it('said before sending, then uploaded to the conversation and sent by id', () => {
-    assert.match(chat, /refuseAttachments\(this\.modeView\?\.attachments/)
+    assert.match(chat, /refuseAttachments\(\s*this\.modeView\?\.attachments/)
     assert.match(chat, /mutation: ATTACH_TO_CONVERSATION_MUTATION/)
     /* Without it the client sends the File as {} and the server refuses the upload (found on :3700, 2026-09-25). */
     assert.match(chat, /context: \{ hasUpload: true \}/)

package/test/attachment-one-rule.test.ts

@@ -0,0 +1,46 @@
+import { readFileSync } from 'fs'
+import { join } from 'path'
+
+import * as screen from '../client/utils/attachment-policy'
+import * as server from '../server/service/chat-session/attachment-policy'
+
+/*
+ * A conversation's attachments are refused on the screen by the one file-picking rule (@operato/utils
+ * sortPickedFiles, ADR-0061 2026-10-17); the mode's policy is a limit, narrowed by the server's upload limit. The
+ * screen's "no" is only so the person hears it early - the door still refuses by the mode's policy on its own.
+ */
+const read = (file: string) => readFileSync(join(__dirname, '..', file), 'utf8')
+
+describe('one rule for a conversation attachment', () => {
+  const policy = { kinds: ['image'], maxBytes: 100, maxFiles: 5 } as any
+
+  it('★ the screen applies the tighter of the mode policy and the server upload limit', () => {
+    const file = [{ name: 'a.png', type: 'image/png', size: 60 }]
+    expect(screen.refuseAttachments(policy, file)).toBeNull()
+    expect(screen.refuseAttachments(policy, file, { maxFileSize: 50 })).toEqual({ code: 'attachment-too-large', name: 'a.png', maxBytes: 50 })
+    expect(screen.refuseAttachments(policy, file, { maxFileSize: 1000 })).toBeNull()
+    expect(screen.refuseAttachments(policy, [{ name: 'b.png', type: 'image/png', size: 200 }], { maxFileSize: 1000 })).toMatchObject({ maxBytes: 100 })
+  })
+
+  it('★ the screen judges with the shared rule, not a copy of its own', () => {
+    const source = read('client/utils/attachment-policy.ts')
+    expect(source).toMatch(/import \{ narrowLimits, sortPickedFiles, type FileUploadLimits \} from '@operato\/utils\/file-acceptance\.js'/)
+    expect(source).not.toMatch(/function takes\(|export function attachmentKindOf/)
+  })
+
+  it('★ the door still refuses by the mode policy itself, before and after saving', () => {
+    expect(server.refuseAttachments(policy, [{ name: 'a.pdf', type: 'application/pdf', size: 1 }])).toMatchObject({ code: 'attachment-kind-not-accepted' })
+    const door = read('server/service/chat-session-resolver.ts')
+    expect(door).toMatch(/import \{ refuseAttachments, type AttachmentRefusal \} from '\.\/chat-session\/attachment-policy\.js'/)
+    expect(door.match(/refuseAttachments\(policy, /g)?.length).toBe(2)
+  })
+
+  it('★ the attach button opens the one picker; paste and drop take the same rule', () => {
+    const chat = read('client/components/assistant-chat.ts')
+    expect(chat).not.toMatch(/type="file"/)
+    expect(chat).toMatch(/<ox-input-file\s+id="chat-file-input"\s+quiet\s+outside-trigger/)
+    expect(chat).toMatch(/\(this\.renderRoot\.querySelector\('#chat-file-input'\) as any\)\?\.pick\(\)/)
+    expect(chat).toMatch(/this\.onAttachFiles\(e\.dataTransfer\.files\)/)
+    expect(chat).toMatch(/await fileUploadLimits\(\)\s*\)/)
+  })
+})

package/test/attachment-policy-agree.test.ts

@@ -13,7 +13,10 @@ const fileSets = [
   [{ name: 'report.CSV', type: '', size: 10 }],
   [{ name: 'a.pdf', type: 'application/pdf', size: 10 }],
   [{ name: 'big.png', type: 'image/png', size: 101 }],
-  [{ name: 'a.png', type: 'image/png', size: 1 }, { name: 'b.png', type: 'image/png', size: 1 }, { name: 'c.png', type: 'image/png', size: 1 }]
+  [{ name: 'a.png', type: 'image/png', size: 1 }, { name: 'b.png', type: 'image/png', size: 1 }, { name: 'c.png', type: 'image/png', size: 1 }],
+  /* Mixed batches: the same "no" in the same order - kind, then size, then one too many, file by file. */
+  [{ name: 'a.png', type: 'image/png', size: 1 }, { name: 'b.png', type: 'image/png', size: 1 }, { name: 'c.pdf', type: 'application/pdf', size: 1 }],
+  [{ name: 'a.png', type: 'image/png', size: 1 }, { name: 'b.png', type: 'image/png', size: 1 }, { name: 'c.png', type: 'image/png', size: 101 }]
 ]
 
 describe('the screen and the door refuse the same things', () => {