@things-factory/ai-assistant 10.1.157 → 10.1.160

package/server/service/testing/mode-conformance.ts

@@ -12,7 +12,7 @@
  *   · 화면에 낼 말이 **키가 아니라 문장**으로 나오는가
  *   · 슬래시가 가리키는 도구가 그 모드 안에 있는가
  */
-import { registryAssistantChat } from '@things-factory/ai-client-base'
+import { openSubjectLine, registryAssistantChat } from '@things-factory/ai-client-base'
 
 import { getAssistantMode, getAssistantModeWarnings } from '../assistant-mode/registry.js'
 import { assistantModeView, resolveModeSettings, type Translate } from '../assistant-mode/resolve.js'
@@ -127,3 +127,29 @@ export function modePromisesItCannotKeep(kind: string): string[] {
     .filter(warning => warning.params.kind === kind)
     .map(warning => `${warning.code}:${warning.params.slash}→${warning.params.tool}`)
 }
+
+/**
+ * What an app's prompt carries that every conversation already gets (design/ai/screen-pattern.md §6 · §7).
+ *
+ * The absence rule is added by the door to every conversation. A copy in an app's prompt says it twice, and the
+ * copies drift - five apps had five spellings of it.
+ */
+export function modeCarriesSharedRules(kind: string): string[] {
+  const prompt = String(getAssistantMode(kind)?.systemPrompt ?? '')
+  const found: string[] = []
+  if (/name our plumbing|do not describe our machinery/i.test(prompt)) found.push('absence-rule-copy')
+  if (/^\s*Next:/im.test(prompt) || /end the reply with one last line/i.test(prompt)) found.push('next-request-rule-copy')
+  return found
+}
+
+/** Subjects that more than one conversation names - a screen has one (design/ai/screen-pattern.md §3). */
+export function subjectsClaimedTwice(): string[] {
+  return getAssistantModeWarnings()
+    .filter(warning => warning.code === 'assistant-mode-subject-claimed-twice')
+    .map(warning => String(warning.params.subject))
+}
+
+/** The line the model reads for an open subject - an app's test checks its describer names its own record. */
+export function openSubjectLineFor(anchorType: string, anchorId: string, domainId: string, state?: any): Promise<string | undefined> {
+  return openSubjectLine({ anchorType, anchorId, domain: { id: domainId }, state })
+}

package/server/tool-registry-boot-report.test.ts

@@ -12,7 +12,7 @@ jest.mock('@things-factory/auth-base', () => ({ privilegeOfField: () => ({ known
 /* ai-client-base keeps the AI usage table since 2026-10-12, so its root brings shell too - the same stand-in. */
 jest.mock('@things-factory/ai-client-base', () => ({ getToolRegistryWarnings: () => [] }))
 
-import { formatToolRegistryWarnings } from './tool-registry-boot-report'
+import { formatAssistantModeWarnings, formatToolRegistryWarnings } from './tool-registry-boot-report'
 
 it('★ groups the recorded omissions by code and names every tool', () => {
   const lines = formatToolRegistryWarnings([
@@ -26,3 +26,16 @@ it('★ groups the recorded omissions by code and names every tool', () => {
 it('says nothing when every tool is declared', () => {
   expect(formatToolRegistryWarnings([])).toEqual([])
 })
+
+describe('a screen with two conversations is reported by its subject (ADR-0072 rule, ruled 2026-10-13)', () => {
+  it('★ the boot line names the code, the subject and both conversations', () => {
+    const lines = formatAssistantModeWarnings([
+      {
+        code: 'assistant-mode-subject-claimed-twice',
+        params: { kind: 'twin.board', subject: 'board', kinds: ['twin.board', 'twin.space'] },
+        message: ''
+      }
+    ])
+    expect(lines).toEqual(['[ai-assistant] assistant-mode-subject-claimed-twice ×1: board:twin.board+twin.space'])
+  })
+})

package/server/tool-registry-boot-report.ts

@@ -28,15 +28,24 @@ export function formatToolRegistryWarnings(warnings: ReadonlyArray<ToolRegistryW
   return [...byCode].map(([code, tools]) => `[ai-assistant] ${code} ×${tools.length}: ${tools.join(', ')}`)
 }
 
-/** One line per code: the code, how many, and which modes promised what. */
+/** What one warning is about, in the words its code needs - a subject claimed twice names the subject and both. */
+function detailOf(warning: AssistantModeWarning): string {
+  const { kind, slash, tool, subject, kinds, target } = warning.params
+  switch (warning.code) {
+    case 'assistant-mode-subject-claimed-twice':
+      return `${subject}:${(kinds ?? []).join('+')}`
+    case 'assistant-mode-entry-target-unknown':
+      return `${kind}→${target}`
+    default:
+      return `${kind}:/${slash}→${tool}`
+  }
+}
+
+/** One line per code: the code, how many, and what each is about. */
 export function formatAssistantModeWarnings(warnings: ReadonlyArray<AssistantModeWarning>): string[] {
   const byCode = new Map<string, string[]>()
-  for (const warning of warnings) {
-    const offers = byCode.get(warning.code) ?? []
-    offers.push(`${warning.params.kind}:/${warning.params.slash}→${warning.params.tool}`)
-    byCode.set(warning.code, offers)
-  }
-  return [...byCode].map(([code, offers]) => `[ai-assistant] ${code} ×${offers.length}: ${offers.join(', ')}`)
+  for (const warning of warnings) byCode.set(warning.code, [...(byCode.get(warning.code) ?? []), detailOf(warning)])
+  return [...byCode].map(([code, details]) => `[ai-assistant] ${code} ×${details.length}: ${details.join(', ')}`)
 }
 
 /*

package/test/assistant-dock.test.ts

@@ -38,9 +38,8 @@ describe('the dock opens on every screen', () => {
 })
 
 describe('every request the chat makes is taken', () => {
-  it('new conversation, mode change and proposal execute', () => {
+  it('new conversation and proposal execute', () => {
     assert.match(dock, /addEventListener\('assistant-start-new-session'/)
-    assert.match(dock, /@assistant-mode-change=\$\{this\.onModeChange\}/)
     assert.match(dock, /@assistant-proposal-execute=\$\{this\.onProposal\}/)
   })
 
@@ -87,8 +86,32 @@ describe('sessions', () => {
     assert.match(dock, /scope: JSON\.stringify\(\[this\.app\.contextPath, userId, this\.kind\]\)/)
   })
 
-  it('a picked conversation of another kind is followed, not refused', () => {
-    assert.match(dock, /followPickedConversation\(pickedKind, this\.kind\)/)
+  it('★ a screen opens its one conversation - nothing to pick, nothing to follow (design/ai/screen-pattern.md §3)', () => {
+    assert.match(dock, /assistantModeFor\(subject: \$subject\)/)
+    assert.match(dock, /this\.kind = mode\?\.kind \?\? ''/)
+    assert.doesNotMatch(dock, /chosenKind|onModeChange|assistant-mode-change|followPickedConversation/)
+  })
+})
+
+describe('what is being written stays with its conversation (ADR-0072 rule, ruled 2026-10-13)', () => {
+  const chat = readFileSync(join(__dirname, '../client/components/assistant-chat.ts'), 'utf8')
+
+  it('★ the unsent text and the attachments both leave the box with the conversation, and come back to it', () => {
+    const take = chat.slice(chat.indexOf('  takeDraft()'), chat.indexOf('  restoreDraft('))
+    assert.match(take, /const draft = \{ text: this\.input, attachments: this\.attachments \}/)
+    assert.match(take, /this\.input = ''\s+this\.attachments = \[\]/)
+    const restore = chat.slice(chat.indexOf('  restoreDraft('), chat.indexOf('  restoreDraft(') + 200)
+    assert.match(restore, /this\.input = draft\.text\s+this\.attachments = draft\.attachments/)
+  })
+
+  it('★ the dock keeps it per subject when the page moves, except when the person signed in changed', () => {
+    assert.match(dock, /if \(transition !== 'reset'\) this\.keepDraft\(\)/)
+    assert.match(dock, /if \(draft\) this\.drafts\.set\(this\.openedFor!, draft\)/)
+    assert.match(dock, /void this\.restoreDraft\(\)/)
+  })
+
+  it('★ a page change while answering waits for the answer - it lands in the conversation it was asked in', () => {
+    assert.match(dock, /if \(!force && transition === 'wait'\) \{[\s\S]{0,160}this\.followWhenIdle\(\)/)
   })
 })
 

package/test/composer-frame.test.ts

@@ -100,14 +100,24 @@ describe('what a Tab writes in', () => {
     expect(composerSuggestion({ started: false, modeExamples: [{ items: [] }, ...mode] })).toBe('현재 Figure의 재질 그룹을 두 개로 줄여줘')
   })
 
-  it('★ nothing is suggested once the conversation is under way, or when no one gave an example', () => {
+  it('★ after an answer the box suggests the next request that answer named - the opening example no longer fits', () => {
+    expect(composerSuggestion({ started: true, modeExamples: mode, hostExamples: host, answered: '날개를 5개로 늘려 줘' })).toBe('날개를 5개로 늘려 줘')
     expect(composerSuggestion({ started: true, modeExamples: mode, hostExamples: host })).toBeUndefined()
+    expect(composerSuggestion({ started: true, answered: '   ' })).toBeUndefined()
     expect(composerSuggestion({ started: false })).toBeUndefined()
   })
 
   it('★ the box shows the suggestion first and falls back to how to write', () => {
     expect(chat).toMatch(/placeholder=\$\{this\.suggestion \?\? this\.conversation\.placeholder \?\? this\.placeholder \?\? i18next\.t\('ai-assistant\.text\.input-placeholder'\)\}/)
-    expect(chat).toMatch(/composerSuggestion\(\{ started: this\.lines\.length > 0, modeExamples: this\.modeView\?\.examples, hostExamples: this\.examples \}\)/)
+    expect(chat).toMatch(/answered: this\.nextRequest/)
+  })
+
+  it('★ the answer\'s next request comes from the door and is dropped once the person sends or the conversation changes', () => {
+    expect(chat).toMatch(/assistantChat\(input: \$input\) \{\s+reply\s+suggestion/)
+    expect(chat).toMatch(/this\.nextRequest = typeof out\.suggestion === 'string'/)
+    const send = chat.slice(chat.indexOf('  private async send() {'), chat.indexOf('  private async send() {') + 600)
+    expect(send).toMatch(/this\.nextRequest = undefined/)
+    expect(chat).toMatch(/changed\.has\('sessionId'\)[^\n]*this\.nextRequest = undefined/)
   })
 })
 

package/server/service/assistant-mode/subject-defaults.test.ts

@@ -1,86 +0,0 @@
-/*
- * 화면이 무엇을 여는가 — ADR-0072 A17 ②.
- *
- * 한 subject 종류에 기본 대화가 없거나 둘이면 화면이 여는 대화는 부팅 순서가 정한다. 그것은 화면을
- * 열어봐야 알 수 있고, 모듈 하나가 늘면 소리 없이 바뀐다. 부팅 보고가 말하게 하고, 여기서 셋 다
- * 문다.
- */
-import {
-  assistantModesForSubject,
-  clearAssistantModes,
-  getAssistantModeWarnings,
-  registerAssistantMode
-} from './registry'
-
-const persona = 'you are here'
-
-describe('assistant mode — subjects and defaults', () => {
-  beforeEach(() => clearAssistantModes())
-  afterAll(() => clearAssistantModes())
-
-  it('★ a subject nobody claims as default is a boot warning, not a silent pick', () => {
-    registerAssistantMode({ kind: 'twin.space', systemPrompt: persona, subjects: ['space'] })
-
-    const codes = getAssistantModeWarnings().map(w => w.code)
-    expect(codes).toContain('assistant-mode-subject-without-default')
-  })
-
-  it('★ two defaults on one subject is a boot warning — boot order must not decide it', () => {
-    registerAssistantMode({
-      kind: 'twin.space',
-      systemPrompt: persona,
-      subjects: ['board'],
-      defaultFor: ['board'],
-      labelKey: 'a'
-    })
-    registerAssistantMode({
-      kind: 'twin.authoring',
-      systemPrompt: persona,
-      subjects: ['board'],
-      defaultFor: ['board'],
-      labelKey: 'b'
-    })
-
-    const twice = getAssistantModeWarnings().find(w => w.code === 'assistant-mode-subject-default-twice')
-    expect(twice?.params.kinds).toEqual(['twin.space', 'twin.authoring'])
-  })
-
-  it('★ a conversation offered beside another needs something to call it', () => {
-    registerAssistantMode({
-      kind: 'twin.space',
-      systemPrompt: persona,
-      subjects: ['board'],
-      defaultFor: ['board'],
-      labelKey: 'twin.ai.mode.space'
-    })
-    registerAssistantMode({ kind: 'twin.authoring', systemPrompt: persona, subjects: ['board'] })
-
-    const unnamed = getAssistantModeWarnings().find(w => w.code === 'assistant-mode-offered-without-label')
-    expect(unnamed?.params.kind).toBe('twin.authoring')
-  })
-
-  it('one conversation alone on its subject needs no label — there is nothing to choose between', () => {
-    registerAssistantMode({
-      kind: 'plant.station',
-      systemPrompt: persona,
-      subjects: ['station'],
-      defaultFor: ['station']
-    })
-
-    expect(getAssistantModeWarnings()).toEqual([])
-  })
-
-  it('the default comes first, so a screen can open the list head without knowing the rule', () => {
-    registerAssistantMode({ kind: 'twin.authoring', systemPrompt: persona, subjects: ['board'], labelKey: 'b' })
-    registerAssistantMode({
-      kind: 'twin.space',
-      systemPrompt: persona,
-      subjects: ['board'],
-      defaultFor: ['board'],
-      labelKey: 'a'
-    })
-
-    expect(assistantModesForSubject('board').map(m => m.kind)).toEqual(['twin.space', 'twin.authoring'])
-    expect(assistantModesForSubject('nothing-shows-this')).toEqual([])
-  })
-})