@things-factory/ai-assistant 10.1.15 → 10.1.17

package/client/components/assistant-chat.ts

@@ -570,6 +570,44 @@ export class OxAssistantChat extends LitElement {
   @state()
   private sentProposals = new Set<string>()
 
+  /** Proposal keys the host has reported staged. Only the host knows; see `acknowledgeProposalStaged`. */
+  @state()
+  private stagedProposals = new Set<string>()
+
+  /**
+   * The host reports that it put this candidate somewhere the person can look at it.
+   *
+   * Staging happens outside this component — a dock catches `assistant-proposal-preview`, hands
+   * the candidate to a viewer, and only that host knows whether it worked, or whether it has a
+   * viewer at all. So the card says nothing until the host calls this, and it then says it in the
+   * words the host registered (`chatDefaults.stagedNoticeKey`).
+   *
+   * Safe to call for a candidate the card never showed; the key simply never matches.
+   */
+  acknowledgeProposalStaged(proposal: any): void {
+    /*
+      Silence has two meanings and they are not the same defect. A host that never calls this is
+      telling us it does not know, and drawing nothing is right. A host that calls it without
+      registering `stagedNoticeKey` meant to say something and left out the words -- staying quiet
+      about that reads to whoever wired it as "the badge just doesn't appear here".
+
+      The screen still shows nothing either way. There is no sentence to show, and inventing one is
+      what this whole correction removed.
+    */
+    if (!chatDefaults.stagedNoticeKey && !OxAssistantChat.warnedMissingStagedNotice) {
+      OxAssistantChat.warnedMissingStagedNotice = true
+      console.warn(
+        '[assistant-chat] a host reported a proposal staged but registered no `stagedNoticeKey`, ' +
+          'so the card can say nothing. Pass one to `registerChatDefaults` from the host.'
+      )
+    }
+
+    this.stagedProposals = new Set(this.stagedProposals).add(this.proposalKey(proposal))
+  }
+
+  /** Once per page: the miss is a wiring mistake, and repeating it per candidate buries it. */
+  private static warnedMissingStagedNotice = false
+
   /**
    * 이 대화가 길어져 앞부분이 프롬프트에서 접혔다는 **사실**(서버 보고). 주제 이탈을 판정한 것이
    * 아니다 — 판정하면 오탐이 생기고, 오탐이 생기면 사용자는 안내 자체를 무시한다.
@@ -3199,13 +3237,12 @@ export class OxAssistantChat extends LitElement {
         ${items.map(p => {
           const key = this.proposalKey(p)
           const sent = this.sentProposals.has(key)
-          const rawChoices: any[] = Array.isArray(p.choices) ? p.choices : (p.source ? [
-            { id: 'save', action: 'save', label: i18next.t('label.save-as-draft', { defaultValue: '초안 저장' }), icon: 'save', primary: true },
-            { id: 'repropose', action: 'prompt', label: '다른 콘셉트 재제안', icon: 'refresh', prompt: '현재 제안과 완전히 다른 스타일과 콘셉트로 새로 제안해줘' },
-            { id: 'slim', action: 'prompt', label: '비율 슬림 조정', icon: 'aspect_ratio', prompt: '전체적인 가로세로 비율을 좀 더 슬림하고 날렵하게 조정해줘' },
-            { id: 'palette', action: 'prompt', label: '색상 테마 변경', icon: 'palette', prompt: '다른 팔레트 색상 테마로 부품 색상을 변경해줘' },
-            { id: 'detail', action: 'prompt', label: '디테일 보강', icon: 'extension', prompt: '주요 디테일과 센서 부품을 좀 더 풍부하게 보강해줘' }
-          ] : [])
+          /*
+            Follow-up chips are the host's words, never this component's. The fallback that used
+            to live here named a 3D modeller's operations in hardcoded Korean, and it reached the
+            plant and twin chats too.
+          */
+          const rawChoices: any[] = Array.isArray(p.choices) ? p.choices : (chatDefaults.proposalChoices ?? [])
 
           return html`
             <div class="proposal ${sent ? 'sent' : ''}">
@@ -3214,20 +3251,32 @@ export class OxAssistantChat extends LitElement {
                 <span class="plabel">${p.label || p.command}</span>
                 ${p.reason ? html`<span class="preason">${p.reason}</span>` : nothing}
               </span>
-              ${!rawChoices.length ? html`
-                <button
-                  class="run"
-                  ?disabled=${sent}
-                  @click=${() => this.executeProposal(p, key)}>
-                  ${sent ? i18next.t('ai-assistant.text.proposal-sent', { defaultValue: '실행 요청됨' })
-                         : i18next.t('ai-assistant.button.run-proposal', { defaultValue: '실행' })}
-                </button>
-              ` : html`
-                <span class="staged-badge" title="3D 뷰어에 모델이 표시되었습니다">
+              ${/*
+                  The run button and the follow-up chips answer different questions — "is there
+                  something to apply" and "what else could I ask for" — and they used to share one
+                  ternary on `rawChoices.length`. A proposal that carried chips lost its button, so
+                  the one action the card exists for became unreachable while the model kept
+                  telling people to press it.
+                */ ''}
+              <button
+                class="run"
+                ?disabled=${sent}
+                @click=${() => this.executeProposal(p, key)}>
+                ${sent ? i18next.t('ai-assistant.text.proposal-sent', { defaultValue: '실행 요청됨' })
+                       : i18next.t('ai-assistant.button.run-proposal', { defaultValue: '실행' })}
+              </button>
+              ${/*
+                  Drawn only where the host has said it staged this candidate, in the host's own
+                  words. Not knowing is not a claim: with no word from the host, nothing is drawn.
+                  This badge used to read "there are chips" as "the model is in the 3D viewer" and
+                  say so, in a component that plant and twin also use.
+                */ ''}
+              ${this.stagedProposals.has(key) && chatDefaults.stagedNoticeKey ? html`
+                <span class="staged-badge">
                   <md-icon>check_circle</md-icon>
-                  <span>뷰어 반영됨</span>
+                  <span>${i18next.t(chatDefaults.stagedNoticeKey)}</span>
                 </span>
-              `}
+              ` : nothing}
             </div>
             ${rawChoices.length ? html`
               <div class="proposal-choices" role="group" aria-label="대화 선택지">

package/client/components/chat-defaults.ts

@@ -28,6 +28,28 @@ export interface ChatDefaults {
    * 그 말을 한다.
    */
   footerNoticeKey?: string
+  /**
+   * Follow-up chips offered on a proposal that arrived without its own `choices`.
+   *
+   * These used to sit in the chat component as a literal array: "다른 콘셉트 재제안", "비율 슬림
+   * 조정", "색상 테마 변경", "디테일 보강". Those are a 3D modeller's words, written in Korean with
+   * no i18n, inside a component four apps share. A plant screen proposal offered to slim its
+   * aspect ratio.
+   *
+   * Same reason as `footerNoticeKey`: the host that knows what a follow-up means writes it.
+   * Leave it unset and a proposal without choices simply gets none, which is correct.
+   */
+  proposalChoices?: any[]
+  /**
+   * The **i18n key** for the line shown once the host reports a proposal staged. Unset means the
+   * badge is never drawn.
+   *
+   * The component cannot know this on its own. It used to read "선택지가 딸려 있다" as "the model is
+   * in the 3D viewer" and say so — in a component plant and twin also use, neither of which has a
+   * 3D viewer. Staging is something the host does, so the host says whether it happened
+   * (`acknowledgeProposalStaged`) and in what words.
+   */
+  stagedNoticeKey?: string
 }
 
 export const chatDefaults: ChatDefaults = { catalogEntries: [], slashTemplates: [] }
@@ -37,4 +59,6 @@ export function registerChatDefaults(defaults: Partial<ChatDefaults>): void {
   if (defaults.catalogEntries) chatDefaults.catalogEntries = defaults.catalogEntries
   if (defaults.slashTemplates) chatDefaults.slashTemplates = defaults.slashTemplates
   if (defaults.footerNoticeKey) chatDefaults.footerNoticeKey = defaults.footerNoticeKey
+  if (defaults.proposalChoices) chatDefaults.proposalChoices = defaults.proposalChoices
+  if (defaults.stagedNoticeKey) chatDefaults.stagedNoticeKey = defaults.stagedNoticeKey
 }

package/dist-client/components/assistant-chat.d.ts

@@ -212,6 +212,21 @@ export declare class OxAssistantChat extends LitElement {
     private openToolSteps;
     /** 이미 실행을 요청한 제안 키 — 같은 카드를 두 번 눌러 되돌릴 수 없는 명령이 두 번 나가지 않게. */
     private sentProposals;
+    /** Proposal keys the host has reported staged. Only the host knows; see `acknowledgeProposalStaged`. */
+    private stagedProposals;
+    /**
+     * The host reports that it put this candidate somewhere the person can look at it.
+     *
+     * Staging happens outside this component — a dock catches `assistant-proposal-preview`, hands
+     * the candidate to a viewer, and only that host knows whether it worked, or whether it has a
+     * viewer at all. So the card says nothing until the host calls this, and it then says it in the
+     * words the host registered (`chatDefaults.stagedNoticeKey`).
+     *
+     * Safe to call for a candidate the card never showed; the key simply never matches.
+     */
+    acknowledgeProposalStaged(proposal: any): void;
+    /** Once per page: the miss is a wiring mistake, and repeating it per candidate buries it. */
+    private static warnedMissingStagedNotice;
     /**
      * 이 대화가 길어져 앞부분이 프롬프트에서 접혔다는 **사실**(서버 보고). 주제 이탈을 판정한 것이
      * 아니다 — 판정하면 오탐이 생기고, 오탐이 생기면 사용자는 안내 자체를 무시한다.

package/dist-client/components/assistant-chat.js

@@ -223,6 +223,8 @@ let OxAssistantChat = class OxAssistantChat extends LitElement {
         this.openToolSteps = new Set();
         /** 이미 실행을 요청한 제안 키 — 같은 카드를 두 번 눌러 되돌릴 수 없는 명령이 두 번 나가지 않게. */
         this.sentProposals = new Set();
+        /** Proposal keys the host has reported staged. Only the host knows; see `acknowledgeProposalStaged`. */
+        this.stagedProposals = new Set();
         /** 안내를 닫았는가 — 한 번 닫으면 이 세션에서는 다시 띄우지 않는다(잔소리 금지). */
         this.foldNoticeDismissed = false;
         this.busy = false;
@@ -395,6 +397,35 @@ let OxAssistantChat = class OxAssistantChat extends LitElement {
             this.onAttachFiles(e.dataTransfer.files);
         }
     }
+    /**
+     * The host reports that it put this candidate somewhere the person can look at it.
+     *
+     * Staging happens outside this component — a dock catches `assistant-proposal-preview`, hands
+     * the candidate to a viewer, and only that host knows whether it worked, or whether it has a
+     * viewer at all. So the card says nothing until the host calls this, and it then says it in the
+     * words the host registered (`chatDefaults.stagedNoticeKey`).
+     *
+     * Safe to call for a candidate the card never showed; the key simply never matches.
+     */
+    acknowledgeProposalStaged(proposal) {
+        /*
+          Silence has two meanings and they are not the same defect. A host that never calls this is
+          telling us it does not know, and drawing nothing is right. A host that calls it without
+          registering `stagedNoticeKey` meant to say something and left out the words -- staying quiet
+          about that reads to whoever wired it as "the badge just doesn't appear here".
+    
+          The screen still shows nothing either way. There is no sentence to show, and inventing one is
+          what this whole correction removed.
+        */
+        if (!chatDefaults.stagedNoticeKey && !OxAssistantChat_1.warnedMissingStagedNotice) {
+            OxAssistantChat_1.warnedMissingStagedNotice = true;
+            console.warn('[assistant-chat] a host reported a proposal staged but registered no `stagedNoticeKey`, ' +
+                'so the card can say nothing. Pass one to `registerChatDefaults` from the host.');
+        }
+        this.stagedProposals = new Set(this.stagedProposals).add(this.proposalKey(proposal));
+    }
+    /** Once per page: the miss is a wiring mistake, and repeating it per candidate buries it. */
+    static { this.warnedMissingStagedNotice = false; }
     /** 현재 로그인 사용자 email — 그룹챗에서 내 메시지 vs 타인 메시지 구분.
      *  email 을 쓰는 이유: /auth/profile 이 항상 내려주는 로그인 식별자이고(비어 있지 않다),
      *  내부 관리키(User.id)를 클라이언트 판정에 의존하지 않기 위함. */
@@ -2836,13 +2867,12 @@ let OxAssistantChat = class OxAssistantChat extends LitElement {
         ${items.map(p => {
             const key = this.proposalKey(p);
             const sent = this.sentProposals.has(key);
-            const rawChoices = Array.isArray(p.choices) ? p.choices : (p.source ? [
-                { id: 'save', action: 'save', label: i18next.t('label.save-as-draft', { defaultValue: '초안 저장' }), icon: 'save', primary: true },
-                { id: 'repropose', action: 'prompt', label: '다른 콘셉트 재제안', icon: 'refresh', prompt: '현재 제안과 완전히 다른 스타일과 콘셉트로 새로 제안해줘' },
-                { id: 'slim', action: 'prompt', label: '비율 슬림 조정', icon: 'aspect_ratio', prompt: '전체적인 가로세로 비율을 좀 더 슬림하고 날렵하게 조정해줘' },
-                { id: 'palette', action: 'prompt', label: '색상 테마 변경', icon: 'palette', prompt: '다른 팔레트 색상 테마로 부품 색상을 변경해줘' },
-                { id: 'detail', action: 'prompt', label: '디테일 보강', icon: 'extension', prompt: '주요 디테일과 센서 부품을 좀 더 풍부하게 보강해줘' }
-            ] : []);
+            /*
+              Follow-up chips are the host's words, never this component's. The fallback that used
+              to live here named a 3D modeller's operations in hardcoded Korean, and it reached the
+              plant and twin chats too.
+            */
+            const rawChoices = Array.isArray(p.choices) ? p.choices : (chatDefaults.proposalChoices ?? []);
             return html `
             <div class="proposal ${sent ? 'sent' : ''}">
               <md-icon>${p.icon || (p.source ? 'view_in_ar' : 'bolt')}</md-icon>
@@ -2850,20 +2880,32 @@ let OxAssistantChat = class OxAssistantChat extends LitElement {
                 <span class="plabel">${p.label || p.command}</span>
                 ${p.reason ? html `<span class="preason">${p.reason}</span>` : nothing}
               </span>
-              ${!rawChoices.length ? html `
-                <button
-                  class="run"
-                  ?disabled=${sent}
-                  @click=${() => this.executeProposal(p, key)}>
-                  ${sent ? i18next.t('ai-assistant.text.proposal-sent', { defaultValue: '실행 요청됨' })
+              ${ /*
+                The run button and the follow-up chips answer different questions — "is there
+                something to apply" and "what else could I ask for" — and they used to share one
+                ternary on `rawChoices.length`. A proposal that carried chips lost its button, so
+                the one action the card exists for became unreachable while the model kept
+                telling people to press it.
+              */''}
+              <button
+                class="run"
+                ?disabled=${sent}
+                @click=${() => this.executeProposal(p, key)}>
+                ${sent ? i18next.t('ai-assistant.text.proposal-sent', { defaultValue: '실행 요청됨' })
                 : i18next.t('ai-assistant.button.run-proposal', { defaultValue: '실행' })}
-                </button>
-              ` : html `
-                <span class="staged-badge" title="3D 뷰어에 모델이 표시되었습니다">
+              </button>
+              ${ /*
+                Drawn only where the host has said it staged this candidate, in the host's own
+                words. Not knowing is not a claim: with no word from the host, nothing is drawn.
+                This badge used to read "there are chips" as "the model is in the 3D viewer" and
+                say so, in a component that plant and twin also use.
+              */''}
+              ${this.stagedProposals.has(key) && chatDefaults.stagedNoticeKey ? html `
+                <span class="staged-badge">
                   <md-icon>check_circle</md-icon>
-                  <span>뷰어 반영됨</span>
+                  <span>${i18next.t(chatDefaults.stagedNoticeKey)}</span>
                 </span>
-              `}
+              ` : nothing}
             </div>
             ${rawChoices.length ? html `
               <div class="proposal-choices" role="group" aria-label="대화 선택지">
@@ -3554,6 +3596,10 @@ __decorate([
     state(),
     __metadata("design:type", Object)
 ], OxAssistantChat.prototype, "sentProposals", void 0);
+__decorate([
+    state(),
+    __metadata("design:type", Object)
+], OxAssistantChat.prototype, "stagedProposals", void 0);
 __decorate([
     state(),
     __metadata("design:type", Object)