@things-factory/ai-assistant 10.1.113 → 10.1.116

package/client/components/assistant-chat.ts

@@ -70,6 +70,7 @@ import { availableTriggers, type TriggerChip } from './chat-triggers.js'
 import './entry-review.js'
 import { entryGroupOf, entryReadyCount, entryTitle, isChangeProposal, isEntryProposal, latestEntryKeys } from '../utils/entry-proposal.js'
 import { isWorkspaceProposal, versionOfCard, workspaceAddress } from '../utils/workspace.js'
+import { isOpenPageProposal, openPageNote } from '../utils/open-page.js'
 
 interface ChatLine {
   role: 'user' | 'assistant' | 'system'
@@ -4321,6 +4322,8 @@ export class OxAssistantChat extends LitElement {
           const key = this.proposalKey(p)
           /* A workspace card opens the page; it runs nothing (design/ai/workspace.md §4). */
           if (isWorkspaceProposal(p)) return this.renderWorkspaceCard(p, key)
+          /* A screen card opens the application's list with the question's conditions; it runs nothing (design/ai/read-targets.md §5). */
+          if (isOpenPageProposal(p)) return this.renderOpenPageCard(p)
           const card = proposalCardState(key, { outcomes, requested, sentHere: this.sentProposals.has(key) })
           const entry = isEntryProposal(p)
           const replaced = entry && latestEntry?.get(entryGroupOf(p)) !== key && card.state === 'ready'
@@ -4415,6 +4418,22 @@ export class OxAssistantChat extends LitElement {
     `
   }
 
+  /** The screen card - which list, the conditions the screen does not take, and the way to open it. */
+  private renderOpenPageCard(p: any) {
+    const note = openPageNote(p, (key, options) => String(i18next.t(key, options)))
+    const open = () => this.dispatchEvent(new CustomEvent('assistant-open-page', { detail: { href: p.href }, bubbles: true, composed: true }))
+    return html`
+      <div class="proposal workspace">
+        <md-icon>${p.icon || 'open_in_new'}</md-icon>
+        <span class="pbody">
+          <span class="plabel">${p.label}</span>
+          ${note ? html`<span class="preason">${note}</span>` : nothing}
+        </span>
+        <button class="run" @click=${open}>${i18next.t('ai-assistant.screen.open', { defaultValue: 'open the screen' })}</button>
+      </div>
+    `
+  }
+
   /** The AI 작업판 card - what it holds, which version, and the way to open it. The person opens it; the model does not. */
   private renderWorkspaceCard(p: any, key: string) {
     const { version, of } = versionOfCard(this.lines.map(one => one.proposals ?? []), p.workspace.name, key)

package/client/components/assistant-dock.ts

@@ -109,9 +109,9 @@ export class AssistantDock extends localize(i18next)(LitElement) {
       @media (max-width: 1439.98px) {
         :host {
           position: fixed;
-          inset: 0 0 0 auto;
-          height: 100vh;
-          height: 100dvh;
+          inset: var(--assistant-dock-overlay-top, 0px) 0 0 auto;
+          height: calc(100vh - var(--assistant-dock-overlay-top, 0px));
+          height: calc(100dvh - var(--assistant-dock-overlay-top, 0px));
           z-index: 10;
           box-shadow: var(--md-sys-elevation-shadow-3, -4px 0 16px rgb(0 0 0 / 20%));
         }
@@ -329,6 +329,23 @@ export class AssistantDock extends localize(i18next)(LitElement) {
 
   private onStartNewSession = () => void this.newConversation()
 
+  /** An editor can reserve its toolbar above the floating dock. Other apps keep the full-height default. */
+  @property({ attribute: false }) overlayBoundary?: () => Element | undefined
+  private boundary?: Element
+  private boundaryObserver?: ResizeObserver
+  private placeOverlay = () => {
+    const boundary = this.overlayBoundary?.()
+    if (boundary !== this.boundary) {
+      this.boundaryObserver?.disconnect()
+      this.boundary = boundary
+      if (boundary) {
+        this.boundaryObserver = new ResizeObserver(this.placeOverlay)
+        this.boundaryObserver.observe(boundary)
+      }
+    }
+    this.style.setProperty('--assistant-dock-overlay-top', `${boundary?.getBoundingClientRect().bottom ?? 0}px`)
+  }
+
   /* A card asks for a page of this application - the AI 작업판. The dock stays open beside it. */
   private onOpenPage = (event: CustomEvent) => {
     const href = event.detail?.href
@@ -349,6 +366,8 @@ export class AssistantDock extends localize(i18next)(LitElement) {
 
   connectedCallback() {
     super.connectedCallback()
+    window.addEventListener('resize', this.placeOverlay)
+    this.placeOverlay()
     this.addEventListener('assistant-start-new-session', this.onStartNewSession)
     this.addEventListener('assistant-open-page', this.onOpenPage as EventListener)
     this.unsubscribers.push(
@@ -371,6 +390,9 @@ export class AssistantDock extends localize(i18next)(LitElement) {
 
   /* Closing keeps the conversation: the dock comes back as it was left (design/ai/shared-dock.md §2-1, §2-7). */
   disconnectedCallback() {
+    window.removeEventListener('resize', this.placeOverlay)
+    this.boundaryObserver?.disconnect()
+    this.boundary = undefined
     this.removeEventListener('assistant-start-new-session', this.onStartNewSession)
     this.removeEventListener('assistant-open-page', this.onOpenPage as EventListener)
     this.unsubscribers.splice(0).forEach(unsubscribe => unsubscribe())
@@ -417,6 +439,7 @@ export class AssistantDock extends localize(i18next)(LitElement) {
 
   /** The screen changed - a different surface or domain is a different conversation. */
   private follow(force = false) {
+    this.placeOverlay()
     const next = currentAssistantSurface()
     const transition = surfaceTransition({
       identityChanged: this.openedIdentity !== this.identityKey(),

package/client/setup-assistant-dock.ts

@@ -117,7 +117,7 @@ export class AssistantDockButton extends LitElement {
 
 let installed = false
 
-export function setupAssistantDock(options: { viewpart?: string } = {}): void {
+export function setupAssistantDock(options: { viewpart?: string; overlayBoundary?: () => Element | undefined } = {}): void {
   if (installed) return
   installed = true
   const viewpart = options.viewpart ?? ASSISTANT_DOCK_VIEWPART
@@ -129,8 +129,9 @@ export function setupAssistantDock(options: { viewpart?: string } = {}): void {
    * makes the element would make a new dock on every opening - and a new composer, the text being written gone
    * (design/ai/shared-dock.md §2-1, §2-7). The same element is put back instead, as the entity360 dock is.
    */
-  const dock = document.createElement('ox-assistant-dock') as HTMLElement & { viewpart: string }
+  const dock = document.createElement('ox-assistant-dock') as HTMLElement & { viewpart: string; overlayBoundary?: () => Element | undefined }
   dock.viewpart = viewpart
+  dock.overlayBoundary = options.overlayBoundary
 
   appendViewpart({
     name: viewpart,

package/client/utils/entry-proposal.ts

@@ -46,6 +46,7 @@ export interface EntryRowResult {
 
 export interface EntryApplyAnswer extends ProposalOutcome {
   rows?: EntryRowResult[]
+  refusal?: { message: string; extensions: Record<string, unknown>; path: string[] }
   /** Set by the handler from the card - which words the conversation line uses. */
   op?: string
 }
@@ -96,7 +97,12 @@ export function entryOutcomeNote(answer: EntryApplyAnswer, t: (key: string, opti
 export function entryProposalHandler(
   apply: (sessionId: string, proposalKey: string, reviewedHash?: string) => Promise<EntryApplyAnswer>,
   t: (key: string, options?: any) => string,
-  reviewedOf: (key: string) => string | undefined = reviewedHashOf
+  reviewedOf: (key: string) => string | undefined = reviewedHashOf,
+  reportRefusal: (notification: { level: 'error'; message: string; ex: NonNullable<EntryApplyAnswer['refusal']>[] }) => void | Promise<void> = async notification => {
+    /* The generic toast transport. auth-ui alone interprets the refusal and offers an access request. */
+    const { notify } = await import('@operato/layout')
+    notify(notification)
+  }
 ) {
   return async (proposal: any, context: ProposalContext): Promise<ProposalOutcome> => {
     if (!context.sessionId || !proposal?.key) return { verdict: 'unavailable', errorCode: 'no-conversation' }
@@ -104,6 +110,13 @@ export function entryProposalHandler(
     const reviewed = reviewedOf(proposal.key)
     if (!reviewStillHolds(proposal, reviewed)) return { verdict: 'refused', errorCode: 'review-stale', note: t('ai-assistant.entry.review-stale', { defaultValue: 'this proposal changed after it was reviewed in the workspace - review it again before entering.' }) } as any
     const answer = { ...(await apply(context.sessionId, proposal.key, reviewed)), op: proposal.op }
+    if (answer.verdict === 'refused' && answer.errorCode === 'door-closed' && answer.refusal) {
+      try {
+        await reportRefusal({ level: 'error', message: answer.refusal.message, ex: [answer.refusal] })
+      } catch {
+        /* Notification delivery is best-effort; it never changes the stored proposal's refusal. */
+      }
+    }
     if (answer.errorCode === 'review-stale')
       return { verdict: 'refused', errorCode: 'review-stale', applied: 0, missed: 0, note: t('ai-assistant.entry.review-stale', { defaultValue: 'this proposal changed after it was reviewed in the workspace - review it again before entering.' }) }
     return {

package/client/utils/open-page.ts

@@ -0,0 +1,21 @@
+/*
+ * The card that opens an application's list screen with the conditions of a question (design/ai/read-targets.md §5).
+ * It reads nothing and runs nothing - the person presses it and the page opens beside the dock.
+ */
+
+/** An address inside the application - never another origin, never a script. */
+export function isAppAddress(href: unknown): href is string {
+  return typeof href === 'string' && !!href.trim() && !/^[a-z][a-z0-9+.-]*:/i.test(href.trim()) && !href.trim().startsWith('//')
+}
+
+export function isOpenPageProposal(proposal: any): boolean {
+  return proposal?.kind === 'open-page' && isAppAddress(proposal?.href)
+}
+
+/** The line under the card's title - the conditions the screen does not take, said, never dropped quietly. */
+export function openPageNote(proposal: any, t: (key: string, options?: any) => string): string {
+  const missing: string[] = Array.isArray(proposal?.notAppliedLabels) ? proposal.notAppliedLabels : []
+  return missing.length
+    ? t('ai-assistant.screen.not-applied', { defaultValue: 'the screen does not take: {conditions}', conditions: missing.join(', ') })
+    : ''
+}

package/dist-client/components/assistant-chat.d.ts

@@ -560,6 +560,8 @@ export declare class OxAssistantChat extends LitElement {
      * 실행 결과는 호스트가 **대화에 기록**한다 — 누가 무엇을 실행했는지가 협의 이력에 남아야 한다.
      */
     private renderProposals;
+    /** The screen card - which list, the conditions the screen does not take, and the way to open it. */
+    private renderOpenPageCard;
     /** The AI 작업판 card - what it holds, which version, and the way to open it. The person opens it; the model does not. */
     private renderWorkspaceCard;
     /**

package/dist-client/components/assistant-chat.js

@@ -54,6 +54,7 @@ import { availableTriggers } from './chat-triggers.js';
 import './entry-review.js';
 import { entryGroupOf, entryReadyCount, entryTitle, isChangeProposal, isEntryProposal, latestEntryKeys } from '../utils/entry-proposal.js';
 import { isWorkspaceProposal, versionOfCard, workspaceAddress } from '../utils/workspace.js';
+import { isOpenPageProposal, openPageNote } from '../utils/open-page.js';
 function formatFileSize(bytes) {
     if (!bytes || bytes < 1024)
         return `${bytes || 0} B`;
@@ -3868,6 +3869,9 @@ let OxAssistantChat = class OxAssistantChat extends LitElement {
             /* A workspace card opens the page; it runs nothing (design/ai/workspace.md §4). */
             if (isWorkspaceProposal(p))
                 return this.renderWorkspaceCard(p, key);
+            /* A screen card opens the application's list with the question's conditions; it runs nothing (design/ai/read-targets.md §5). */
+            if (isOpenPageProposal(p))
+                return this.renderOpenPageCard(p);
             const card = proposalCardState(key, { outcomes, requested, sentHere: this.sentProposals.has(key) });
             const entry = isEntryProposal(p);
             const replaced = entry && latestEntry?.get(entryGroupOf(p)) !== key && card.state === 'ready';
@@ -3959,6 +3963,21 @@ let OxAssistantChat = class OxAssistantChat extends LitElement {
       </div>
     `;
     }
+    /** The screen card - which list, the conditions the screen does not take, and the way to open it. */
+    renderOpenPageCard(p) {
+        const note = openPageNote(p, (key, options) => String(i18next.t(key, options)));
+        const open = () => this.dispatchEvent(new CustomEvent('assistant-open-page', { detail: { href: p.href }, bubbles: true, composed: true }));
+        return html `
+      <div class="proposal workspace">
+        <md-icon>${p.icon || 'open_in_new'}</md-icon>
+        <span class="pbody">
+          <span class="plabel">${p.label}</span>
+          ${note ? html `<span class="preason">${note}</span>` : nothing}
+        </span>
+        <button class="run" @click=${open}>${i18next.t('ai-assistant.screen.open', { defaultValue: 'open the screen' })}</button>
+      </div>
+    `;
+    }
     /** The AI 작업판 card - what it holds, which version, and the way to open it. The person opens it; the model does not. */
     renderWorkspaceCard(p, key) {
         const { version, of } = versionOfCard(this.lines.map(one => one.proposals ?? []), p.workspace.name, key);