@things-factory/ai-assistant 10.1.109 → 10.1.111

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@things-factory/ai-assistant",
-  "version": "10.1.109",
+  "version": "10.1.111",
   "main": "dist-server/index.js",
   "things-factory": true,
   "author": "heartyoh",
@@ -35,8 +35,8 @@
     "@operato/styles": "^10.0.0",
     "@things-factory/ai-client-base": "^10.1.81",
     "@things-factory/apptool-base": "^10.1.106",
-    "@things-factory/attachment-base": "^10.1.107",
-    "@things-factory/auth-base": "^10.1.107",
+    "@things-factory/attachment-base": "^10.1.111",
+    "@things-factory/auth-base": "^10.1.111",
     "@things-factory/env": "^10.1.20",
     "@things-factory/shell": "^10.1.106",
     "dompurify": "^3.0.0",
@@ -52,5 +52,5 @@
     "copyfiles": "^2.4.1",
     "rimraf": "^5.0.0"
   },
-  "gitHead": "4d51757c50d8347e83c96aeba73d770bdde55b73"
+  "gitHead": "f33122c15e5b3e45393129e9418e2c367a273ade"
 }

package/test/assistant-dock.test.ts

@@ -147,3 +147,31 @@ describe('what twin needed of the dock', () => {
     assert.match(dock, /this\.startCarried\(ask\)\.catch\(error => \{\s*notify\(\{ level: 'error'/)
   })
 })
+
+describe('closing and opening the dock again (design/ai/shared-dock.md §2-1, §2-7)', () => {
+  const setup = code('../client/setup-assistant-dock.ts')
+  const between = (text: string, from: string, to: string) => text.slice(text.indexOf(from), text.indexOf(to, text.indexOf(from)))
+
+  it('★ the viewpart puts back one dock - a template that makes the element makes a new dock on every opening', () => {
+    assert.match(setup, /const dock = document\.createElement\('ox-assistant-dock'\)/)
+    assert.match(setup, /template: html`\$\{dock\}`/)
+    assert.doesNotMatch(setup, /<ox-assistant-dock[\s>]/)
+  })
+
+  it('★ closing keeps the conversation - no reset, no cancelled opening', () => {
+    const closing = between(dock, 'disconnectedCallback() {', 'super.disconnectedCallback()')
+    assert.doesNotMatch(closing, /controller\.clear\(\)/)
+    assert.doesNotMatch(closing, /this\.revision\+\+/)
+  })
+
+  it('★ opening again follows what moved, it does not open the conversation anew', () => {
+    const opening = between(dock, 'connectedCallback() {', 'disconnectedCallback() {')
+    assert.match(opening, /if \(!this\.openedIdentity\) return this\.follow\(true\)/)
+    assert.match(opening, /setOpenSession\(this\.sessionId\)\s*this\.follow\(\)/)
+  })
+
+  it('★ the chat put back reads its conversation again and starts its broadcast and presence again', () => {
+    const opening = between(chat, '  connectedCallback() {', '  private async onSubjectChanged()')
+    assert.match(opening, /if \(this\.hasUpdated && this\.sessionId\) \{\s*this\.loadHistory\(\)\s*this\._startPresence\(\)\s*this\._startMessageSubscription\(\)/)
+  })
+})

package/test/composer-frame.test.ts

@@ -0,0 +1,125 @@
+/*
+ * The composer's frame (client/utils/composer-frame.ts, design/ai/shared-dock.md §10): it grows with its text and
+ * stops at 40% of the chat, Enter means a line in the wide box, and a pasted table can go back to words.
+ */
+import { readFileSync } from 'fs'
+import { join } from 'path'
+
+import { appendWords, composerHeight, composerKeyAction, sendShortcut, tableAsWords } from '../client/utils/composer-frame'
+
+const chat = readFileSync(join(__dirname, '../client/components/assistant-chat.ts'), 'utf8')
+
+describe('the composer grows with its text', () => {
+  it('★ one line stands at the resting height', () => {
+    expect(composerHeight(35, 714, 54)).toEqual({ height: 54, scrolls: false })
+  })
+
+  it('★ twelve lines show whole - the box was three lines high and hid the rest', () => {
+    expect(composerHeight(221, 714, 54)).toEqual({ height: 221, scrolls: false })
+  })
+
+  it('★ past 40% of the chat it stops and scrolls', () => {
+    expect(composerHeight(900, 714, 54)).toEqual({ height: 285, scrolls: true })
+  })
+
+  it('a chat too short for 40% to hold the resting height keeps the resting height', () => {
+    expect(composerHeight(200, 100, 54)).toEqual({ height: 54, scrolls: true })
+  })
+
+  it('★ the chat sizes the box from the rule, and the dead 140px ceiling is gone', () => {
+    expect(chat).toMatch(/composerHeight\(/)
+    expect(chat).not.toMatch(/max-height: 140px/)
+  })
+})
+
+describe('Enter', () => {
+  const enter = { key: 'Enter' }
+
+  it('★ in the small box Enter sends and Shift+Enter breaks the line', () => {
+    expect(composerKeyAction(enter, false)).toBe('send')
+    expect(composerKeyAction({ ...enter, shiftKey: true }, false)).toBeNull()
+  })
+
+  it('★ in the wide box Enter breaks the line', () => {
+    expect(composerKeyAction(enter, true)).toBeNull()
+    expect(composerKeyAction({ ...enter, shiftKey: true }, true)).toBeNull()
+  })
+
+  it('★ Ctrl/Cmd+Enter sends in both boxes', () => {
+    for (const wide of [false, true]) {
+      expect(composerKeyAction({ ...enter, ctrlKey: true }, wide)).toBe('send')
+      expect(composerKeyAction({ ...enter, metaKey: true }, wide)).toBe('send')
+    }
+  })
+
+  it('Escape closes the wide box and leaves the small one alone', () => {
+    expect(composerKeyAction({ key: 'Escape' }, true)).toBe('narrow')
+    expect(composerKeyAction({ key: 'Escape' }, false)).toBeNull()
+  })
+
+  it('other keys are the textarea\'s', () => {
+    expect(composerKeyAction({ key: 'a' }, true)).toBeNull()
+    expect(composerKeyAction({ ...enter, altKey: true }, false)).toBeNull()
+  })
+
+  it('the shortcut is named in this machine\'s keys', () => {
+    expect(sendShortcut('MacIntel')).toBe('⌘ Enter')
+    expect(sendShortcut('Win32')).toBe('Ctrl+Enter')
+    expect(sendShortcut(undefined)).toBe('Ctrl+Enter')
+  })
+
+  it('★ the chat decides the key by the rule', () => {
+    expect(chat).toMatch(/composerKeyAction\(e, this\.composerWide\)/)
+  })
+})
+
+describe('a pasted table back as words', () => {
+  const rows = [
+    ['이용일', '가맹점'],
+    ['2026-09-12', '카카오T']
+  ]
+
+  it('★ the clipboard\'s own text comes back as it was copied', () => {
+    expect(tableAsWords({ rows, text: '이용일\t가맹점\r\n2026-09-12\t카카오T\r\n' })).toBe('이용일\t가맹점\n2026-09-12\t카카오T')
+  })
+
+  it('★ a clipboard that held only HTML gives the rows tab-separated', () => {
+    expect(tableAsWords({ rows, text: '' })).toBe('이용일\t가맹점\n2026-09-12\t카카오T')
+    expect(tableAsWords({ rows })).toBe('이용일\t가맹점\n2026-09-12\t카카오T')
+  })
+
+  it('the words go on a line of their own after what is written', () => {
+    expect(appendWords('', 'a\tb')).toBe('a\tb')
+    expect(appendWords('경비로 올려 줘  \n', 'a\tb')).toBe('경비로 올려 줘\na\tb')
+  })
+})
+
+describe('the pasted table chip', () => {
+  it('★ the paste hands its rows and its words to the chip', () => {
+    expect(chat).toMatch(/onAttachFiles\(\[new File\(\[pasted\.text\], pasted\.name, \{ type: 'text\/csv' \}\)\], \{ \.\.\.pasted\.table, text: words \}\)/)
+  })
+
+  it('★ the chip names rows × columns, opens the rows, and gives them back as words', () => {
+    const chip = chat.slice(chat.indexOf('${att.table'), chat.indexOf('formatFileSize(att.size)'))
+    expect(chip).toMatch(/table_chart/)
+    expect(chip).toMatch(/this\.tableShape\(att\.table\)/)
+    expect(chip).toMatch(/this\.previewAttachmentId = /)
+    expect(chat).toMatch(/@click=\$\{\(\) => this\.tableToWords\(att\.id\)\}/)
+  })
+})
+
+describe('found on the screen (office :4700, 10.1.110)', () => {
+  it('★ the Escape that narrows the wide box does not reach the floating dock, which closed on it', () => {
+    const branch = chat.slice(chat.indexOf("if (action === 'narrow')"), chat.indexOf("} else if (action === 'send')"))
+    expect(branch).toMatch(/e\.stopPropagation\(\)/)
+  })
+
+  it('★ the send shortcut stands out of the row - it took 74px of the wide box\'s width', () => {
+    const rule = /\n    \.send-shortcut \{([^}]*)\}/.exec(chat)?.[1] ?? ''
+    expect(rule).toMatch(/position: absolute/)
+  })
+
+  it('★ a finger is not told a key it does not have - the phone showed the shortcut', () => {
+    expect(chat).toMatch(/@media \(pointer: coarse\) \{\s*\.send-shortcut \{\s*display: none;/)
+  })
+})

package/test/pasted-table.test.ts

@@ -118,7 +118,7 @@ describe('a pasted table', () => {
   const nameOf = (rows: number) => `붙여넣은 표 ${rows}행`
 
   it('★ a conversation that takes text gets a CSV file - one that takes none keeps the paste as words', () => {
-    expect(pastedTableFile({ text: EXCEL_TEXT }, { kinds: ['image', 'text'] }, nameOf)).toEqual({ name: '붙여넣은 표 4행.csv', text: pastedTableText(pastedTable({ text: EXCEL_TEXT })!, '붙여넣은 표 4행') })
+    expect(pastedTableFile({ text: EXCEL_TEXT }, { kinds: ['image', 'text'] }, nameOf)).toEqual({ name: '붙여넣은 표 4행.csv', text: pastedTableText(pastedTable({ text: EXCEL_TEXT })!, '붙여넣은 표 4행'), table: pastedTable({ text: EXCEL_TEXT }) })
     expect(pastedTableFile({ text: EXCEL_TEXT }, { kinds: ['spreadsheet'] }, nameOf)).toMatchObject({ name: '붙여넣은 표 4행.csv' })
     expect(pastedTableFile({ text: EXCEL_TEXT }, { kinds: ['image'] }, nameOf)).toBeNull()
     expect(pastedTableFile({ text: EXCEL_TEXT }, null, nameOf)).toBeNull()

package/translations/en.json

@@ -289,5 +289,11 @@
   "ai-assistant.entry.review-stale": "this proposal changed after it was reviewed in the workspace - review it again before entering.",
   "ai-assistant.workspace.entry-not-found": "there is no proposal here that you can see.",
   "ai-assistant.workspace.entry-superseded": "a newer card replaced this one in the conversation - review that one.",
-  "ai-assistant.workspace.entry-press-in-dock": "this is a review. Enter the rows with the button on the card in the AI dock."
+  "ai-assistant.workspace.entry-press-in-dock": "this is a review. Enter the rows with the button on the card in the AI dock.",
+  "ai-assistant.button.write-wide": "Write wide",
+  "ai-assistant.button.write-narrow": "Narrow",
+  "ai-assistant.text.send-shortcut": "{key} to send",
+  "ai-assistant.text.send-tooltip-wide": "Send ({key})",
+  "ai-assistant.text.table-shape": "{rows} rows × {columns} columns",
+  "ai-assistant.button.table-to-words": "Put in as words"
 }

package/translations/ja.json

@@ -289,5 +289,11 @@
   "ai-assistant.entry.review-stale": "作業ボードで確認した後に入力案が変わりました。もう一度確認してから入力してください。",
   "ai-assistant.workspace.entry-not-found": "表示できる入力案はありません。",
   "ai-assistant.workspace.entry-superseded": "会話の中で新しいカードがこのカードに置き換わりました。そちらを確認してください。",
-  "ai-assistant.workspace.entry-press-in-dock": "これは確認画面です。入力は AI ドックのカードのボタンで行います。"
+  "ai-assistant.workspace.entry-press-in-dock": "これは確認画面です。入力は AI ドックのカードのボタンで行います。",
+  "ai-assistant.button.write-wide": "広く書く",
+  "ai-assistant.button.write-narrow": "縮める",
+  "ai-assistant.text.send-shortcut": "{key} で送信",
+  "ai-assistant.text.send-tooltip-wide": "送信 ({key})",
+  "ai-assistant.text.table-shape": "{rows}行 × {columns}列",
+  "ai-assistant.button.table-to-words": "文字で入れる"
 }

package/translations/ko.json

@@ -289,5 +289,11 @@
   "ai-assistant.entry.review-stale": "작업판에서 검토한 뒤 입력안이 바뀌었습니다. 다시 검토한 뒤 입력하십시오.",
   "ai-assistant.workspace.entry-not-found": "볼 수 있는 입력안이 없습니다.",
   "ai-assistant.workspace.entry-superseded": "대화에서 더 새로운 카드가 이 카드를 대신했습니다. 그 카드를 검토하십시오.",
-  "ai-assistant.workspace.entry-press-in-dock": "검토 화면입니다. 입력은 AI 도크의 카드에 있는 단추로 합니다."
+  "ai-assistant.workspace.entry-press-in-dock": "검토 화면입니다. 입력은 AI 도크의 카드에 있는 단추로 합니다.",
+  "ai-assistant.button.write-wide": "넓게 쓰기",
+  "ai-assistant.button.write-narrow": "줄이기",
+  "ai-assistant.text.send-shortcut": "{key} 보내기",
+  "ai-assistant.text.send-tooltip-wide": "전송 ({key})",
+  "ai-assistant.text.table-shape": "{rows}행 × {columns}열",
+  "ai-assistant.button.table-to-words": "글로 넣기"
 }

package/translations/ms.json

@@ -289,5 +289,11 @@
   "ai-assistant.entry.review-stale": "cadangan ini berubah selepas disemak di papan kerja - semak semula sebelum memasukkan.",
   "ai-assistant.workspace.entry-not-found": "tiada cadangan di sini yang boleh anda lihat.",
   "ai-assistant.workspace.entry-superseded": "kad yang lebih baharu telah menggantikan kad ini dalam perbualan - semak kad itu.",
-  "ai-assistant.workspace.entry-press-in-dock": "ini ialah semakan. Masukkan baris dengan butang pada kad di dok AI."
+  "ai-assistant.workspace.entry-press-in-dock": "ini ialah semakan. Masukkan baris dengan butang pada kad di dok AI.",
+  "ai-assistant.button.write-wide": "Tulis luas",
+  "ai-assistant.button.write-narrow": "Kecilkan",
+  "ai-assistant.text.send-shortcut": "{key} untuk hantar",
+  "ai-assistant.text.send-tooltip-wide": "Hantar ({key})",
+  "ai-assistant.text.table-shape": "{rows} baris × {columns} lajur",
+  "ai-assistant.button.table-to-words": "Masukkan sebagai teks"
 }

package/translations/zh.json

@@ -289,5 +289,11 @@
   "ai-assistant.entry.review-stale": "在工作板审阅后输入方案已变更。请重新审阅后再输入。",
   "ai-assistant.workspace.entry-not-found": "这里没有您可查看的输入方案。",
   "ai-assistant.workspace.entry-superseded": "对话中较新的卡片已取代此卡片，请审阅那一张。",
-  "ai-assistant.workspace.entry-press-in-dock": "这是审阅页面。请用 AI 停靠栏卡片上的按钮输入。"
+  "ai-assistant.workspace.entry-press-in-dock": "这是审阅页面。请用 AI 停靠栏卡片上的按钮输入。",
+  "ai-assistant.button.write-wide": "展开书写",
+  "ai-assistant.button.write-narrow": "收起",
+  "ai-assistant.text.send-shortcut": "{key} 发送",
+  "ai-assistant.text.send-tooltip-wide": "发送 ({key})",
+  "ai-assistant.text.table-shape": "{rows}行 × {columns}列",
+  "ai-assistant.button.table-to-words": "作为文字放入"
 }