@thijshakkenberg/valkyrie-mom-mcp 2.3.2 → 2.3.3

package/.claude-plugin/plugin.json

@@ -1,6 +1,6 @@
 {
   "name": "valkyrie-mom",
-  "version": "2.3.2",
+  "version": "2.3.3",
   "description": "AI-assisted Mansions of Madness scenario editor for Valkyrie",
   "author": {
     "name": "Thijs Hakkenberg"

package/dist/validation/rules/ui-lifetime.d.ts

@@ -0,0 +1,16 @@
+import type { ScenarioModel } from '../../model/scenario-model.js';
+import type { ValidationResult } from '../../model/component-types.js';
+/**
+ * UI must be off the board when a chain of events ends. While any UI component is on the
+ * board, Valkyrie's "next phase" button does nothing (NextStageButton.Next returns when
+ * Quest.UIItemsPresent()), so a UI left behind — a status panel, a portrait, a handout nobody
+ * removes — stops the investigator phase from ever ending: no mythos, no monsters.
+ *
+ * Follows every chain from what can start one (triggered events, token clicks, item
+ * inspections, monster events) and tracks which UI is on the board. A chain may end with UI
+ * showing only when the scenario has ended, or when that UI is clickable and clicking it leads
+ * to its removal (a Begin button). A clickable UI whose chain comes back with it still showing
+ * (a status panel that re-adds itself) never leaves.
+ */
+export declare function checkUILifetime(model: ScenarioModel): ValidationResult[];
+//# sourceMappingURL=ui-lifetime.d.ts.map

package/dist/validation/rules/ui-lifetime.d.ts.map

@@ -0,0 +1 @@
+{"version":3,"file":"ui-lifetime.d.ts","sourceRoot":"","sources":["../../../src/validation/rules/ui-lifetime.ts"],"names":[],"mappings":"AAAA,OAAO,KAAK,EAAE,aAAa,EAAE,MAAM,+BAA+B,CAAC;AACnE,OAAO,KAAK,EAAE,gBAAgB,EAAE,MAAM,gCAAgC,CAAC;AAQvE;;;;;;;;;;;GAWG;AACH,wBAAgB,eAAe,CAAC,KAAK,EAAE,aAAa,GAAG,gBAAgB,EAAE,CA6ExE"}

package/dist/validation/rules/ui-lifetime.js

@@ -0,0 +1,105 @@
+const UI_REMOVE_KEYWORDS = new Set(['#uicomponents', '#boardcomponents']);
+/** Stop exploring huge scenarios after this many (event, UI on board) states */
+const MAX_STATES = 50_000;
+const refs = (v) => (v ?? '').split(/\s+/).filter(Boolean);
+/**
+ * UI must be off the board when a chain of events ends. While any UI component is on the
+ * board, Valkyrie's "next phase" button does nothing (NextStageButton.Next returns when
+ * Quest.UIItemsPresent()), so a UI left behind — a status panel, a portrait, a handout nobody
+ * removes — stops the investigator phase from ever ending: no mythos, no monsters.
+ *
+ * Follows every chain from what can start one (triggered events, token clicks, item
+ * inspections, monster events) and tracks which UI is on the board. A chain may end with UI
+ * showing only when the scenario has ended, or when that UI is clickable and clicking it leads
+ * to its removal (a Begin button). A clickable UI whose chain comes back with it still showing
+ * (a status panel that re-adds itself) never leaves.
+ */
+export function checkUILifetime(model) {
+    const next = (name) => {
+        const d = model.get(name)?.data;
+        if (!d)
+            return [];
+        const buttons = parseInt(d.buttons ?? '0', 10) || 0;
+        // A hidden event always follows button 1
+        const count = d.display === 'false' ? Math.min(buttons, 1) : buttons;
+        const out = [];
+        for (let i = 1; i <= count; i++)
+            out.push(...refs(d[`event${i}`]));
+        return out.filter(n => model.get(n));
+    };
+    const isClickableUI = (ui) => {
+        const d = model.get(ui)?.data;
+        return !!d && (parseInt(d.buttons ?? '0', 10) || 0) >= 1 && refs(d.event1).length > 0;
+    };
+    // Where chains start
+    const entries = new Set();
+    for (const comp of model.getAll()) {
+        const d = comp.data;
+        if (d.trigger)
+            entries.add(comp.name);
+        if (comp.name.startsWith('Token'))
+            entries.add(comp.name);
+        if (comp.name.startsWith('QItem'))
+            refs(d.inspect).forEach(e => entries.add(e));
+        if (comp.name.startsWith('CustomMonster'))
+            [d.activation, d.evadeevent, d.horrorevent].flatMap(refs).forEach(e => entries.add(e));
+    }
+    // UI name -> the event after which it was still showing, and where that chain began
+    const leftOver = new Map();
+    const seen = new Set();
+    let states = 0;
+    const visit = (name, onBoard, from, clicked) => {
+        const key = `${name}|${[...onBoard].sort().join(',')}|${clicked ?? ''}`;
+        if (seen.has(key)) {
+            // Back where we were, and the UI whose click led here is still showing: it never goes away
+            if (clicked && onBoard.has(clicked) && !leftOver.has(clicked))
+                leftOver.set(clicked, { at: name, from });
+            return;
+        }
+        if (++states > MAX_STATES)
+            return;
+        seen.add(key);
+        const d = model.get(name)?.data ?? {};
+        const board = new Set(onBoard);
+        // Valkyrie adds first, then removes
+        refs(d.add).filter(n => n.startsWith('UI')).forEach(n => board.add(n));
+        for (const r of refs(d.remove)) {
+            if (UI_REMOVE_KEYWORDS.has(r))
+                board.clear();
+            else
+                board.delete(r);
+        }
+        if (/(^|\s)\$end,=,[1-9]/.test(d.operations ?? ''))
+            return;
+        const targets = next(name);
+        if (targets.length > 0) {
+            for (const t of targets)
+                visit(t, board, from, clicked);
+            return;
+        }
+        // The chain ends here: a clickable UI on the board carries the story on
+        const clickable = [...board].filter(isClickableUI);
+        if (clickable.length > 0) {
+            for (const ui of clickable)
+                for (const t of refs(model.get(ui).data.event1))
+                    visit(t, board, from, ui);
+            return;
+        }
+        for (const ui of board)
+            if (!leftOver.has(ui))
+                leftOver.set(ui, { at: name, from });
+    };
+    for (const e of entries)
+        visit(e, new Set(), e);
+    const results = [];
+    for (const [ui, { at, from }] of leftOver) {
+        results.push({
+            rule: 'ui-lifetime',
+            severity: 'warning',
+            message: `"${ui}" is still on the board when "${at}" ends (a chain that starts at "${from}"). While any UI element is on the board, Valkyrie's next phase button does nothing, so the investigator phase never ends. Remove it on every button that leaves it; use a token with customImage for anything that should stay on the board`,
+            component: ui,
+        });
+    }
+    return results;
+}
+//# sourceMappingURL=ui-lifetime.js.map

package/dist/validation/rules/ui-lifetime.js.map

@@ -0,0 +1 @@
+{"version":3,"file":"ui-lifetime.js","sourceRoot":"","sources":["../../../src/validation/rules/ui-lifetime.ts"],"names":[],"mappings":"AAGA,MAAM,kBAAkB,GAAG,IAAI,GAAG,CAAC,CAAC,eAAe,EAAE,kBAAkB,CAAC,CAAC,CAAC;AAC1E,gFAAgF;AAChF,MAAM,UAAU,GAAG,MAAM,CAAC;AAE1B,MAAM,IAAI,GAAG,CAAC,CAAqB,EAAE,EAAE,CAAC,CAAC,CAAC,IAAI,EAAE,CAAC,CAAC,KAAK,CAAC,KAAK,CAAC,CAAC,MAAM,CAAC,OAAO,CAAC,CAAC;AAE/E;;;;;;;;;;;GAWG;AACH,MAAM,UAAU,eAAe,CAAC,KAAoB;IAClD,MAAM,IAAI,GAAG,CAAC,IAAY,EAAY,EAAE;QACtC,MAAM,CAAC,GAAG,KAAK,CAAC,GAAG,CAAC,IAAI,CAAC,EAAE,IAAI,CAAC;QAChC,IAAI,CAAC,CAAC;YAAE,OAAO,EAAE,CAAC;QAClB,MAAM,OAAO,GAAG,QAAQ,CAAC,CAAC,CAAC,OAAO,IAAI,GAAG,EAAE,EAAE,CAAC,IAAI,CAAC,CAAC;QACpD,yCAAyC;QACzC,MAAM,KAAK,GAAG,CAAC,CAAC,OAAO,KAAK,OAAO,CAAC,CAAC,CAAC,IAAI,CAAC,GAAG,CAAC,OAAO,EAAE,CAAC,CAAC,CAAC,CAAC,CAAC,OAAO,CAAC;QACrE,MAAM,GAAG,GAAa,EAAE,CAAC;QACzB,KAAK,IAAI,CAAC,GAAG,CAAC,EAAE,CAAC,IAAI,KAAK,EAAE,CAAC,EAAE;YAAE,GAAG,CAAC,IAAI,CAAC,GAAG,IAAI,CAAC,CAAC,CAAC,QAAQ,CAAC,EAAE,CAAC,CAAC,CAAC,CAAC;QACnE,OAAO,GAAG,CAAC,MAAM,CAAC,CAAC,CAAC,EAAE,CAAC,KAAK,CAAC,GAAG,CAAC,CAAC,CAAC,CAAC,CAAC;IACvC,CAAC,CAAC;IACF,MAAM,aAAa,GAAG,CAAC,EAAU,EAAE,EAAE;QACnC,MAAM,CAAC,GAAG,KAAK,CAAC,GAAG,CAAC,EAAE,CAAC,EAAE,IAAI,CAAC;QAC9B,OAAO,CAAC,CAAC,CAAC,IAAI,CAAC,QAAQ,CAAC,CAAC,CAAC,OAAO,IAAI,GAAG,EAAE,EAAE,CAAC,IAAI,CAAC,CAAC,IAAI,CAAC,IAAI,IAAI,CAAC,CAAC,CAAC,MAAM,CAAC,CAAC,MAAM,GAAG,CAAC,CAAC;IACxF,CAAC,CAAC;IAEF,qBAAqB;IACrB,MAAM,OAAO,GAAG,IAAI,GAAG,EAAU,CAAC;IAClC,KAAK,MAAM,IAAI,IAAI,KAAK,CAAC,MAAM,EAAE,EAAE,CAAC;QAClC,MAAM,CAAC,GAAG,IAAI,CAAC,IAAI,CAAC;QACpB,IAAI,CAAC,CAAC,OAAO;YAAE,OAAO,CAAC,GAAG,CAAC,IAAI,CAAC,IAAI,CAAC,CAAC;QACtC,IAAI,IAAI,CAAC,IAAI,CAAC,UAAU,CAAC,OAAO,CAAC;YAAE,OAAO,CAAC,GAAG,CAAC,IAAI,CAAC,IAAI,CAAC,CAAC;QAC1D,IAAI,IAAI,CAAC,IAAI,CAAC,UAAU,CAAC,OAAO,CAAC;YAAE,IAAI,CAAC,CAAC,CAAC,OAAO,CAAC,CAAC,OAAO,CAAC,CAAC,CAAC,EAAE,CAAC,OAAO,CAAC,GAAG,CAAC,CAAC,CAAC,CAAC,CAAC;QAChF,IAAI,IAAI,CAAC,IAAI,CAAC,UAAU,CAAC,eAAe,CAAC;YAAE,CAAC,CAAC,CAAC,UAAU,EAAE,CAAC,CAAC,UAAU,EAAE,CAAC,CAAC,WAAW,CAAC,CAAC,OAAO,CAAC,IAAI,CAAC,CAAC,OAAO,CAAC,CAAC,CAAC,EAAE,CAAC,OAAO,CAAC,GAAG,CAAC,CAAC,CAAC,CAAC,CAAC;IACpI,CAAC;IAED,oFAAoF;IACpF,MAAM,QAAQ,GAAG,IAAI,GAAG,EAAwC,CAAC;IACjE,MAAM,IAAI,GAAG,IAAI,GAAG,EAAU,CAAC;IAC/B,IAAI,MAAM,GAAG,CAAC,CAAC;IAEf,MAAM,KAAK,GAAG,CAAC,IAAY,EAAE,OAAoB,EAAE,IAAY,EAAE,OAAgB,EAAE,EAAE;QACnF,MAAM,GAAG,GAAG,GAAG,IAAI,IAAI,CAAC,GAAG,OAAO,CAAC,CAAC,IAAI,EAAE,CAAC,IAAI,CAAC,GAAG,CAAC,IAAI,OAAO,IAAI,EAAE,EAAE,CAAC;QACxE,IAAI,IAAI,CAAC,GAAG,CAAC,GAAG,CAAC,EAAE,CAAC;YAClB,2FAA2F;YAC3F,IAAI,OAAO,IAAI,OAAO,CAAC,GAAG,CAAC,OAAO,CAAC,IAAI,CAAC,QAAQ,CAAC,GAAG,CAAC,OAAO,CAAC;gBAAE,QAAQ,CAAC,GAAG,CAAC,OAAO,EAAE,EAAE,EAAE,EAAE,IAAI,EAAE,IAAI,EAAE,CAAC,CAAC;YACzG,OAAO;QACT,CAAC;QACD,IAAI,EAAE,MAAM,GAAG,UAAU;YAAE,OAAO;QAClC,IAAI,CAAC,GAAG,CAAC,GAAG,CAAC,CAAC;QAEd,MAAM,CAAC,GAAG,KAAK,CAAC,GAAG,CAAC,IAAI,CAAC,EAAE,IAAI,IAAI,EAAE,CAAC;QACtC,MAAM,KAAK,GAAG,IAAI,GAAG,CAAC,OAAO,CAAC,CAAC;QAC/B,oCAAoC;QACpC,IAAI,CAAC,CAAC,CAAC,GAAG,CAAC,CAAC,MAAM,CAAC,CAAC,CAAC,EAAE,CAAC,CAAC,CAAC,UAAU,CAAC,IAAI,CAAC,CAAC,CAAC,OAAO,CAAC,CAAC,CAAC,EAAE,CAAC,KAAK,CAAC,GAAG,CAAC,CAAC,CAAC,CAAC,CAAC;QACvE,KAAK,MAAM,CAAC,IAAI,IAAI,CAAC,CAAC,CAAC,MAAM,CAAC,EAAE,CAAC;YAC/B,IAAI,kBAAkB,CAAC,GAAG,CAAC,CAAC,CAAC;gBAAE,KAAK,CAAC,KAAK,EAAE,CAAC;;gBACxC,KAAK,CAAC,MAAM,CAAC,CAAC,CAAC,CAAC;QACvB,CAAC;QACD,IAAI,qBAAqB,CAAC,IAAI,CAAC,CAAC,CAAC,UAAU,IAAI,EAAE,CAAC;YAAE,OAAO;QAE3D,MAAM,OAAO,GAAG,IAAI,CAAC,IAAI,CAAC,CAAC;QAC3B,IAAI,OAAO,CAAC,MAAM,GAAG,CAAC,EAAE,CAAC;YACvB,KAAK,MAAM,CAAC,IAAI,OAAO;gBAAE,KAAK,CAAC,CAAC,EAAE,KAAK,EAAE,IAAI,EAAE,OAAO,CAAC,CAAC;YACxD,OAAO;QACT,CAAC;QACD,wEAAwE;QACxE,MAAM,SAAS,GAAG,CAAC,GAAG,KAAK,CAAC,CAAC,MAAM,CAAC,aAAa,CAAC,CAAC;QACnD,IAAI,SAAS,CAAC,MAAM,GAAG,CAAC,EAAE,CAAC;YACzB,KAAK,MAAM,EAAE,IAAI,SAAS;gBAAE,KAAK,MAAM,CAAC,IAAI,IAAI,CAAC,KAAK,CAAC,GAAG,CAAC,EAAE,CAAE,CAAC,IAAI,CAAC,MAAM,CAAC;oBAAE,KAAK,CAAC,CAAC,EAAE,KAAK,EAAE,IAAI,EAAE,EAAE,CAAC,CAAC;YACxG,OAAO;QACT,CAAC;QACD,KAAK,MAAM,EAAE,IAAI,KAAK;YAAE,IAAI,CAAC,QAAQ,CAAC,GAAG,CAAC,EAAE,CAAC;gBAAE,QAAQ,CAAC,GAAG,CAAC,EAAE,EAAE,EAAE,EAAE,EAAE,IAAI,EAAE,IAAI,EAAE,CAAC,CAAC;IACtF,CAAC,CAAC;IAEF,KAAK,MAAM,CAAC,IAAI,OAAO;QAAE,KAAK,CAAC,CAAC,EAAE,IAAI,GAAG,EAAE,EAAE,CAAC,CAAC,CAAC;IAEhD,MAAM,OAAO,GAAuB,EAAE,CAAC;IACvC,KAAK,MAAM,CAAC,EAAE,EAAE,EAAE,EAAE,EAAE,IAAI,EAAE,CAAC,IAAI,QAAQ,EAAE,CAAC;QAC1C,OAAO,CAAC,IAAI,CAAC;YACX,IAAI,EAAE,aAAa;YACnB,QAAQ,EAAE,SAAS;YACnB,OAAO,EAAE,IAAI,EAAE,iCAAiC,EAAE,mCAAmC,IAAI,8OAA8O;YACvU,SAAS,EAAE,EAAE;SACd,CAAC,CAAC;IACL,CAAC;IACD,OAAO,OAAO,CAAC;AACjB,CAAC"}

package/dist/validation/validator.d.ts.map

@@ -1 +1 @@
-{"version":3,"file":"validator.d.ts","sourceRoot":"","sources":["../../src/validation/validator.ts"],"names":[],"mappings":"AAAA,OAAO,KAAK,EAAE,gBAAgB,EAAE,MAAM,6BAA6B,CAAC;AACpE,OAAO,KAAK,EAAE,aAAa,EAAE,MAAM,4BAA4B,CAAC;AA4ChE;;GAEG;AACH,wBAAgB,gBAAgB,CAAC,KAAK,EAAE,aAAa,GAAG,gBAAgB,EAAE,CAMzE"}
+{"version":3,"file":"validator.d.ts","sourceRoot":"","sources":["../../src/validation/validator.ts"],"names":[],"mappings":"AAAA,OAAO,KAAK,EAAE,gBAAgB,EAAE,MAAM,6BAA6B,CAAC;AACpE,OAAO,KAAK,EAAE,aAAa,EAAE,MAAM,4BAA4B,CAAC;AA8ChE;;GAEG;AACH,wBAAgB,gBAAgB,CAAC,KAAK,EAAE,aAAa,GAAG,gBAAgB,EAAE,CAMzE"}

package/dist/validation/validator.js

@@ -17,6 +17,7 @@ import { checkTriggers } from './rules/triggers.js';
 import { checkGameFlow } from './rules/game-flow.js';
 import { checkPuzzles } from './rules/puzzles.js';
 import { checkPackageName } from './rules/package-name.js';
+import { checkUILifetime } from './rules/ui-lifetime.js';
 const ALL_RULES = [
     checkRequiredFields,
     checkCrossReferences,
@@ -38,6 +39,7 @@ const ALL_RULES = [
     checkGameFlow,
     checkPuzzles,
     checkPackageName,
+    checkUILifetime,
 ];
 /**
  * Runs all validation rules against a scenario model and aggregates results.

package/dist/validation/validator.js.map

@@ -1 +1 @@
-{"version":3,"file":"validator.js","sourceRoot":"","sources":["../../src/validation/validator.ts"],"names":[],"mappings":"AAEA,OAAO,EAAE,mBAAmB,EAAE,MAAM,4BAA4B,CAAC;AACjE,OAAO,EAAE,oBAAoB,EAAE,MAAM,6BAA6B,CAAC;AACnE,OAAO,EAAE,eAAe,EAAE,MAAM,wBAAwB,CAAC;AACzD,OAAO,EAAE,6BAA6B,EAAE,MAAM,sCAAsC,CAAC;AACrF,OAAO,EAAE,gBAAgB,EAAE,MAAM,yBAAyB,CAAC;AAC3D,OAAO,EAAE,sBAAsB,EAAE,MAAM,+BAA+B,CAAC;AACvE,OAAO,EAAE,oBAAoB,EAAE,MAAM,6BAA6B,CAAC;AACnE,OAAO,EAAE,wBAAwB,EAAE,MAAM,kCAAkC,CAAC;AAC5E,OAAO,EAAE,6BAA6B,EAAE,MAAM,uCAAuC,CAAC;AACtF,OAAO,EAAE,qBAAqB,EAAE,mBAAmB,EAAE,MAAM,8BAA8B,CAAC;AAC1F,OAAO,EAAE,cAAc,EAAE,MAAM,uBAAuB,CAAC;AACvD,OAAO,EAAE,qBAAqB,EAAE,MAAM,+BAA+B,CAAC;AACtE,OAAO,EAAE,gBAAgB,EAAE,MAAM,yBAAyB,CAAC;AAC3D,OAAO,EAAE,mBAAmB,EAAE,MAAM,4BAA4B,CAAC;AACjE,OAAO,EAAE,iBAAiB,EAAE,MAAM,0BAA0B,CAAC;AAC7D,OAAO,EAAE,aAAa,EAAE,MAAM,qBAAqB,CAAC;AACpD,OAAO,EAAE,aAAa,EAAE,MAAM,sBAAsB,CAAC;AACrD,OAAO,EAAE,YAAY,EAAE,MAAM,oBAAoB,CAAC;AAClD,OAAO,EAAE,gBAAgB,EAAE,MAAM,yBAAyB,CAAC;AAE3D,MAAM,SAAS,GAAG;IAChB,mBAAmB;IACnB,oBAAoB;IACpB,eAAe;IACf,6BAA6B;IAC7B,gBAAgB;IAChB,sBAAsB;IACtB,oBAAoB;IACpB,wBAAwB;IACxB,6BAA6B;IAC7B,qBAAqB;IACrB,mBAAmB;IACnB,cAAc;IACd,qBAAqB;IACrB,gBAAgB;IAChB,mBAAmB;IACnB,iBAAiB;IACjB,aAAa;IACb,aAAa;IACb,YAAY;IACZ,gBAAgB;CACjB,CAAC;AAEF;;GAEG;AACH,MAAM,UAAU,gBAAgB,CAAC,KAAoB;IACnD,MAAM,OAAO,GAAuB,EAAE,CAAC;IACvC,KAAK,MAAM,IAAI,IAAI,SAAS,EAAE,CAAC;QAC7B,OAAO,CAAC,IAAI,CAAC,GAAG,IAAI,CAAC,KAAK,CAAC,CAAC,CAAC;IAC/B,CAAC;IACD,OAAO,OAAO,CAAC;AACjB,CAAC"}
+{"version":3,"file":"validator.js","sourceRoot":"","sources":["../../src/validation/validator.ts"],"names":[],"mappings":"AAEA,OAAO,EAAE,mBAAmB,EAAE,MAAM,4BAA4B,CAAC;AACjE,OAAO,EAAE,oBAAoB,EAAE,MAAM,6BAA6B,CAAC;AACnE,OAAO,EAAE,eAAe,EAAE,MAAM,wBAAwB,CAAC;AACzD,OAAO,EAAE,6BAA6B,EAAE,MAAM,sCAAsC,CAAC;AACrF,OAAO,EAAE,gBAAgB,EAAE,MAAM,yBAAyB,CAAC;AAC3D,OAAO,EAAE,sBAAsB,EAAE,MAAM,+BAA+B,CAAC;AACvE,OAAO,EAAE,oBAAoB,EAAE,MAAM,6BAA6B,CAAC;AACnE,OAAO,EAAE,wBAAwB,EAAE,MAAM,kCAAkC,CAAC;AAC5E,OAAO,EAAE,6BAA6B,EAAE,MAAM,uCAAuC,CAAC;AACtF,OAAO,EAAE,qBAAqB,EAAE,mBAAmB,EAAE,MAAM,8BAA8B,CAAC;AAC1F,OAAO,EAAE,cAAc,EAAE,MAAM,uBAAuB,CAAC;AACvD,OAAO,EAAE,qBAAqB,EAAE,MAAM,+BAA+B,CAAC;AACtE,OAAO,EAAE,gBAAgB,EAAE,MAAM,yBAAyB,CAAC;AAC3D,OAAO,EAAE,mBAAmB,EAAE,MAAM,4BAA4B,CAAC;AACjE,OAAO,EAAE,iBAAiB,EAAE,MAAM,0BAA0B,CAAC;AAC7D,OAAO,EAAE,aAAa,EAAE,MAAM,qBAAqB,CAAC;AACpD,OAAO,EAAE,aAAa,EAAE,MAAM,sBAAsB,CAAC;AACrD,OAAO,EAAE,YAAY,EAAE,MAAM,oBAAoB,CAAC;AAClD,OAAO,EAAE,gBAAgB,EAAE,MAAM,yBAAyB,CAAC;AAC3D,OAAO,EAAE,eAAe,EAAE,MAAM,wBAAwB,CAAC;AAEzD,MAAM,SAAS,GAAG;IAChB,mBAAmB;IACnB,oBAAoB;IACpB,eAAe;IACf,6BAA6B;IAC7B,gBAAgB;IAChB,sBAAsB;IACtB,oBAAoB;IACpB,wBAAwB;IACxB,6BAA6B;IAC7B,qBAAqB;IACrB,mBAAmB;IACnB,cAAc;IACd,qBAAqB;IACrB,gBAAgB;IAChB,mBAAmB;IACnB,iBAAiB;IACjB,aAAa;IACb,aAAa;IACb,YAAY;IACZ,gBAAgB;IAChB,eAAe;CAChB,CAAC;AAEF;;GAEG;AACH,MAAM,UAAU,gBAAgB,CAAC,KAAoB;IACnD,MAAM,OAAO,GAAuB,EAAE,CAAC;IACvC,KAAK,MAAM,IAAI,IAAI,SAAS,EAAE,CAAC;QAC7B,OAAO,CAAC,IAAI,CAAC,GAAG,IAAI,CAAC,KAAK,CAAC,CAAC,CAAC;IAC/B,CAAC;IACD,OAAO,OAAO,CAAC;AACjB,CAAC"}

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@thijshakkenberg/valkyrie-mom-mcp",
-  "version": "2.3.2",
+  "version": "2.3.3",
   "description": "MCP server for AI-assisted Mansions of Madness scenario creation with Valkyrie",
   "type": "module",
   "main": "dist/index.js",

package/skills/artwork/SKILL.md

@@ -102,6 +102,7 @@ upsert_event("EventReadLetter", { buttons: "1", event1: "EventHideLetter", add:
 upsert_event("EventHideLetter", { display: "false", buttons: "0", remove: "UILetter" })
 ```
 
+- Never leave a picture up: while any UI element is on the board, the next phase button does nothing. For a portrait that stays available, use a token with `customImage`.
 - Use `size` 0.6–0.7 for portrait handouts and 0.55–0.65 for landscape scenes, so a long dialog text still clears the picture.
 - For an item the players keep, give the item `inspect=EventReadLetter`, so the picture comes back whenever they inspect it.
 

package/skills/ui-and-puzzles/SKILL.md

@@ -39,6 +39,10 @@ add: "UIBackground UIButton UIImage UIText"
 
 A UI element with `buttons=1` and `event1=` is itself clickable, and its label is `<name>.uitext`.
 
+### UI never stays on the board
+
+While **any** UI element is on the board, Valkyrie's next phase button does nothing (`Quest.UIItemsPresent()`), so the investigator phase can never end: no mythos, no monsters. UI is for cutscenes, handouts and puzzles that the next button removes again. For something that should stay available all game (a companion, a status sheet), use a token with `customImage`, and show the values in its dialog with `{var:Name}`, which dialog text fills in each time it opens. `validate_scenario` warns about UI that nothing removes (rule `ui-lifetime`).
+
 ## Prologue / Intro Cutscene
 
 `/artwork` has the complete, tested pattern. It uses a full-screen `ImageCutsceneBG` backdrop, the scenario's own picture on the left (`xposition=-0.45`), the story on the right (`xposition=0.35`, `textAlignment=TOP`), and a Begin button anchored to the bottom (`valign=bottom`) whose event removes the UI and sets up the board. `/artwork` also covers showing handouts and scene pictures during play, and generating the pictures with ComfyUI.

package/src/validation/rules/ui-lifetime.ts

@@ -0,0 +1,99 @@
+import type { ScenarioModel } from '../../model/scenario-model.js';
+import type { ValidationResult } from '../../model/component-types.js';
+
+const UI_REMOVE_KEYWORDS = new Set(['#uicomponents', '#boardcomponents']);
+/** Stop exploring huge scenarios after this many (event, UI on board) states */
+const MAX_STATES = 50_000;
+
+const refs = (v: string | undefined) => (v ?? '').split(/\s+/).filter(Boolean);
+
+/**
+ * UI must be off the board when a chain of events ends. While any UI component is on the
+ * board, Valkyrie's "next phase" button does nothing (NextStageButton.Next returns when
+ * Quest.UIItemsPresent()), so a UI left behind — a status panel, a portrait, a handout nobody
+ * removes — stops the investigator phase from ever ending: no mythos, no monsters.
+ *
+ * Follows every chain from what can start one (triggered events, token clicks, item
+ * inspections, monster events) and tracks which UI is on the board. A chain may end with UI
+ * showing only when the scenario has ended, or when that UI is clickable and clicking it leads
+ * to its removal (a Begin button). A clickable UI whose chain comes back with it still showing
+ * (a status panel that re-adds itself) never leaves.
+ */
+export function checkUILifetime(model: ScenarioModel): ValidationResult[] {
+  const next = (name: string): string[] => {
+    const d = model.get(name)?.data;
+    if (!d) return [];
+    const buttons = parseInt(d.buttons ?? '0', 10) || 0;
+    // A hidden event always follows button 1
+    const count = d.display === 'false' ? Math.min(buttons, 1) : buttons;
+    const out: string[] = [];
+    for (let i = 1; i <= count; i++) out.push(...refs(d[`event${i}`]));
+    return out.filter(n => model.get(n));
+  };
+  const isClickableUI = (ui: string) => {
+    const d = model.get(ui)?.data;
+    return !!d && (parseInt(d.buttons ?? '0', 10) || 0) >= 1 && refs(d.event1).length > 0;
+  };
+
+  // Where chains start
+  const entries = new Set<string>();
+  for (const comp of model.getAll()) {
+    const d = comp.data;
+    if (d.trigger) entries.add(comp.name);
+    if (comp.name.startsWith('Token')) entries.add(comp.name);
+    if (comp.name.startsWith('QItem')) refs(d.inspect).forEach(e => entries.add(e));
+    if (comp.name.startsWith('CustomMonster')) [d.activation, d.evadeevent, d.horrorevent].flatMap(refs).forEach(e => entries.add(e));
+  }
+
+  // UI name -> the event after which it was still showing, and where that chain began
+  const leftOver = new Map<string, { at: string; from: string }>();
+  const seen = new Set<string>();
+  let states = 0;
+
+  const visit = (name: string, onBoard: Set<string>, from: string, clicked?: string) => {
+    const key = `${name}|${[...onBoard].sort().join(',')}|${clicked ?? ''}`;
+    if (seen.has(key)) {
+      // Back where we were, and the UI whose click led here is still showing: it never goes away
+      if (clicked && onBoard.has(clicked) && !leftOver.has(clicked)) leftOver.set(clicked, { at: name, from });
+      return;
+    }
+    if (++states > MAX_STATES) return;
+    seen.add(key);
+
+    const d = model.get(name)?.data ?? {};
+    const board = new Set(onBoard);
+    // Valkyrie adds first, then removes
+    refs(d.add).filter(n => n.startsWith('UI')).forEach(n => board.add(n));
+    for (const r of refs(d.remove)) {
+      if (UI_REMOVE_KEYWORDS.has(r)) board.clear();
+      else board.delete(r);
+    }
+    if (/(^|\s)\$end,=,[1-9]/.test(d.operations ?? '')) return;
+
+    const targets = next(name);
+    if (targets.length > 0) {
+      for (const t of targets) visit(t, board, from, clicked);
+      return;
+    }
+    // The chain ends here: a clickable UI on the board carries the story on
+    const clickable = [...board].filter(isClickableUI);
+    if (clickable.length > 0) {
+      for (const ui of clickable) for (const t of refs(model.get(ui)!.data.event1)) visit(t, board, from, ui);
+      return;
+    }
+    for (const ui of board) if (!leftOver.has(ui)) leftOver.set(ui, { at: name, from });
+  };
+
+  for (const e of entries) visit(e, new Set(), e);
+
+  const results: ValidationResult[] = [];
+  for (const [ui, { at, from }] of leftOver) {
+    results.push({
+      rule: 'ui-lifetime',
+      severity: 'warning',
+      message: `"${ui}" is still on the board when "${at}" ends (a chain that starts at "${from}"). While any UI element is on the board, Valkyrie's next phase button does nothing, so the investigator phase never ends. Remove it on every button that leaves it; use a token with customImage for anything that should stay on the board`,
+      component: ui,
+    });
+  }
+  return results;
+}

package/src/validation/validator.ts

@@ -19,6 +19,7 @@ import { checkTriggers } from './rules/triggers.js';
 import { checkGameFlow } from './rules/game-flow.js';
 import { checkPuzzles } from './rules/puzzles.js';
 import { checkPackageName } from './rules/package-name.js';
+import { checkUILifetime } from './rules/ui-lifetime.js';
 
 const ALL_RULES = [
   checkRequiredFields,
@@ -41,6 +42,7 @@ const ALL_RULES = [
   checkGameFlow,
   checkPuzzles,
   checkPackageName,
+  checkUILifetime,
 ];
 
 /**