@thierrynakoa/fire-flow 12.2.2 → 13.0.1

package/agents/fire-debugger.md

@@ -293,6 +293,50 @@ For each hypothesis, starting with the most likely:
 - Consider combining partial hypotheses
 - If still stuck after 5 hypotheses, escalate with full evidence trail
 
+### Step 4.5: Red-Green Bugfix Gate
+
+Before applying the fix, decide whether this bug warrants a regression test.
+
+**Write a test if ANY of:**
+- 2+ hypotheses were eliminated (non-obvious bug)
+- The bug is in business logic, not config
+- The area has no existing test coverage
+- The bug could recur from future changes
+
+**Skip the test if ALL of:**
+- Fix is a one-line typo/config change
+- Existing tests already cover this path
+- Bug is environmental (ports, env vars, OS-specific)
+
+```markdown
+## Red-Green Gate Decision
+
+**Hypotheses eliminated:** [N]
+**Existing test coverage:** [yes/no — check with `grep -r "test.*[function/route]"` or `glob **/[area]*.test.*`]
+**Could recur:** [yes/no]
+
+**Decision:** WRITE TEST | SKIP (reason: [reason])
+```
+
+**If writing a test:**
+1. Write the failing test FIRST (before any code changes)
+2. Run it — MUST FAIL (RED). If it passes, the test doesn't capture the bug.
+3. Apply the fix
+4. Run the same test — MUST PASS (GREEN)
+5. Continue to Step 6 (verify) and Step 7 (regression check)
+
+**Test type selection:**
+| Bug Location | Test Type | Tool |
+|-------------|-----------|------|
+| Pure function / service | Unit test | Vitest |
+| API endpoint | Integration test | Vitest + supertest |
+| UI interaction / render | E2E test | Playwright |
+| Database / ORM | Integration test | Vitest + test DB |
+
+**Test naming:** `{bug-slug}.regression.test.ts` or add a test case to the nearest existing spec.
+
+> Skill reference: @skills-library/testing/RED_GREEN_BUGFIX_GATE.md
+
 ### Step 5: Apply Fix
 
 ```markdown
@@ -414,6 +458,13 @@ files_modified:
 **Cause:** [Detailed explanation of what went wrong]
 **Why it happened:** [Deeper analysis — what allowed this to occur]
 
+## Red-Green Gate
+**Decision:** [WRITE TEST | SKIP]
+**Reason:** [Why test was written or skipped]
+**Test file:** [path/to/test or N/A]
+**RED confirmed:** [yes — test fails before fix | N/A]
+**GREEN confirmed:** [yes — test passes after fix | N/A]
+
 ## Fix Applied
 **Strategy:** [What the fix does]
 **Files:** [List of modified files with line references]
@@ -466,7 +517,10 @@ files_modified:
 - [ ] Each hypothesis tested with targeted evidence
 - [ ] Hypotheses eliminated with documented reasoning
 - [ ] Root cause confirmed (not assumed)
+- [ ] Red-Green Gate evaluated (write test or document skip reason)
+- [ ] If test written: RED confirmed (test fails before fix)
 - [ ] Fix applied addressing root cause (not symptom)
+- [ ] If test written: GREEN confirmed (test passes after fix)
 - [ ] Fix verified against original reproduction
 - [ ] Regression check completed (test suite passes)
 - [ ] Debug session file created in .planning/debug/