@thiagobueno/rn-selectable-text 1.0.4 → 1.0.6

package/android/src/main/java/com/selectabletext/SelectableTextView.kt

@@ -5,6 +5,8 @@ import android.util.AttributeSet
 import android.view.ActionMode
 import android.view.Menu
 import android.view.MenuItem
+import android.view.View
+import android.view.ViewGroup
 import android.widget.FrameLayout
 import android.widget.TextView
 import com.facebook.react.bridge.Arguments
@@ -16,7 +18,7 @@ class SelectableTextView : FrameLayout {
   private var menuOptions: Array<String> = emptyArray()
   private var textView: TextView? = null
   
-  // A MÁGICA: Variável para segurar a referência do menu nativo do Android
+  // Holds the reference to the native Android ActionMode (the text selection menu)
   private var currentActionMode: ActionMode? = null
   
   constructor(context: Context?) : super(context!!)
@@ -48,13 +50,33 @@ class SelectableTextView : FrameLayout {
     textView.setTextIsSelectable(true)
     textView.customSelectionActionModeCallback = object : ActionMode.Callback {
       override fun onCreateActionMode(mode: ActionMode?, menu: Menu?): Boolean {
-        // Salva a referência da barra nativa do Android assim que ela nasce
+        // Save the reference of the native Android bar as soon as it is created
         currentActionMode = mode
         return true
       }
       
       override fun onPrepareActionMode(mode: ActionMode?, menu: Menu?): Boolean {
         menu?.clear()
+        
+        // ====================================================================
+        // CUSTOM INVISIBLE MODE: Suppress native menu if array is empty
+        // ====================================================================
+        if (menuOptions.isEmpty()) {
+            // Trick to hide the native action bar: assign a 1x1 pixel empty view
+            val view = View(context)
+            view.layoutParams = ViewGroup.LayoutParams(1, 1)
+            mode?.customView = view
+            
+            val selectionStart = textView.selectionStart
+            val selectionEnd = textView.selectionEnd
+            if (selectionEnd > selectionStart) {
+                val selectedText = textView.text.toString().substring(selectionStart, selectionEnd)
+                onSelectionEvent("CUSTOM_MODE", selectedText)
+            }
+            return true
+        }
+
+        // Standard behavior: populate native menu
         menuOptions.forEachIndexed { index, option ->
           menu?.add(0, index, 0, option)
         }
@@ -75,7 +97,7 @@ class SelectableTextView : FrameLayout {
       }
       
       override fun onDestroyActionMode(mode: ActionMode?) {
-        // Limpa a referência quando o próprio usuário fecha o menu tocando fora
+        // Clear the reference when the user closes the menu by tapping outside
         currentActionMode = null
       }
     }
@@ -102,13 +124,13 @@ class SelectableTextView : FrameLayout {
   }
 
   // ====================================================================
-  // A CIRURGIA DE SEGURANÇA (Prevenção do Bug das Views que Somem)
+  // SAFETY FIX (Preventing the disappearing views bug)
   // ====================================================================
   override fun onDetachedFromWindow() {
     super.onDetachedFromWindow()
-    // Se o React Native decidir remover essa View da tela (scroll ou navegação)
-    // e a barra nativa ainda estiver aberta, nós a fechamos à força.
-    // Isso devolve a memória e libera a UI Thread do Android.
+    // If React Native decides to remove this View from the screen (scroll or navigation)
+    // and the native bar is still open, we force it to close.
+    // This frees up memory and releases the Android UI Thread.
     currentActionMode?.finish()
     currentActionMode = null
   }

package/ios/SelectableTextView.mm

@@ -20,8 +20,6 @@ using namespace facebook::react;
 
 - (void)didMoveToWindow {
     [super didMoveToWindow];
-    // FIX: iOS 16+ text selection bug after navigation.
-    // When returning to the screen, we force iOS to re-evaluate the interaction state.
     if (self.window) {
         BOOL wasSelectable = self.selectable;
         self.selectable = NO;
@@ -31,12 +29,8 @@ using namespace facebook::react;
 
 - (BOOL)canPerformAction:(SEL)action withSender:(id)sender
 {
-    // FIX: We explicitly tell iOS that we can perform standard actions.
-    // This prevents the "[UIKitCore] The edit menu did not have performable commands" warning.
-    if (action == @selector(copy:) || action == @selector(selectAll:)) {
-        return YES;
-    }
-    
+    // FIX: Remove hardcoded YES. We delegate entirely to the parent logic
+    // to allow complete suppression of the menu in Custom Mode.
     if (self.parentSelectableTextView) {
         return [self.parentSelectableTextView canPerformAction:action withSender:sender];
     }
@@ -63,7 +57,6 @@ using namespace facebook::react;
     }
 }
 
-// Intercepts physical keyboard "Copy" and nullifies the action to keep it custom
 - (void)copy:(id)sender
 {
     // Silently blocked
@@ -142,7 +135,6 @@ using namespace facebook::react;
 - (void)prepareForRecycle {
     [super prepareForRecycle];
     
-    // FIX: Force drop focus when leaving screen
     [_customTextView resignFirstResponder];
     
     [[UIMenuController sharedMenuController] hideMenuFromView:_customTextView];
@@ -151,11 +143,6 @@ using namespace facebook::react;
     _customTextView.text = nil;
     _customTextView.selectedTextRange = nil;
     
-    // CRITICAL FIX: Do NOT clear _menuOptions here. Fabric's prop diffing will handle updates.
-    // If we clear it here, navigating away and back will result in an empty menu and crash iOS.
-    // _menuOptions = @[];
-    // _menuOptionsVector.clear();
-    
     [self unhideAllViews:self];
 }
 
@@ -244,18 +231,59 @@ using namespace facebook::react;
 
 #pragma mark - UITextViewDelegate
 
+// ====================================================================
+// REAL-TIME CUSTOM MODE TRACKING
+// ====================================================================
+- (void)textViewDidChangeSelection:(UITextView *)textView
+{
+    if (textView.selectedRange.length > 0) {
+        // INVISIBLE MODE (ALL IOS VERSIONS)
+        if (_menuOptions.count == 0) {
+            NSString *selectedText = [textView.text substringWithRange:textView.selectedRange];
+            if (auto eventEmitter = std::static_pointer_cast<const SelectableTextViewEventEmitter>(_eventEmitter)) {
+                SelectableTextViewEventEmitter::OnSelection selectionEvent = {
+                    .chosenOption = std::string("CUSTOM_MODE"),
+                    .highlightedText = std::string([selectedText UTF8String])
+                };
+                eventEmitter->onSelection(selectionEvent);
+            }
+            return;
+        }
+        
+        // STANDARD MODE
+        if (@available(iOS 16.0, *)) {
+            return;
+        } else {
+            dispatch_async(dispatch_get_main_queue(), ^{
+                [self showCustomMenu];
+            });
+        }
+    } else {
+        [[UIMenuController sharedMenuController] hideMenuFromView:_customTextView];
+        
+        // IF SELECTION IS CLEARED, NOTIFY JS TO HIDE THE BOTTOM SHEET
+        if (_menuOptions.count == 0) {
+             if (auto eventEmitter = std::static_pointer_cast<const SelectableTextViewEventEmitter>(_eventEmitter)) {
+                SelectableTextViewEventEmitter::OnSelection selectionEvent = {
+                    .chosenOption = std::string("CUSTOM_MODE"),
+                    .highlightedText = std::string("")
+                };
+                eventEmitter->onSelection(selectionEvent);
+            }
+        }
+    }
+}
+
 // ====================================================================
 // THE NEW IOS 16+ API
 // ====================================================================
 - (UIMenu *)textView:(UITextView *)textView editMenuForTextInRange:(NSRange)range suggestedActions:(NSArray<UIMenuElement *> *)suggestedActions API_AVAILABLE(ios(16.0)) {
     
-    // FORCING THE FOCUS: ensures the system doesn't dismiss our menu unexpectedly
-    [textView becomeFirstResponder];
-    
-    // SAFETY NET: If options are empty (due to async loading), return standard copy to avoid crash
     if (_menuOptions.count == 0) {
-        return [UIMenu menuWithTitle:@"" children:suggestedActions];
+        return [UIMenu menuWithTitle:@"" children:@[]];
     }
+    
+    [textView becomeFirstResponder];
 
     NSMutableArray<UIMenuElement *> *customActions = [[NSMutableArray alloc] init];
 
@@ -266,25 +294,9 @@ using namespace facebook::react;
         [customActions addObject:action];
     }
 
-    // Returns only our custom menu. The native "Copy" action required by the system is swallowed and doesn't appear.
     return [UIMenu menuWithTitle:@"" children:customActions];
 }
 
-- (void)textViewDidChangeSelection:(UITextView *)textView
-{
-    if (@available(iOS 16.0, *)) {
-        return;
-    } else {
-        if (textView.selectedRange.length > 0 && _menuOptions.count > 0) {
-            dispatch_async(dispatch_get_main_queue(), ^{
-                [self showCustomMenu];
-            });
-        } else {
-            [[UIMenuController sharedMenuController] hideMenuFromView:_customTextView];
-        }
-    }
-}
-
 - (void)showCustomMenu
 {
     if (![_customTextView canBecomeFirstResponder]) return;
@@ -323,17 +335,20 @@ using namespace facebook::react;
 }
 
 // ====================================================================
-// THE TRICK TO FORCE THE MENU TO OPEN AND PREVENT UIKIT WARNINGS
+// SUPPRESS SYSTEM MENU IN CUSTOM MODE
 // ====================================================================
 - (BOOL)canPerformAction:(SEL)action withSender:(id)sender
 {
+    // 100% INVISIBLE MODE: iOS is forbidden to render any bubble menu
+    if (_menuOptions.count == 0) {
+        return NO;
+    }
+    
     NSString *selectorName = NSStringFromSelector(action);
     if ([selectorName hasPrefix:@"customAction_"] && [selectorName hasSuffix:@":"]) {
         return YES;
     }
     
-    // We tell iOS that we can perform standard actions. 
-    // This convinces the system not to abort the menu rendering.
     if (action == @selector(copy:) || action == @selector(selectAll:)) {
         return YES;
     }

package/package.json

@@ -1,6 +1,6 @@
 {
     "name": "@thiagobueno/rn-selectable-text",
-    "version": "1.0.4",
+    "version": "1.0.6",
     "type": "module",
     "description": "A library for custom text selection menus",
     "main": "./lib/module/index.js",