@thi.ng/rdom 1.7.3 → 1.7.5

package/CHANGELOG.md

@@ -1,6 +1,6 @@
 # Change Log
 
-- **Last updated**: 2024-09-19T21:09:34Z
+- **Last updated**: 2024-10-03T15:37:53Z
 - **Generator**: [thi.ng/monopub](https://thi.ng/monopub)
 
 All notable changes to this project will be documented in this file.
@@ -9,6 +9,21 @@ See [Conventional Commits](https://conventionalcommits.org/) for commit guidelin
 **Note:** Unlisted _patch_ versions only involve non-code or otherwise excluded changes
 and/or version bumps of transitive dependencies.
 
+### [1.7.5](https://github.com/thi-ng/umbrella/tree/@thi.ng/rdom@1.7.5) (2024-10-03)
+
+#### ⏱ Performance improvements
+
+- internal update __setAttrib() ([15ed31d](https://github.com/thi-ng/umbrella/commit/15ed31d))
+  - only lookup property setters if value non-nullish
+
+### [1.7.4](https://github.com/thi-ng/umbrella/tree/@thi.ng/rdom@1.7.4) (2024-09-22)
+
+#### 🩹 Bug fixes
+
+- further fix __updateValueAttrib() ([378441c](https://github.com/thi-ng/umbrella/commit/378441c))
+  - also skip cursor pos update for readonly elements
+  - fix textarea handling
+
 ### [1.7.3](https://github.com/thi-ng/umbrella/tree/@thi.ng/rdom@1.7.3) (2024-09-19)
 
 #### 🩹 Bug fixes

package/dom.d.ts

@@ -137,14 +137,15 @@ export declare const $html: (el: HTMLElement | SVGElement, body: MaybeDeref<stri
  * [`mergeClasses()`](https://docs.thi.ng/umbrella/hiccup/functions/mergeClasses.html)
  * for details.
  *
- * CSS style rules can be defined via the `style` attrib. Please {@link $style}
- *  for further details.
+ * CSS style rules can be defined via the `style` attrib. Please see
+ * {@link $style} for further details.
  *
  * Data attributes are to be given as object under the `data` attribute name,
  * with its values being merged with the element's current `dataset` property.
  *
- * Depending on element type the `value` attribute will be updated keeping the
- * current cursor position / selection intact.
+ * Depending on element type, the `value` attribute will be updated keeping the
+ * current cursor position / selection intact. (**NOT** done for disabled or
+ * readonly elements due to issues with Safari)
  *
  * @param el -
  * @param attribs -

package/dom.js

@@ -141,9 +141,9 @@ const __setAttrib = (el, id, val, attribs) => {
       el.setAttribute(id, isString(val) ? val : formatPrefixes(val));
       break;
     default: {
-      const setter = __setter(el, id);
-      if (setter && val != null) {
-        return setter.call(el, val);
+      if (val != null) {
+        const setter = __setter(el, id);
+        if (setter) return setter.call(el, val);
       }
       const idx = id.indexOf(":");
       if (idx < 0) {
@@ -156,7 +156,8 @@ const __setAttrib = (el, id, val, attribs) => {
   }
 };
 const __updateValueAttrib = (el, value) => {
-  switch (el.type) {
+  const type = el instanceof HTMLTextAreaElement ? "text" : el.type;
+  switch (type) {
     case "text":
     case "textarea":
     case "password":
@@ -168,7 +169,7 @@ const __updateValueAttrib = (el, value) => {
         const start = el.selectionStart;
         const end = el.selectionEnd;
         el.value = value;
-        !el.disabled && el.setSelectionRange(start, end);
+        !(el.disabled || el.readOnly) && el.setSelectionRange(start, end);
         break;
       }
     default:

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@thi.ng/rdom",
-  "version": "1.7.3",
+  "version": "1.7.5",
   "description": "Lightweight, reactive, VDOM-less UI/DOM components with async lifecycle and @thi.ng/hiccup compatible",
   "type": "module",
   "module": "./index.js",
@@ -146,5 +146,5 @@
     ],
     "year": 2020
   },
-  "gitHead": "b52baa3750ddd1256892df966ab7ac9b4806a9ef\n"
+  "gitHead": "dadc6e71940c091e50fbf9f88ea3ba115d3937df\n"
 }