@thethracian/oxlint-config 0.4.0 → 0.5.0
This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
- package/CHANGELOG.md +6 -0
- package/README.md +153 -1
- package/dist/rules/effect-default.d.ts +19 -0
- package/dist/rules/effect-default.d.ts.map +1 -1
- package/dist/rules/effect-default.js +29 -0
- package/dist/rules/effect-default.js.map +1 -1
- package/dist/rules/effect-imported-call-matcher.d.ts.map +1 -1
- package/dist/rules/effect-imported-call-matcher.js +7 -11
- package/dist/rules/effect-imported-call-matcher.js.map +1 -1
- package/dist/rules/effect-prefer-all-discard.d.ts +5 -0
- package/dist/rules/effect-prefer-all-discard.d.ts.map +1 -0
- package/dist/rules/effect-prefer-all-discard.js +212 -0
- package/dist/rules/effect-prefer-all-discard.js.map +1 -0
- package/dist/rules/effect-prefer-andthen-over-flatmap-discarded-value.d.ts +4 -0
- package/dist/rules/effect-prefer-andthen-over-flatmap-discarded-value.d.ts.map +1 -0
- package/dist/rules/effect-prefer-andthen-over-flatmap-discarded-value.js +104 -0
- package/dist/rules/effect-prefer-andthen-over-flatmap-discarded-value.js.map +1 -0
- package/dist/rules/effect-prefer-as-over-map-constant.d.ts +4 -0
- package/dist/rules/effect-prefer-as-over-map-constant.d.ts.map +1 -0
- package/dist/rules/effect-prefer-as-over-map-constant.js +169 -0
- package/dist/rules/effect-prefer-as-over-map-constant.js.map +1 -0
- package/dist/rules/effect-prefer-as-some.d.ts +4 -0
- package/dist/rules/effect-prefer-as-some.d.ts.map +1 -0
- package/dist/rules/effect-prefer-as-some.js +255 -0
- package/dist/rules/effect-prefer-as-some.js.map +1 -0
- package/dist/rules/effect-prefer-catchif-over-conditional-catch.d.ts +4 -0
- package/dist/rules/effect-prefer-catchif-over-conditional-catch.d.ts.map +1 -0
- package/dist/rules/effect-prefer-catchif-over-conditional-catch.js +204 -0
- package/dist/rules/effect-prefer-catchif-over-conditional-catch.js.map +1 -0
- package/dist/rules/effect-prefer-collection-discard-over-asvoid.d.ts +5 -0
- package/dist/rules/effect-prefer-collection-discard-over-asvoid.d.ts.map +1 -0
- package/dist/rules/effect-prefer-collection-discard-over-asvoid.js +337 -0
- package/dist/rules/effect-prefer-collection-discard-over-asvoid.js.map +1 -0
- package/dist/rules/effect-prefer-filter-or-fail-over-flatmap-guard.d.ts +4 -0
- package/dist/rules/effect-prefer-filter-or-fail-over-flatmap-guard.d.ts.map +1 -0
- package/dist/rules/effect-prefer-filter-or-fail-over-flatmap-guard.js +275 -0
- package/dist/rules/effect-prefer-filter-or-fail-over-flatmap-guard.js.map +1 -0
- package/dist/rules/effect-prefer-foreach-discard.d.ts +4 -0
- package/dist/rules/effect-prefer-foreach-discard.d.ts.map +1 -0
- package/dist/rules/effect-prefer-foreach-discard.js +237 -0
- package/dist/rules/effect-prefer-foreach-discard.js.map +1 -0
- package/dist/rules/effect-prefer-layer-sync.d.ts +5 -0
- package/dist/rules/effect-prefer-layer-sync.d.ts.map +1 -0
- package/dist/rules/effect-prefer-layer-sync.js +183 -0
- package/dist/rules/effect-prefer-layer-sync.js.map +1 -0
- package/dist/rules/effect-prefer-map-both.d.ts +4 -0
- package/dist/rules/effect-prefer-map-both.d.ts.map +1 -0
- package/dist/rules/effect-prefer-map-both.js +175 -0
- package/dist/rules/effect-prefer-map-both.js.map +1 -0
- package/dist/rules/effect-prefer-option-get-or-else.d.ts +5 -0
- package/dist/rules/effect-prefer-option-get-or-else.d.ts.map +1 -0
- package/dist/rules/effect-prefer-option-get-or-else.js +186 -0
- package/dist/rules/effect-prefer-option-get-or-else.js.map +1 -0
- package/dist/rules/effect-prefer-option-nullish-getters.d.ts +5 -0
- package/dist/rules/effect-prefer-option-nullish-getters.d.ts.map +1 -0
- package/dist/rules/effect-prefer-option-nullish-getters.js +304 -0
- package/dist/rules/effect-prefer-option-nullish-getters.js.map +1 -0
- package/dist/rules/effect-prefer-option-or-else-some.d.ts +5 -0
- package/dist/rules/effect-prefer-option-or-else-some.d.ts.map +1 -0
- package/dist/rules/effect-prefer-option-or-else-some.js +158 -0
- package/dist/rules/effect-prefer-option-or-else-some.js.map +1 -0
- package/dist/rules/effect-prefer-ref-get-and-update.d.ts +5 -0
- package/dist/rules/effect-prefer-ref-get-and-update.d.ts.map +1 -0
- package/dist/rules/effect-prefer-ref-get-and-update.js +185 -0
- package/dist/rules/effect-prefer-ref-get-and-update.js.map +1 -0
- package/dist/rules/effect-prefer-succeed-none.d.ts +4 -0
- package/dist/rules/effect-prefer-succeed-none.d.ts.map +1 -0
- package/dist/rules/effect-prefer-succeed-none.js +107 -0
- package/dist/rules/effect-prefer-succeed-none.js.map +1 -0
- package/dist/rules/effect-prefer-succeed-some.d.ts +4 -0
- package/dist/rules/effect-prefer-succeed-some.d.ts.map +1 -0
- package/dist/rules/effect-prefer-succeed-some.js +117 -0
- package/dist/rules/effect-prefer-succeed-some.js.map +1 -0
- package/dist/rules/effect-prefer-tap-over-flatmap-as.d.ts +4 -0
- package/dist/rules/effect-prefer-tap-over-flatmap-as.d.ts.map +1 -0
- package/dist/rules/effect-prefer-tap-over-flatmap-as.js +194 -0
- package/dist/rules/effect-prefer-tap-over-flatmap-as.js.map +1 -0
- package/dist/rules/effect-prefer-yieldable-error-over-fail.d.ts +5 -0
- package/dist/rules/effect-prefer-yieldable-error-over-fail.d.ts.map +1 -0
- package/dist/rules/effect-prefer-yieldable-error-over-fail.js +348 -0
- package/dist/rules/effect-prefer-yieldable-error-over-fail.js.map +1 -0
- package/dist/rules/effect-rule-names.d.ts.map +1 -1
- package/dist/rules/effect-rule-names.js +1 -1
- package/dist/rules/effect-rule-names.js.map +1 -1
- package/dist/rules/effect-schema-no-redundant-tag-identifier.d.ts +5 -0
- package/dist/rules/effect-schema-no-redundant-tag-identifier.d.ts.map +1 -0
- package/dist/rules/effect-schema-no-redundant-tag-identifier.js +112 -0
- package/dist/rules/effect-schema-no-redundant-tag-identifier.js.map +1 -0
- package/dist/rules/effect-yieldable-schema-superclass.d.ts +12 -0
- package/dist/rules/effect-yieldable-schema-superclass.d.ts.map +1 -0
- package/dist/rules/effect-yieldable-schema-superclass.js +73 -0
- package/dist/rules/effect-yieldable-schema-superclass.js.map +1 -0
- package/package.json +1 -1
|
@@ -0,0 +1 @@
|
|
|
1
|
+
{"version":3,"file":"effect-prefer-foreach-discard.d.ts","sourceRoot":"","sources":["../../src/rules/effect-prefer-foreach-discard.ts"],"names":[],"mappings":"AAIA,OAAO,KAAK,EAAW,UAAU,EAAE,MAAM,oBAAoB,CAAC;AAyR9D,QAAA,MAAM,IAAI,EAAE,UAsCX,CAAC;AAEF,eAAe,IAAI,CAAC"}
|
|
@@ -0,0 +1,237 @@
|
|
|
1
|
+
/* -------------------------------------------------------------------------- */
|
|
2
|
+
/* Prefer discard mode when Effect.gen ignores forEach results. */
|
|
3
|
+
/* -------------------------------------------------------------------------- */
|
|
4
|
+
import { asNode, childNode, childNodes, identifierName } from './effect-ast.js';
|
|
5
|
+
import { diagnosticMessage } from './diagnostic-guidance.js';
|
|
6
|
+
import { importedEffectCallMatcher } from './effect-imported-call-matcher.js';
|
|
7
|
+
import { readCachedSource } from './source-cache.js';
|
|
8
|
+
import { strictPathOptionsSchema } from './effect-path-options.js';
|
|
9
|
+
const MESSAGE = diagnosticMessage({
|
|
10
|
+
example: 'import { Effect } from "effect"\n\n' +
|
|
11
|
+
'Effect.gen(function* () {\n' +
|
|
12
|
+
' yield* Effect.forEach(items, work, { concurrency: 4, discard: true })\n' +
|
|
13
|
+
'})',
|
|
14
|
+
fix: 'Add discard: true to the existing options object, or add an options object when none exists.',
|
|
15
|
+
summary: 'Effect.forEach with { discard: true } avoids collecting a result array when a delegated yield ignores the result.',
|
|
16
|
+
});
|
|
17
|
+
const SAFE_OPTION_KEYS = new Set(['batching', 'concurrency', 'concurrentFinalizers']);
|
|
18
|
+
const FOREACH_ARGUMENT_COUNT = 2;
|
|
19
|
+
const FOREACH_WITH_OPTIONS_ARGUMENT_COUNT = 3;
|
|
20
|
+
const literalString = (node) => {
|
|
21
|
+
if (node?.type !== 'Literal') {
|
|
22
|
+
return undefined;
|
|
23
|
+
}
|
|
24
|
+
const value = Reflect.get(node, 'value');
|
|
25
|
+
if (typeof value === 'string') {
|
|
26
|
+
return value;
|
|
27
|
+
}
|
|
28
|
+
return undefined;
|
|
29
|
+
};
|
|
30
|
+
const isTypeImport = (node) => Reflect.get(node, 'importKind') === 'type';
|
|
31
|
+
const isRuntimeEffectImport = (statement) => {
|
|
32
|
+
if (statement.type !== 'ImportDeclaration' || isTypeImport(statement)) {
|
|
33
|
+
return false;
|
|
34
|
+
}
|
|
35
|
+
const source = literalString(childNode(statement, 'source'));
|
|
36
|
+
if (source !== 'effect' && source !== 'effect/Effect') {
|
|
37
|
+
return false;
|
|
38
|
+
}
|
|
39
|
+
const specifiers = childNodes(statement, 'specifiers');
|
|
40
|
+
return specifiers.some((specifier) => !isTypeImport(specifier));
|
|
41
|
+
};
|
|
42
|
+
const hasRuntimeEffectImport = (program) => childNodes(program, 'body').some(isRuntimeEffectImport);
|
|
43
|
+
const addRootPackageNamespace = (namespaces, specifier) => {
|
|
44
|
+
if (specifier.type !== 'ImportNamespaceSpecifier' || isTypeImport(specifier)) {
|
|
45
|
+
return;
|
|
46
|
+
}
|
|
47
|
+
const name = identifierName(childNode(specifier, 'local'));
|
|
48
|
+
if (name) {
|
|
49
|
+
namespaces.add(name);
|
|
50
|
+
}
|
|
51
|
+
};
|
|
52
|
+
const rootPackageNamespaces = (program) => {
|
|
53
|
+
const namespaces = new Set();
|
|
54
|
+
for (const statement of childNodes(program, 'body')) {
|
|
55
|
+
if (statement.type === 'ImportDeclaration' &&
|
|
56
|
+
!isTypeImport(statement) &&
|
|
57
|
+
literalString(childNode(statement, 'source')) === 'effect') {
|
|
58
|
+
childNodes(statement, 'specifiers').forEach((specifier) => {
|
|
59
|
+
addRootPackageNamespace(namespaces, specifier);
|
|
60
|
+
});
|
|
61
|
+
}
|
|
62
|
+
}
|
|
63
|
+
return namespaces;
|
|
64
|
+
};
|
|
65
|
+
const hasTypeArguments = (node) => Boolean(childNode(node, 'typeArguments') || childNode(node, 'typeParameters'));
|
|
66
|
+
const hasUnsupportedMemberAccess = (node) => {
|
|
67
|
+
if (node?.type !== 'MemberExpression') {
|
|
68
|
+
return false;
|
|
69
|
+
}
|
|
70
|
+
return (Reflect.get(node, 'computed') === true ||
|
|
71
|
+
Reflect.get(node, 'optional') === true ||
|
|
72
|
+
hasUnsupportedMemberAccess(childNode(node, 'object')));
|
|
73
|
+
};
|
|
74
|
+
const isPlainCall = (call) => Reflect.get(call, 'optional') !== true &&
|
|
75
|
+
!hasTypeArguments(call) &&
|
|
76
|
+
!hasUnsupportedMemberAccess(childNode(call, 'callee'));
|
|
77
|
+
const boundedArguments = (call, minimumCount, maximumCount) => {
|
|
78
|
+
if (!isPlainCall(call)) {
|
|
79
|
+
return undefined;
|
|
80
|
+
}
|
|
81
|
+
const callArguments = childNodes(call, 'arguments');
|
|
82
|
+
if (callArguments.length < minimumCount || callArguments.length > maximumCount) {
|
|
83
|
+
return undefined;
|
|
84
|
+
}
|
|
85
|
+
for (const argument of callArguments) {
|
|
86
|
+
if (argument.type === 'SpreadElement') {
|
|
87
|
+
return undefined;
|
|
88
|
+
}
|
|
89
|
+
}
|
|
90
|
+
return callArguments;
|
|
91
|
+
};
|
|
92
|
+
const staticPropertyName = (property) => {
|
|
93
|
+
const key = childNode(property, 'key');
|
|
94
|
+
return identifierName(key) ?? literalString(key);
|
|
95
|
+
};
|
|
96
|
+
const isSafeOptionsProperty = (property) => {
|
|
97
|
+
if (property.type !== 'Property' ||
|
|
98
|
+
Reflect.get(property, 'kind') !== 'init' ||
|
|
99
|
+
Reflect.get(property, 'computed') === true ||
|
|
100
|
+
Reflect.get(property, 'method') === true ||
|
|
101
|
+
Reflect.get(property, 'optional') === true) {
|
|
102
|
+
return false;
|
|
103
|
+
}
|
|
104
|
+
const name = staticPropertyName(property);
|
|
105
|
+
return Boolean(name && SAFE_OPTION_KEYS.has(name));
|
|
106
|
+
};
|
|
107
|
+
const isSafeOptions = (node) => node.type === 'ObjectExpression' && childNodes(node, 'properties').every(isSafeOptionsProperty);
|
|
108
|
+
const isDirectRootPackageAPI = (callee, namespaces) => callee?.type === 'MemberExpression' &&
|
|
109
|
+
namespaces.has(identifierName(childNode(callee, 'object')) ?? '');
|
|
110
|
+
const isDataFirstForEach = (call, state) => {
|
|
111
|
+
const callee = childNode(call, 'callee');
|
|
112
|
+
if (!state.effectForEach.matches(callee) ||
|
|
113
|
+
isDirectRootPackageAPI(callee, state.rootPackageNamespaces)) {
|
|
114
|
+
return false;
|
|
115
|
+
}
|
|
116
|
+
const callArguments = boundedArguments(call, FOREACH_ARGUMENT_COUNT, FOREACH_WITH_OPTIONS_ARGUMENT_COUNT);
|
|
117
|
+
if (!callArguments) {
|
|
118
|
+
return false;
|
|
119
|
+
}
|
|
120
|
+
const [, callback, options] = callArguments;
|
|
121
|
+
if (callArguments.length === FOREACH_ARGUMENT_COUNT) {
|
|
122
|
+
return callback?.type !== 'ObjectExpression';
|
|
123
|
+
}
|
|
124
|
+
return options !== undefined && isSafeOptions(options);
|
|
125
|
+
};
|
|
126
|
+
const reportIgnoredForEach = (context, node, parent, state) => {
|
|
127
|
+
if (node.type !== 'YieldExpression' ||
|
|
128
|
+
Reflect.get(node, 'delegate') !== true ||
|
|
129
|
+
parent?.type !== 'ExpressionStatement' ||
|
|
130
|
+
childNode(parent, 'expression') !== node) {
|
|
131
|
+
return;
|
|
132
|
+
}
|
|
133
|
+
const call = childNode(node, 'argument');
|
|
134
|
+
if (call?.type === 'CallExpression' && isDataFirstForEach(call, state)) {
|
|
135
|
+
context.report({ message: MESSAGE, node: childNode(call, 'callee') ?? call });
|
|
136
|
+
}
|
|
137
|
+
};
|
|
138
|
+
const isUnknownArray = (value) => Array.isArray(value);
|
|
139
|
+
const scanValue = (context, value, parent, state) => {
|
|
140
|
+
if (isUnknownArray(value)) {
|
|
141
|
+
for (const item of value) {
|
|
142
|
+
const child = asNode(item);
|
|
143
|
+
if (child) {
|
|
144
|
+
scanNode(context, child, parent, state);
|
|
145
|
+
}
|
|
146
|
+
}
|
|
147
|
+
return;
|
|
148
|
+
}
|
|
149
|
+
const child = asNode(value);
|
|
150
|
+
if (child) {
|
|
151
|
+
scanNode(context, child, parent, state);
|
|
152
|
+
}
|
|
153
|
+
};
|
|
154
|
+
const isFunction = (node) => node.type === 'ArrowFunctionExpression' ||
|
|
155
|
+
node.type === 'FunctionDeclaration' ||
|
|
156
|
+
node.type === 'FunctionExpression';
|
|
157
|
+
const scanNode = (context, node, parent, state) => {
|
|
158
|
+
if (isFunction(node)) {
|
|
159
|
+
return;
|
|
160
|
+
}
|
|
161
|
+
reportIgnoredForEach(context, node, parent, state);
|
|
162
|
+
for (const key of Object.keys(node)) {
|
|
163
|
+
if (key !== 'parent' &&
|
|
164
|
+
key !== 'type' &&
|
|
165
|
+
key !== 'start' &&
|
|
166
|
+
key !== 'end' &&
|
|
167
|
+
key !== 'loc' &&
|
|
168
|
+
key !== 'range') {
|
|
169
|
+
scanValue(context, Reflect.get(node, key), node, state);
|
|
170
|
+
}
|
|
171
|
+
}
|
|
172
|
+
};
|
|
173
|
+
const supportedGenerator = (call) => {
|
|
174
|
+
const callArguments = boundedArguments(call, 1, 2);
|
|
175
|
+
const generator = callArguments?.[callArguments.length - 1];
|
|
176
|
+
if (generator?.type !== 'FunctionExpression' ||
|
|
177
|
+
Reflect.get(generator, 'generator') !== true ||
|
|
178
|
+
Reflect.get(generator, 'async') === true ||
|
|
179
|
+
hasTypeArguments(generator) ||
|
|
180
|
+
childNode(generator, 'id') ||
|
|
181
|
+
childNode(generator, 'returnType')) {
|
|
182
|
+
return undefined;
|
|
183
|
+
}
|
|
184
|
+
return generator;
|
|
185
|
+
};
|
|
186
|
+
const scanGenCall = (context, call, state) => {
|
|
187
|
+
const callee = childNode(call, 'callee');
|
|
188
|
+
if (!state.effectGen.matches(callee) ||
|
|
189
|
+
isDirectRootPackageAPI(callee, state.rootPackageNamespaces)) {
|
|
190
|
+
return;
|
|
191
|
+
}
|
|
192
|
+
const generator = supportedGenerator(call);
|
|
193
|
+
const body = generator && childNode(generator, 'body');
|
|
194
|
+
if (body) {
|
|
195
|
+
scanNode(context, body, undefined, state);
|
|
196
|
+
}
|
|
197
|
+
};
|
|
198
|
+
const hasCandidateTokens = (source) => source.includes('forEach') && source.includes('gen') && source.includes('yield');
|
|
199
|
+
const rule = {
|
|
200
|
+
create(context) {
|
|
201
|
+
if (!hasCandidateTokens(readCachedSource(context))) {
|
|
202
|
+
return { Program() { } };
|
|
203
|
+
}
|
|
204
|
+
let state = undefined;
|
|
205
|
+
return {
|
|
206
|
+
CallExpression(value) {
|
|
207
|
+
const call = asNode(value);
|
|
208
|
+
if (call && state) {
|
|
209
|
+
scanGenCall(context, call, state);
|
|
210
|
+
}
|
|
211
|
+
},
|
|
212
|
+
Program(value) {
|
|
213
|
+
const program = asNode(value);
|
|
214
|
+
if (!program || !hasRuntimeEffectImport(program)) {
|
|
215
|
+
return;
|
|
216
|
+
}
|
|
217
|
+
const matcherState = {
|
|
218
|
+
effectForEach: importedEffectCallMatcher(context, 'Effect', ['forEach']),
|
|
219
|
+
effectGen: importedEffectCallMatcher(context, 'Effect', ['gen']),
|
|
220
|
+
rootPackageNamespaces: rootPackageNamespaces(program),
|
|
221
|
+
};
|
|
222
|
+
matcherState.effectForEach.initialize(program);
|
|
223
|
+
matcherState.effectGen.initialize(program);
|
|
224
|
+
state = matcherState;
|
|
225
|
+
},
|
|
226
|
+
};
|
|
227
|
+
},
|
|
228
|
+
meta: {
|
|
229
|
+
docs: {
|
|
230
|
+
description: MESSAGE,
|
|
231
|
+
},
|
|
232
|
+
schema: strictPathOptionsSchema,
|
|
233
|
+
type: 'problem',
|
|
234
|
+
},
|
|
235
|
+
};
|
|
236
|
+
export default rule;
|
|
237
|
+
//# sourceMappingURL=effect-prefer-foreach-discard.js.map
|
|
@@ -0,0 +1 @@
|
|
|
1
|
+
{"version":3,"file":"effect-prefer-foreach-discard.js","sourceRoot":"","sources":["../../src/rules/effect-prefer-foreach-discard.ts"],"names":[],"mappings":"AAAA,gFAAgF;AAChF,gFAAgF;AAChF,gFAAgF;AAGhF,OAAO,EAAE,MAAM,EAAE,SAAS,EAAE,UAAU,EAAE,cAAc,EAAE,MAAM,cAAc,CAAC;AAG7E,OAAO,EAAE,iBAAiB,EAAE,MAAM,uBAAuB,CAAC;AAC1D,OAAO,EAAE,yBAAyB,EAAE,MAAM,gCAAgC,CAAC;AAC3E,OAAO,EAAE,gBAAgB,EAAE,MAAM,gBAAgB,CAAC;AAClD,OAAO,EAAE,uBAAuB,EAAE,MAAM,uBAAuB,CAAC;AAEhE,MAAM,OAAO,GAAG,iBAAiB,CAAC;IAChC,OAAO,EACL,qCAAqC;QACrC,6BAA6B;QAC7B,2EAA2E;QAC3E,IAAI;IACN,GAAG,EAAE,8FAA8F;IACnG,OAAO,EACL,mHAAmH;CACtH,CAAC,CAAC;AAQH,MAAM,gBAAgB,GAAG,IAAI,GAAG,CAAC,CAAC,UAAU,EAAE,aAAa,EAAE,sBAAsB,CAAC,CAAC,CAAC;AACtF,MAAM,sBAAsB,GAAG,CAAC,CAAC;AACjC,MAAM,mCAAmC,GAAG,CAAC,CAAC;AAE9C,MAAM,aAAa,GAAG,CAAC,IAAyB,EAAsB,EAAE;IACtE,IAAI,IAAI,EAAE,IAAI,KAAK,SAAS,EAAE,CAAC;QAC7B,OAAO,SAAS,CAAC;IACnB,CAAC;IACD,MAAM,KAAK,GAAY,OAAO,CAAC,GAAG,CAAC,IAAI,EAAE,OAAO,CAAC,CAAC;IAClD,IAAI,OAAO,KAAK,KAAK,QAAQ,EAAE,CAAC;QAC9B,OAAO,KAAK,CAAC;IACf,CAAC;IACD,OAAO,SAAS,CAAC;AACnB,CAAC,CAAC;AAEF,MAAM,YAAY,GAAG,CAAC,IAAa,EAAW,EAAE,CAAC,OAAO,CAAC,GAAG,CAAC,IAAI,EAAE,YAAY,CAAC,KAAK,MAAM,CAAC;AAE5F,MAAM,qBAAqB,GAAG,CAAC,SAAkB,EAAW,EAAE;IAC5D,IAAI,SAAS,CAAC,IAAI,KAAK,mBAAmB,IAAI,YAAY,CAAC,SAAS,CAAC,EAAE,CAAC;QACtE,OAAO,KAAK,CAAC;IACf,CAAC;IACD,MAAM,MAAM,GAAG,aAAa,CAAC,SAAS,CAAC,SAAS,EAAE,QAAQ,CAAC,CAAC,CAAC;IAC7D,IAAI,MAAM,KAAK,QAAQ,IAAI,MAAM,KAAK,eAAe,EAAE,CAAC;QACtD,OAAO,KAAK,CAAC;IACf,CAAC;IACD,MAAM,UAAU,GAAG,UAAU,CAAC,SAAS,EAAE,YAAY,CAAC,CAAC;IACvD,OAAO,UAAU,CAAC,IAAI,CAAC,CAAC,SAAS,EAAW,EAAE,CAAC,CAAC,YAAY,CAAC,SAAS,CAAC,CAAC,CAAC;AAC3E,CAAC,CAAC;AAEF,MAAM,sBAAsB,GAAG,CAAC,OAAgB,EAAW,EAAE,CAC3D,UAAU,CAAC,OAAO,EAAE,MAAM,CAAC,CAAC,IAAI,CAAC,qBAAqB,CAAC,CAAC;AAE1D,MAAM,uBAAuB,GAAG,CAAC,UAAuB,EAAE,SAAkB,EAAQ,EAAE;IACpF,IAAI,SAAS,CAAC,IAAI,KAAK,0BAA0B,IAAI,YAAY,CAAC,SAAS,CAAC,EAAE,CAAC;QAC7E,OAAO;IACT,CAAC;IACD,MAAM,IAAI,GAAG,cAAc,CAAC,SAAS,CAAC,SAAS,EAAE,OAAO,CAAC,CAAC,CAAC;IAC3D,IAAI,IAAI,EAAE,CAAC;QACT,UAAU,CAAC,GAAG,CAAC,IAAI,CAAC,CAAC;IACvB,CAAC;AACH,CAAC,CAAC;AAEF,MAAM,qBAAqB,GAAG,CAAC,OAAgB,EAAuB,EAAE;IACtE,MAAM,UAAU,GAAG,IAAI,GAAG,EAAU,CAAC;IACrC,KAAK,MAAM,SAAS,IAAI,UAAU,CAAC,OAAO,EAAE,MAAM,CAAC,EAAE,CAAC;QACpD,IACE,SAAS,CAAC,IAAI,KAAK,mBAAmB;YACtC,CAAC,YAAY,CAAC,SAAS,CAAC;YACxB,aAAa,CAAC,SAAS,CAAC,SAAS,EAAE,QAAQ,CAAC,CAAC,KAAK,QAAQ,EAC1D,CAAC;YACD,UAAU,CAAC,SAAS,EAAE,YAAY,CAAC,CAAC,OAAO,CAAC,CAAC,SAAS,EAAQ,EAAE;gBAC9D,uBAAuB,CAAC,UAAU,EAAE,SAAS,CAAC,CAAC;YACjD,CAAC,CAAC,CAAC;QACL,CAAC;IACH,CAAC;IACD,OAAO,UAAU,CAAC;AACpB,CAAC,CAAC;AAEF,MAAM,gBAAgB,GAAG,CAAC,IAAa,EAAW,EAAE,CAClD,OAAO,CAAC,SAAS,CAAC,IAAI,EAAE,eAAe,CAAC,IAAI,SAAS,CAAC,IAAI,EAAE,gBAAgB,CAAC,CAAC,CAAC;AAEjF,MAAM,0BAA0B,GAAG,CAAC,IAAyB,EAAW,EAAE;IACxE,IAAI,IAAI,EAAE,IAAI,KAAK,kBAAkB,EAAE,CAAC;QACtC,OAAO,KAAK,CAAC;IACf,CAAC;IACD,OAAO,CACL,OAAO,CAAC,GAAG,CAAC,IAAI,EAAE,UAAU,CAAC,KAAK,IAAI;QACtC,OAAO,CAAC,GAAG,CAAC,IAAI,EAAE,UAAU,CAAC,KAAK,IAAI;QACtC,0BAA0B,CAAC,SAAS,CAAC,IAAI,EAAE,QAAQ,CAAC,CAAC,CACtD,CAAC;AACJ,CAAC,CAAC;AAEF,MAAM,WAAW,GAAG,CAAC,IAAa,EAAW,EAAE,CAC7C,OAAO,CAAC,GAAG,CAAC,IAAI,EAAE,UAAU,CAAC,KAAK,IAAI;IACtC,CAAC,gBAAgB,CAAC,IAAI,CAAC;IACvB,CAAC,0BAA0B,CAAC,SAAS,CAAC,IAAI,EAAE,QAAQ,CAAC,CAAC,CAAC;AAEzD,MAAM,gBAAgB,GAAG,CACvB,IAAa,EACb,YAAoB,EACpB,YAAoB,EACG,EAAE;IACzB,IAAI,CAAC,WAAW,CAAC,IAAI,CAAC,EAAE,CAAC;QACvB,OAAO,SAAS,CAAC;IACnB,CAAC;IACD,MAAM,aAAa,GAAG,UAAU,CAAC,IAAI,EAAE,WAAW,CAAC,CAAC;IACpD,IAAI,aAAa,CAAC,MAAM,GAAG,YAAY,IAAI,aAAa,CAAC,MAAM,GAAG,YAAY,EAAE,CAAC;QAC/E,OAAO,SAAS,CAAC;IACnB,CAAC;IACD,KAAK,MAAM,QAAQ,IAAI,aAAa,EAAE,CAAC;QACrC,IAAI,QAAQ,CAAC,IAAI,KAAK,eAAe,EAAE,CAAC;YACtC,OAAO,SAAS,CAAC;QACnB,CAAC;IACH,CAAC;IACD,OAAO,aAAa,CAAC;AACvB,CAAC,CAAC;AAEF,MAAM,kBAAkB,GAAG,CAAC,QAAiB,EAAsB,EAAE;IACnE,MAAM,GAAG,GAAG,SAAS,CAAC,QAAQ,EAAE,KAAK,CAAC,CAAC;IACvC,OAAO,cAAc,CAAC,GAAG,CAAC,IAAI,aAAa,CAAC,GAAG,CAAC,CAAC;AACnD,CAAC,CAAC;AAEF,MAAM,qBAAqB,GAAG,CAAC,QAAiB,EAAW,EAAE;IAC3D,IACE,QAAQ,CAAC,IAAI,KAAK,UAAU;QAC5B,OAAO,CAAC,GAAG,CAAC,QAAQ,EAAE,MAAM,CAAC,KAAK,MAAM;QACxC,OAAO,CAAC,GAAG,CAAC,QAAQ,EAAE,UAAU,CAAC,KAAK,IAAI;QAC1C,OAAO,CAAC,GAAG,CAAC,QAAQ,EAAE,QAAQ,CAAC,KAAK,IAAI;QACxC,OAAO,CAAC,GAAG,CAAC,QAAQ,EAAE,UAAU,CAAC,KAAK,IAAI,EAC1C,CAAC;QACD,OAAO,KAAK,CAAC;IACf,CAAC;IACD,MAAM,IAAI,GAAG,kBAAkB,CAAC,QAAQ,CAAC,CAAC;IAC1C,OAAO,OAAO,CAAC,IAAI,IAAI,gBAAgB,CAAC,GAAG,CAAC,IAAI,CAAC,CAAC,CAAC;AACrD,CAAC,CAAC;AAEF,MAAM,aAAa,GAAG,CAAC,IAAa,EAAW,EAAE,CAC/C,IAAI,CAAC,IAAI,KAAK,kBAAkB,IAAI,UAAU,CAAC,IAAI,EAAE,YAAY,CAAC,CAAC,KAAK,CAAC,qBAAqB,CAAC,CAAC;AAElG,MAAM,sBAAsB,GAAG,CAC7B,MAA2B,EAC3B,UAA+B,EACtB,EAAE,CACX,MAAM,EAAE,IAAI,KAAK,kBAAkB;IACnC,UAAU,CAAC,GAAG,CAAC,cAAc,CAAC,SAAS,CAAC,MAAM,EAAE,QAAQ,CAAC,CAAC,IAAI,EAAE,CAAC,CAAC;AAEpE,MAAM,kBAAkB,GAAG,CAAC,IAAa,EAAE,KAAmB,EAAW,EAAE;IACzE,MAAM,MAAM,GAAG,SAAS,CAAC,IAAI,EAAE,QAAQ,CAAC,CAAC;IACzC,IACE,CAAC,KAAK,CAAC,aAAa,CAAC,OAAO,CAAC,MAAM,CAAC;QACpC,sBAAsB,CAAC,MAAM,EAAE,KAAK,CAAC,qBAAqB,CAAC,EAC3D,CAAC;QACD,OAAO,KAAK,CAAC;IACf,CAAC;IACD,MAAM,aAAa,GAAG,gBAAgB,CACpC,IAAI,EACJ,sBAAsB,EACtB,mCAAmC,CACpC,CAAC;IACF,IAAI,CAAC,aAAa,EAAE,CAAC;QACnB,OAAO,KAAK,CAAC;IACf,CAAC;IACD,MAAM,CAAC,EAAE,QAAQ,EAAE,OAAO,CAAC,GAAG,aAAa,CAAC;IAC5C,IAAI,aAAa,CAAC,MAAM,KAAK,sBAAsB,EAAE,CAAC;QACpD,OAAO,QAAQ,EAAE,IAAI,KAAK,kBAAkB,CAAC;IAC/C,CAAC;IACD,OAAO,OAAO,KAAK,SAAS,IAAI,aAAa,CAAC,OAAO,CAAC,CAAC;AACzD,CAAC,CAAC;AAEF,MAAM,oBAAoB,GAAG,CAC3B,OAAgB,EAChB,IAAa,EACb,MAA2B,EAC3B,KAAmB,EACb,EAAE;IACR,IACE,IAAI,CAAC,IAAI,KAAK,iBAAiB;QAC/B,OAAO,CAAC,GAAG,CAAC,IAAI,EAAE,UAAU,CAAC,KAAK,IAAI;QACtC,MAAM,EAAE,IAAI,KAAK,qBAAqB;QACtC,SAAS,CAAC,MAAM,EAAE,YAAY,CAAC,KAAK,IAAI,EACxC,CAAC;QACD,OAAO;IACT,CAAC;IACD,MAAM,IAAI,GAAG,SAAS,CAAC,IAAI,EAAE,UAAU,CAAC,CAAC;IACzC,IAAI,IAAI,EAAE,IAAI,KAAK,gBAAgB,IAAI,kBAAkB,CAAC,IAAI,EAAE,KAAK,CAAC,EAAE,CAAC;QACvE,OAAO,CAAC,MAAM,CAAC,EAAE,OAAO,EAAE,OAAO,EAAE,IAAI,EAAE,SAAS,CAAC,IAAI,EAAE,QAAQ,CAAC,IAAI,IAAI,EAAE,CAAC,CAAC;IAChF,CAAC;AACH,CAAC,CAAC;AAEF,MAAM,cAAc,GAAG,CAAC,KAAc,EAA+B,EAAE,CAAC,KAAK,CAAC,OAAO,CAAC,KAAK,CAAC,CAAC;AAE7F,MAAM,SAAS,GAAG,CAChB,OAAgB,EAChB,KAAc,EACd,MAAe,EACf,KAAmB,EACb,EAAE;IACR,IAAI,cAAc,CAAC,KAAK,CAAC,EAAE,CAAC;QAC1B,KAAK,MAAM,IAAI,IAAI,KAAK,EAAE,CAAC;YACzB,MAAM,KAAK,GAAG,MAAM,CAAC,IAAI,CAAC,CAAC;YAC3B,IAAI,KAAK,EAAE,CAAC;gBACV,QAAQ,CAAC,OAAO,EAAE,KAAK,EAAE,MAAM,EAAE,KAAK,CAAC,CAAC;YAC1C,CAAC;QACH,CAAC;QACD,OAAO;IACT,CAAC;IACD,MAAM,KAAK,GAAG,MAAM,CAAC,KAAK,CAAC,CAAC;IAC5B,IAAI,KAAK,EAAE,CAAC;QACV,QAAQ,CAAC,OAAO,EAAE,KAAK,EAAE,MAAM,EAAE,KAAK,CAAC,CAAC;IAC1C,CAAC;AACH,CAAC,CAAC;AAEF,MAAM,UAAU,GAAG,CAAC,IAAa,EAAW,EAAE,CAC5C,IAAI,CAAC,IAAI,KAAK,yBAAyB;IACvC,IAAI,CAAC,IAAI,KAAK,qBAAqB;IACnC,IAAI,CAAC,IAAI,KAAK,oBAAoB,CAAC;AAErC,MAAM,QAAQ,GAAG,CACf,OAAgB,EAChB,IAAa,EACb,MAA2B,EAC3B,KAAmB,EACb,EAAE;IACR,IAAI,UAAU,CAAC,IAAI,CAAC,EAAE,CAAC;QACrB,OAAO;IACT,CAAC;IACD,oBAAoB,CAAC,OAAO,EAAE,IAAI,EAAE,MAAM,EAAE,KAAK,CAAC,CAAC;IACnD,KAAK,MAAM,GAAG,IAAI,MAAM,CAAC,IAAI,CAAC,IAAI,CAAC,EAAE,CAAC;QACpC,IACE,GAAG,KAAK,QAAQ;YAChB,GAAG,KAAK,MAAM;YACd,GAAG,KAAK,OAAO;YACf,GAAG,KAAK,KAAK;YACb,GAAG,KAAK,KAAK;YACb,GAAG,KAAK,OAAO,EACf,CAAC;YACD,SAAS,CAAC,OAAO,EAAE,OAAO,CAAC,GAAG,CAAC,IAAI,EAAE,GAAG,CAAC,EAAE,IAAI,EAAE,KAAK,CAAC,CAAC;QAC1D,CAAC;IACH,CAAC;AACH,CAAC,CAAC;AAEF,MAAM,kBAAkB,GAAG,CAAC,IAAa,EAAuB,EAAE;IAChE,MAAM,aAAa,GAAG,gBAAgB,CAAC,IAAI,EAAE,CAAC,EAAE,CAAC,CAAC,CAAC;IACnD,MAAM,SAAS,GAAG,aAAa,EAAE,CAAC,aAAa,CAAC,MAAM,GAAG,CAAC,CAAC,CAAC;IAC5D,IACE,SAAS,EAAE,IAAI,KAAK,oBAAoB;QACxC,OAAO,CAAC,GAAG,CAAC,SAAS,EAAE,WAAW,CAAC,KAAK,IAAI;QAC5C,OAAO,CAAC,GAAG,CAAC,SAAS,EAAE,OAAO,CAAC,KAAK,IAAI;QACxC,gBAAgB,CAAC,SAAS,CAAC;QAC3B,SAAS,CAAC,SAAS,EAAE,IAAI,CAAC;QAC1B,SAAS,CAAC,SAAS,EAAE,YAAY,CAAC,EAClC,CAAC;QACD,OAAO,SAAS,CAAC;IACnB,CAAC;IACD,OAAO,SAAS,CAAC;AACnB,CAAC,CAAC;AAEF,MAAM,WAAW,GAAG,CAAC,OAAgB,EAAE,IAAa,EAAE,KAAmB,EAAQ,EAAE;IACjF,MAAM,MAAM,GAAG,SAAS,CAAC,IAAI,EAAE,QAAQ,CAAC,CAAC;IACzC,IACE,CAAC,KAAK,CAAC,SAAS,CAAC,OAAO,CAAC,MAAM,CAAC;QAChC,sBAAsB,CAAC,MAAM,EAAE,KAAK,CAAC,qBAAqB,CAAC,EAC3D,CAAC;QACD,OAAO;IACT,CAAC;IACD,MAAM,SAAS,GAAG,kBAAkB,CAAC,IAAI,CAAC,CAAC;IAC3C,MAAM,IAAI,GAAG,SAAS,IAAI,SAAS,CAAC,SAAS,EAAE,MAAM,CAAC,CAAC;IACvD,IAAI,IAAI,EAAE,CAAC;QACT,QAAQ,CAAC,OAAO,EAAE,IAAI,EAAE,SAAS,EAAE,KAAK,CAAC,CAAC;IAC5C,CAAC;AACH,CAAC,CAAC;AAEF,MAAM,kBAAkB,GAAG,CAAC,MAAc,EAAW,EAAE,CACrD,MAAM,CAAC,QAAQ,CAAC,SAAS,CAAC,IAAI,MAAM,CAAC,QAAQ,CAAC,KAAK,CAAC,IAAI,MAAM,CAAC,QAAQ,CAAC,OAAO,CAAC,CAAC;AAEnF,MAAM,IAAI,GAAe;IACvB,MAAM,CAAC,OAAgB;QACrB,IAAI,CAAC,kBAAkB,CAAC,gBAAgB,CAAC,OAAO,CAAC,CAAC,EAAE,CAAC;YACnD,OAAO,EAAE,OAAO,KAAU,CAAC,EAAE,CAAC;QAChC,CAAC;QAED,IAAI,KAAK,GAA6B,SAAS,CAAC;QAEhD,OAAO;YACL,cAAc,CAAC,KAAK;gBAClB,MAAM,IAAI,GAAG,MAAM,CAAC,KAAK,CAAC,CAAC;gBAC3B,IAAI,IAAI,IAAI,KAAK,EAAE,CAAC;oBAClB,WAAW,CAAC,OAAO,EAAE,IAAI,EAAE,KAAK,CAAC,CAAC;gBACpC,CAAC;YACH,CAAC;YACD,OAAO,CAAC,KAAK;gBACX,MAAM,OAAO,GAAG,MAAM,CAAC,KAAK,CAAC,CAAC;gBAC9B,IAAI,CAAC,OAAO,IAAI,CAAC,sBAAsB,CAAC,OAAO,CAAC,EAAE,CAAC;oBACjD,OAAO;gBACT,CAAC;gBACD,MAAM,YAAY,GAAiB;oBACjC,aAAa,EAAE,yBAAyB,CAAC,OAAO,EAAE,QAAQ,EAAE,CAAC,SAAS,CAAC,CAAC;oBACxE,SAAS,EAAE,yBAAyB,CAAC,OAAO,EAAE,QAAQ,EAAE,CAAC,KAAK,CAAC,CAAC;oBAChE,qBAAqB,EAAE,qBAAqB,CAAC,OAAO,CAAC;iBACtD,CAAC;gBACF,YAAY,CAAC,aAAa,CAAC,UAAU,CAAC,OAAO,CAAC,CAAC;gBAC/C,YAAY,CAAC,SAAS,CAAC,UAAU,CAAC,OAAO,CAAC,CAAC;gBAC3C,KAAK,GAAG,YAAY,CAAC;YACvB,CAAC;SACF,CAAC;IACJ,CAAC;IACD,IAAI,EAAE;QACJ,IAAI,EAAE;YACJ,WAAW,EAAE,OAAO;SACrB;QACD,MAAM,EAAE,uBAAuB;QAC/B,IAAI,EAAE,SAAS;KAChB;CACF,CAAC;AAEF,eAAe,IAAI,CAAC"}
|
|
@@ -0,0 +1,5 @@
|
|
|
1
|
+
import type { SourceRule } from './effect-rule-core';
|
|
2
|
+
export { default as preferOptionNullishGettersRule, preferAllDiscardRule, preferCollectionDiscardOverAsVoidRule, preferForEachDiscardRule, } from './effect-prefer-option-nullish-getters';
|
|
3
|
+
declare const rule: SourceRule;
|
|
4
|
+
export default rule;
|
|
5
|
+
//# sourceMappingURL=effect-prefer-layer-sync.d.ts.map
|
|
@@ -0,0 +1 @@
|
|
|
1
|
+
{"version":3,"file":"effect-prefer-layer-sync.d.ts","sourceRoot":"","sources":["../../src/rules/effect-prefer-layer-sync.ts"],"names":[],"mappings":"AAIA,OAAO,KAAK,EAAW,UAAU,EAAE,MAAM,oBAAoB,CAAC;AAS9D,OAAO,EACL,OAAO,IAAI,8BAA8B,EACzC,oBAAoB,EACpB,qCAAqC,EACrC,wBAAwB,GACzB,MAAM,wCAAwC,CAAC;AAkMhD,QAAA,MAAM,IAAI,EAAE,UA0CX,CAAC;AAEF,eAAe,IAAI,CAAC"}
|
|
@@ -0,0 +1,183 @@
|
|
|
1
|
+
/* -------------------------------------------------------------------------- */
|
|
2
|
+
/* Prefer Layer.sync over Layer.effect wrapping an Effect.sync. */
|
|
3
|
+
/* -------------------------------------------------------------------------- */
|
|
4
|
+
import { asNode, childNode, childNodes, identifierName } from './effect-ast.js';
|
|
5
|
+
import { diagnosticMessage } from './diagnostic-guidance.js';
|
|
6
|
+
import { importedEffectCallMatcher } from './effect-imported-call-matcher.js';
|
|
7
|
+
import { readCachedSource } from './source-cache.js';
|
|
8
|
+
import { strictPathOptionsSchema } from './effect-path-options.js';
|
|
9
|
+
export { default as preferOptionNullishGettersRule, preferAllDiscardRule, preferCollectionDiscardOverAsVoidRule, preferForEachDiscardRule, } from './effect-prefer-option-nullish-getters.js';
|
|
10
|
+
const MESSAGE = diagnosticMessage({
|
|
11
|
+
example: 'import { Layer } from "effect"\n\nconst live = Layer.sync(Service, () => makeService())',
|
|
12
|
+
fix: 'Pass the Effect.sync thunk directly to Layer.sync.',
|
|
13
|
+
summary: 'Layer.sync expresses synchronous service construction more directly than Layer.effect with Effect.sync.',
|
|
14
|
+
});
|
|
15
|
+
const literalString = (node) => {
|
|
16
|
+
if (node?.type !== 'Literal') {
|
|
17
|
+
return undefined;
|
|
18
|
+
}
|
|
19
|
+
const value = Reflect.get(node, 'value');
|
|
20
|
+
if (typeof value === 'string') {
|
|
21
|
+
return value;
|
|
22
|
+
}
|
|
23
|
+
return undefined;
|
|
24
|
+
};
|
|
25
|
+
const isTypeImport = (node) => Reflect.get(node, 'importKind') === 'type';
|
|
26
|
+
const isEffectModule = (source) => source === 'effect' || source === 'effect/Effect' || source === 'effect/Layer';
|
|
27
|
+
const isRuntimeEffectImport = (statement) => {
|
|
28
|
+
if (statement.type !== 'ImportDeclaration' ||
|
|
29
|
+
isTypeImport(statement) ||
|
|
30
|
+
!isEffectModule(literalString(childNode(statement, 'source')))) {
|
|
31
|
+
return false;
|
|
32
|
+
}
|
|
33
|
+
const specifiers = childNodes(statement, 'specifiers');
|
|
34
|
+
return (specifiers.length === 0 || specifiers.some((specifier) => !isTypeImport(specifier)));
|
|
35
|
+
};
|
|
36
|
+
const hasRuntimeEffectImport = (program) => childNodes(program, 'body').some(isRuntimeEffectImport);
|
|
37
|
+
const addRootPackageNamespace = (namespaces, specifier) => {
|
|
38
|
+
if (specifier.type !== 'ImportNamespaceSpecifier' || isTypeImport(specifier)) {
|
|
39
|
+
return;
|
|
40
|
+
}
|
|
41
|
+
const localName = identifierName(childNode(specifier, 'local'));
|
|
42
|
+
if (localName) {
|
|
43
|
+
namespaces.add(localName);
|
|
44
|
+
}
|
|
45
|
+
};
|
|
46
|
+
const rootPackageNamespaces = (program) => {
|
|
47
|
+
const namespaces = new Set();
|
|
48
|
+
for (const statement of childNodes(program, 'body')) {
|
|
49
|
+
if (statement.type === 'ImportDeclaration' &&
|
|
50
|
+
!isTypeImport(statement) &&
|
|
51
|
+
literalString(childNode(statement, 'source')) === 'effect') {
|
|
52
|
+
for (const specifier of childNodes(statement, 'specifiers')) {
|
|
53
|
+
addRootPackageNamespace(namespaces, specifier);
|
|
54
|
+
}
|
|
55
|
+
}
|
|
56
|
+
}
|
|
57
|
+
return namespaces;
|
|
58
|
+
};
|
|
59
|
+
const hasTypeArguments = (node) => Boolean(childNode(node, 'typeArguments') || childNode(node, 'typeParameters'));
|
|
60
|
+
const hasUnsupportedMemberAccess = (node) => node?.type === 'MemberExpression' &&
|
|
61
|
+
(Reflect.get(node, 'computed') === true ||
|
|
62
|
+
Reflect.get(node, 'optional') === true ||
|
|
63
|
+
hasUnsupportedMemberAccess(childNode(node, 'object')));
|
|
64
|
+
const isPlainCall = (call) => Reflect.get(call, 'optional') !== true &&
|
|
65
|
+
!hasTypeArguments(call) &&
|
|
66
|
+
!hasUnsupportedMemberAccess(childNode(call, 'callee'));
|
|
67
|
+
const exactArguments = (call, expectedCount) => {
|
|
68
|
+
if (!isPlainCall(call)) {
|
|
69
|
+
return undefined;
|
|
70
|
+
}
|
|
71
|
+
const callArguments = childNodes(call, 'arguments');
|
|
72
|
+
if (callArguments.length !== expectedCount ||
|
|
73
|
+
callArguments.some((argument) => argument.type === 'SpreadElement')) {
|
|
74
|
+
return undefined;
|
|
75
|
+
}
|
|
76
|
+
return callArguments;
|
|
77
|
+
};
|
|
78
|
+
const isDirectRootPackageCall = (callee, namespaces) => callee?.type === 'MemberExpression' &&
|
|
79
|
+
namespaces.has(identifierName(childNode(callee, 'object')) ?? '');
|
|
80
|
+
const isImportedCall = (callee, matcher, namespaces) => !isDirectRootPackageCall(callee, namespaces) && matcher.matches(callee);
|
|
81
|
+
const isSupportedInlineThunk = (node) => (node?.type === 'ArrowFunctionExpression' || node?.type === 'FunctionExpression') &&
|
|
82
|
+
childNodes(node, 'params').length === 0 &&
|
|
83
|
+
Reflect.get(node, 'async') !== true &&
|
|
84
|
+
Reflect.get(node, 'generator') !== true;
|
|
85
|
+
const singleReturnExpression = (body) => {
|
|
86
|
+
const statements = childNodes(body, 'body');
|
|
87
|
+
const [statement] = statements;
|
|
88
|
+
if (statements.length === 1 && statement?.type === 'ReturnStatement') {
|
|
89
|
+
return childNode(statement, 'argument');
|
|
90
|
+
}
|
|
91
|
+
return undefined;
|
|
92
|
+
};
|
|
93
|
+
const returnedExpression = (thunk) => {
|
|
94
|
+
if (!isSupportedInlineThunk(thunk)) {
|
|
95
|
+
return undefined;
|
|
96
|
+
}
|
|
97
|
+
const body = childNode(thunk, 'body');
|
|
98
|
+
if (body?.type === 'BlockStatement') {
|
|
99
|
+
return singleReturnExpression(body);
|
|
100
|
+
}
|
|
101
|
+
return body;
|
|
102
|
+
};
|
|
103
|
+
const hasStableThunkResult = (thunk) => {
|
|
104
|
+
const expression = returnedExpression(thunk);
|
|
105
|
+
return expression?.type === 'Literal' || identifierName(expression) !== undefined;
|
|
106
|
+
};
|
|
107
|
+
const isEffectSyncCall = (node, state) => {
|
|
108
|
+
if (node?.type !== 'CallExpression') {
|
|
109
|
+
return false;
|
|
110
|
+
}
|
|
111
|
+
const callArguments = exactArguments(node, 1);
|
|
112
|
+
return Boolean(callArguments &&
|
|
113
|
+
isImportedCall(childNode(node, 'callee'), state.effectSync, state.rootPackageNamespaces) &&
|
|
114
|
+
!hasStableThunkResult(callArguments[0]));
|
|
115
|
+
};
|
|
116
|
+
const dataFirstLayerCallee = (call, state) => {
|
|
117
|
+
const callArguments = exactArguments(call, 2);
|
|
118
|
+
const callee = childNode(call, 'callee');
|
|
119
|
+
if (callArguments &&
|
|
120
|
+
isImportedCall(callee, state.layerEffect, state.rootPackageNamespaces) &&
|
|
121
|
+
isEffectSyncCall(callArguments[1], state)) {
|
|
122
|
+
return callee;
|
|
123
|
+
}
|
|
124
|
+
return undefined;
|
|
125
|
+
};
|
|
126
|
+
const curriedLayerCallee = (call, state) => {
|
|
127
|
+
const callArguments = exactArguments(call, 1);
|
|
128
|
+
const layerHead = childNode(call, 'callee');
|
|
129
|
+
if (!callArguments || layerHead?.type !== 'CallExpression' || !exactArguments(layerHead, 1)) {
|
|
130
|
+
return undefined;
|
|
131
|
+
}
|
|
132
|
+
const callee = childNode(layerHead, 'callee');
|
|
133
|
+
if (isImportedCall(callee, state.layerEffect, state.rootPackageNamespaces) &&
|
|
134
|
+
isEffectSyncCall(callArguments[0], state)) {
|
|
135
|
+
return callee;
|
|
136
|
+
}
|
|
137
|
+
return undefined;
|
|
138
|
+
};
|
|
139
|
+
const matchingLayerCallee = (call, state) => dataFirstLayerCallee(call, state) ?? curriedLayerCallee(call, state);
|
|
140
|
+
const hasCandidateTokens = (source) => source.includes('effect') && source.includes('Layer') && source.includes('sync');
|
|
141
|
+
const rule = {
|
|
142
|
+
create(context) {
|
|
143
|
+
if (!hasCandidateTokens(readCachedSource(context))) {
|
|
144
|
+
return { Program() { } };
|
|
145
|
+
}
|
|
146
|
+
let state = undefined;
|
|
147
|
+
return {
|
|
148
|
+
CallExpression(value) {
|
|
149
|
+
const call = asNode(value);
|
|
150
|
+
if (!call || !state) {
|
|
151
|
+
return;
|
|
152
|
+
}
|
|
153
|
+
const callee = matchingLayerCallee(call, state);
|
|
154
|
+
if (callee) {
|
|
155
|
+
context.report({ message: MESSAGE, node: callee });
|
|
156
|
+
}
|
|
157
|
+
},
|
|
158
|
+
Program(value) {
|
|
159
|
+
const program = asNode(value);
|
|
160
|
+
if (!program || !hasRuntimeEffectImport(program)) {
|
|
161
|
+
return;
|
|
162
|
+
}
|
|
163
|
+
const matcherState = {
|
|
164
|
+
effectSync: importedEffectCallMatcher(context, 'Effect', ['sync']),
|
|
165
|
+
layerEffect: importedEffectCallMatcher(context, 'Layer', ['effect']),
|
|
166
|
+
rootPackageNamespaces: rootPackageNamespaces(program),
|
|
167
|
+
};
|
|
168
|
+
matcherState.effectSync.initialize(program);
|
|
169
|
+
matcherState.layerEffect.initialize(program);
|
|
170
|
+
state = matcherState;
|
|
171
|
+
},
|
|
172
|
+
};
|
|
173
|
+
},
|
|
174
|
+
meta: {
|
|
175
|
+
docs: {
|
|
176
|
+
description: MESSAGE,
|
|
177
|
+
},
|
|
178
|
+
schema: strictPathOptionsSchema,
|
|
179
|
+
type: 'problem',
|
|
180
|
+
},
|
|
181
|
+
};
|
|
182
|
+
export default rule;
|
|
183
|
+
//# sourceMappingURL=effect-prefer-layer-sync.js.map
|
|
@@ -0,0 +1 @@
|
|
|
1
|
+
{"version":3,"file":"effect-prefer-layer-sync.js","sourceRoot":"","sources":["../../src/rules/effect-prefer-layer-sync.ts"],"names":[],"mappings":"AAAA,gFAAgF;AAChF,gFAAgF;AAChF,gFAAgF;AAGhF,OAAO,EAAE,MAAM,EAAE,SAAS,EAAE,UAAU,EAAE,cAAc,EAAE,MAAM,cAAc,CAAC;AAG7E,OAAO,EAAE,iBAAiB,EAAE,MAAM,uBAAuB,CAAC;AAC1D,OAAO,EAAE,yBAAyB,EAAE,MAAM,gCAAgC,CAAC;AAC3E,OAAO,EAAE,gBAAgB,EAAE,MAAM,gBAAgB,CAAC;AAClD,OAAO,EAAE,uBAAuB,EAAE,MAAM,uBAAuB,CAAC;AAEhE,OAAO,EACL,OAAO,IAAI,8BAA8B,EACzC,oBAAoB,EACpB,qCAAqC,EACrC,wBAAwB,GACzB,MAAM,wCAAwC,CAAC;AAQhD,MAAM,OAAO,GAAG,iBAAiB,CAAC;IAChC,OAAO,EACL,yFAAyF;IAC3F,GAAG,EAAE,oDAAoD;IACzD,OAAO,EACL,yGAAyG;CAC5G,CAAC,CAAC;AAEH,MAAM,aAAa,GAAG,CAAC,IAAyB,EAAsB,EAAE;IACtE,IAAI,IAAI,EAAE,IAAI,KAAK,SAAS,EAAE,CAAC;QAC7B,OAAO,SAAS,CAAC;IACnB,CAAC;IACD,MAAM,KAAK,GAAY,OAAO,CAAC,GAAG,CAAC,IAAI,EAAE,OAAO,CAAC,CAAC;IAClD,IAAI,OAAO,KAAK,KAAK,QAAQ,EAAE,CAAC;QAC9B,OAAO,KAAK,CAAC;IACf,CAAC;IACD,OAAO,SAAS,CAAC;AACnB,CAAC,CAAC;AAEF,MAAM,YAAY,GAAG,CAAC,IAAa,EAAW,EAAE,CAAC,OAAO,CAAC,GAAG,CAAC,IAAI,EAAE,YAAY,CAAC,KAAK,MAAM,CAAC;AAE5F,MAAM,cAAc,GAAG,CAAC,MAA0B,EAAW,EAAE,CAC7D,MAAM,KAAK,QAAQ,IAAI,MAAM,KAAK,eAAe,IAAI,MAAM,KAAK,cAAc,CAAC;AAEjF,MAAM,qBAAqB,GAAG,CAAC,SAAkB,EAAW,EAAE;IAC5D,IACE,SAAS,CAAC,IAAI,KAAK,mBAAmB;QACtC,YAAY,CAAC,SAAS,CAAC;QACvB,CAAC,cAAc,CAAC,aAAa,CAAC,SAAS,CAAC,SAAS,EAAE,QAAQ,CAAC,CAAC,CAAC,EAC9D,CAAC;QACD,OAAO,KAAK,CAAC;IACf,CAAC;IACD,MAAM,UAAU,GAAG,UAAU,CAAC,SAAS,EAAE,YAAY,CAAC,CAAC;IACvD,OAAO,CACL,UAAU,CAAC,MAAM,KAAK,CAAC,IAAI,UAAU,CAAC,IAAI,CAAC,CAAC,SAAS,EAAW,EAAE,CAAC,CAAC,YAAY,CAAC,SAAS,CAAC,CAAC,CAC7F,CAAC;AACJ,CAAC,CAAC;AAEF,MAAM,sBAAsB,GAAG,CAAC,OAAgB,EAAW,EAAE,CAC3D,UAAU,CAAC,OAAO,EAAE,MAAM,CAAC,CAAC,IAAI,CAAC,qBAAqB,CAAC,CAAC;AAE1D,MAAM,uBAAuB,GAAG,CAAC,UAAuB,EAAE,SAAkB,EAAQ,EAAE;IACpF,IAAI,SAAS,CAAC,IAAI,KAAK,0BAA0B,IAAI,YAAY,CAAC,SAAS,CAAC,EAAE,CAAC;QAC7E,OAAO;IACT,CAAC;IACD,MAAM,SAAS,GAAG,cAAc,CAAC,SAAS,CAAC,SAAS,EAAE,OAAO,CAAC,CAAC,CAAC;IAChE,IAAI,SAAS,EAAE,CAAC;QACd,UAAU,CAAC,GAAG,CAAC,SAAS,CAAC,CAAC;IAC5B,CAAC;AACH,CAAC,CAAC;AAEF,MAAM,qBAAqB,GAAG,CAAC,OAAgB,EAAuB,EAAE;IACtE,MAAM,UAAU,GAAG,IAAI,GAAG,EAAU,CAAC;IACrC,KAAK,MAAM,SAAS,IAAI,UAAU,CAAC,OAAO,EAAE,MAAM,CAAC,EAAE,CAAC;QACpD,IACE,SAAS,CAAC,IAAI,KAAK,mBAAmB;YACtC,CAAC,YAAY,CAAC,SAAS,CAAC;YACxB,aAAa,CAAC,SAAS,CAAC,SAAS,EAAE,QAAQ,CAAC,CAAC,KAAK,QAAQ,EAC1D,CAAC;YACD,KAAK,MAAM,SAAS,IAAI,UAAU,CAAC,SAAS,EAAE,YAAY,CAAC,EAAE,CAAC;gBAC5D,uBAAuB,CAAC,UAAU,EAAE,SAAS,CAAC,CAAC;YACjD,CAAC;QACH,CAAC;IACH,CAAC;IACD,OAAO,UAAU,CAAC;AACpB,CAAC,CAAC;AAEF,MAAM,gBAAgB,GAAG,CAAC,IAAa,EAAW,EAAE,CAClD,OAAO,CAAC,SAAS,CAAC,IAAI,EAAE,eAAe,CAAC,IAAI,SAAS,CAAC,IAAI,EAAE,gBAAgB,CAAC,CAAC,CAAC;AAEjF,MAAM,0BAA0B,GAAG,CAAC,IAAyB,EAAW,EAAE,CACxE,IAAI,EAAE,IAAI,KAAK,kBAAkB;IACjC,CAAC,OAAO,CAAC,GAAG,CAAC,IAAI,EAAE,UAAU,CAAC,KAAK,IAAI;QACrC,OAAO,CAAC,GAAG,CAAC,IAAI,EAAE,UAAU,CAAC,KAAK,IAAI;QACtC,0BAA0B,CAAC,SAAS,CAAC,IAAI,EAAE,QAAQ,CAAC,CAAC,CAAC,CAAC;AAE3D,MAAM,WAAW,GAAG,CAAC,IAAa,EAAW,EAAE,CAC7C,OAAO,CAAC,GAAG,CAAC,IAAI,EAAE,UAAU,CAAC,KAAK,IAAI;IACtC,CAAC,gBAAgB,CAAC,IAAI,CAAC;IACvB,CAAC,0BAA0B,CAAC,SAAS,CAAC,IAAI,EAAE,QAAQ,CAAC,CAAC,CAAC;AAEzD,MAAM,cAAc,GAAG,CAAC,IAAa,EAAE,aAAqB,EAAyB,EAAE;IACrF,IAAI,CAAC,WAAW,CAAC,IAAI,CAAC,EAAE,CAAC;QACvB,OAAO,SAAS,CAAC;IACnB,CAAC;IACD,MAAM,aAAa,GAAG,UAAU,CAAC,IAAI,EAAE,WAAW,CAAC,CAAC;IACpD,IACE,aAAa,CAAC,MAAM,KAAK,aAAa;QACtC,aAAa,CAAC,IAAI,CAAC,CAAC,QAAQ,EAAW,EAAE,CAAC,QAAQ,CAAC,IAAI,KAAK,eAAe,CAAC,EAC5E,CAAC;QACD,OAAO,SAAS,CAAC;IACnB,CAAC;IACD,OAAO,aAAa,CAAC;AACvB,CAAC,CAAC;AAEF,MAAM,uBAAuB,GAAG,CAC9B,MAA2B,EAC3B,UAA+B,EACtB,EAAE,CACX,MAAM,EAAE,IAAI,KAAK,kBAAkB;IACnC,UAAU,CAAC,GAAG,CAAC,cAAc,CAAC,SAAS,CAAC,MAAM,EAAE,QAAQ,CAAC,CAAC,IAAI,EAAE,CAAC,CAAC;AAEpE,MAAM,cAAc,GAAG,CACrB,MAA2B,EAC3B,OAAkC,EAClC,UAA+B,EACtB,EAAE,CAAC,CAAC,uBAAuB,CAAC,MAAM,EAAE,UAAU,CAAC,IAAI,OAAO,CAAC,OAAO,CAAC,MAAM,CAAC,CAAC;AAEtF,MAAM,sBAAsB,GAAG,CAAC,IAAyB,EAAmB,EAAE,CAC5E,CAAC,IAAI,EAAE,IAAI,KAAK,yBAAyB,IAAI,IAAI,EAAE,IAAI,KAAK,oBAAoB,CAAC;IACjF,UAAU,CAAC,IAAI,EAAE,QAAQ,CAAC,CAAC,MAAM,KAAK,CAAC;IACvC,OAAO,CAAC,GAAG,CAAC,IAAI,EAAE,OAAO,CAAC,KAAK,IAAI;IACnC,OAAO,CAAC,GAAG,CAAC,IAAI,EAAE,WAAW,CAAC,KAAK,IAAI,CAAC;AAE1C,MAAM,sBAAsB,GAAG,CAAC,IAAa,EAAuB,EAAE;IACpE,MAAM,UAAU,GAAG,UAAU,CAAC,IAAI,EAAE,MAAM,CAAC,CAAC;IAC5C,MAAM,CAAC,SAAS,CAAC,GAAG,UAAU,CAAC;IAC/B,IAAI,UAAU,CAAC,MAAM,KAAK,CAAC,IAAI,SAAS,EAAE,IAAI,KAAK,iBAAiB,EAAE,CAAC;QACrE,OAAO,SAAS,CAAC,SAAS,EAAE,UAAU,CAAC,CAAC;IAC1C,CAAC;IACD,OAAO,SAAS,CAAC;AACnB,CAAC,CAAC;AAEF,MAAM,kBAAkB,GAAG,CAAC,KAA0B,EAAuB,EAAE;IAC7E,IAAI,CAAC,sBAAsB,CAAC,KAAK,CAAC,EAAE,CAAC;QACnC,OAAO,SAAS,CAAC;IACnB,CAAC;IACD,MAAM,IAAI,GAAG,SAAS,CAAC,KAAK,EAAE,MAAM,CAAC,CAAC;IACtC,IAAI,IAAI,EAAE,IAAI,KAAK,gBAAgB,EAAE,CAAC;QACpC,OAAO,sBAAsB,CAAC,IAAI,CAAC,CAAC;IACtC,CAAC;IACD,OAAO,IAAI,CAAC;AACd,CAAC,CAAC;AAEF,MAAM,oBAAoB,GAAG,CAAC,KAA0B,EAAW,EAAE;IACnE,MAAM,UAAU,GAAG,kBAAkB,CAAC,KAAK,CAAC,CAAC;IAC7C,OAAO,UAAU,EAAE,IAAI,KAAK,SAAS,IAAI,cAAc,CAAC,UAAU,CAAC,KAAK,SAAS,CAAC;AACpF,CAAC,CAAC;AAEF,MAAM,gBAAgB,GAAG,CAAC,IAAyB,EAAE,KAAmB,EAAW,EAAE;IACnF,IAAI,IAAI,EAAE,IAAI,KAAK,gBAAgB,EAAE,CAAC;QACpC,OAAO,KAAK,CAAC;IACf,CAAC;IACD,MAAM,aAAa,GAAG,cAAc,CAAC,IAAI,EAAE,CAAC,CAAC,CAAC;IAC9C,OAAO,OAAO,CACZ,aAAa;QACb,cAAc,CAAC,SAAS,CAAC,IAAI,EAAE,QAAQ,CAAC,EAAE,KAAK,CAAC,UAAU,EAAE,KAAK,CAAC,qBAAqB,CAAC;QACxF,CAAC,oBAAoB,CAAC,aAAa,CAAC,CAAC,CAAC,CAAC,CACxC,CAAC;AACJ,CAAC,CAAC;AAEF,MAAM,oBAAoB,GAAG,CAAC,IAAa,EAAE,KAAmB,EAAuB,EAAE;IACvF,MAAM,aAAa,GAAG,cAAc,CAAC,IAAI,EAAE,CAAC,CAAC,CAAC;IAC9C,MAAM,MAAM,GAAG,SAAS,CAAC,IAAI,EAAE,QAAQ,CAAC,CAAC;IACzC,IACE,aAAa;QACb,cAAc,CAAC,MAAM,EAAE,KAAK,CAAC,WAAW,EAAE,KAAK,CAAC,qBAAqB,CAAC;QACtE,gBAAgB,CAAC,aAAa,CAAC,CAAC,CAAC,EAAE,KAAK,CAAC,EACzC,CAAC;QACD,OAAO,MAAM,CAAC;IAChB,CAAC;IACD,OAAO,SAAS,CAAC;AACnB,CAAC,CAAC;AAEF,MAAM,kBAAkB,GAAG,CAAC,IAAa,EAAE,KAAmB,EAAuB,EAAE;IACrF,MAAM,aAAa,GAAG,cAAc,CAAC,IAAI,EAAE,CAAC,CAAC,CAAC;IAC9C,MAAM,SAAS,GAAG,SAAS,CAAC,IAAI,EAAE,QAAQ,CAAC,CAAC;IAC5C,IAAI,CAAC,aAAa,IAAI,SAAS,EAAE,IAAI,KAAK,gBAAgB,IAAI,CAAC,cAAc,CAAC,SAAS,EAAE,CAAC,CAAC,EAAE,CAAC;QAC5F,OAAO,SAAS,CAAC;IACnB,CAAC;IACD,MAAM,MAAM,GAAG,SAAS,CAAC,SAAS,EAAE,QAAQ,CAAC,CAAC;IAC9C,IACE,cAAc,CAAC,MAAM,EAAE,KAAK,CAAC,WAAW,EAAE,KAAK,CAAC,qBAAqB,CAAC;QACtE,gBAAgB,CAAC,aAAa,CAAC,CAAC,CAAC,EAAE,KAAK,CAAC,EACzC,CAAC;QACD,OAAO,MAAM,CAAC;IAChB,CAAC;IACD,OAAO,SAAS,CAAC;AACnB,CAAC,CAAC;AAEF,MAAM,mBAAmB,GAAG,CAAC,IAAa,EAAE,KAAmB,EAAuB,EAAE,CACtF,oBAAoB,CAAC,IAAI,EAAE,KAAK,CAAC,IAAI,kBAAkB,CAAC,IAAI,EAAE,KAAK,CAAC,CAAC;AAEvE,MAAM,kBAAkB,GAAG,CAAC,MAAc,EAAW,EAAE,CACrD,MAAM,CAAC,QAAQ,CAAC,QAAQ,CAAC,IAAI,MAAM,CAAC,QAAQ,CAAC,OAAO,CAAC,IAAI,MAAM,CAAC,QAAQ,CAAC,MAAM,CAAC,CAAC;AAEnF,MAAM,IAAI,GAAe;IACvB,MAAM,CAAC,OAAgB;QACrB,IAAI,CAAC,kBAAkB,CAAC,gBAAgB,CAAC,OAAO,CAAC,CAAC,EAAE,CAAC;YACnD,OAAO,EAAE,OAAO,KAAU,CAAC,EAAE,CAAC;QAChC,CAAC;QAED,IAAI,KAAK,GAA6B,SAAS,CAAC;QAEhD,OAAO;YACL,cAAc,CAAC,KAAK;gBAClB,MAAM,IAAI,GAAG,MAAM,CAAC,KAAK,CAAC,CAAC;gBAC3B,IAAI,CAAC,IAAI,IAAI,CAAC,KAAK,EAAE,CAAC;oBACpB,OAAO;gBACT,CAAC;gBACD,MAAM,MAAM,GAAG,mBAAmB,CAAC,IAAI,EAAE,KAAK,CAAC,CAAC;gBAChD,IAAI,MAAM,EAAE,CAAC;oBACX,OAAO,CAAC,MAAM,CAAC,EAAE,OAAO,EAAE,OAAO,EAAE,IAAI,EAAE,MAAM,EAAE,CAAC,CAAC;gBACrD,CAAC;YACH,CAAC;YACD,OAAO,CAAC,KAAK;gBACX,MAAM,OAAO,GAAG,MAAM,CAAC,KAAK,CAAC,CAAC;gBAC9B,IAAI,CAAC,OAAO,IAAI,CAAC,sBAAsB,CAAC,OAAO,CAAC,EAAE,CAAC;oBACjD,OAAO;gBACT,CAAC;gBACD,MAAM,YAAY,GAAiB;oBACjC,UAAU,EAAE,yBAAyB,CAAC,OAAO,EAAE,QAAQ,EAAE,CAAC,MAAM,CAAC,CAAC;oBAClE,WAAW,EAAE,yBAAyB,CAAC,OAAO,EAAE,OAAO,EAAE,CAAC,QAAQ,CAAC,CAAC;oBACpE,qBAAqB,EAAE,qBAAqB,CAAC,OAAO,CAAC;iBACtD,CAAC;gBACF,YAAY,CAAC,UAAU,CAAC,UAAU,CAAC,OAAO,CAAC,CAAC;gBAC5C,YAAY,CAAC,WAAW,CAAC,UAAU,CAAC,OAAO,CAAC,CAAC;gBAC7C,KAAK,GAAG,YAAY,CAAC;YACvB,CAAC;SACF,CAAC;IACJ,CAAC;IACD,IAAI,EAAE;QACJ,IAAI,EAAE;YACJ,WAAW,EAAE,OAAO;SACrB;QACD,MAAM,EAAE,uBAAuB;QAC/B,IAAI,EAAE,SAAS;KAChB;CACF,CAAC;AAEF,eAAe,IAAI,CAAC"}
|
|
@@ -0,0 +1 @@
|
|
|
1
|
+
{"version":3,"file":"effect-prefer-map-both.d.ts","sourceRoot":"","sources":["../../src/rules/effect-prefer-map-both.ts"],"names":[],"mappings":"AAIA,OAAO,KAAK,EAAW,UAAU,EAAE,MAAM,oBAAoB,CAAC;AAwK9D,QAAA,MAAM,IAAI,EAAE,UAiDX,CAAC;AAEF,eAAe,IAAI,CAAC"}
|
|
@@ -0,0 +1,175 @@
|
|
|
1
|
+
/* -------------------------------------------------------------------------- */
|
|
2
|
+
/* Prefer Effect.mapBoth over adjacent map and mapError stages. */
|
|
3
|
+
/* -------------------------------------------------------------------------- */
|
|
4
|
+
import { asNode, childNode, childNodes, identifierName } from './effect-ast.js';
|
|
5
|
+
import { diagnosticMessage } from './diagnostic-guidance.js';
|
|
6
|
+
import { importedEffectCallMatcher } from './effect-imported-call-matcher.js';
|
|
7
|
+
import { readCachedSource } from './source-cache.js';
|
|
8
|
+
import { strictPathOptionsSchema } from './effect-path-options.js';
|
|
9
|
+
const MESSAGE = diagnosticMessage({
|
|
10
|
+
example: 'import { Effect } from "effect"\n\nconst normalized = program.pipe(\n' +
|
|
11
|
+
' Effect.mapBoth({ onFailure: normalizeError, onSuccess: normalizeValue })\n)',
|
|
12
|
+
fix: 'Replace the adjacent operators with Effect.mapBoth({ onFailure, onSuccess }), ' +
|
|
13
|
+
'keeping callback expressions in their original evaluation order.',
|
|
14
|
+
summary: 'Effect.mapBoth expresses adjacent success and failure transformations more directly ' +
|
|
15
|
+
'and in one Effect stage than separate Effect.map and Effect.mapError calls.',
|
|
16
|
+
});
|
|
17
|
+
const MAP = 1;
|
|
18
|
+
const MAP_ERROR = 2;
|
|
19
|
+
const MAP_TOKEN = /\bmap\b/;
|
|
20
|
+
const literalString = (node) => {
|
|
21
|
+
if (node?.type !== 'Literal') {
|
|
22
|
+
return undefined;
|
|
23
|
+
}
|
|
24
|
+
const value = Reflect.get(node, 'value');
|
|
25
|
+
if (typeof value === 'string') {
|
|
26
|
+
return value;
|
|
27
|
+
}
|
|
28
|
+
return undefined;
|
|
29
|
+
};
|
|
30
|
+
const hasEffectImport = (program) => {
|
|
31
|
+
for (const statement of childNodes(program, 'body')) {
|
|
32
|
+
if (statement.type === 'ImportDeclaration') {
|
|
33
|
+
const source = literalString(childNode(statement, 'source'));
|
|
34
|
+
if (source === 'effect' || source === 'effect/Effect') {
|
|
35
|
+
return true;
|
|
36
|
+
}
|
|
37
|
+
}
|
|
38
|
+
}
|
|
39
|
+
return false;
|
|
40
|
+
};
|
|
41
|
+
const hasTypeArguments = (node) => Boolean(childNode(node, 'typeArguments') || childNode(node, 'typeParameters'));
|
|
42
|
+
const hasOptionalMemberAccess = (node) => {
|
|
43
|
+
if (node?.type !== 'MemberExpression') {
|
|
44
|
+
return false;
|
|
45
|
+
}
|
|
46
|
+
return (Reflect.get(node, 'optional') === true || hasOptionalMemberAccess(childNode(node, 'object')));
|
|
47
|
+
};
|
|
48
|
+
const isPlainCall = (call) => Reflect.get(call, 'optional') !== true &&
|
|
49
|
+
!hasTypeArguments(call) &&
|
|
50
|
+
!hasOptionalMemberAccess(childNode(call, 'callee'));
|
|
51
|
+
const exactArguments = (call, expectedCount) => {
|
|
52
|
+
const callArguments = childNodes(call, 'arguments');
|
|
53
|
+
if (callArguments.length !== expectedCount || !isPlainCall(call)) {
|
|
54
|
+
return undefined;
|
|
55
|
+
}
|
|
56
|
+
for (const argument of callArguments) {
|
|
57
|
+
if (argument.type === 'SpreadElement') {
|
|
58
|
+
return undefined;
|
|
59
|
+
}
|
|
60
|
+
}
|
|
61
|
+
return callArguments;
|
|
62
|
+
};
|
|
63
|
+
const isPipeCall = (call) => {
|
|
64
|
+
const callee = childNode(call, 'callee');
|
|
65
|
+
return (callee?.type === 'MemberExpression' &&
|
|
66
|
+
Reflect.get(callee, 'computed') !== true &&
|
|
67
|
+
identifierName(childNode(callee, 'property')) === 'pipe' &&
|
|
68
|
+
isPlainCall(call));
|
|
69
|
+
};
|
|
70
|
+
const hasCandidateTokens = (source) => source.includes('mapError') && MAP_TOKEN.test(source);
|
|
71
|
+
const transformationKind = (state, call, expectedCount) => {
|
|
72
|
+
if (!exactArguments(call, expectedCount)) {
|
|
73
|
+
return 0;
|
|
74
|
+
}
|
|
75
|
+
const callee = childNode(call, 'callee');
|
|
76
|
+
if (state.effectMap.matches(callee)) {
|
|
77
|
+
return MAP;
|
|
78
|
+
}
|
|
79
|
+
if (state.effectMapError.matches(callee)) {
|
|
80
|
+
return MAP_ERROR;
|
|
81
|
+
}
|
|
82
|
+
return 0;
|
|
83
|
+
};
|
|
84
|
+
const isTransformationPair = (state, first, second, expectedCount) => {
|
|
85
|
+
if (first?.type !== 'CallExpression' || second?.type !== 'CallExpression') {
|
|
86
|
+
return false;
|
|
87
|
+
}
|
|
88
|
+
const firstKind = transformationKind(state, first, expectedCount);
|
|
89
|
+
return (firstKind !== 0 &&
|
|
90
|
+
firstKind + transformationKind(state, second, expectedCount) === MAP + MAP_ERROR);
|
|
91
|
+
};
|
|
92
|
+
const report = (state, call) => {
|
|
93
|
+
state.context.report({ message: MESSAGE, node: childNode(call, 'callee') ?? call });
|
|
94
|
+
};
|
|
95
|
+
const inspectPipe = (state, call) => {
|
|
96
|
+
const operators = childNodes(call, 'arguments');
|
|
97
|
+
const operatorCount = operators.length;
|
|
98
|
+
for (let index = 0; index + 1 < operatorCount; index += 1) {
|
|
99
|
+
const second = operators[index + 1];
|
|
100
|
+
if (isTransformationPair(state, operators[index], second, 1)) {
|
|
101
|
+
report(state, second);
|
|
102
|
+
index += 1;
|
|
103
|
+
}
|
|
104
|
+
}
|
|
105
|
+
};
|
|
106
|
+
const nestedPairInner = (state, outer) => {
|
|
107
|
+
if (state.consumedNestedCalls.has(outer)) {
|
|
108
|
+
return undefined;
|
|
109
|
+
}
|
|
110
|
+
const [inner] = childNodes(outer, 'arguments');
|
|
111
|
+
if (state.consumedNestedCalls.has(inner ?? outer) ||
|
|
112
|
+
!isTransformationPair(state, inner, outer, 2)) {
|
|
113
|
+
return undefined;
|
|
114
|
+
}
|
|
115
|
+
return inner;
|
|
116
|
+
};
|
|
117
|
+
const inspectNested = (state, outer) => {
|
|
118
|
+
const inner = nestedPairInner(state, outer);
|
|
119
|
+
if (!inner) {
|
|
120
|
+
return;
|
|
121
|
+
}
|
|
122
|
+
state.consumedNestedCalls.add(outer);
|
|
123
|
+
state.consumedNestedCalls.add(inner);
|
|
124
|
+
report(state, outer);
|
|
125
|
+
};
|
|
126
|
+
const rule = {
|
|
127
|
+
create(context) {
|
|
128
|
+
if (!hasCandidateTokens(readCachedSource(context))) {
|
|
129
|
+
return { Program() { } };
|
|
130
|
+
}
|
|
131
|
+
const effectMap = importedEffectCallMatcher(context, 'Effect', ['map']);
|
|
132
|
+
const effectMapError = importedEffectCallMatcher(context, 'Effect', ['mapError']);
|
|
133
|
+
const state = {
|
|
134
|
+
consumedNestedCalls: new WeakSet(),
|
|
135
|
+
context,
|
|
136
|
+
effectMap,
|
|
137
|
+
effectMapError,
|
|
138
|
+
};
|
|
139
|
+
let isInitialized = false;
|
|
140
|
+
return {
|
|
141
|
+
CallExpression(value) {
|
|
142
|
+
if (!isInitialized) {
|
|
143
|
+
return;
|
|
144
|
+
}
|
|
145
|
+
const call = asNode(value);
|
|
146
|
+
if (!call) {
|
|
147
|
+
return;
|
|
148
|
+
}
|
|
149
|
+
if (isPipeCall(call)) {
|
|
150
|
+
inspectPipe(state, call);
|
|
151
|
+
return;
|
|
152
|
+
}
|
|
153
|
+
inspectNested(state, call);
|
|
154
|
+
},
|
|
155
|
+
Program(value) {
|
|
156
|
+
const program = asNode(value);
|
|
157
|
+
if (!program || !hasEffectImport(program)) {
|
|
158
|
+
return;
|
|
159
|
+
}
|
|
160
|
+
isInitialized = true;
|
|
161
|
+
effectMap.initialize(program);
|
|
162
|
+
effectMapError.initialize(program);
|
|
163
|
+
},
|
|
164
|
+
};
|
|
165
|
+
},
|
|
166
|
+
meta: {
|
|
167
|
+
docs: {
|
|
168
|
+
description: MESSAGE,
|
|
169
|
+
},
|
|
170
|
+
schema: strictPathOptionsSchema,
|
|
171
|
+
type: 'problem',
|
|
172
|
+
},
|
|
173
|
+
};
|
|
174
|
+
export default rule;
|
|
175
|
+
//# sourceMappingURL=effect-prefer-map-both.js.map
|