@thesmurph/agentlink 0.2.0 → 0.2.1

package/CHANGELOG.md

@@ -1,5 +1,15 @@
 # Changelog
 
+## 0.2.1
+
+- Fixed: `select` remembered your selection but the picker did not use it, so
+  every run re-ticked every installed harness and a harness you removed came
+  back by default. The picker now starts from the saved selection, and falls
+  back to what is installed only on a first run.
+- The picker's help line says the current selection is pre-ticked, and a
+  harness kept in the selection but no longer installed is labelled
+  "still linked" rather than looking like a stray checkbox.
+
 ## 0.2.0
 
 Corrects the path table against the code each harness actually ships, checked

package/dist/cli.js

@@ -11,7 +11,7 @@ import { endpointVerified, HARNESSES, resolveHarnessList } from "./harnesses.js"
 import { isIgnoreMode, readIgnoreBlock, removeIgnoreBlock, updateGitignore } from "./ignore.js";
 import { apply, mergeState, plan, pruneStale, readState, unlink, writeState } from "./link.js";
 import { resolveScope } from "./scope.js";
-import { selectMany } from "./ui.js";
+import { buildHarnessChoices, selectMany } from "./ui.js";
 const ESC = String.fromCharCode(27);
 // Colour only when something is reading it: a TTY, and not opted out. Piped
 // output and CI logs stay free of escape codes.
@@ -502,7 +502,7 @@ async function chooseHarnesses(paths, options, behaviour) {
     // Never prompt when the caller cannot answer: --yes, --json, or no TTY.
     const canPrompt = !options.yes && !options.json && process.stdin.isTTY === true && process.stdout.isTTY === true;
     if (behaviour.prompt && canPrompt)
-        return promptForHarnesses();
+        return promptForHarnesses(paths);
     const fallback = detectedHarnesses();
     if (!options.json) {
         const names = fallback.map((h) => h.id).join(", ") || "none";
@@ -513,18 +513,17 @@ async function chooseHarnesses(paths, options, behaviour) {
     }
     return fallback;
 }
-async function promptForHarnesses() {
+async function promptForHarnesses(paths) {
     const detections = detectAll();
-    const choices = detections.map(({ harness, installed, reasons }) => ({
+    const choices = buildHarnessChoices(detections.map(({ harness, installed, reasons }) => ({
         id: harness.id,
         label: harness.label,
-        hint: installed ? reasons.join(" · ") : "not detected",
-        checked: installed,
-        group: installed ? "detected" : "other",
-    }));
+        installed,
+        reasons,
+    })), readState(paths).harnesses);
     const picked = await selectMany(choices, {
         title: "Which harnesses should read this project's AGENTS.md and skills?",
-        help: "space toggle · a all · i installed only · enter confirm · esc cancel",
+        help: "current selection pre-ticked · space toggle · a all · i installed only · enter confirm · esc cancel",
     });
     if (picked === null) {
         process.stdout.write(`${DIM}cancelled${RESET}\n`);

package/dist/ui.js

@@ -6,6 +6,28 @@ const DIM = `${ESC}[2m`;
 const BOLD = `${ESC}[1m`;
 const RESET = `${ESC}[0m`;
 const CYAN = `${ESC}[36m`;
+/**
+ * What the picker starts with.
+ *
+ * The saved selection wins, so re-running `select` shows the current state and
+ * a harness you removed stays removed. Only a first run, with nothing saved,
+ * falls back to what is installed on this machine.
+ */
+export function buildHarnessChoices(inputs, saved) {
+    const useSaved = saved.length > 0;
+    return inputs.map((input) => {
+        const checked = useSaved ? saved.includes(input.id) : input.installed;
+        const reasons = input.reasons.length > 0 ? input.reasons.join(" · ") : "not detected";
+        return {
+            id: input.id,
+            label: input.label,
+            // A selected-but-absent harness looks like a mistake unless it is explained.
+            hint: checked && !input.installed ? `${reasons} · still linked` : reasons,
+            checked,
+            group: input.installed ? "detected" : "other",
+        };
+    });
+}
 export async function selectMany(choices, options) {
     if (!process.stdin.isTTY || !process.stdout.isTTY) {
         return choices.filter((c) => c.checked).map((c) => c.id);

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@thesmurph/agentlink",
-  "version": "0.2.0",
+  "version": "0.2.1",
   "description": "One source of truth for agent instructions and skills, symlinked into every coding-agent harness.",
   "keywords": [
     "agents.md",

package/src/cli.ts

@@ -11,7 +11,7 @@ import { endpointVerified, HARNESSES, resolveHarnessList, type Harness } from ".
 import { isIgnoreMode, readIgnoreBlock, removeIgnoreBlock, updateGitignore, type IgnoreMode } from "./ignore.js";
 import { apply, mergeState, plan, pruneStale, readState, unlink, writeState } from "./link.js";
 import { resolveScope, type Scope, type ScopePaths } from "./scope.js";
-import { selectMany, type Choice } from "./ui.js";
+import { buildHarnessChoices, selectMany } from "./ui.js";
 
 const ESC = String.fromCharCode(27);
 // Colour only when something is reading it: a TTY, and not opted out. Piped
@@ -588,7 +588,7 @@ async function chooseHarnesses(
 
   // Never prompt when the caller cannot answer: --yes, --json, or no TTY.
   const canPrompt = !options.yes && !options.json && process.stdin.isTTY === true && process.stdout.isTTY === true;
-  if (behaviour.prompt && canPrompt) return promptForHarnesses();
+  if (behaviour.prompt && canPrompt) return promptForHarnesses(paths);
 
   const fallback = detectedHarnesses();
   if (!options.json) {
@@ -603,19 +603,21 @@ async function chooseHarnesses(
   return fallback;
 }
 
-async function promptForHarnesses(): Promise<Harness[]> {
+async function promptForHarnesses(paths: ScopePaths): Promise<Harness[]> {
   const detections = detectAll();
-  const choices: Choice[] = detections.map(({ harness, installed, reasons }) => ({
-    id: harness.id,
-    label: harness.label,
-    hint: installed ? reasons.join(" · ") : "not detected",
-    checked: installed,
-    group: installed ? "detected" : "other",
-  }));
+  const choices = buildHarnessChoices(
+    detections.map(({ harness, installed, reasons }) => ({
+      id: harness.id,
+      label: harness.label,
+      installed,
+      reasons,
+    })),
+    readState(paths).harnesses,
+  );
 
   const picked = await selectMany(choices, {
     title: "Which harnesses should read this project's AGENTS.md and skills?",
-    help: "space toggle · a all · i installed only · enter confirm · esc cancel",
+    help: "current selection pre-ticked · space toggle · a all · i installed only · enter confirm · esc cancel",
   });
   if (picked === null) {
     process.stdout.write(`${DIM}cancelled${RESET}\n`);

package/src/ui.ts

@@ -29,6 +29,32 @@ const BOLD = `${ESC}[1m`;
 const RESET = `${ESC}[0m`;
 const CYAN = `${ESC}[36m`;
 
+/**
+ * What the picker starts with.
+ *
+ * The saved selection wins, so re-running `select` shows the current state and
+ * a harness you removed stays removed. Only a first run, with nothing saved,
+ * falls back to what is installed on this machine.
+ */
+export function buildHarnessChoices(
+  inputs: { id: string; label: string; installed: boolean; reasons: string[] }[],
+  saved: string[],
+): Choice[] {
+  const useSaved = saved.length > 0;
+  return inputs.map((input) => {
+    const checked = useSaved ? saved.includes(input.id) : input.installed;
+    const reasons = input.reasons.length > 0 ? input.reasons.join(" · ") : "not detected";
+    return {
+      id: input.id,
+      label: input.label,
+      // A selected-but-absent harness looks like a mistake unless it is explained.
+      hint: checked && !input.installed ? `${reasons} · still linked` : reasons,
+      checked,
+      group: input.installed ? "detected" : "other",
+    };
+  });
+}
+
 export async function selectMany(choices: Choice[], options: SelectOptions): Promise<string[] | null> {
   if (!process.stdin.isTTY || !process.stdout.isTTY) {
     return choices.filter((c) => c.checked).map((c) => c.id);