@thermarthae/eslint-config 2.0.0 → 3.0.0

package/README.md

@@ -1,6 +1,6 @@
 # @thermarthae/eslint-config
 
-Just a personalized [Airbnb](https://www.npmjs.com/package/eslint-config-airbnb) Eslint config.
+Just an Eslint config.
 
 ## ✨ Setup
 
@@ -9,13 +9,13 @@ Just a personalized [Airbnb](https://www.npmjs.com/package/eslint-config-airbnb)
 This step assumes that you have already installed Eslint and Typescript.
 
 ```bash
-yarn add -D @thermarthae/eslint-config @typescript-eslint/eslint-plugin @typescript-eslint/parser eslint-plugin-import eslint-plugin-jsx-a11y eslint-plugin-react eslint-plugin-react-hooks eslint-plugin-simple-import-sort
+yarn add -D @thermarthae/eslint-config @typescript-eslint/eslint-plugin @typescript-eslint/parser eslint-plugin-import eslint-plugin-jsx-a11y eslint-plugin-react eslint-plugin-react-hooks eslint-plugin-simple-import-sort @stylistic/eslint-plugin
 ```
 
 If you don't need React support:
 
 ```bash
-yarn add -D @thermarthae/eslint-config @typescript-eslint/eslint-plugin @typescript-eslint/parser eslint-plugin-import eslint-plugin-simple-import-sort
+yarn add -D @thermarthae/eslint-config @typescript-eslint/eslint-plugin @typescript-eslint/parser eslint-plugin-import eslint-plugin-simple-import-sort @stylistic/eslint-plugin
 ```
 
 ### 2) Configure ESLint
@@ -27,7 +27,7 @@ An example `.eslintrc.cjs`:
 ```js
 module.exports = {
 	// If you don't need React support:
-	// extends: ['@thermarthae/eslint-config/base'],
+	// extends: ['@thermarthae/eslint-config/base.cjs'],
 	extends: ['@thermarthae/eslint-config'],
 };
 ```

package/base.cjs

@@ -1,7 +1,5 @@
 module.exports = {
 	extends: [
-		'airbnb-base',
-		'airbnb-typescript/base',
 		'./shared.cjs',
 	],
 };

package/index.cjs

@@ -1,30 +1,55 @@
 module.exports = {
 	extends: [
-		'airbnb',
-		'airbnb-typescript',
-		'airbnb/hooks',
-		'plugin:react/jsx-runtime',
 		'./shared.cjs',
+		'plugin:react/recommended',
+		'plugin:react/jsx-runtime',
+		'plugin:react-hooks/recommended',
+		'plugin:jsx-a11y/recommended',
 	],
-	overrides: [
-		{
-			files: '*.tsx',
-			rules: {
-				'@typescript-eslint/member-ordering': 0, // `react/sort-comp` is handling this out
-				'consistent-return': 0, // annoys inside react hooks
-			},
+	plugins: ['jsx-a11y'],
+	settings: {
+		react: {
+			version: 'detect',
 		},
-	],
+	},
 	rules: {
-		'react/destructuring-assignment': 0,
-		'react/function-component-definition': 0,
-		'react/jsx-indent': ['error', 'tab'],
-		'react/jsx-indent-props': ['error', 'tab'],
-		'react/jsx-props-no-spreading': 0,
+		'react/no-unknown-property': 0,
 		'react/no-children-prop': 0,
 		'react/prop-types': 0,
-		'react/require-default-props': 0,
-		'react/state-in-constructor': ['error', 'never'],
-		'react/static-property-placement': ['error', 'static public field'],
+		'react/jsx-boolean-value': ['error', 'never', { always: [] }],
+		'react/jsx-closing-bracket-location': ['error', 'line-aligned'],
+		'react/jsx-closing-tag-location': 'error',
+		'react/jsx-curly-spacing': ['error', 'never', { allowMultiline: true }],
+		'react/jsx-max-props-per-line': ['error', { maximum: 1, when: 'multiline' }],
+		'react/self-closing-comp': 'error',
+		'react/jsx-wrap-multilines': ['error', {
+			declaration: 'parens-new-line',
+			assignment: 'parens-new-line',
+			return: 'parens-new-line',
+			arrow: 'parens-new-line',
+			condition: 'parens-new-line',
+			logical: 'parens-new-line',
+			prop: 'parens-new-line',
+		}],
+		'react/jsx-first-prop-new-line': 'error',
+		'react/jsx-tag-spacing': ['error', {
+			closingSlash: 'never',
+			beforeSelfClosing: 'always',
+			afterOpening: 'never',
+			beforeClosing: 'never',
+		}],
+		'react/void-dom-elements-no-children': 'error',
+		'react/jsx-curly-brace-presence': ['error', { props: 'never', children: 'never', propElementValues: 'always' }],
+		'react/jsx-one-expression-per-line': ['error', { allow: 'single-child' }],
+		'react/button-has-type': ['error', {
+			button: true,
+			submit: true,
+			reset: false,
+		}],
+		'react/jsx-props-no-multi-spaces': 'error',
+		'react/jsx-curly-newline': 'error',
+		'react/jsx-no-useless-fragment': 'error',
+		'react/jsx-no-constructed-context-values': 'error',
+		'react/no-unstable-nested-components': 'error',
 	},
 };

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@thermarthae/eslint-config",
-  "version": "2.0.0",
+  "version": "3.0.0",
   "main": "index.cjs",
   "description": "Just a personal eslint config",
   "license": "MIT",
@@ -14,34 +14,33 @@
     "index.cjs",
     "shared.cjs"
   ],
-  "packageManager": "yarn@3.4.1",
+  "packageManager": "yarn@4.1.0+sha256.81a00df816059803e6b5148acf03ce313cad36b7f6e5af6efa040a15981a6ffb",
   "scripts": {
-    "update": "yarn set version latest",
     "pnpify": "yarn dlx @yarnpkg/sdks vscode"
   },
-  "dependencies": {
-    "eslint-config-airbnb": "^19.0.4",
-    "eslint-config-airbnb-base": "^15.0.0",
-    "eslint-config-airbnb-typescript": "^17.0.0"
+  "resolutions": {
+    "@stylistic/eslint-plugin-plus/@typescript-eslint/utils": "^7.1.0",
+    "@stylistic/eslint-plugin-ts/@typescript-eslint/utils": "^7.1.0"
   },
   "devDependencies": {
-    "@typescript-eslint/eslint-plugin": "^5.55.0",
-    "@typescript-eslint/parser": "^5.55.0",
-    "eslint": "^8.36.0",
-    "eslint-plugin-import": "^2.27.5",
-    "eslint-plugin-simple-import-sort": "^10.0.0",
-    "typescript": "^4.9.5"
+    "@stylistic/eslint-plugin": "^1.6.2",
+    "@typescript-eslint/eslint-plugin": "^7.1.0",
+    "@typescript-eslint/parser": "^7.1.0",
+    "eslint": "^8.57.0",
+    "eslint-plugin-import": "^2.29.1",
+    "eslint-plugin-simple-import-sort": "^12.0.0",
+    "typescript": "^5.3.3"
   },
   "peerDependencies": {
-    "@typescript-eslint/eslint-plugin": "^5.55.0",
-    "@typescript-eslint/parser": "^5.55.0",
-    "eslint": "^8.36.0",
-    "eslint-plugin-import": "^2.27.5",
-    "eslint-plugin-jsx-a11y": "^6.7.1",
-    "eslint-plugin-react": "^7.32.2",
+    "@stylistic/eslint-plugin": "^1.6.2",
+    "@typescript-eslint/parser": "^6.20.0 || ^7.1.0",
+    "eslint": "^8.56.0",
+    "eslint-plugin-import": "^2.29.1",
+    "eslint-plugin-jsx-a11y": "^6.8.0",
+    "eslint-plugin-react": "^7.33.2",
     "eslint-plugin-react-hooks": "^4.6.0",
-    "eslint-plugin-simple-import-sort": "^10.0.0",
-    "typescript": "^4.9.5 || ^5.0.0"
+    "eslint-plugin-simple-import-sort": "^12.0.0",
+    "typescript": "^5.3.3"
   },
   "peerDependenciesMeta": {
     "eslint-config-prettier": {
@@ -55,9 +54,6 @@
     },
     "eslint-plugin-react-hooks": {
       "optional": true
-    },
-    "eslint-plugin-simple-import-sort": {
-      "optional": true
     }
   }
 }

package/shared.cjs

@@ -1,15 +1,38 @@
+const stylistic = require('@stylistic/eslint-plugin');
+
+const customized = stylistic.configs.customize({
+	indent: 'tab',
+	semi: true,
+	jsx: false,
+	braceStyle: '1tbs',
+	quoteProps: 'as-needed',
+});
+
 module.exports = {
 	extends: [
-		'plugin:@typescript-eslint/recommended',
-		'plugin:@typescript-eslint/recommended-requiring-type-checking',
+		'eslint:recommended',
+		'plugin:@typescript-eslint/recommended-type-checked',
+		'plugin:@typescript-eslint/stylistic-type-checked',
+		'plugin:@stylistic/disable-legacy',
 	],
-	plugins: ['simple-import-sort'],
+	plugins: [
+		'@typescript-eslint',
+		'import',
+		'simple-import-sort',
+		'@stylistic',
+	],
+	parser: '@typescript-eslint/parser',
 	parserOptions: {
-		ecmaVersion: 'latest',
-		project: 'tsconfig.json',
-		warnOnUnsupportedTypeScriptVersion: false,
+		project: true,
+		sourceType: 'module',
 	},
 	overrides: [
+		{
+			files: ['*.cjs'],
+			env: {
+				node: true,
+			},
+		},
 		{
 			files: ['*.cjs', '*.js'],
 			rules: {
@@ -20,14 +43,22 @@ module.exports = {
 				'@typescript-eslint/no-var-requires': 0,
 			},
 		},
-		{
-			files: '*.d.ts',
-			rules: {
-				'import/prefer-default-export': 0,
-			},
-		},
 	],
 	rules: {
+		...customized.rules,
+		'@stylistic/arrow-parens': ['error', 'as-needed', {
+			requireForBlockBody: true,
+		}],
+		'@stylistic/linebreak-style': ['error', 'windows'],
+		'@stylistic/max-len': ['error', { code: 120 }],
+		'@stylistic/no-multiple-empty-lines': ['error', {
+			max: 3,
+			maxBOF: 0,
+			maxEOF: 1,
+		}],
+		'@stylistic/max-statements-per-line': 0,
+		'@stylistic/indent-binary-ops': 0,
+		//
 		'@typescript-eslint/array-type': ['error', {
 			default: 'array-simple',
 		}],
@@ -35,63 +66,16 @@ module.exports = {
 			assertionStyle: 'as',
 			objectLiteralTypeAssertions: 'allow-as-parameter',
 		}],
-		'@typescript-eslint/explicit-module-boundary-types': 0,
-		'@typescript-eslint/indent': ['error', 'tab'],
-		'@typescript-eslint/member-delimiter-style': ['error', {
-			multiline: {
-				delimiter: 'semi',
-				requireLast: true,
-			},
-			singleline: {
-				delimiter: 'semi',
-				requireLast: false,
-			},
-		}],
-		'@typescript-eslint/member-ordering': 'error',
-		'@typescript-eslint/no-explicit-any': 0,
+		'@typescript-eslint/consistent-type-definitions': 0,
+		'@typescript-eslint/no-unused-vars': 0,
+		'@typescript-eslint/no-empty-function': 0,
 		'@typescript-eslint/no-misused-promises': ['error', {
 			checksVoidReturn: false,
 		}],
-		'@typescript-eslint/no-non-null-assertion': 0,
-		'@typescript-eslint/no-unnecessary-type-arguments': 'error',
-		'@typescript-eslint/no-unsafe-assignment': 0, // its not very performant
-		'@typescript-eslint/prefer-optional-chain': 'error',
+		'@typescript-eslint/no-unnecessary-type-arguments': 'warn',
+		'@typescript-eslint/no-shadow': 'error',
 		'@typescript-eslint/promise-function-async': 'error',
-		'arrow-parens': ['error', 'as-needed', {
-			requireForBlockBody: true,
-		}],
-		'import/no-cycle': 0,
-		'import/no-named-as-default': 0, // its not very performant
-		'linebreak-style': ['error', 'windows'],
-		'max-len': ['error', { code: 120 }],
-		'no-console': 0,
-		'no-multiple-empty-lines': ['error', {
-			max: 3,
-			maxBOF: 0,
-			maxEOF: 1,
-		}],
-		'no-param-reassign': ['error', {
-			ignorePropertyModificationsFor: [
-				'request',
-				'reply',
-				'session',
-			],
-			props: true,
-		}],
-		'no-restricted-exports': 0,
-		'no-restricted-syntax': [
-			'error',
-			{
-				selector: 'ForInStatement',
-				message: 'for..in loops iterate over the entire prototype chain,'
-					+ ' which is virtually never what you want. Use Object.{keys,values,entries},'
-					+ ' and iterate over the resulting array.',
-			},
-		],
-		'no-tabs': 0,
-		'no-void': ['error', {
-			allowAsStatement: true,
-		}],
+		//
 		'simple-import-sort/imports': ['warn', {
 			groups: [
 				// Side effect imports.
@@ -118,8 +102,17 @@ module.exports = {
 				],
 			],
 		}],
-		yoda: ['error', 'never', {
-			exceptRange: true,
+		//
+		'no-param-reassign': ['error', {
+			ignorePropertyModificationsFor: [
+				'request',
+				'reply',
+				'session',
+				'state',
+			],
+			props: true,
 		}],
+		'no-void': ['error', { allowAsStatement: true }],
+		yoda: ['error', 'never', { exceptRange: true }],
 	},
 };