@thepalaceproject/circulation-admin 1.46.0-post.1 → 1.46.0-post.2

package/package.json

@@ -139,5 +139,5 @@
     "*.{js,jsx,ts,tsx,css,md}": "prettier --write",
     "*.{js,css,md}": "prettier --write"
   },
-  "version": "1.46.0-post.1"
+  "version": "1.46.0-post.2"
 }

package/tests/jest/components/PatronAuthServiceEditForm.test.tsx

@@ -1,5 +1,5 @@
 import * as React from "react";
-import { render, screen, waitFor } from "@testing-library/react";
+import { render, screen, waitFor, within } from "@testing-library/react";
 import userEvent from "@testing-library/user-event";
 import * as fetchMock from "fetch-mock-jest";
 import { QueryClient, QueryClientProvider } from "@tanstack/react-query";
@@ -217,8 +217,11 @@ describe("PatronAuthServiceEditForm – serialization", () => {
 
     await user.click(saveButton);
 
-    // The library should now be collapsed (indicating editLibrary was called)
+    // Saving collapses the library. Reopening it shows the rule was stored in
+    // library state, not just read from the editor.
     expect(screen.queryByRole("button", { name: /Add Rule/i })).toBeNull();
+    await user.click(screen.getByRole("button", { name: /Edit/i }));
+    expect(screen.getByLabelText(/Rule Name/i)).toHaveValue("Test Rule");
   });
 
   it("includes patron_blocking_rules in payload when adding a new library", async () => {
@@ -253,8 +256,11 @@ describe("PatronAuthServiceEditForm – serialization", () => {
 
     await user.click(addButton);
 
-    // After adding, the library should appear in the list, editor no longer in "new library" form
+    // The new-library editor is gone. Opening the added library shows the rule
+    // was stored in library state.
     expect(screen.queryByLabelText(/Rule Name/i)).toBeNull();
+    await user.click(screen.getByRole("button", { name: /Edit/i }));
+    expect(screen.getByLabelText(/Rule Name/i)).toHaveValue("New Rule");
   });
 });
 
@@ -268,8 +274,10 @@ describe("PatronAuthServiceEditForm – per-library settings", () => {
     ...servicesData,
     protocols: [protocolWithLibrarySettings, OTHER_PROTOCOL_DATA],
   };
-  const settingInput = (root: ParentNode) =>
-    root.querySelector(`input[name="${LIB_SETTING_KEY}"]`) as HTMLInputElement;
+  const settingInput = (root: HTMLElement) =>
+    within(root).getByRole("textbox", {
+      name: /Library setting/i,
+    }) as HTMLInputElement;
 
   it("keeps a library setting entered when adding a new library", async () => {
     const user = userEvent.setup();

package/tests/jest/components/ServiceEditForm.test.tsx

@@ -4,6 +4,7 @@ import { render, within } from "@testing-library/react";
 import userEvent from "@testing-library/user-event";
 
 import ServiceEditForm, {
+  libraryRefKey,
   ServiceEditFormProps,
   ServiceEditFormState,
 } from "../../../src/components/ServiceEditForm";
@@ -999,6 +1000,15 @@ describe("ServiceEditForm", () => {
       ).toBe("option3");
     });
 
+    it("builds library ref keys for add and edit mode", () => {
+      expect(libraryRefKey("key", "add")).toBe("key");
+      expect(libraryRefKey("key", "edit", "nypl")).toBe("nypl_key");
+      // Compile-time guard: ts-jest fails this file if the overloads stop
+      // rejecting an edit-mode call with no short name.
+      // @ts-expect-error edit mode must pass the library short name
+      libraryRefKey("key", "edit");
+    });
+
     it("calls save when the form is submitted", async () => {
       // The reusable Form wires submission solely through its submit button's
       // onClick, so clicking it is the only way to submit; assert the resulting