@thepalaceproject/circulation-admin 1.43.0-post.8 → 1.43.0-post.9

package/tests/jest/components/LoadButton.test.tsx

@@ -0,0 +1,49 @@
+import * as React from "react";
+import { render, screen } from "@testing-library/react";
+import userEvent from "@testing-library/user-event";
+
+import LoadButton from "../../../src/components/LoadButton";
+
+describe("LoadButton", () => {
+  it("displays 'Load more' text when not fetching", () => {
+    render(<LoadButton isFetching={false} loadMore={jest.fn()} />);
+
+    expect(
+      screen.getByRole("button", { name: "Load more" })
+    ).toBeInTheDocument();
+  });
+
+  it("renders the MoreDotsIcon only while fetching", () => {
+    const { container, rerender } = render(
+      <LoadButton isFetching={false} loadMore={jest.fn()} />
+    );
+
+    // The MoreDotsIcon is a Font Awesome-style <svg>, so query for it directly.
+    expect(container.querySelector("svg")).not.toBeInTheDocument();
+
+    rerender(<LoadButton isFetching={true} loadMore={jest.fn()} />);
+
+    expect(container.querySelector("svg")).toBeInTheDocument();
+    expect(screen.queryByText("Load more")).not.toBeInTheDocument();
+  });
+
+  it("calls loadMore when clicked", async () => {
+    const user = userEvent.setup();
+    const loadMore = jest.fn();
+    render(<LoadButton isFetching={false} loadMore={loadMore} />);
+
+    await user.click(screen.getByRole("button"));
+
+    expect(loadMore).toHaveBeenCalledTimes(1);
+  });
+
+  it("does nothing when disabled", async () => {
+    const user = userEvent.setup();
+    const loadMore = jest.fn();
+    render(<LoadButton isFetching={true} loadMore={loadMore} />);
+
+    await user.click(screen.getByRole("button"));
+
+    expect(loadMore).not.toHaveBeenCalled();
+  });
+});

package/tests/jest/components/ManagePatronsForm.test.tsx

@@ -0,0 +1,180 @@
+import * as React from "react";
+import { screen } from "@testing-library/react";
+import userEvent from "@testing-library/user-event";
+
+import { renderWithProviders } from "../testUtils/withProviders";
+import { installFormDataShim } from "../testUtils/formDataShim";
+import buildStore from "../../../src/store";
+import { ManagePatronsForm } from "../../../src/components/ManagePatronsForm";
+import { PatronData } from "../../../src/interfaces";
+
+// The reusable-components `Form` builds `new FormData(formElement)` on submit,
+// which the unit jsdom environment's undici FormData rejects; install the shared
+// shim that reads the form's successful controls.
+installFormDataShim();
+
+const patron: PatronData = {
+  authorization_expires: "",
+  username: "User Name",
+  personal_name: "Personal Name",
+  email_address: "user@email.com",
+  authorization_identifier: "1234",
+  authorization_identifiers: [""],
+  block_reason: "",
+  external_type: "",
+  fines: "",
+  permanent_id: "",
+};
+
+// `clearPatronData` is called on unmount (RTL cleanup), so it must always be a
+// function; `patronLookup` too, so the connected dispatch props are stubbed.
+const renderForm = (props: Record<string, unknown> = {}) =>
+  renderWithProviders(
+    <ManagePatronsForm
+      store={buildStore()}
+      csrfToken="token"
+      library="nypl"
+      patronLookup={jest.fn()}
+      clearPatronData={jest.fn()}
+      {...props}
+    />
+  );
+
+describe("ManagePatronsForm", () => {
+  describe("rendering", () => {
+    it("has .manage-patrons-form class", () => {
+      const { container } = renderForm();
+      expect(
+        container.querySelector(".manage-patrons-form")
+      ).toBeInTheDocument();
+    });
+
+    it("shows an editable identifier input", () => {
+      renderForm();
+      expect(
+        screen.getByPlaceholderText("Enter the patron's identifier")
+      ).toBeInTheDocument();
+      expect(screen.getByRole("textbox")).toBeInTheDocument();
+    });
+
+    it("has a form with an input field and a button", () => {
+      const { container } = renderForm();
+      expect(container.querySelectorAll("form")).toHaveLength(1);
+      expect(container.querySelectorAll("form input")).toHaveLength(1);
+      expect(container.querySelectorAll("form button")).toHaveLength(1);
+    });
+
+    it("doesn't initially show an alert or error message", () => {
+      const { container } = renderForm();
+      expect(container.querySelector(".alert")).not.toBeInTheDocument();
+      expect(screen.queryByText(/Patron found/)).not.toBeInTheDocument();
+    });
+  });
+
+  describe("behavior", () => {
+    it("calls patronLookup on submit", async () => {
+      const user = userEvent.setup();
+      const patronLookup = jest.fn();
+      renderForm({ patronLookup });
+
+      expect(patronLookup).not.toHaveBeenCalled();
+
+      await user.type(
+        screen.getByPlaceholderText("Enter the patron's identifier"),
+        "1234"
+      );
+      await user.click(screen.getByRole("button"));
+
+      expect(patronLookup).toHaveBeenCalledTimes(1);
+      // The second argument is the library short name.
+      expect(patronLookup.mock.calls[0][1]).toBe("nypl");
+    });
+
+    it("displays an error message if there is an error", () => {
+      const fetchError = { status: 400, response: "", url: "" };
+      const { container, rerender } = renderForm();
+      expect(container.querySelector(".alert-danger")).not.toBeInTheDocument();
+
+      rerender(
+        <ManagePatronsForm
+          store={buildStore()}
+          csrfToken="token"
+          library="nypl"
+          patronLookup={jest.fn()}
+          clearPatronData={jest.fn()}
+          fetchError={fetchError}
+        />
+      );
+
+      expect(container.querySelector(".alert-danger")).toBeInTheDocument();
+      expect(screen.getByText(/Error:/)).toBeInTheDocument();
+    });
+
+    it("should display a no-identifier message if the input field is blank when searching", () => {
+      const fetchError = {
+        status: 400,
+        response: "No patron identifier provided",
+        url: "",
+      };
+      const { rerender } = renderForm();
+      expect(
+        screen.queryByText("Error: No patron identifier provided")
+      ).not.toBeInTheDocument();
+
+      rerender(
+        <ManagePatronsForm
+          store={buildStore()}
+          csrfToken="token"
+          library="nypl"
+          patronLookup={jest.fn()}
+          clearPatronData={jest.fn()}
+          fetchError={fetchError}
+        />
+      );
+
+      expect(
+        screen.getByText("Error: No patron identifier provided")
+      ).toBeInTheDocument();
+    });
+
+    it("should display a success alert message when a patron is found", () => {
+      const { container, rerender } = renderForm();
+      expect(container.querySelector(".alert-success")).not.toBeInTheDocument();
+
+      rerender(
+        <ManagePatronsForm
+          store={buildStore()}
+          csrfToken="token"
+          library="nypl"
+          patronLookup={jest.fn()}
+          clearPatronData={jest.fn()}
+          patron={patron}
+        />
+      );
+
+      const alert = container.querySelector(".alert-success");
+      expect(alert).toBeInTheDocument();
+      expect(alert).toHaveTextContent(
+        `Patron found: ${patron.authorization_identifier}`
+      );
+    });
+
+    it("should show the PatronInfo list when a patron is found", () => {
+      const { container, rerender } = renderForm();
+      expect(container.querySelector(".patron-info")).not.toBeInTheDocument();
+
+      rerender(
+        <ManagePatronsForm
+          store={buildStore()}
+          csrfToken="token"
+          library="nypl"
+          patronLookup={jest.fn()}
+          clearPatronData={jest.fn()}
+          patron={patron}
+        />
+      );
+
+      expect(container.querySelector(".patron-info")).toBeInTheDocument();
+    });
+  });
+});

package/tests/jest/components/ManagePatronsTabContainer.test.tsx

@@ -0,0 +1,143 @@
+import * as React from "react";
+import * as PropTypes from "prop-types";
+import { render, screen } from "@testing-library/react";
+import userEvent from "@testing-library/user-event";
+
+import buildStore from "../../../src/store";
+import Admin from "../../../src/models/Admin";
+
+// Both tab panels fetch on mount (ResetAdobeId is a connected component; Debug
+// Authentication uses react-query). They're incidental to a tab-navigation test,
+// so mock them to markers. ResetAdobeId echoes the csrfToken asserted below.
+jest.mock("../../../src/components/ResetAdobeId", () => ({
+  __esModule: true,
+  default: (props: any) => (
+    <div data-testid="reset-adobe-id" data-csrf-token={props.csrfToken} />
+  ),
+}));
+jest.mock("../../../src/components/DebugAuthentication", () => ({
+  __esModule: true,
+  default: () => <div data-testid="debug-authentication" />,
+}));
+
+import ManagePatronsTabContainer from "../../../src/components/ManagePatronsTabContainer";
+
+// ManagePatronsTabContainer reads `admin`, `router`, and `pathFor` from the legacy
+// React context the app supplies in production. Wrap it in a small provider that
+// hands it those.
+class LegacyContextProvider extends React.Component<{ context: any }> {
+  static childContextTypes = {
+    router: PropTypes.object,
+    pathFor: PropTypes.func,
+    admin: PropTypes.object,
+  };
+  getChildContext() {
+    return this.props.context;
+  }
+  render() {
+    return this.props.children;
+  }
+}
+
+describe("ManagePatronsTabContainer", () => {
+  const systemAdmin = new Admin([{ role: "system" }]);
+  const libraryManagerNYPL = new Admin([{ role: "manager", library: "NYPL" }]);
+  const libraryManagerA = new Admin([{ role: "manager", library: "a" }]);
+  const librarian = new Admin([{ role: "librarian", library: "NYPL" }]);
+
+  const renderWithAdmin = (admin: Admin, push: jest.Mock = jest.fn()) => {
+    const context = { router: { push }, pathFor: jest.fn(), admin };
+    const result = render(
+      <LegacyContextProvider context={context}>
+        <ManagePatronsTabContainer
+          tab={null}
+          csrfToken="token"
+          store={buildStore()}
+          library="NYPL"
+        />
+      </LegacyContextProvider>
+    );
+    return { ...result, push };
+  };
+
+  describe("for system admin", () => {
+    it("shows tabs", () => {
+      renderWithAdmin(systemAdmin);
+      expect(
+        screen.getByRole("link", { name: "Reset Adobe ID" })
+      ).toBeInTheDocument();
+      expect(
+        screen.getByRole("link", { name: "Debug Authentication" })
+      ).toBeInTheDocument();
+    });
+
+    it("shows components", () => {
+      renderWithAdmin(systemAdmin);
+      expect(screen.getByTestId("reset-adobe-id")).toHaveAttribute(
+        "data-csrf-token",
+        "token"
+      );
+    });
+
+    it("uses router to navigate when tab is clicked", async () => {
+      const user = userEvent.setup();
+      const { push } = renderWithAdmin(systemAdmin);
+      await user.click(screen.getByRole("link", { name: "Reset Adobe ID" }));
+      expect(push).toHaveBeenCalledTimes(1);
+      expect(push).toHaveBeenCalledWith("/admin/web/patrons/NYPL/resetAdobeId");
+    });
+  });
+
+  describe("for right library manager", () => {
+    it("shows tabs", () => {
+      renderWithAdmin(libraryManagerNYPL);
+      expect(
+        screen.getByRole("link", { name: "Reset Adobe ID" })
+      ).toBeInTheDocument();
+      expect(
+        screen.getByRole("link", { name: "Debug Authentication" })
+      ).toBeInTheDocument();
+    });
+
+    it("marks the current tab as active", () => {
+      const { container } = renderWithAdmin(libraryManagerNYPL);
+      const tabItems = container.querySelectorAll("ul.nav-tabs li");
+      expect(tabItems).toHaveLength(2);
+      expect(tabItems[0]).toHaveClass("active");
+    });
+
+    it("shows components", () => {
+      renderWithAdmin(libraryManagerNYPL);
+      expect(screen.getByTestId("reset-adobe-id")).toHaveAttribute(
+        "data-csrf-token",
+        "token"
+      );
+    });
+
+    it("uses router to navigate when tab is clicked", async () => {
+      const user = userEvent.setup();
+      const { push } = renderWithAdmin(libraryManagerNYPL);
+      await user.click(screen.getByRole("link", { name: "Reset Adobe ID" }));
+      expect(push).toHaveBeenCalledTimes(1);
+      expect(push).toHaveBeenCalledWith("/admin/web/patrons/NYPL/resetAdobeId");
+    });
+  });
+
+  describe("for wrong library manager", () => {
+    it("doesn't show tabs", () => {
+      renderWithAdmin(libraryManagerA);
+      expect(
+        screen.queryByRole("link", { name: "Reset Adobe ID" })
+      ).not.toBeInTheDocument();
+    });
+  });
+
+  describe("for librarian", () => {
+    it("doesn't show tabs", () => {
+      renderWithAdmin(librarian);
+      expect(
+        screen.queryByRole("link", { name: "Reset Adobe ID" })
+      ).not.toBeInTheDocument();
+    });
+  });
+});

package/tests/jest/components/MetadataServices.test.tsx

@@ -0,0 +1,59 @@
+import * as React from "react";
+import { screen, within } from "@testing-library/react";
+import { MetadataServices } from "../../../src/components/MetadataServices";
+import renderWithContext from "../testUtils/renderWithContext";
+import { defaultFeatureFlags } from "../../../src/utils/featureFlags";
+
+describe("MetadataServices", () => {
+  const data = {
+    metadata_services: [
+      {
+        id: 2,
+        protocol: "test protocol",
+        name: "sample name",
+        settings: {
+          test_setting: "test setting",
+        },
+        libraries: [{ short_name: "nypl" }],
+      },
+    ],
+    protocols: [
+      {
+        name: "test protocol",
+        label: "test protocol label",
+        sitewide: false,
+        settings: [],
+      },
+    ],
+    allLibraries: [
+      {
+        short_name: "nypl",
+      },
+    ],
+  };
+
+  const config = { csrfToken: "token", featureFlags: defaultFeatureFlags };
+
+  it("shows metadata service list", () => {
+    renderWithContext(
+      <MetadataServices
+        data={data}
+        fetchData={jest.fn()}
+        editItem={jest.fn().mockResolvedValue(undefined)}
+        csrfToken="token"
+        isFetching={false}
+      />,
+      config
+    );
+
+    const items = screen.getAllByRole("listitem");
+    expect(items).toHaveLength(1);
+    expect(items[0]).toHaveTextContent("sample name: test protocol");
+
+    const editLink = within(items[0]).getByRole("link");
+    expect(editLink).toHaveAttribute(
+      "href",
+      "/admin/web/config/metadata/edit/2"
+    );
+  });
+});

package/tests/jest/components/SelfTestResult.test.tsx

@@ -0,0 +1,164 @@
+import * as React from "react";
+import { render, screen } from "@testing-library/react";
+
+import SelfTestResult from "../../../src/components/SelfTestResult";
+import { SelfTestsResult } from "../../../src/interfaces";
+
+const stringResult: SelfTestsResult = {
+  duration: 0,
+  end: "",
+  name: "Test Result",
+  result: "abc",
+  start: "",
+  success: true,
+};
+
+describe("SelfTestResult", () => {
+  it("displays a result with a string", () => {
+    const { container } = render(
+      <SelfTestResult result={stringResult} isFetching={false} />
+    );
+
+    expect(container.querySelector("li")).toHaveClass("success");
+
+    expect(screen.getByRole("heading", { level: 4 })).toHaveTextContent(
+      "Test Result"
+    );
+
+    const testResult = container.querySelector("pre");
+    expect(testResult).toHaveClass("result-description");
+    expect(testResult).toHaveTextContent("abc");
+
+    expect(screen.getByText("success: true")).toHaveClass(
+      "success-description"
+    );
+
+    // A single-line string result is not shown in a collapsible panel.
+    expect(container.querySelector(".panel")).not.toBeInTheDocument();
+  });
+
+  it("displays a result with a multi-line string", () => {
+    const longStringResult: SelfTestsResult = {
+      ...stringResult,
+      result: "abc \n def",
+    };
+    const { container } = render(
+      <SelfTestResult result={longStringResult} isFetching={false} />
+    );
+
+    const panel = container.querySelector(".panel");
+    expect(panel).toBeInTheDocument();
+    expect(panel).toHaveClass("panel-success");
+    expect(screen.getByText("Results")).toBeInTheDocument();
+
+    expect(container.querySelector("pre")?.textContent).toBe("abc \n def");
+  });
+
+  it("displays a result with an array", () => {
+    const arrayResult: SelfTestsResult = {
+      ...stringResult,
+      result: ["Thing 1", "Thing 2"],
+    };
+    const { container } = render(
+      <SelfTestResult result={arrayResult} isFetching={false} />
+    );
+
+    const panel = container.querySelector(".panel");
+    expect(panel).toBeInTheDocument();
+    expect(panel).toHaveClass("panel-success");
+    expect(screen.getByText("Results (2)")).toBeInTheDocument();
+
+    const items = container.querySelectorAll("ol li");
+    expect(items).toHaveLength(2);
+    expect(items[0]).toHaveTextContent("Thing 1");
+    expect(items[1]).toHaveTextContent("Thing 2");
+  });
+
+  it("displays a result with an empty array", () => {
+    const emptyArrayResult: SelfTestsResult = { ...stringResult, result: [] };
+    const { container } = render(
+      <SelfTestResult result={emptyArrayResult} isFetching={false} />
+    );
+
+    expect(container.querySelector(".panel")).not.toBeInTheDocument();
+    expect(
+      screen.getByText("The test ran successfully, but no results were found.")
+    ).toHaveClass("warning");
+  });
+
+  it("displays a result with an exception", () => {
+    const exceptionResult: SelfTestsResult = {
+      ...stringResult,
+      success: false,
+      exception: { class: "IntegrationException", message: "Problem!" },
+    };
+    const { container } = render(
+      <SelfTestResult result={exceptionResult} isFetching={false} />
+    );
+
+    expect(container.querySelector("li")).toHaveClass("failure");
+    expect(screen.getByText("success: false")).toHaveClass(
+      "success-description"
+    );
+    expect(screen.getByText("exception: Problem!")).toHaveClass(
+      "exception-description"
+    );
+  });
+
+  it("displays debug_message when present", () => {
+    const exceptionResult: SelfTestsResult = {
+      ...stringResult,
+      success: false,
+      exception: {
+        class: "IntegrationException",
+        debug_message: "debug message...",
+        message: "Problem!",
+      },
+    };
+    render(<SelfTestResult result={exceptionResult} isFetching={false} />);
+
+    expect(screen.getByText("debug: debug message...")).toHaveClass(
+      "debug-description"
+    );
+  });
+
+  it("does not display debug_message when it is empty", () => {
+    const exceptionResult: SelfTestsResult = {
+      ...stringResult,
+      success: false,
+      exception: {
+        class: "IntegrationException",
+        debug_message: "",
+        message: "Problem!",
+      },
+    };
+    const { container } = render(
+      <SelfTestResult result={exceptionResult} isFetching={false} />
+    );
+
+    expect(
+      container.querySelector(".exception-description")
+    ).toBeInTheDocument();
+    expect(
+      container.querySelector(".debug-description")
+    ).not.toBeInTheDocument();
+  });
+
+  it("does not display debug_message when it is absent", () => {
+    const exceptionResult: SelfTestsResult = {
+      ...stringResult,
+      success: false,
+      exception: { class: "IntegrationException", message: "Problem!" },
+    };
+    const { container } = render(
+      <SelfTestResult result={exceptionResult} isFetching={false} />
+    );
+
+    expect(
+      container.querySelector(".exception-description")
+    ).toBeInTheDocument();
+    expect(
+      container.querySelector(".debug-description")
+    ).not.toBeInTheDocument();
+  });
+});