@thepalaceproject/circulation-admin 1.43.0-post.2 → 1.43.0-post.4

package/jest.config.js

@@ -1,31 +1,63 @@
 /** @type {import('ts-jest').JestConfigWithTsJest} */
-module.exports = {
+
+// Options shared by both projects.
+const sharedProjectConfig = {
+  preset: "ts-jest",
+  testEnvironmentOptions: {
+    // Without this, jsdom's default `["browser"]` export condition resolves sinon
+    // to its ESM bundle, which ts-jest does not transform. Every legacy suite then
+    // dies with `SyntaxError: Unexpected token 'export'`.
+    customExportConditions: [""],
+  },
+  setupFiles: ["<rootDir>/jest.polyfills.js"],
   moduleNameMapper: {
     "\\.(jpg|jpeg|png|gif|eot|otf|webp|svg|ttf|woff|woff2|mp4|webm|wav|mp3|m4a|aac|oga)$":
       "<rootDir>/tests/__mocks__/fileMock.js",
-    "\\.(css|less)$": "<rootDir>/tests/__mocks__/styleMock.js",
+    "\\.(css|less|scss|sass)$": "<rootDir>/tests/__mocks__/styleMock.js",
     "\\.md$": "<rootDir>/tests/__mocks__/fileMock.js",
   },
-  preset: "ts-jest",
-  testEnvironment: "jest-fixed-jsdom",
-  testEnvironmentOptions: {
-    customExportConditions: [""],
-  },
-  setupFiles: ["./jest.polyfills.js"],
-  setupFilesAfterEnv: ["./tests/jest/jest-setup.ts"],
   // `src` must stay in `roots` so that `collectCoverageFrom` can discover source
-  // files that no jest test imports — otherwise they are silently omitted from
-  // the report rather than counted as uncovered. `testMatch` (not `--roots`) is
-  // therefore what keeps jest from picking up the legacy mocha tests that live
-  // in `src/**/__tests__/`.
-  roots: ["<rootDir>/src", "<rootDir>/tests/jest"],
-  testMatch: ["<rootDir>/tests/jest/**/*.test.{js,jsx,ts,tsx}"],
+  // files that no test imports — otherwise they are silently omitted from the
+  // report rather than counted as uncovered, and the coverage percentage rises
+  // while real coverage is unchanged.
+  roots: ["<rootDir>/src"],
+};
+
+module.exports = {
   coverageDirectory: "coverage/jest",
   coverageReporters: ["lcov", "text-summary"],
+  // Must live at the top level, not inside `projects`: jest reads
+  // `collectCoverageFrom` off the *global* config. Set it only per-project and it
+  // is silently undefined globally, so every executed file gets instrumented —
+  // including test helpers and everything under `tests/`.
   collectCoverageFrom: [
     "src/**/*.{ts,tsx}",
     "!src/**/__tests__/**",
-    "!src/testHelper.ts",
     "!src/**/*.d.ts",
   ],
+  projects: [
+    {
+      ...sharedProjectConfig,
+      displayName: "unit",
+      roots: [...sharedProjectConfig.roots, "<rootDir>/tests/jest"],
+      testMatch: ["<rootDir>/tests/jest/**/*.test.{js,jsx,ts,tsx}"],
+      // `jest-fixed-jsdom` restores Node's fetch/Response globals so MSW can
+      // intercept them.
+      testEnvironment: "jest-fixed-jsdom",
+      setupFilesAfterEnv: ["<rootDir>/tests/jest/jest-setup.ts"],
+    },
+    {
+      // Legacy enzyme + chai + sinon tests, still in `src/**/__tests__/`. They are
+      // being rewritten as React Testing Library tests under `tests/jest/`; when the
+      // last one is gone, delete this project, its environment, and its setup file.
+      //
+      // These cannot use `jest-fixed-jsdom`: it swaps in undici's `FormData`, which
+      // rejects `new FormData(formElement)` and crashes any test that submits a form.
+      ...sharedProjectConfig,
+      displayName: "legacy",
+      testMatch: ["<rootDir>/src/**/__tests__/*-test.{ts,tsx}"],
+      testEnvironment: "<rootDir>/tests/jest/legacyJsdomEnvironment.js",
+      setupFilesAfterEnv: ["<rootDir>/tests/jest/legacy-setup.ts"],
+    },
+  ],
 };

package/package.json

@@ -17,20 +17,14 @@
     "prepublish": "npm run prod",
     "lint": "npm run lint:js && sass-lint -c .sass-lint.yml -v -q",
     "lint:js": "eslint . --max-warnings 0",
-    "test-js": "tsc && cp -r src/stylesheets lib && cp -r src/images lib && mocha --require lib/testHelper.js lib/__tests__/*.js lib/**/__tests__/*.js lib/**/**/__tests__/*.js",
-    "test-js-file": "tsc && cp -r src/stylesheets lib && cp -r src/images lib && mocha --require lib/testHelper.js",
-    "test-js-list": "mocha --require lib/testHelper.js lib/__tests__/*.js lib/**/__tests__/*.js lib/**/**/__tests__/*.js --reporter ./testReporter.js",
-    "test-ts": "mocha -r ts-node/register --require src/testHelper.ts src/__tests__/*.ts* src/**/__tests__/*.ts* src/**/**/__tests__/*.ts*",
-    "test-file-ts": "mocha -r ts-node/register --require src/testHelper.ts",
-    "test": "npm run test-ts && npm run test-jest",
-    "test-file": "npm run test-file-ts",
+    "test": "npm run test-jest",
+    "test-file": "npm run test-jest-file",
     "test-browser": "npm run test-chrome && npm run test-firefox",
     "test-chrome": "node_modules/.bin/selenium-standalone install && nightwatch -e chrome",
     "test-firefox": "node_modules/.bin/selenium-standalone install && nightwatch -e firefox",
     "test-jest": "jest --verbose",
     "test-jest-file": "jest --verbose",
-    "coverage": "npm run coverage-ts && npm run coverage-jest",
-    "coverage-ts": "nyc npm run test-ts",
+    "coverage": "npm run coverage-jest",
     "coverage-jest": "npm run test-jest -- --coverage",
     "dev": "webpack --watch --progress --config webpack.dev.config",
     "dev-server": "dotenv -c -- webpack serve --progress --hot --config webpack.dev-server.config",
@@ -81,7 +75,6 @@
     "@testing-library/react-hooks": "^8.0.1",
     "@testing-library/user-event": "^14.4.3",
     "@types/jest": "^29.2.6",
-    "@types/mocha": "^10.0.1",
     "@types/node": "^25.9.3",
     "@types/numeral": "^2.0.5",
     "@types/prop-types": "^15.7.3",
@@ -93,7 +86,6 @@
     "@types/redux-mock-store": "^1.0.3",
     "chai": "4.2.0",
     "clean-webpack-plugin": "^2.0.1",
-    "colors-cli": "^1.0.27",
     "copy-webpack-plugin": "14.0.0",
     "css-loader": "^7.1.4",
     "dotenv-cli": "^11.0.0",
@@ -114,18 +106,14 @@
     "jest": "^29.3.1",
     "jest-environment-jsdom": "^30.4.1",
     "jest-fixed-jsdom": "^0.0.11",
-    "jsdom": "^29.1.1",
     "json-loader": "^0.5.4",
     "lint-staged": "^17.0.7",
     "marked": "^18.0.5",
     "mini-css-extract-plugin": "1.6.0",
-    "mocha": "^11.7.6",
     "msw": "^2.7.3",
     "nightwatch": "^3.14.0",
-    "nyc": "^17.1.0",
     "prettier": "3.8.4",
     "react-axe": "^3.3.0",
-    "react-test-renderer": "^16.14.0",
     "redux-mock-store": "^1.5.4",
     "resize-observer-polyfill": "^1.5.1",
     "sass": "^1.64.2",
@@ -137,7 +125,6 @@
     "terser-webpack-plugin": "^5.3.6",
     "ts-jest": "^29.2.6",
     "ts-loader": "^9.5.2",
-    "ts-node": "^10.9.2",
     "typedoc": "^0.28.19",
     "typescript": "^5.7.3",
     "typescript-eslint": "^8.60.1",
@@ -157,5 +144,5 @@
     "*.{js,jsx,ts,tsx,css,md}": "prettier --write",
     "*.{js,css,md}": "prettier --write"
   },
-  "version": "1.43.0-post.2"
+  "version": "1.43.0-post.4"
 }

package/tests/jest/editorAdapter.test.ts

@@ -0,0 +1,245 @@
+import adapter from "../../src/editorAdapter";
+import {
+  OPDSEntry,
+  Contributor,
+  Series,
+  Category,
+  Summary,
+} from "opds-feed-parser";
+
+describe("editorAdapter", () => {
+  it("adapts valid OPDS entry", () => {
+    const entry = new OPDSEntry({
+      id: "id",
+      updated: "updated",
+      title: "title",
+      authors: [new Contributor({ name: "name", uri: "uri", role: "role" })],
+      subtitle: "subtitle",
+      contributors: [
+        new Contributor({ name: "name2", uri: "uri2", role: "role2" }),
+      ],
+      series: new Series({ name: "series", position: 2 }),
+      categories: [
+        new Category({ term: "term", scheme: "scheme", label: "label" }),
+        new Category({
+          term: "13-16",
+          scheme: "http://schema.org/typicalAgeRange",
+          label: "age",
+        }),
+        new Category({
+          term: "ya",
+          scheme: "http://schema.org/audience",
+          label: "ya",
+        }),
+        new Category({
+          term: "fiction",
+          scheme: "http://librarysimplified.org/terms/fiction/",
+          label: "Fiction",
+        }),
+      ],
+      identifiers: [],
+      links: [
+        {
+          href: "hide",
+          rel: "http://librarysimplified.org/terms/rel/hide",
+          type: "type",
+          title: "title",
+          role: "role",
+        },
+        {
+          href: "restore",
+          rel: "http://librarysimplified.org/terms/rel/restore",
+          type: "type",
+          title: "title",
+          role: "role",
+        },
+        {
+          href: "refresh",
+          rel: "http://librarysimplified.org/terms/rel/refresh",
+          type: "type",
+          title: "title",
+          role: "role",
+        },
+        {
+          href: "edit",
+          rel: "edit",
+          type: "type",
+          title: "title",
+          role: "role",
+        },
+        {
+          href: "issues",
+          rel: "issues",
+          type: "type",
+          title: "title",
+          role: "role",
+        },
+        {
+          href: "change-cover",
+          rel: "http://librarysimplified.org/terms/rel/change_cover",
+          type: "type",
+          title: "title",
+          role: "role",
+        },
+        {
+          href: "cover",
+          rel: "http://opds-spec.org/image",
+          type: "image/png",
+          title: "title",
+          role: "role",
+        },
+      ],
+      issued: "issued",
+      language: "language",
+      rights: "rights",
+      publisher: "publisher",
+      published: "published",
+      summary: new Summary({ content: "content", link: "link" }),
+      unparsed: {
+        "schema:alternativeHeadline": [{ _: "subtitle" }],
+        $: {
+          "schema:additionalType": { value: "medium" },
+        },
+        "bib:publisherImprint": [{ _: "imprint" }],
+        "schema:Rating": [
+          {
+            $: {
+              "schema:ratingValue": { value: "0.3" },
+              "schema:additionalType": {
+                value: "http://librarysimplified.org/terms/rel/quality",
+              },
+            },
+          },
+          {
+            $: {
+              "schema:ratingValue": { value: "4" },
+              "schema:additionalType": {
+                value: "http://schema.org/ratingValue",
+              },
+            },
+          },
+        ],
+      },
+    });
+
+    const adapted = adapter(entry);
+    expect(adapted.title).toBe("title");
+    expect(adapted.authors).toStrictEqual([
+      { name: "name", uri: "uri", role: "aut" },
+    ]);
+    // The adapter flattens `Contributor` instances into plain objects, so assert
+    // the shape it produces rather than comparing against `entry.contributors`.
+    expect(adapted.contributors).toStrictEqual([
+      { name: "name2", uri: "uri2", role: "role2" },
+    ]);
+    expect(adapted.subtitle).toBe("subtitle");
+    expect(adapted.summary).toBe("content");
+    expect(adapted.audience).toBe("ya");
+    expect(adapted.targetAgeRange).toStrictEqual(["13", "16"]);
+    expect(adapted.fiction).toBe(true);
+    expect(adapted.categories).toStrictEqual(["label", "age", "ya", "Fiction"]);
+    expect(adapted.hideLink).toStrictEqual(entry.links[0]);
+    expect(adapted.restoreLink).toStrictEqual(entry.links[1]);
+    expect(adapted.refreshLink).toStrictEqual(entry.links[2]);
+    expect(adapted.editLink).toStrictEqual(entry.links[3]);
+    expect(adapted.issuesLink).toStrictEqual(entry.links[4]);
+    expect(adapted.changeCoverLink).toStrictEqual(entry.links[5]);
+    expect(adapted.coverUrl).toBe(entry.links[6].href);
+    expect(adapted.series).toBe("series");
+    expect(adapted.seriesPosition).toBe(2);
+    expect(adapted.medium).toBe("medium");
+    expect(adapted.language).toBe("language");
+    expect(adapted.publisher).toBe("publisher");
+    expect(adapted.imprint).toBe("imprint");
+    expect(adapted.issued).toBe("issued");
+    expect(adapted.rating).toBe("4");
+  });
+
+  it("adapts visibility status from categories", () => {
+    const entry = new OPDSEntry({
+      id: "id",
+      updated: "updated",
+      title: "title",
+      subtitle: "subtitle",
+      authors: [],
+      contributors: [],
+      series: new Series({ name: "series", position: 2 }),
+      categories: [
+        new Category({ term: "term", scheme: "scheme", label: "label" }),
+        new Category({
+          term: "manually-suppressed",
+          scheme: "http://palaceproject.io/terms/visibility-status",
+          label: "Manually Suppressed",
+        }),
+      ],
+      identifiers: [],
+      links: [],
+      issued: "issued",
+      language: "language",
+      rights: "rights",
+      publisher: "publisher",
+      published: "published",
+      summary: new Summary({ content: "content", link: "link" }),
+      unparsed: {},
+    });
+
+    const adapted = adapter(entry);
+    expect(adapted.visibilityStatus).toBe("manually-suppressed");
+  });
+
+  it("adapts policy-filtered visibility status", () => {
+    const entry = new OPDSEntry({
+      id: "id",
+      updated: "updated",
+      title: "title",
+      subtitle: "subtitle",
+      authors: [],
+      contributors: [],
+      series: new Series({ name: "series", position: 2 }),
+      categories: [
+        new Category({
+          term: "policy-filtered",
+          scheme: "http://palaceproject.io/terms/visibility-status",
+          label: "Policy Filtered",
+        }),
+      ],
+      identifiers: [],
+      links: [],
+      issued: "issued",
+      language: "language",
+      rights: "rights",
+      publisher: "publisher",
+      published: "published",
+      summary: new Summary({ content: "content", link: "link" }),
+      unparsed: {},
+    });
+
+    const adapted = adapter(entry);
+    expect(adapted.visibilityStatus).toBe("policy-filtered");
+  });
+
+  it("doesn't crash when expected data is missing", () => {
+    const entry = new OPDSEntry({
+      id: "id",
+      updated: "updated",
+      title: "title",
+      subtitle: "subtitle",
+      authors: [],
+      contributors: [],
+      series: new Series({ name: "series", position: 2 }),
+      categories: [],
+      identifiers: [],
+      links: [],
+      issued: "issued",
+      language: "language",
+      rights: "rights",
+      publisher: "publisher",
+      published: "published",
+      summary: new Summary({ content: "content", link: "link" }),
+      unparsed: {},
+    });
+
+    const adapted = adapter(entry);
+    expect(adapted.title).toBe("title");
+  });
+});

package/tests/jest/legacy-setup.ts

@@ -0,0 +1,13 @@
+import { configure } from "enzyme";
+import * as Adapter from "enzyme-adapter-react-16";
+
+// Setup for the legacy enzyme + chai + sinon tests under `src/**/__tests__/`.
+// Replaces what `src/testHelper.ts` did for mocha. Delete alongside the last
+// enzyme test.
+
+configure({ adapter: new Adapter() });
+
+// Unhandled promise rejections are tolerated for these tests — see the comment in
+// `legacyJsdomEnvironment.js`. It cannot be done from here: jest hands test code a
+// *copy* of `process`, so a listener registered in this file never reaches the real
+// one that Node checks before throwing.

package/tests/jest/legacyJsdomEnvironment.js

@@ -0,0 +1,49 @@
+"use strict";
+
+const JSDOMEnvironment = require("jest-environment-jsdom").default;
+
+const warnUnhandledRejection = (reason) => {
+  console.warn("Unhandled promise rejection in a legacy test:", reason);
+};
+
+/**
+ * jsdom environment for the legacy enzyme tests. Delete it with the last one.
+ *
+ * Two things it restores that `src/testHelper.ts` used to provide under mocha:
+ *
+ * 1. `global.jsdom`. A handful of tests call `global.jsdom.reconfigure({ url })` to
+ *    change the page origin mid-test. `history.replaceState` is not a substitute —
+ *    they navigate across origins (`http://example.com`), which it cannot do.
+ *
+ * 2. Tolerance for unhandled promise rejections. Several suites stub a `fetch` that
+ *    rejects, and nothing awaits the result; the rejection surfaces after the test
+ *    has already passed. Mocha shrugged those off because its runner keeps an
+ *    `unhandledRejection` listener installed, and Node only throws when there are
+ *    none. Under jest they kill the worker and take the whole suite with them.
+ *
+ *    Re-arming has to happen on the `teardown` event, not in the constructor.
+ *    `jest-circus/globalErrorHandlers` reads `process.listeners()` off the sandbox's
+ *    *copied* `process` (always empty) but calls `removeAllListeners()` on the real
+ *    one. So any listener registered earlier is dropped at `setup` and "restored"
+ *    from an empty list, leaving zero listeners during the post-run window where
+ *    these rejections actually land.
+ *
+ *    Scoping this to the legacy environment keeps the modern `tests/jest/` suite
+ *    strict: jest clears listeners at each file's `setup`, and nothing re-arms one
+ *    for a project that does not use this environment.
+ */
+module.exports = class LegacyJSDOMEnvironment extends JSDOMEnvironment {
+  constructor(config, context) {
+    super(config, context);
+    this.global.jsdom = this.dom;
+  }
+
+  handleTestEvent(event) {
+    if (
+      event.name === "teardown" &&
+      process.listenerCount("unhandledRejection") === 0
+    ) {
+      process.on("unhandledRejection", warnUnhandledRejection);
+    }
+  }
+};

package/tests/jest/models/Admin.test.ts

@@ -0,0 +1,206 @@
+import Admin from "../../../src/models/Admin";
+
+describe("Admin", () => {
+  const systemAdmin = new Admin([{ role: "system" }]);
+  const sitewideLibraryManager = new Admin([{ role: "manager-all" }]);
+  const sitewideLibrarian = new Admin([{ role: "librarian-all" }]);
+  const libraryManagerA = new Admin([{ role: "manager", library: "a" }]);
+  const librarianA = new Admin([{ role: "librarian", library: "a" }]);
+  const libraryManagerB = new Admin([{ role: "manager", library: "b" }]);
+  const librarianB = new Admin([{ role: "librarian", library: "b" }]);
+  const libraryManagerASitewideLibrarian = new Admin([
+    { role: "librarian-all" },
+    { role: "manager", library: "a" },
+  ]);
+  const libraryManagerALibrarianB = new Admin([
+    { role: "manager", library: "a" },
+    { role: "librarian", library: "b" },
+  ]);
+
+  it("stores email", () => {
+    expect(new Admin([], "email").email).toBe("email");
+    expect(new Admin([]).email).toBeFalsy();
+  });
+
+  it("identifies system admins", () => {
+    expect(systemAdmin.isSystemAdmin()).toBeTruthy();
+    expect(sitewideLibraryManager.isSystemAdmin()).toBeFalsy();
+    expect(sitewideLibrarian.isSystemAdmin()).toBeFalsy();
+    expect(libraryManagerA.isSystemAdmin()).toBeFalsy();
+    expect(librarianA.isSystemAdmin()).toBeFalsy();
+    expect(libraryManagerB.isSystemAdmin()).toBeFalsy();
+    expect(librarianB.isSystemAdmin()).toBeFalsy();
+    expect(libraryManagerASitewideLibrarian.isSystemAdmin()).toBeFalsy();
+    expect(libraryManagerALibrarianB.isSystemAdmin()).toBeFalsy();
+  });
+
+  it("identifies sitewide library managers", () => {
+    expect(systemAdmin.isSitewideLibraryManager()).toBeTruthy();
+    expect(sitewideLibraryManager.isSitewideLibraryManager()).toBeTruthy();
+    expect(sitewideLibrarian.isSitewideLibraryManager()).toBeFalsy();
+    expect(libraryManagerA.isSitewideLibraryManager()).toBeFalsy();
+    expect(librarianA.isSitewideLibraryManager()).toBeFalsy();
+    expect(libraryManagerB.isSitewideLibraryManager()).toBeFalsy();
+    expect(librarianB.isSitewideLibraryManager()).toBeFalsy();
+    expect(
+      libraryManagerASitewideLibrarian.isSitewideLibraryManager()
+    ).toBeFalsy();
+    expect(libraryManagerALibrarianB.isSitewideLibraryManager()).toBeFalsy();
+  });
+
+  it("identifies sitewide librarians", () => {
+    expect(systemAdmin.isSitewideLibrarian()).toBeTruthy();
+    expect(sitewideLibraryManager.isSitewideLibrarian()).toBeTruthy();
+    expect(sitewideLibrarian.isSitewideLibrarian()).toBeTruthy();
+    expect(libraryManagerA.isSitewideLibrarian()).toBeFalsy();
+    expect(librarianA.isSitewideLibrarian()).toBeFalsy();
+    expect(libraryManagerB.isSitewideLibrarian()).toBeFalsy();
+    expect(librarianB.isSitewideLibrarian()).toBeFalsy();
+    expect(libraryManagerASitewideLibrarian.isSitewideLibrarian()).toBeTruthy();
+    expect(libraryManagerALibrarianB.isSitewideLibrarian()).toBeFalsy();
+  });
+
+  it("identifies library managers", () => {
+    expect(systemAdmin.isLibraryManager("a")).toBeTruthy();
+    expect(sitewideLibraryManager.isLibraryManager("a")).toBeTruthy();
+    expect(sitewideLibrarian.isLibraryManager("a")).toBeFalsy();
+    expect(libraryManagerA.isLibraryManager("a")).toBeTruthy();
+    expect(librarianA.isLibraryManager("a")).toBeFalsy();
+    expect(libraryManagerB.isLibraryManager("a")).toBeFalsy();
+    expect(librarianB.isLibraryManager("a")).toBeFalsy();
+    expect(libraryManagerASitewideLibrarian.isLibraryManager("a")).toBeTruthy();
+    expect(libraryManagerALibrarianB.isLibraryManager("a")).toBeTruthy();
+
+    expect(systemAdmin.isLibraryManager("b")).toBeTruthy();
+    expect(sitewideLibraryManager.isLibraryManager("b")).toBeTruthy();
+    expect(sitewideLibrarian.isLibraryManager("b")).toBeFalsy();
+    expect(libraryManagerA.isLibraryManager("b")).toBeFalsy();
+    expect(librarianA.isLibraryManager("b")).toBeFalsy();
+    expect(libraryManagerB.isLibraryManager("b")).toBeTruthy();
+    expect(librarianB.isLibraryManager("b")).toBeFalsy();
+    expect(libraryManagerASitewideLibrarian.isLibraryManager("b")).toBeFalsy();
+    expect(libraryManagerALibrarianB.isLibraryManager("b")).toBeFalsy();
+  });
+
+  it("identifies librarians", () => {
+    expect(systemAdmin.isLibrarian("a")).toBeTruthy();
+    expect(sitewideLibraryManager.isLibrarian("a")).toBeTruthy();
+    expect(sitewideLibrarian.isLibrarian("a")).toBeTruthy();
+    expect(libraryManagerA.isLibrarian("a")).toBeTruthy();
+    expect(librarianA.isLibrarian("a")).toBeTruthy();
+    expect(libraryManagerB.isLibrarian("a")).toBeFalsy();
+    expect(librarianB.isLibrarian("a")).toBeFalsy();
+    expect(libraryManagerASitewideLibrarian.isLibrarian("a")).toBeTruthy();
+    expect(libraryManagerALibrarianB.isLibrarian("a")).toBeTruthy();
+
+    expect(systemAdmin.isLibrarian("b")).toBeTruthy();
+    expect(sitewideLibraryManager.isLibrarian("b")).toBeTruthy();
+    expect(sitewideLibrarian.isLibrarian("b")).toBeTruthy();
+    expect(libraryManagerA.isLibrarian("b")).toBeFalsy();
+    expect(librarianA.isLibrarian("b")).toBeFalsy();
+    expect(libraryManagerB.isLibrarian("b")).toBeTruthy();
+    expect(librarianB.isLibrarian("b")).toBeTruthy();
+    expect(libraryManagerASitewideLibrarian.isLibrarian("b")).toBeTruthy();
+    expect(libraryManagerALibrarianB.isLibrarian("b")).toBeTruthy();
+  });
+
+  it("identifies all library managers", () => {
+    expect(systemAdmin.isLibraryManagerOfSomeLibrary()).toBeTruthy();
+    expect(sitewideLibraryManager.isLibraryManagerOfSomeLibrary()).toBeTruthy();
+    expect(sitewideLibrarian.isLibraryManagerOfSomeLibrary()).toBeFalsy();
+    expect(libraryManagerA.isLibraryManagerOfSomeLibrary()).toBeTruthy();
+    expect(librarianA.isLibraryManagerOfSomeLibrary()).toBeFalsy();
+    expect(libraryManagerB.isLibraryManagerOfSomeLibrary()).toBeTruthy();
+    expect(librarianB.isLibraryManagerOfSomeLibrary()).toBeFalsy();
+    expect(
+      libraryManagerASitewideLibrarian.isLibraryManagerOfSomeLibrary()
+    ).toBeTruthy();
+    expect(
+      libraryManagerALibrarianB.isLibraryManagerOfSomeLibrary()
+    ).toBeTruthy();
+  });
+
+  it("checks for specific roles", () => {
+    expect(systemAdmin.hasRole("system")).toBeTruthy();
+    expect(systemAdmin.hasRole("manager-all")).toBeTruthy();
+    expect(systemAdmin.hasRole("librarian-all")).toBeTruthy();
+    expect(systemAdmin.hasRole("manager", "a")).toBeTruthy();
+    expect(systemAdmin.hasRole("librarian", "a")).toBeTruthy();
+    expect(systemAdmin.hasRole("manager", "b")).toBeTruthy();
+    expect(systemAdmin.hasRole("librarian", "b")).toBeTruthy();
+
+    expect(sitewideLibraryManager.hasRole("system")).toBeFalsy();
+    expect(sitewideLibraryManager.hasRole("manager-all")).toBeTruthy();
+    expect(sitewideLibraryManager.hasRole("librarian-all")).toBeTruthy();
+    expect(sitewideLibraryManager.hasRole("manager", "a")).toBeTruthy();
+    expect(sitewideLibraryManager.hasRole("librarian", "a")).toBeTruthy();
+    expect(sitewideLibraryManager.hasRole("manager", "b")).toBeTruthy();
+    expect(sitewideLibraryManager.hasRole("librarian", "b")).toBeTruthy();
+
+    expect(sitewideLibrarian.hasRole("system")).toBeFalsy();
+    expect(sitewideLibrarian.hasRole("manager-all")).toBeFalsy();
+    expect(sitewideLibrarian.hasRole("librarian-all")).toBeTruthy();
+    expect(sitewideLibrarian.hasRole("manager", "a")).toBeFalsy();
+    expect(sitewideLibrarian.hasRole("librarian", "a")).toBeTruthy();
+    expect(sitewideLibrarian.hasRole("manager", "b")).toBeFalsy();
+    expect(sitewideLibrarian.hasRole("librarian", "b")).toBeTruthy();
+
+    expect(libraryManagerA.hasRole("system")).toBeFalsy();
+    expect(libraryManagerA.hasRole("manager-all")).toBeFalsy();
+    expect(libraryManagerA.hasRole("librarian-all")).toBeFalsy();
+    expect(libraryManagerA.hasRole("manager", "a")).toBeTruthy();
+    expect(libraryManagerA.hasRole("librarian", "a")).toBeTruthy();
+    expect(libraryManagerA.hasRole("manager", "b")).toBeFalsy();
+    expect(libraryManagerA.hasRole("librarian", "b")).toBeFalsy();
+
+    expect(librarianA.hasRole("system")).toBeFalsy();
+    expect(librarianA.hasRole("manager-all")).toBeFalsy();
+    expect(librarianA.hasRole("librarian-all")).toBeFalsy();
+    expect(librarianA.hasRole("manager", "a")).toBeFalsy();
+    expect(librarianA.hasRole("librarian", "a")).toBeTruthy();
+    expect(librarianA.hasRole("manager", "b")).toBeFalsy();
+    expect(librarianA.hasRole("librarian", "b")).toBeFalsy();
+
+    expect(libraryManagerB.hasRole("system")).toBeFalsy();
+    expect(libraryManagerB.hasRole("manager-all")).toBeFalsy();
+    expect(libraryManagerB.hasRole("librarian-all")).toBeFalsy();
+    expect(libraryManagerB.hasRole("manager", "a")).toBeFalsy();
+    expect(libraryManagerB.hasRole("librarian", "a")).toBeFalsy();
+    expect(libraryManagerB.hasRole("manager", "b")).toBeTruthy();
+    expect(libraryManagerB.hasRole("librarian", "b")).toBeTruthy();
+
+    expect(librarianB.hasRole("system")).toBeFalsy();
+    expect(librarianB.hasRole("manager-all")).toBeFalsy();
+    expect(librarianB.hasRole("librarian-all")).toBeFalsy();
+    expect(librarianB.hasRole("manager", "a")).toBeFalsy();
+    expect(librarianB.hasRole("librarian", "a")).toBeFalsy();
+    expect(librarianB.hasRole("manager", "b")).toBeFalsy();
+    expect(librarianB.hasRole("librarian", "b")).toBeTruthy();
+
+    expect(libraryManagerASitewideLibrarian.hasRole("system")).toBeFalsy();
+    expect(libraryManagerASitewideLibrarian.hasRole("manager-all")).toBeFalsy();
+    expect(
+      libraryManagerASitewideLibrarian.hasRole("librarian-all")
+    ).toBeTruthy();
+    expect(
+      libraryManagerASitewideLibrarian.hasRole("manager", "a")
+    ).toBeTruthy();
+    expect(
+      libraryManagerASitewideLibrarian.hasRole("librarian", "a")
+    ).toBeTruthy();
+    expect(
+      libraryManagerASitewideLibrarian.hasRole("manager", "b")
+    ).toBeFalsy();
+    expect(
+      libraryManagerASitewideLibrarian.hasRole("librarian", "b")
+    ).toBeTruthy();
+
+    expect(libraryManagerALibrarianB.hasRole("system")).toBeFalsy();
+    expect(libraryManagerALibrarianB.hasRole("manager-all")).toBeFalsy();
+    expect(libraryManagerALibrarianB.hasRole("librarian-all")).toBeFalsy();
+    expect(libraryManagerALibrarianB.hasRole("manager", "a")).toBeTruthy();
+    expect(libraryManagerALibrarianB.hasRole("librarian", "a")).toBeTruthy();
+    expect(libraryManagerALibrarianB.hasRole("manager", "b")).toBeFalsy();
+    expect(libraryManagerALibrarianB.hasRole("librarian", "b")).toBeTruthy();
+  });
+});