@thepalaceproject/circulation-admin 1.43.0-post.2 → 1.43.0-post.3

package/jest.config.js

@@ -1,31 +1,63 @@
 /** @type {import('ts-jest').JestConfigWithTsJest} */
-module.exports = {
+
+// Options shared by both projects.
+const sharedProjectConfig = {
+  preset: "ts-jest",
+  testEnvironmentOptions: {
+    // Without this, jsdom's default `["browser"]` export condition resolves sinon
+    // to its ESM bundle, which ts-jest does not transform. Every legacy suite then
+    // dies with `SyntaxError: Unexpected token 'export'`.
+    customExportConditions: [""],
+  },
+  setupFiles: ["<rootDir>/jest.polyfills.js"],
   moduleNameMapper: {
     "\\.(jpg|jpeg|png|gif|eot|otf|webp|svg|ttf|woff|woff2|mp4|webm|wav|mp3|m4a|aac|oga)$":
       "<rootDir>/tests/__mocks__/fileMock.js",
-    "\\.(css|less)$": "<rootDir>/tests/__mocks__/styleMock.js",
+    "\\.(css|less|scss|sass)$": "<rootDir>/tests/__mocks__/styleMock.js",
     "\\.md$": "<rootDir>/tests/__mocks__/fileMock.js",
   },
-  preset: "ts-jest",
-  testEnvironment: "jest-fixed-jsdom",
-  testEnvironmentOptions: {
-    customExportConditions: [""],
-  },
-  setupFiles: ["./jest.polyfills.js"],
-  setupFilesAfterEnv: ["./tests/jest/jest-setup.ts"],
   // `src` must stay in `roots` so that `collectCoverageFrom` can discover source
-  // files that no jest test imports — otherwise they are silently omitted from
-  // the report rather than counted as uncovered. `testMatch` (not `--roots`) is
-  // therefore what keeps jest from picking up the legacy mocha tests that live
-  // in `src/**/__tests__/`.
-  roots: ["<rootDir>/src", "<rootDir>/tests/jest"],
-  testMatch: ["<rootDir>/tests/jest/**/*.test.{js,jsx,ts,tsx}"],
+  // files that no test imports — otherwise they are silently omitted from the
+  // report rather than counted as uncovered, and the coverage percentage rises
+  // while real coverage is unchanged.
+  roots: ["<rootDir>/src"],
+};
+
+module.exports = {
   coverageDirectory: "coverage/jest",
   coverageReporters: ["lcov", "text-summary"],
+  // Must live at the top level, not inside `projects`: jest reads
+  // `collectCoverageFrom` off the *global* config. Set it only per-project and it
+  // is silently undefined globally, so every executed file gets instrumented —
+  // including test helpers and everything under `tests/`.
   collectCoverageFrom: [
     "src/**/*.{ts,tsx}",
     "!src/**/__tests__/**",
-    "!src/testHelper.ts",
     "!src/**/*.d.ts",
   ],
+  projects: [
+    {
+      ...sharedProjectConfig,
+      displayName: "unit",
+      roots: [...sharedProjectConfig.roots, "<rootDir>/tests/jest"],
+      testMatch: ["<rootDir>/tests/jest/**/*.test.{js,jsx,ts,tsx}"],
+      // `jest-fixed-jsdom` restores Node's fetch/Response globals so MSW can
+      // intercept them.
+      testEnvironment: "jest-fixed-jsdom",
+      setupFilesAfterEnv: ["<rootDir>/tests/jest/jest-setup.ts"],
+    },
+    {
+      // Legacy enzyme + chai + sinon tests, still in `src/**/__tests__/`. They are
+      // being rewritten as React Testing Library tests under `tests/jest/`; when the
+      // last one is gone, delete this project, its environment, and its setup file.
+      //
+      // These cannot use `jest-fixed-jsdom`: it swaps in undici's `FormData`, which
+      // rejects `new FormData(formElement)` and crashes any test that submits a form.
+      ...sharedProjectConfig,
+      displayName: "legacy",
+      testMatch: ["<rootDir>/src/**/__tests__/*-test.{ts,tsx}"],
+      testEnvironment: "<rootDir>/tests/jest/legacyJsdomEnvironment.js",
+      setupFilesAfterEnv: ["<rootDir>/tests/jest/legacy-setup.ts"],
+    },
+  ],
 };

package/package.json

@@ -17,20 +17,14 @@
     "prepublish": "npm run prod",
     "lint": "npm run lint:js && sass-lint -c .sass-lint.yml -v -q",
     "lint:js": "eslint . --max-warnings 0",
-    "test-js": "tsc && cp -r src/stylesheets lib && cp -r src/images lib && mocha --require lib/testHelper.js lib/__tests__/*.js lib/**/__tests__/*.js lib/**/**/__tests__/*.js",
-    "test-js-file": "tsc && cp -r src/stylesheets lib && cp -r src/images lib && mocha --require lib/testHelper.js",
-    "test-js-list": "mocha --require lib/testHelper.js lib/__tests__/*.js lib/**/__tests__/*.js lib/**/**/__tests__/*.js --reporter ./testReporter.js",
-    "test-ts": "mocha -r ts-node/register --require src/testHelper.ts src/__tests__/*.ts* src/**/__tests__/*.ts* src/**/**/__tests__/*.ts*",
-    "test-file-ts": "mocha -r ts-node/register --require src/testHelper.ts",
-    "test": "npm run test-ts && npm run test-jest",
-    "test-file": "npm run test-file-ts",
+    "test": "npm run test-jest",
+    "test-file": "npm run test-jest-file",
     "test-browser": "npm run test-chrome && npm run test-firefox",
     "test-chrome": "node_modules/.bin/selenium-standalone install && nightwatch -e chrome",
     "test-firefox": "node_modules/.bin/selenium-standalone install && nightwatch -e firefox",
     "test-jest": "jest --verbose",
     "test-jest-file": "jest --verbose",
-    "coverage": "npm run coverage-ts && npm run coverage-jest",
-    "coverage-ts": "nyc npm run test-ts",
+    "coverage": "npm run coverage-jest",
     "coverage-jest": "npm run test-jest -- --coverage",
     "dev": "webpack --watch --progress --config webpack.dev.config",
     "dev-server": "dotenv -c -- webpack serve --progress --hot --config webpack.dev-server.config",
@@ -81,7 +75,6 @@
     "@testing-library/react-hooks": "^8.0.1",
     "@testing-library/user-event": "^14.4.3",
     "@types/jest": "^29.2.6",
-    "@types/mocha": "^10.0.1",
     "@types/node": "^25.9.3",
     "@types/numeral": "^2.0.5",
     "@types/prop-types": "^15.7.3",
@@ -93,7 +86,6 @@
     "@types/redux-mock-store": "^1.0.3",
     "chai": "4.2.0",
     "clean-webpack-plugin": "^2.0.1",
-    "colors-cli": "^1.0.27",
     "copy-webpack-plugin": "14.0.0",
     "css-loader": "^7.1.4",
     "dotenv-cli": "^11.0.0",
@@ -114,18 +106,14 @@
     "jest": "^29.3.1",
     "jest-environment-jsdom": "^30.4.1",
     "jest-fixed-jsdom": "^0.0.11",
-    "jsdom": "^29.1.1",
     "json-loader": "^0.5.4",
     "lint-staged": "^17.0.7",
     "marked": "^18.0.5",
     "mini-css-extract-plugin": "1.6.0",
-    "mocha": "^11.7.6",
     "msw": "^2.7.3",
     "nightwatch": "^3.14.0",
-    "nyc": "^17.1.0",
     "prettier": "3.8.4",
     "react-axe": "^3.3.0",
-    "react-test-renderer": "^16.14.0",
     "redux-mock-store": "^1.5.4",
     "resize-observer-polyfill": "^1.5.1",
     "sass": "^1.64.2",
@@ -137,7 +125,6 @@
     "terser-webpack-plugin": "^5.3.6",
     "ts-jest": "^29.2.6",
     "ts-loader": "^9.5.2",
-    "ts-node": "^10.9.2",
     "typedoc": "^0.28.19",
     "typescript": "^5.7.3",
     "typescript-eslint": "^8.60.1",
@@ -157,5 +144,5 @@
     "*.{js,jsx,ts,tsx,css,md}": "prettier --write",
     "*.{js,css,md}": "prettier --write"
   },
-  "version": "1.43.0-post.2"
+  "version": "1.43.0-post.3"
 }

package/tests/jest/legacy-setup.ts

@@ -0,0 +1,13 @@
+import { configure } from "enzyme";
+import * as Adapter from "enzyme-adapter-react-16";
+
+// Setup for the legacy enzyme + chai + sinon tests under `src/**/__tests__/`.
+// Replaces what `src/testHelper.ts` did for mocha. Delete alongside the last
+// enzyme test.
+
+configure({ adapter: new Adapter() });
+
+// Unhandled promise rejections are tolerated for these tests — see the comment in
+// `legacyJsdomEnvironment.js`. It cannot be done from here: jest hands test code a
+// *copy* of `process`, so a listener registered in this file never reaches the real
+// one that Node checks before throwing.

package/tests/jest/legacyJsdomEnvironment.js

@@ -0,0 +1,49 @@
+"use strict";
+
+const JSDOMEnvironment = require("jest-environment-jsdom").default;
+
+const warnUnhandledRejection = (reason) => {
+  console.warn("Unhandled promise rejection in a legacy test:", reason);
+};
+
+/**
+ * jsdom environment for the legacy enzyme tests. Delete it with the last one.
+ *
+ * Two things it restores that `src/testHelper.ts` used to provide under mocha:
+ *
+ * 1. `global.jsdom`. A handful of tests call `global.jsdom.reconfigure({ url })` to
+ *    change the page origin mid-test. `history.replaceState` is not a substitute —
+ *    they navigate across origins (`http://example.com`), which it cannot do.
+ *
+ * 2. Tolerance for unhandled promise rejections. Several suites stub a `fetch` that
+ *    rejects, and nothing awaits the result; the rejection surfaces after the test
+ *    has already passed. Mocha shrugged those off because its runner keeps an
+ *    `unhandledRejection` listener installed, and Node only throws when there are
+ *    none. Under jest they kill the worker and take the whole suite with them.
+ *
+ *    Re-arming has to happen on the `teardown` event, not in the constructor.
+ *    `jest-circus/globalErrorHandlers` reads `process.listeners()` off the sandbox's
+ *    *copied* `process` (always empty) but calls `removeAllListeners()` on the real
+ *    one. So any listener registered earlier is dropped at `setup` and "restored"
+ *    from an empty list, leaving zero listeners during the post-run window where
+ *    these rejections actually land.
+ *
+ *    Scoping this to the legacy environment keeps the modern `tests/jest/` suite
+ *    strict: jest clears listeners at each file's `setup`, and nothing re-arms one
+ *    for a project that does not use this environment.
+ */
+module.exports = class LegacyJSDOMEnvironment extends JSDOMEnvironment {
+  constructor(config, context) {
+    super(config, context);
+    this.global.jsdom = this.dom;
+  }
+
+  handleTestEvent(event) {
+    if (
+      event.name === "teardown" &&
+      process.listenerCount("unhandledRejection") === 0
+    ) {
+      process.on("unhandledRejection", warnUnhandledRejection);
+    }
+  }
+};

package/tsconfig.json

@@ -6,11 +6,10 @@
     "outDir": "lib",
     "lib": ["es2023.array","es2019", "dom"],
     "rootDir": ".",
-    // Mocha and jest are both used in this project. Certain globals are declared by both,
-    // such as describe, it, and test. Setting skipLibCheck to true prevents typescript from
-    // erroring when it sees duplicate variable declarations with different types.
+    // Some dependencies' type declarations (recharts, @open-draft/deferred-promise)
+    // do not compile under this project's `target` and `esModuleInterop` settings.
     "skipLibCheck": true,
-    "types": ["mocha", "node", "jest", "@testing-library/jest-dom"],
+    "types": ["node", "jest", "@testing-library/jest-dom"],
     "jsx": "react"
   },
   "exclude": [

package/.nycrc.json

@@ -1,8 +0,0 @@
-{
-  "$schema": "https://json.schemastore.org/nycrc",
-  "extension": [".ts", ".tsx"],
-  "include": ["src/**/*.ts", "src/**/*.tsx"],
-  "exclude": ["src/**/__tests__/**", "src/testHelper.ts", "**/*.d.ts"],
-  "reporter": ["lcov", "text-summary"],
-  "report-dir": "coverage/mocha"
-}

package/testReporter.js

@@ -1,29 +0,0 @@
-const mocha = require("mocha");
-const sinon = require("sinon");
-const color = require("colors-cli/safe");
-
-function TestReporter(runner) {
-  // This isn't the place for warnings about soon-to-be-deprecated React methods, etc; we just want a clean list.
-  console.warn = sinon.stub();
-  console.error = sinon.stub();
-
-  const {
-    EVENT_SUITE_BEGIN,
-    EVENT_TEST_BEGIN,
-    EVENT_SUITE_END,
-  } = mocha.Runner.constants;
-
-  mocha.reporters.Base.call(this, runner);
-
-  runner.on(EVENT_SUITE_BEGIN, function (suite) {
-    console.group(color.x25.bold(suite.title));
-  });
-  runner.on(EVENT_TEST_BEGIN, function (test) {
-    console.log(test.title);
-  });
-  runner.on(EVENT_SUITE_END, function () {
-    console.groupEnd();
-  });
-}
-
-module.exports = TestReporter;