@thepalaceproject/circulation-admin 1.43.0-post.1 → 1.43.0-post.2

package/.nycrc.json

@@ -0,0 +1,8 @@
+{
+  "$schema": "https://json.schemastore.org/nycrc",
+  "extension": [".ts", ".tsx"],
+  "include": ["src/**/*.ts", "src/**/*.tsx"],
+  "exclude": ["src/**/__tests__/**", "src/testHelper.ts", "**/*.d.ts"],
+  "reporter": ["lcov", "text-summary"],
+  "report-dir": "coverage/mocha"
+}

package/CLAUDE.md

@@ -20,6 +20,9 @@ npm test                       # Full test suite (mocha legacy + jest)
 npm run test-jest              # Jest tests only
 npm run test-jest-file <path>  # Single jest test: npm run test-jest-file tests/jest/components/MyTest.test.tsx
 npm run test-file-ts <path>    # Single mocha test: npm run test-file-ts src/components/__tests__/MyTest-test.tsx
+npm run coverage               # Both suites with coverage (what CI runs); writes coverage/{mocha,jest}/lcov.info
+npm run coverage-ts            # Mocha suite coverage only (nyc)
+npm run coverage-jest          # Jest suite coverage only
 npm run dev-test-axe           # Dev build with react-axe accessibility checking (output in browser console)
 ```
 
@@ -68,6 +71,10 @@ The dev server can also read the backend URL from `.env` or `.env.local` with `B
 
 2. **Mocha** (legacy): Tests in `src/*/__tests__/` directories. Uses Enzyme with React 16 adapter. Do not add new mocha tests.
 
+**Coverage:** Both suites report to Codecov under separate flags (`jest`, `mocha`). Each emits an istanbul `lcov` report — jest natively, mocha via `nyc` (configured in `.nycrc.json`) — so the two agree on which lines are executable and Codecov can merge them into a single union. Do not swap `nyc` for `c8`: c8's V8-based line mapping counts every physical line of a `.ts` file as executable, which reports untested-but-imported modules as 100% covered and corrupts the merge.
+
+Jest's `roots` must keep `<rootDir>/src` so `collectCoverageFrom` can discover source files no jest test imports; `testMatch` (not `--roots`) is what keeps jest from picking up the mocha tests under `src/**/__tests__/`.
+
 ## Code Style
 
 - Prettier: double quotes, semicolons, trailing commas (es5), 80 char width

package/eslint.config.mjs

@@ -8,7 +8,15 @@ import globals from "globals";
 
 export default tseslint.config(
   {
-    ignores: ["dist/", "lib/", "docs/", "typings/", "node_modules/"],
+    ignores: [
+      "dist/",
+      "lib/",
+      "docs/",
+      "typings/",
+      "node_modules/",
+      "coverage/",
+      ".nyc_output/",
+    ],
   },
   js.configs.recommended,
   ...tseslint.configs.recommended,

package/jest.config.js

@@ -13,4 +13,19 @@ module.exports = {
   },
   setupFiles: ["./jest.polyfills.js"],
   setupFilesAfterEnv: ["./tests/jest/jest-setup.ts"],
+  // `src` must stay in `roots` so that `collectCoverageFrom` can discover source
+  // files that no jest test imports — otherwise they are silently omitted from
+  // the report rather than counted as uncovered. `testMatch` (not `--roots`) is
+  // therefore what keeps jest from picking up the legacy mocha tests that live
+  // in `src/**/__tests__/`.
+  roots: ["<rootDir>/src", "<rootDir>/tests/jest"],
+  testMatch: ["<rootDir>/tests/jest/**/*.test.{js,jsx,ts,tsx}"],
+  coverageDirectory: "coverage/jest",
+  coverageReporters: ["lcov", "text-summary"],
+  collectCoverageFrom: [
+    "src/**/*.{ts,tsx}",
+    "!src/**/__tests__/**",
+    "!src/testHelper.ts",
+    "!src/**/*.d.ts",
+  ],
 };

package/package.json

@@ -27,8 +27,11 @@
     "test-browser": "npm run test-chrome && npm run test-firefox",
     "test-chrome": "node_modules/.bin/selenium-standalone install && nightwatch -e chrome",
     "test-firefox": "node_modules/.bin/selenium-standalone install && nightwatch -e firefox",
-    "test-jest": "jest --verbose --roots tests/jest",
+    "test-jest": "jest --verbose",
     "test-jest-file": "jest --verbose",
+    "coverage": "npm run coverage-ts && npm run coverage-jest",
+    "coverage-ts": "nyc npm run test-ts",
+    "coverage-jest": "npm run test-jest -- --coverage",
     "dev": "webpack --watch --progress --config webpack.dev.config",
     "dev-server": "dotenv -c -- webpack serve --progress --hot --config webpack.dev-server.config",
     "dev-test-axe": "TEST_AXE=true npm run dev",
@@ -119,6 +122,7 @@
     "mocha": "^11.7.6",
     "msw": "^2.7.3",
     "nightwatch": "^3.14.0",
+    "nyc": "^17.1.0",
     "prettier": "3.8.4",
     "react-axe": "^3.3.0",
     "react-test-renderer": "^16.14.0",
@@ -153,5 +157,5 @@
     "*.{js,jsx,ts,tsx,css,md}": "prettier --write",
     "*.{js,css,md}": "prettier --write"
   },
-  "version": "1.43.0-post.1"
+  "version": "1.43.0-post.2"
 }