@thepalaceproject/circulation-admin 1.42.2 → 1.43.0-post.2

package/.node-version

@@ -1 +1 @@
-20.18.3
+24.16.0

package/.nvmrc

@@ -1 +1 @@
-v20
+v24

package/.nycrc.json

@@ -0,0 +1,8 @@
+{
+  "$schema": "https://json.schemastore.org/nycrc",
+  "extension": [".ts", ".tsx"],
+  "include": ["src/**/*.ts", "src/**/*.tsx"],
+  "exclude": ["src/**/__tests__/**", "src/testHelper.ts", "**/*.d.ts"],
+  "reporter": ["lcov", "text-summary"],
+  "report-dir": "coverage/mocha"
+}

package/CLAUDE.md

@@ -20,6 +20,9 @@ npm test                       # Full test suite (mocha legacy + jest)
 npm run test-jest              # Jest tests only
 npm run test-jest-file <path>  # Single jest test: npm run test-jest-file tests/jest/components/MyTest.test.tsx
 npm run test-file-ts <path>    # Single mocha test: npm run test-file-ts src/components/__tests__/MyTest-test.tsx
+npm run coverage               # Both suites with coverage (what CI runs); writes coverage/{mocha,jest}/lcov.info
+npm run coverage-ts            # Mocha suite coverage only (nyc)
+npm run coverage-jest          # Jest suite coverage only
 npm run dev-test-axe           # Dev build with react-axe accessibility checking (output in browser console)
 ```
 
@@ -68,6 +71,10 @@ The dev server can also read the backend URL from `.env` or `.env.local` with `B
 
 2. **Mocha** (legacy): Tests in `src/*/__tests__/` directories. Uses Enzyme with React 16 adapter. Do not add new mocha tests.
 
+**Coverage:** Both suites report to Codecov under separate flags (`jest`, `mocha`). Each emits an istanbul `lcov` report — jest natively, mocha via `nyc` (configured in `.nycrc.json`) — so the two agree on which lines are executable and Codecov can merge them into a single union. Do not swap `nyc` for `c8`: c8's V8-based line mapping counts every physical line of a `.ts` file as executable, which reports untested-but-imported modules as 100% covered and corrupts the merge.
+
+Jest's `roots` must keep `<rootDir>/src` so `collectCoverageFrom` can discover source files no jest test imports; `testMatch` (not `--roots`) is what keeps jest from picking up the mocha tests under `src/**/__tests__/`.
+
 ## Code Style
 
 - Prettier: double quotes, semicolons, trailing commas (es5), 80 char width
@@ -79,7 +86,7 @@ The dev server can also read the backend URL from `.env` or `.env.local` with `B
 
 ## Output
 
-Webpack builds to `dist/circulation-admin.js` (UMD library, global `CirculationAdmin`) and `dist/circulation-admin.css`. Node.js 20+ required.
+Webpack builds to `dist/circulation-admin.js` (UMD library, global `CirculationAdmin`) and `dist/circulation-admin.css`. Node.js 24 required (>=24.0.0 <25.0.0).
 
 ## Code Conventions
 

package/README.md

@@ -12,7 +12,7 @@ To see screenshots, read in-depth documentation, and find out more about the pro
 
 This package may be used in a local build of the Palace Project [Circulation Manager](https://github.com/ThePalaceProject/circulation), or it may be run against a remote Circulation Manager.
 
-This project uses Node.js 20. We recommend the latest version of Node.js 20.
+This project uses Node.js 24. We recommend the latest version of Node.js 24.
 
 You have a number of options for installing Node.js. One convenient way on macOS is to use Homebrew and nvm to manage Node.js versions.
 
@@ -28,22 +28,22 @@ Install nvm using Homebrew:
 brew install nvm
 ```
 
-Install and use the latest version of Node.js 18, e.g. 18.14.2 with nvm:
+Install and use the latest version of Node.js 24, e.g. 24.16.0 with nvm:
 
 ```
-nvm install 20.18.3
-nvm use 20.18.3
+nvm install 24.16.0
+nvm use 24.16.0
 ```
 
 Alternatively, you can use `nodenv` on macOS:
 
 ```
 brew install nodenv
-nodenv install 20.18.3
-nodenv global 20.18.3
+nodenv install 24.16.0
+nodenv global 24.16.0
 ```
 
-If you have different projects requiring different Node.js versions, you can use nodenv to set a local version for the project by navigating to the root directory of circulation-admin and executing `nodenv local 18.14.2`.
+If you have different projects requiring different Node.js versions, you can use nodenv to set a local version for the project by navigating to the root directory of circulation-admin and executing `nodenv local 24.16.0`.
 
 You can also use the `n` npm package to manage Node.js versions, or simply install the Node.js binary directly.