@thepalaceproject/circulation-admin 1.42.2 → 1.43.0-post.10

package/.node-version

@@ -1 +1 @@
-20.18.3
+24.16.0

package/.nvmrc

@@ -1 +1 @@
-v20
+v24

package/CLAUDE.md

@@ -16,13 +16,16 @@ npm run dev-server -- --env=backend=https://your-cm-url  # Dev server against re
 npm run prod                   # Production build
 npm run lint                   # Run ESLint (lint:js) + sass-lint
 npm run lint:js                # Run ESLint over the whole tree (eslint . --max-warnings 0)
-npm test                       # Full test suite (mocha legacy + jest)
-npm run test-jest              # Jest tests only
-npm run test-jest-file <path>  # Single jest test: npm run test-jest-file tests/jest/components/MyTest.test.tsx
-npm run test-file-ts <path>    # Single mocha test: npm run test-file-ts src/components/__tests__/MyTest-test.tsx
+npm test                       # Full test suite (both jest projects)
+npm run test-jest-file <path>  # Single test: npm run test-jest-file tests/jest/components/MyTest.test.tsx
+npm run coverage               # Test suite with coverage (what CI runs); writes coverage/jest/lcov.info
 npm run dev-test-axe           # Dev build with react-axe accessibility checking (output in browser console)
 ```
 
+Run one jest project at a time with `npx jest --selectProjects=unit` (or `=legacy`). Note
+`--selectProjects` is variadic, so put file paths behind `--testPathPattern` rather than
+after it as positional arguments.
+
 The dev server can also read the backend URL from `.env` or `.env.local` with `BACKEND=https://...`.
 
 ## Architecture
@@ -62,11 +65,17 @@ The dev server can also read the backend URL from `.env` or `.env.local` with `B
 
 ## Testing
 
-**Two test systems coexist:**
+Everything runs under jest, split into **two jest `projects`** (see `jest.config.js`):
+
+1. **`unit`** (for all new tests): Tests in `tests/jest/` mirroring `src/` structure. Uses React Testing Library, jest-dom, and MSW for API mocking. Test utilities in `tests/jest/testUtils/withProviders.tsx` provide `renderWithProviders()` and `componentWithProviders()` to wrap components with Redux, Context, and QueryClient. Runs on `jest-fixed-jsdom` so MSW can intercept `fetch`.
+
+2. **`legacy`**: Tests in `src/*/__tests__/` directories, still written with Enzyme, chai, and sinon. Being rewritten as `unit` tests; **do not add new ones**. Runs on `tests/jest/legacyJsdomEnvironment.js` — plain jsdom, because `jest-fixed-jsdom` substitutes undici's `FormData`, which rejects `new FormData(formElement)`. That environment also restores `global.jsdom` and tolerates unhandled promise rejections; both are documented in the file. Delete the project, the environment, and `tests/jest/legacy-setup.ts` along with the last enzyme test — that is what unblocks React 17+, since enzyme has no adapter beyond React 16.
+
+Both projects need `testEnvironmentOptions.customExportConditions: [""]`. Without it, jsdom's default `["browser"]` condition resolves **sinon** to its ESM bundle and every suite that imports it fails to parse.
 
-1. **Jest** (for all new tests): Tests in `tests/jest/` mirroring `src/` structure. Uses React Testing Library, jest-dom, and MSW for API mocking. Test utilities in `tests/jest/testUtils/withProviders.tsx` provide `renderWithProviders()` and `componentWithProviders()` to wrap components with Redux, Context, and QueryClient.
+**Coverage:** Reported to Codecov under the `jest` flag. `collectCoverageFrom` must stay at the _top level_ of `jest.config.js`, not inside `projects` — jest reads it off the global config, and setting it per-project leaves it globally undefined, so every executed file gets instrumented (including `tests/` helpers).
 
-2. **Mocha** (legacy): Tests in `src/*/__tests__/` directories. Uses Enzyme with React 16 adapter. Do not add new mocha tests.
+Jest's `roots` must keep `<rootDir>/src` so `collectCoverageFrom` can discover source files no test imports; otherwise they are silently omitted rather than counted as uncovered, and the reported percentage rises while real coverage is unchanged.
 
 ## Code Style
 
@@ -79,7 +88,7 @@ The dev server can also read the backend URL from `.env` or `.env.local` with `B
 
 ## Output
 
-Webpack builds to `dist/circulation-admin.js` (UMD library, global `CirculationAdmin`) and `dist/circulation-admin.css`. Node.js 20+ required.
+Webpack builds to `dist/circulation-admin.js` (UMD library, global `CirculationAdmin`) and `dist/circulation-admin.css`. Node.js 24 required (>=24.0.0 <25.0.0).
 
 ## Code Conventions
 

package/README.md

@@ -12,7 +12,7 @@ To see screenshots, read in-depth documentation, and find out more about the pro
 
 This package may be used in a local build of the Palace Project [Circulation Manager](https://github.com/ThePalaceProject/circulation), or it may be run against a remote Circulation Manager.
 
-This project uses Node.js 20. We recommend the latest version of Node.js 20.
+This project uses Node.js 24. We recommend the latest version of Node.js 24.
 
 You have a number of options for installing Node.js. One convenient way on macOS is to use Homebrew and nvm to manage Node.js versions.
 
@@ -28,22 +28,22 @@ Install nvm using Homebrew:
 brew install nvm
 ```
 
-Install and use the latest version of Node.js 18, e.g. 18.14.2 with nvm:
+Install and use the latest version of Node.js 24, e.g. 24.16.0 with nvm:
 
 ```
-nvm install 20.18.3
-nvm use 20.18.3
+nvm install 24.16.0
+nvm use 24.16.0
 ```
 
 Alternatively, you can use `nodenv` on macOS:
 
 ```
 brew install nodenv
-nodenv install 20.18.3
-nodenv global 20.18.3
+nodenv install 24.16.0
+nodenv global 24.16.0
 ```
 
-If you have different projects requiring different Node.js versions, you can use nodenv to set a local version for the project by navigating to the root directory of circulation-admin and executing `nodenv local 18.14.2`.
+If you have different projects requiring different Node.js versions, you can use nodenv to set a local version for the project by navigating to the root directory of circulation-admin and executing `nodenv local 24.16.0`.
 
 You can also use the `n` npm package to manage Node.js versions, or simply install the Node.js binary directly.