@thepalaceproject/circulation-admin 1.41.0-post.34 → 1.41.0-post.35

package/CLAUDE.md

@@ -14,7 +14,7 @@ Built on `@thepalaceproject/web-opds-client` which provides the base OPDS catalo
 npm run dev                    # Watch build (for use with local Circulation Manager)
 npm run dev-server -- --env=backend=https://your-cm-url  # Dev server against remote backend
 npm run prod                   # Production build
-npm run lint                   # Run tslint + sass-lint
+npm run lint                   # Run ESLint (lint:js) + sass-lint
 npm run lint:js                # Run ESLint over the whole tree (eslint . --max-warnings 0)
 npm test                       # Full test suite (mocha legacy + jest)
 npm run test-jest              # Jest tests only
@@ -71,7 +71,7 @@ The dev server can also read the backend URL from `.env` or `.env.local` with `B
 ## Code Style
 
 - Prettier: double quotes, semicolons, trailing commas (es5), 80 char width
-- ESLint (flat config, `eslint.config.mjs`) with `jsx-a11y/strict` — runs on the whole tree in CI via `npm run lint:js` (`eslint . --max-warnings 0`, so warnings fail the build) and on staged files via the husky pre-commit hook. Separate from `npm run lint`, which runs tslint + sass-lint.
+- ESLint (flat config, `eslint.config.mjs`) with `jsx-a11y/strict` — runs on the whole tree in CI via `npm run lint:js` (`eslint . --max-warnings 0`, so warnings fail the build) and on staged files via the husky pre-commit hook. `npm run lint` runs ESLint (`lint:js`) followed by sass-lint.
 - `@typescript-eslint/no-explicit-any` is disabled (any is allowed)
 - Prefer template literals over string concatenation for building strings with variables
 - When an arrow function only passes its arguments through to another function with the same signature, pass the function directly instead of wrapping it (e.g., `onClick: this.handleClick` not `onClick: (e) => this.handleClick(e)`)

package/README.md

@@ -118,7 +118,7 @@ publish the release. The GitHub Actions workflow will automatically build, test,
 
 ## Accessibility
 
-In order to develop user interfaces that are accessible to everyone, there are tools added to the workflow. Besides the Typescript `tslint-react-a11y` plugin, `react-axe` is also installed for local development. Using that module while running the app uses a lot of resources so it should be only when specifically testing for accessibility and not while actively developing new features or fixing bugs.
+In order to develop user interfaces that are accessible to everyone, there are tools added to the workflow. Besides the ESLint `jsx-a11y` plugin, `react-axe` is also installed for local development. Using that module while running the app uses a lot of resources so it should be only when specifically testing for accessibility and not while actively developing new features or fixing bugs.
 
 In order to run the app with `react-axe`, run `npm run dev-test-axe`. This will add a local global variable `process.env.TEST_AXE` (through webpack) that will trigger `react-axe` in `/src/index.tsx`. The output will be seen in the _browser's_ console terminal.
 

package/eslint.config.mjs

@@ -79,6 +79,9 @@ export default tseslint.config(
           ignoreRestSiblings: true,
         },
       ],
+      "no-var": "error",
+      "no-eval": "error",
+      eqeqeq: ["error", "smart"],
     },
   },
   // Disable ESLint formatting rules that conflict with Prettier.

package/package.json

@@ -14,14 +14,13 @@
   },
   "scripts": {
     "prepublish": "npm run prod",
-    "lint": "tslint -c tslint.json src/*.ts src/*.tsx src/**/*.ts src/**/*.tsx src/**/**/*.ts src/**/**/*.tsx && sass-lint -c .sass-lint.yml -v -q",
+    "lint": "npm run lint:js && sass-lint -c .sass-lint.yml -v -q",
     "lint:js": "eslint . --max-warnings 0",
-    "test-js": "npm run lint && tsc && cp -r src/stylesheets lib && cp -r src/images lib && mocha --require lib/testHelper.js lib/__tests__/*.js lib/**/__tests__/*.js lib/**/**/__tests__/*.js",
-    "test-js-file": "npm run lint && tsc && cp -r src/stylesheets lib && cp -r src/images lib && mocha --require lib/testHelper.js",
+    "test-js": "tsc && cp -r src/stylesheets lib && cp -r src/images lib && mocha --require lib/testHelper.js lib/__tests__/*.js lib/**/__tests__/*.js lib/**/**/__tests__/*.js",
+    "test-js-file": "tsc && cp -r src/stylesheets lib && cp -r src/images lib && mocha --require lib/testHelper.js",
     "test-js-list": "mocha --require lib/testHelper.js lib/__tests__/*.js lib/**/__tests__/*.js lib/**/**/__tests__/*.js --reporter ./testReporter.js",
-    "test-ts": "npm run lint && mocha -r ts-node/register --require src/testHelper.ts src/__tests__/*.ts* src/**/__tests__/*.ts* src/**/**/__tests__/*.ts*",
-    "test-file-ts": "npm run lint && mocha -r ts-node/register --require src/testHelper.ts",
-    "test-file-ts-nolint": "mocha -r ts-node/register --require src/testHelper.ts",
+    "test-ts": "mocha -r ts-node/register --require src/testHelper.ts src/__tests__/*.ts* src/**/__tests__/*.ts* src/**/**/__tests__/*.ts*",
+    "test-file-ts": "mocha -r ts-node/register --require src/testHelper.ts",
     "test": "npm run test-ts && npm run test-jest",
     "test-file": "npm run test-file-ts",
     "test-browser": "npm run test-chrome && npm run test-firefox",
@@ -134,8 +133,6 @@
     "ts-jest": "^29.2.6",
     "ts-loader": "^9.5.2",
     "ts-node": "^10.9.2",
-    "tslint": "^6.1.3",
-    "tslint-react-a11y": "^1.1.0",
     "typedoc": "^0.28.19",
     "typescript": "^5.7.3",
     "typescript-eslint": "^8.60.1",
@@ -155,5 +152,5 @@
     "*.{js,jsx,ts,tsx,css,md}": "prettier --write",
     "*.{js,css,md}": "prettier --write"
   },
-  "version": "1.41.0-post.34"
+  "version": "1.41.0-post.35"
 }

package/tests/browser/commands/goHome.js

@@ -1,13 +1,12 @@
-var bookSelector = ".lane-books li:first-child a";
+const bookSelector = ".lane-books li:first-child a";
 
 /**
  * @method goHome
  * @api command
  * @description This custom command navigates the user to the home page.
  */
-exports.command = function() {
-  return this
-    .url(this.globals.homeUrl)
+exports.command = function () {
+  return this.url(this.globals.homeUrl)
     .waitForElementVisible(bookSelector, 5000)
     .verify.noError();
 };

package/tests/jest/components/InventoryReportRequestModal.test.tsx

@@ -88,7 +88,7 @@ describe("InventoryReportRequestModal", () => {
           () => useReportInfo(show, API_ENDPOINT_PARAMS),
           { wrapper }
         );
-        await waitFor(() => result.current.fetchStatus == "idle");
+        await waitFor(() => result.current.fetchStatus === "idle");
         const { isSuccess, isError, error, collections } = result.current;
 
         expect(mock_info_api).toHaveBeenCalledWith(API_ENDPOINT_PARAMS);
@@ -107,7 +107,7 @@ describe("InventoryReportRequestModal", () => {
           () => useReportInfo(show, API_ENDPOINT_PARAMS),
           { wrapper }
         );
-        await waitFor(() => result.current.fetchStatus == "idle");
+        await waitFor(() => result.current.fetchStatus === "idle");
         const { isSuccess, isError, error, collections } = result.current;
 
         expect(mock_info_api).not.toHaveBeenCalled();
@@ -127,7 +127,7 @@ describe("InventoryReportRequestModal", () => {
           () => useReportInfo(show, API_ENDPOINT_PARAMS),
           { wrapper }
         );
-        await waitFor(() => result.current.fetchStatus == "idle");
+        await waitFor(() => result.current.fetchStatus === "idle");
         const { isSuccess, isError, error, collections } = result.current;
 
         expect(mock_info_api).toHaveBeenCalledWith(API_ENDPOINT_PARAMS);

package/webpack.dev-server.config.js

@@ -85,7 +85,7 @@ module.exports = (env) => {
     if (redirectParam) {
       const redirectUrl = new URL(redirectParam);
 
-      if (redirectUrl.host == backendUrl.host) {
+      if (redirectUrl.host === backendUrl.host) {
         redirectUrl.protocol = "http";
         redirectUrl.host = requestHost;
 

package/webpack.dev.config.js

@@ -1,7 +1,7 @@
-const { merge } = require('webpack-merge');
-const common = require('./webpack.common.js');
+const { merge } = require("webpack-merge");
+const common = require("./webpack.common.js");
 
-var config = merge(common, {
+const config = merge(common, {
   mode: "development",
   devtool: "eval-source-map",
 });

package/webpack.prod.config.js

@@ -1,8 +1,8 @@
-const { merge } = require('webpack-merge');
-const common = require('./webpack.common.js');
+const { merge } = require("webpack-merge");
+const common = require("./webpack.common.js");
 
-var config = merge(common, {
-  mode: "production"
+const config = merge(common, {
+  mode: "production",
 });
 
 module.exports = config;

package/tslint.json

@@ -1,56 +0,0 @@
-{
-    "extends": ["tslint-react-a11y"],
-    "rules": {
-        "class-name": true,
-        "comment-format": [
-            true,
-            "check-space"
-        ],
-        "indent": [
-            true,
-            "spaces"
-        ],
-        "no-duplicate-variable": true,
-        "no-eval": true,
-        "no-internal-module": true,
-        "no-trailing-whitespace": true,
-        "no-var-keyword": true,
-        "one-line": [
-            true,
-            "check-open-brace",
-            "check-whitespace"
-        ],
-        "quotemark": [
-            true,
-            "double",
-            "avoid-escape"
-        ],
-        "semicolon": true,
-        "triple-equals": [
-            true,
-            "allow-null-check"
-        ],
-        "typedef-whitespace": [
-            true,
-            {
-                "call-signature": "nospace",
-                "index-signature": "nospace",
-                "parameter": "nospace",
-                "property-declaration": "nospace",
-                "variable-declaration": "nospace"
-            }
-        ],
-        "variable-name": [
-            true,
-            "ban-keywords"
-        ],
-        "whitespace": [
-            true,
-            "check-branch",
-            "check-decl",
-            "check-operator",
-            "check-separator",
-            "check-type"
-        ]
-    }
-}