@thepalaceproject/circulation-admin 1.41.0-post.33 → 1.41.0-post.35

package/tests/jest/components/PatronBlockingRulesHelpModal.test.tsx

@@ -1,5 +1,5 @@
 import * as React from "react";
-import { render, screen, waitFor } from "@testing-library/react";
+import { render, screen } from "@testing-library/react";
 import userEvent from "@testing-library/user-event";
 import { PatronBlockingRulesHelpModal } from "../../../src/components/PatronBlockingRulesHelpModal";
 
@@ -29,9 +29,7 @@ describe("PatronBlockingRulesHelpModal", () => {
 
   it("does not render when show is false", () => {
     render(<PatronBlockingRulesHelpModal {...baseProps} show={false} />);
-    expect(
-      screen.queryByText(/Patron Blocking Rules — Help/i)
-    ).toBeNull();
+    expect(screen.queryByText(/Patron Blocking Rules — Help/i)).toBeNull();
   });
 
   it("shows a loading indicator when fieldsLoading is true", () => {
@@ -84,7 +82,9 @@ describe("PatronBlockingRulesHelpModal", () => {
       />
     );
     expect(
-      screen.getByText(/Save the service before template variables can be fetched/i)
+      screen.getByText(
+        /Save the service before template variables can be fetched/i
+      )
     ).toBeTruthy();
     expect(screen.queryByText("fines")).toBeNull();
   });
@@ -97,9 +97,7 @@ describe("PatronBlockingRulesHelpModal", () => {
         fieldsError={null}
       />
     );
-    expect(
-      screen.getByText(/No field data available/i)
-    ).toBeTruthy();
+    expect(screen.getByText(/No field data available/i)).toBeTruthy();
   });
 
   it("renders null values as italic 'null'", () => {

package/tests/jest/components/QuicksightDashboard.test.tsx

@@ -6,7 +6,6 @@ import { LibrariesData } from "../../../src/interfaces";
 import buildStore from "../../../src/store";
 import { setupServer } from "msw/node";
 import { http, HttpResponse } from "msw";
-import renderWithContext from "../testUtils/renderWithContext";
 import { renderWithProviders } from "../testUtils/withProviders";
 import QuicksightDashboardPage from "../../../src/components/QuicksightDashboardPage";
 

package/tests/jest/components/Stats.test.tsx

@@ -21,11 +21,7 @@ import { renderHook } from "@testing-library/react-hooks";
 import { FetchErrorData } from "@thepalaceproject/web-opds-client/lib/interfaces";
 import { store } from "../../../src/store";
 import { api } from "../../../src/features/api/apiSlice";
-import {
-  AdminRoleData,
-  ConfigurationSettings,
-  RolesData,
-} from "../../../src/interfaces";
+import { AdminRoleData, ConfigurationSettings } from "../../../src/interfaces";
 
 const normalizedData = normalizeStatistics(statisticsApiResponseData);
 
@@ -442,14 +438,12 @@ describe("Dashboard Statistics", () => {
             roles,
             quicksightPagePath: fakeQuickSightHref,
           };
-          const {
-            container,
-            getByRole,
-            queryByRole,
-            queryByText,
-          } = renderWithProviders(<Stats library={sampleLibraryKey} />, {
-            appConfigSettings,
-          });
+          const { container, getByRole, queryByRole } = renderWithProviders(
+            <Stats library={sampleLibraryKey} />,
+            {
+              appConfigSettings,
+            }
+          );
 
           // We should always render a Usage reports group when a library is specified.
           getByRole("heading", {

package/tests/jest/features/book.test.ts

@@ -1,15 +1,12 @@
 import reducer, {
   initialState,
   getBookData,
-  GetBookDataArgs,
   submitBookData,
 } from "../../../src/features/book/bookEditorSlice";
 import { expect } from "chai";
 import * as fetchMock from "fetch-mock-jest";
-import { store } from "../../../src/store";
 import { BookData } from "@thepalaceproject/web-opds-client/lib/interfaces";
 import { RequestError } from "@thepalaceproject/web-opds-client/lib/DataFetcher";
-import { AsyncThunkAction, Dispatch } from "@reduxjs/toolkit";
 import ActionCreator from "@thepalaceproject/web-opds-client/lib/actions";
 
 const SAMPLE_BOOK_ADMIN_DETAIL = `
@@ -274,8 +271,6 @@ describe("Redux bookEditorSlice...", () => {
     describe("submitBookData...", () => {
       const goodBookUrl = "https://example.com/book";
       const editBookUrl = `${goodBookUrl}/edit`;
-      const brokenBookUrl = "https://example.com/broken-book";
-      const errorBookUrl = "https://example.com/error-book";
       const csrfTokenHeader = "X-CSRF-Token";
       const validCsrfToken = "valid-csrf-token";
 
@@ -328,7 +323,7 @@ describe("Redux bookEditorSlice...", () => {
           csrfToken,
         });
 
-        const result = await action(dispatch, getState, undefined);
+        await action(dispatch, getState, undefined);
         const dispatchCalls = dispatch.mock.calls;
         const fetchCalls = fetchMock.calls();
 
@@ -366,7 +361,7 @@ describe("Redux bookEditorSlice...", () => {
           csrfToken,
         });
 
-        const result = await action(dispatch, getState, undefined);
+        await action(dispatch, getState, undefined);
         const dispatchCalls = dispatch.mock.calls;
         const fetchCalls = fetchMock.calls();
 

package/webpack.common.js

@@ -1,11 +1,9 @@
-/* eslint-disable @typescript-eslint/no-var-requires */
 const path = require("path");
 const CleanWebpackPlugin = require("clean-webpack-plugin");
 const webpack = require("webpack");
 const MiniCssExtractPlugin = require("mini-css-extract-plugin");
 const TerserPlugin = require("terser-webpack-plugin");
 const CopyPlugin = require("copy-webpack-plugin");
-/* eslint-enable @typescript-eslint/no-var-requires */
 
 module.exports = {
   entry: {

package/webpack.dev-server.config.js

@@ -1,5 +1,3 @@
-/* eslint-disable @typescript-eslint/no-var-requires */
-
 /**
  * This webpack config establishes a proxy server to enable a local build of circulation-admin to
  * connect to a remote Circulation Manager back-end. Requests for webpack assets are served from
@@ -87,7 +85,7 @@ module.exports = (env) => {
     if (redirectParam) {
       const redirectUrl = new URL(redirectParam);
 
-      if (redirectUrl.host == backendUrl.host) {
+      if (redirectUrl.host === backendUrl.host) {
         redirectUrl.protocol = "http";
         redirectUrl.host = requestHost;
 

package/webpack.dev.config.js

@@ -1,7 +1,7 @@
-const { merge } = require('webpack-merge');
-const common = require('./webpack.common.js');
+const { merge } = require("webpack-merge");
+const common = require("./webpack.common.js");
 
-var config = merge(common, {
+const config = merge(common, {
   mode: "development",
   devtool: "eval-source-map",
 });

package/webpack.prod.config.js

@@ -1,8 +1,8 @@
-const { merge } = require('webpack-merge');
-const common = require('./webpack.common.js');
+const { merge } = require("webpack-merge");
+const common = require("./webpack.common.js");
 
-var config = merge(common, {
-  mode: "production"
+const config = merge(common, {
+  mode: "production",
 });
 
 module.exports = config;

package/tslint.json

@@ -1,56 +0,0 @@
-{
-    "extends": ["tslint-react-a11y"],
-    "rules": {
-        "class-name": true,
-        "comment-format": [
-            true,
-            "check-space"
-        ],
-        "indent": [
-            true,
-            "spaces"
-        ],
-        "no-duplicate-variable": true,
-        "no-eval": true,
-        "no-internal-module": true,
-        "no-trailing-whitespace": true,
-        "no-var-keyword": true,
-        "one-line": [
-            true,
-            "check-open-brace",
-            "check-whitespace"
-        ],
-        "quotemark": [
-            true,
-            "double",
-            "avoid-escape"
-        ],
-        "semicolon": true,
-        "triple-equals": [
-            true,
-            "allow-null-check"
-        ],
-        "typedef-whitespace": [
-            true,
-            {
-                "call-signature": "nospace",
-                "index-signature": "nospace",
-                "parameter": "nospace",
-                "property-declaration": "nospace",
-                "variable-declaration": "nospace"
-            }
-        ],
-        "variable-name": [
-            true,
-            "ban-keywords"
-        ],
-        "whitespace": [
-            true,
-            "check-branch",
-            "check-decl",
-            "check-operator",
-            "check-separator",
-            "check-type"
-        ]
-    }
-}