@thepalaceproject/circulation-admin 1.38.0 → 1.39.0-post.1

package/tests/jest/components/IndividualAdmins.test.tsx

@@ -0,0 +1,390 @@
+import * as React from "react";
+import { fireEvent } from "@testing-library/react";
+import { IndividualAdmins } from "../../../src/components/IndividualAdmins";
+import renderWithContext from "../testUtils/renderWithContext";
+import {
+  ConfigurationSettings,
+  IndividualAdminsData,
+} from "../../../src/interfaces";
+import { defaultFeatureFlags } from "../../../src/utils/featureFlags";
+
+// NB: This adds tests to the already existing tests in:
+// - `src/components/__tests__/IndividualAdmins-test.tsx`.
+//
+// Those tests should eventually be migrated here and
+// adapted to the Jest/React Testing Library paradigm.
+
+describe("IndividualAdmins - role association disclosure", () => {
+  // ── Shared fixtures ───────────────────────────────────────────────────────
+
+  const allLibraries = [
+    { short_name: "gamma", name: "Gamma Library", uuid: "uuid-gamma" },
+    { short_name: "alpha", name: "Alpha Library", uuid: "uuid-alpha" },
+    { short_name: "beta", name: "Beta Library", uuid: "uuid-beta" },
+    { short_name: "delta", name: "Delta Library" }, // no uuid
+  ];
+
+  const sysAdminConfig: Partial<ConfigurationSettings> = {
+    csrfToken: "",
+    featureFlags: defaultFeatureFlags,
+    roles: [{ role: "system" }],
+  };
+
+  const renderAdmins = (
+    admins: IndividualAdminsData["individualAdmins"],
+    config = sysAdminConfig
+  ) =>
+    renderWithContext(
+      <IndividualAdmins
+        data={{ individualAdmins: admins, allLibraries }}
+        fetchData={jest.fn()}
+        editItem={jest.fn().mockResolvedValue(undefined)}
+        deleteItem={jest.fn().mockResolvedValue(undefined)}
+        csrfToken="token"
+        isFetching={false}
+      />,
+      config
+    );
+
+  // ── Toggle visibility ─────────────────────────────────────────────────────
+
+  it("shows no toggle for an admin with no roles field", () => {
+    const { container } = renderAdmins([{ email: "noroles@example.com" }]);
+    expect(container.querySelector(".association-toggle")).toBeNull();
+    expect(container.querySelector(".library-count")).toBeNull();
+  });
+
+  it("shows 'no roles' and a disabled toggle for an admin with an empty roles array", () => {
+    const { container } = renderAdmins([
+      { email: "empty@example.com", roles: [] },
+    ]);
+    const toggle = container.querySelector<HTMLButtonElement>(
+      ".association-toggle"
+    );
+    expect(toggle).not.toBeNull();
+    expect(toggle.disabled).toBe(true);
+    expect(container.querySelector(".library-count").textContent).toBe(
+      " (no roles)"
+    );
+  });
+
+  it("shows '1 role' for a system admin", () => {
+    const { container } = renderAdmins([
+      { email: "sys@example.com", roles: [{ role: "system" }] },
+    ]);
+    expect(container.querySelector(".library-count").textContent).toBe(
+      " (1 role)"
+    );
+  });
+
+  it("shows 'N roles' for an admin with multiple role entries", () => {
+    const { container } = renderAdmins([
+      {
+        email: "mgr@example.com",
+        roles: [
+          { role: "manager", library: "alpha" },
+          { role: "manager", library: "beta" },
+          { role: "librarian", library: "gamma" },
+        ],
+      },
+    ]);
+    expect(container.querySelector(".library-count").textContent).toBe(
+      " (3 roles)"
+    );
+  });
+
+  it("counts deduplicated display entries, not raw roles, when a library has both manager and librarian roles", () => {
+    // Two raw roles for the same library collapse to one display entry (highest wins).
+    // The count shown to the user should reflect what is displayed, not item.roles.length.
+    const { container } = renderAdmins([
+      {
+        email: "mgr@example.com",
+        roles: [
+          { role: "librarian", library: "alpha" },
+          { role: "manager", library: "alpha" },
+        ],
+      },
+    ]);
+    expect(container.querySelector(".library-count").textContent).toBe(
+      " (1 role)"
+    );
+  });
+
+  // ── System admin ──────────────────────────────────────────────────────────
+
+  it("shows only 'sysadmin' in the expanded list for a system-role admin", () => {
+    const { container } = renderAdmins([
+      { email: "sys@example.com", roles: [{ role: "system" }] },
+    ]);
+    fireEvent.click(container.querySelector(".association-toggle"));
+
+    const items = container.querySelectorAll(".associated-items li");
+    expect(items).toHaveLength(1);
+    expect(items[0].textContent).toBe("sysadmin");
+  });
+
+  it("shows only 'sysadmin' even when other roles are also present", () => {
+    const { container } = renderAdmins([
+      {
+        email: "sys@example.com",
+        roles: [{ role: "system" }, { role: "manager", library: "alpha" }],
+      },
+    ]);
+    fireEvent.click(container.querySelector(".association-toggle"));
+
+    const items = container.querySelectorAll(".associated-items li");
+    expect(items).toHaveLength(1);
+    expect(items[0].textContent).toBe("sysadmin");
+  });
+
+  // ── Library-specific roles ────────────────────────────────────────────────
+
+  it("shows '<library> - Manager' for a library manager role", () => {
+    const { container } = renderAdmins([
+      {
+        email: "mgr@example.com",
+        roles: [{ role: "manager", library: "alpha" }],
+      },
+    ]);
+    fireEvent.click(container.querySelector(".association-toggle"));
+
+    const items = container.querySelectorAll(".associated-items li");
+    expect(items).toHaveLength(1);
+    expect(items[0].textContent).toBe("Alpha Library - Manager");
+  });
+
+  it("shows '<library> - Librarian' for a librarian role", () => {
+    const { container } = renderAdmins([
+      {
+        email: "lib@example.com",
+        roles: [{ role: "librarian", library: "beta" }],
+      },
+    ]);
+    fireEvent.click(container.querySelector(".association-toggle"));
+
+    const items = container.querySelectorAll(".associated-items li");
+    expect(items).toHaveLength(1);
+    expect(items[0].textContent).toBe("Beta Library - Librarian");
+  });
+
+  it("shows the highest role (Manager) when a library has both manager and librarian roles", () => {
+    const { container } = renderAdmins([
+      {
+        email: "mgr@example.com",
+        roles: [
+          { role: "librarian", library: "alpha" },
+          { role: "manager", library: "alpha" },
+        ],
+      },
+    ]);
+    fireEvent.click(container.querySelector(".association-toggle"));
+
+    const items = container.querySelectorAll(".associated-items li");
+    expect(items).toHaveLength(1);
+    expect(items[0].textContent).toBe("Alpha Library - Manager");
+  });
+
+  // ── Sitewide roles ────────────────────────────────────────────────────────
+
+  it("shows 'All libraries - Manager' for a manager-all role", () => {
+    const { container } = renderAdmins([
+      { email: "mgr@example.com", roles: [{ role: "manager-all" }] },
+    ]);
+    fireEvent.click(container.querySelector(".association-toggle"));
+
+    const items = container.querySelectorAll(".associated-items li");
+    expect(items[0].textContent).toBe("All libraries - Manager");
+  });
+
+  it("shows 'All libraries - Librarian' for a librarian-all role", () => {
+    const { container } = renderAdmins([
+      { email: "lib@example.com", roles: [{ role: "librarian-all" }] },
+    ]);
+    fireEvent.click(container.querySelector(".association-toggle"));
+
+    const items = container.querySelectorAll(".associated-items li");
+    expect(items[0].textContent).toBe("All libraries - Librarian");
+  });
+
+  it("shows Manager (not Librarian) when both manager-all and librarian-all are present", () => {
+    const { container } = renderAdmins([
+      {
+        email: "mgr@example.com",
+        roles: [{ role: "librarian-all" }, { role: "manager-all" }],
+      },
+    ]);
+    fireEvent.click(container.querySelector(".association-toggle"));
+
+    const items = container.querySelectorAll(".associated-items li");
+    // Only the manager-all entry; librarian-all is superseded.
+    expect(Array.from(items).map((li) => li.textContent)).toEqual([
+      "All libraries - Manager",
+    ]);
+  });
+
+  // ── Combined sitewide + library-specific roles ────────────────────────────
+
+  it("shows both 'All libraries' and per-library entries when manager-all and library roles coexist", () => {
+    const { container } = renderAdmins([
+      {
+        email: "mgr@example.com",
+        roles: [
+          { role: "manager-all" },
+          { role: "manager", library: "alpha" },
+          { role: "librarian", library: "beta" },
+        ],
+      },
+    ]);
+    fireEvent.click(container.querySelector(".association-toggle"));
+
+    const items = container.querySelectorAll(".associated-items li");
+    const texts = Array.from(items).map((li) => li.textContent);
+    expect(texts).toContain("All libraries - Manager");
+    expect(texts).toContain("Alpha Library - Manager");
+    expect(texts).toContain("Beta Library - Librarian");
+  });
+
+  it("shows both 'All libraries' and per-library entries when librarian-all and library roles coexist", () => {
+    const { container } = renderAdmins([
+      {
+        email: "lib@example.com",
+        roles: [
+          { role: "librarian-all" },
+          { role: "librarian", library: "gamma" },
+        ],
+      },
+    ]);
+    fireEvent.click(container.querySelector(".association-toggle"));
+
+    const items = container.querySelectorAll(".associated-items li");
+    const texts = Array.from(items).map((li) => li.textContent);
+    expect(texts).toContain("All libraries - Librarian");
+    expect(texts).toContain("Gamma Library - Librarian");
+  });
+
+  // ── Sorting ───────────────────────────────────────────────────────────────
+
+  it("sorts library role entries alphabetically by library display name", () => {
+    const { container } = renderAdmins([
+      {
+        email: "mgr@example.com",
+        roles: [
+          { role: "manager", library: "gamma" },
+          { role: "manager", library: "alpha" },
+          { role: "librarian", library: "beta" },
+        ],
+      },
+    ]);
+    fireEvent.click(container.querySelector(".association-toggle"));
+
+    const items = container.querySelectorAll(".associated-items li");
+    expect(items[0].textContent).toBe("Alpha Library - Manager");
+    expect(items[1].textContent).toBe("Beta Library - Librarian");
+    expect(items[2].textContent).toBe("Gamma Library - Manager");
+  });
+
+  // ── Links ─────────────────────────────────────────────────────────────────
+
+  it("links the library name to its config page when a uuid is available", () => {
+    const { container } = renderAdmins([
+      {
+        email: "mgr@example.com",
+        roles: [{ role: "manager", library: "alpha" }],
+      },
+    ]);
+    fireEvent.click(container.querySelector(".association-toggle"));
+
+    const link = container.querySelector<HTMLAnchorElement>(
+      ".associated-items a"
+    );
+    expect(link).not.toBeNull();
+    expect(link.textContent).toBe("Alpha Library");
+    expect(link.href).toContain("/admin/web/config/libraries/edit/uuid-alpha");
+    // The role suffix should not be part of the link.
+    expect(link.nextSibling.textContent).toBe(" - Manager");
+  });
+
+  it("renders the library name as plain text when no uuid is available", () => {
+    const { container } = renderAdmins([
+      {
+        email: "lib@example.com",
+        roles: [{ role: "librarian", library: "delta" }],
+      },
+    ]);
+    fireEvent.click(container.querySelector(".association-toggle"));
+
+    expect(container.querySelector(".associated-items a")).toBeNull();
+    expect(container.querySelector(".associated-items li").textContent).toBe(
+      "Delta Library - Librarian"
+    );
+  });
+
+  // ── Expand all / Collapse all buttons ────────────────────────────────────
+
+  it("Expand all expands all admins that have roles", () => {
+    const { container } = renderAdmins([
+      { email: "sys@example.com", roles: [{ role: "system" }] },
+      {
+        email: "mgr@example.com",
+        roles: [{ role: "manager", library: "alpha" }],
+      },
+      { email: "none@example.com" }, // no roles field → no toggle
+    ]);
+
+    fireEvent.click(container.querySelector(".expand-all"));
+
+    expect(container.querySelectorAll(".associated-items")).toHaveLength(2);
+  });
+
+  it("Collapse all collapses all expanded admins", () => {
+    const { container } = renderAdmins([
+      { email: "sys@example.com", roles: [{ role: "system" }] },
+      {
+        email: "mgr@example.com",
+        roles: [{ role: "manager", library: "alpha" }],
+      },
+    ]);
+
+    fireEvent.click(container.querySelector(".expand-all"));
+    expect(container.querySelectorAll(".associated-items")).toHaveLength(2);
+
+    fireEvent.click(container.querySelector(".collapse-all"));
+    expect(container.querySelectorAll(".associated-items")).toHaveLength(0);
+  });
+
+  // ── Alt+click toggle-all ──────────────────────────────────────────────────
+
+  it("alt+click expands all admins that have roles", () => {
+    const { container } = renderAdmins([
+      { email: "sys@example.com", roles: [{ role: "system" }] },
+      {
+        email: "mgr@example.com",
+        roles: [{ role: "manager", library: "alpha" }],
+      },
+      { email: "none@example.com" }, // no roles field → no toggle
+    ]);
+    const toggles = container.querySelectorAll(".association-toggle");
+    expect(toggles).toHaveLength(2);
+
+    fireEvent.click(toggles[0], { altKey: true });
+
+    expect(container.querySelectorAll(".associated-items")).toHaveLength(2);
+  });
+
+  it("alt+click collapses all when all are already expanded", () => {
+    const { container } = renderAdmins([
+      { email: "sys@example.com", roles: [{ role: "system" }] },
+      {
+        email: "mgr@example.com",
+        roles: [{ role: "manager", library: "alpha" }],
+      },
+    ]);
+    const toggles = container.querySelectorAll(".association-toggle");
+
+    fireEvent.click(toggles[0], { altKey: true });
+    expect(container.querySelectorAll(".associated-items")).toHaveLength(2);
+
+    fireEvent.click(toggles[0], { altKey: true });
+    expect(container.querySelectorAll(".associated-items")).toHaveLength(0);
+  });
+});

package/tests/jest/components/PatronAuthServiceEditForm.test.tsx

@@ -2,6 +2,7 @@ import * as React from "react";
 import { render, screen, waitFor } from "@testing-library/react";
 import userEvent from "@testing-library/user-event";
 import * as fetchMock from "fetch-mock-jest";
+import { QueryClient, QueryClientProvider } from "@tanstack/react-query";
 import PatronAuthServiceEditForm from "../../../src/components/PatronAuthServiceEditForm";
 import {
   PatronAuthServicesData,
@@ -66,6 +67,16 @@ function buildSIP2Item(rules: PatronBlockingRule[] = []) {
   };
 }
 
+/** Renders with a fresh QueryClient so useAvailableFields (useQuery) works. */
+function renderForm(element: React.ReactElement) {
+  const queryClient = new QueryClient({
+    defaultOptions: { queries: { retry: false } },
+  });
+  return render(
+    <QueryClientProvider client={queryClient}>{element}</QueryClientProvider>
+  );
+}
+
 // Guard: any blur on the Rule Expression textarea calls validatePatronBlockingRuleExpression.
 // All describe blocks get a default 200 mock so tests that incidentally trigger blur
 // don't fail with "only absolute URLs are supported" from the fetch polyfill.
@@ -80,7 +91,9 @@ afterEach(() => {
 describe("PatronAuthServiceEditForm – capability gating", () => {
   it("shows PatronBlockingRulesEditor in expanded library settings for SIP2", async () => {
     const user = userEvent.setup();
-    render(<PatronAuthServiceEditForm {...baseProps} item={buildSIP2Item()} />);
+    renderForm(
+      <PatronAuthServiceEditForm {...baseProps} item={buildSIP2Item()} />
+    );
 
     await expandLibrariesPanel(user);
     const editButton = screen.getByRole("button", { name: /Edit/i });
@@ -99,7 +112,7 @@ describe("PatronAuthServiceEditForm – capability gating", () => {
       settings: { idp_url: "https://idp.example.com" },
       libraries: [{ short_name: LIBRARY_SHORT_NAME }],
     };
-    render(<PatronAuthServiceEditForm {...baseProps} item={item} />);
+    renderForm(<PatronAuthServiceEditForm {...baseProps} item={item} />);
     await expandLibrariesPanel(user);
 
     // For non-SIP2 with no library_settings, the Edit button should not render
@@ -119,7 +132,7 @@ describe("PatronAuthServiceEditForm – load / initial value", () => {
         message: "Card expired",
       },
     ];
-    render(
+    renderForm(
       <PatronAuthServiceEditForm
         {...baseProps}
         item={buildSIP2Item(existingRules)}
@@ -144,7 +157,7 @@ describe("PatronAuthServiceEditForm – load / initial value", () => {
 
   it("shows empty editor when library has no existing patron_blocking_rules", async () => {
     const user = userEvent.setup();
-    render(
+    renderForm(
       <PatronAuthServiceEditForm {...baseProps} item={buildSIP2Item([])} />
     );
 
@@ -160,7 +173,7 @@ describe("PatronAuthServiceEditForm – error display", () => {
   it("passes error prop down to PatronBlockingRulesEditor", async () => {
     const user = userEvent.setup();
     const error = { status: 400, response: "Validation failed", url: "" };
-    render(
+    renderForm(
       <PatronAuthServiceEditForm
         {...baseProps}
         item={buildSIP2Item([{ name: "", rule: "expr", message: null }])}
@@ -180,7 +193,9 @@ describe("PatronAuthServiceEditForm – error display", () => {
 describe("PatronAuthServiceEditForm – serialization", () => {
   it("includes patron_blocking_rules in the library state when editLibrary is called", async () => {
     const user = userEvent.setup();
-    render(<PatronAuthServiceEditForm {...baseProps} item={buildSIP2Item()} />);
+    renderForm(
+      <PatronAuthServiceEditForm {...baseProps} item={buildSIP2Item()} />
+    );
 
     await expandLibrariesPanel(user);
     const editButton = screen.getByRole("button", { name: /Edit/i });
@@ -215,7 +230,7 @@ describe("PatronAuthServiceEditForm – serialization", () => {
       settings: {},
       libraries: [],
     };
-    render(<PatronAuthServiceEditForm {...baseProps} item={item} />);
+    renderForm(<PatronAuthServiceEditForm {...baseProps} item={item} />);
 
     await expandLibrariesPanel(user);
     // Select the library from the dropdown
@@ -246,7 +261,9 @@ describe("PatronAuthServiceEditForm – serialization", () => {
 describe("PatronAuthServiceEditForm – save button gating", () => {
   it("disables the per-library Save button immediately when a new rule is added", async () => {
     const user = userEvent.setup();
-    render(<PatronAuthServiceEditForm {...baseProps} item={buildSIP2Item()} />);
+    renderForm(
+      <PatronAuthServiceEditForm {...baseProps} item={buildSIP2Item()} />
+    );
 
     await expandLibrariesPanel(user);
     await user.click(screen.getByRole("button", { name: /Edit/i }));
@@ -258,7 +275,9 @@ describe("PatronAuthServiceEditForm – save button gating", () => {
 
   it("re-enables the per-library Save button once validation succeeds", async () => {
     const user = userEvent.setup();
-    render(<PatronAuthServiceEditForm {...baseProps} item={buildSIP2Item()} />);
+    renderForm(
+      <PatronAuthServiceEditForm {...baseProps} item={buildSIP2Item()} />
+    );
 
     await expandLibrariesPanel(user);
     await user.click(screen.getByRole("button", { name: /Edit/i }));
@@ -280,7 +299,9 @@ describe("PatronAuthServiceEditForm – save button gating", () => {
       body: { detail: "Unknown placeholder" },
     });
 
-    render(<PatronAuthServiceEditForm {...baseProps} item={buildSIP2Item()} />);
+    renderForm(
+      <PatronAuthServiceEditForm {...baseProps} item={buildSIP2Item()} />
+    );
 
     await expandLibrariesPanel(user);
     await user.click(screen.getByRole("button", { name: /Edit/i }));
@@ -302,7 +323,7 @@ describe("PatronAuthServiceEditForm – save button gating", () => {
       settings: {},
       libraries: [],
     };
-    render(<PatronAuthServiceEditForm {...baseProps} item={item} />);
+    renderForm(<PatronAuthServiceEditForm {...baseProps} item={item} />);
 
     await expandLibrariesPanel(user);
     const select = screen.getByRole("combobox", { name: /Add Library/i });
@@ -324,7 +345,7 @@ describe("PatronAuthServiceEditForm – save button gating", () => {
       { name: "Rule A", rule: "expr_a" },
       { name: "Rule B", rule: "expr_b" },
     ];
-    render(
+    renderForm(
       <PatronAuthServiceEditForm
         {...baseProps}
         item={buildSIP2Item(existingRules)}
@@ -354,7 +375,7 @@ describe("PatronAuthServiceEditForm – save button gating", () => {
       { name: "Rule A", rule: "expr_a" },
       { name: "Rule A", rule: "expr_b" }, // starts as duplicate
     ];
-    render(
+    renderForm(
       <PatronAuthServiceEditForm
         {...baseProps}
         item={buildSIP2Item(existingRules)}
@@ -380,7 +401,7 @@ describe("PatronAuthServiceEditForm – save button gating", () => {
   it("re-blocks and then re-enables the Save button when an existing rule's expression is edited and re-validated", async () => {
     const user = userEvent.setup();
     const existingRules = [{ name: "Rule A", rule: "expr_a" }];
-    render(
+    renderForm(
       <PatronAuthServiceEditForm
         {...baseProps}
         item={buildSIP2Item(existingRules)}
@@ -411,7 +432,7 @@ describe("PatronAuthServiceEditForm – save button gating", () => {
 describe("PatronAuthServiceEditForm – csrfToken / serviceId wiring", () => {
   it("passes the csrfToken from additionalData to the validation API request", async () => {
     const user = userEvent.setup();
-    render(
+    renderForm(
       <PatronAuthServiceEditForm
         {...baseProps}
         item={buildSIP2Item()}
@@ -441,7 +462,9 @@ describe("PatronAuthServiceEditForm – csrfToken / serviceId wiring", () => {
   it("passes the item id as service_id in the validation API request body", async () => {
     const user = userEvent.setup();
     // item.id = 1 (from buildSIP2Item)
-    render(<PatronAuthServiceEditForm {...baseProps} item={buildSIP2Item()} />);
+    renderForm(
+      <PatronAuthServiceEditForm {...baseProps} item={buildSIP2Item()} />
+    );
 
     await expandLibrariesPanel(user);
     await user.click(screen.getByRole("button", { name: /Edit/i }));