@theokit/sdk-tools 0.20.0 → 0.20.1

package/CHANGELOG.md

@@ -1,5 +1,20 @@
 # Changelog
 
+## 0.20.1
+
+### Patch Changes
+
+- apply_patch (V4A) M18 review fixes — a security-critical writing tool hardened after adversarial review:
+  - **Security:** the forbidden-secret guard now blocks `.env`/`.git`/`node_modules`/`.theo` at ANY path
+    depth (not just the first segment) and defeats absolute-path spelling (`<root>/.env`) — closing a hole
+    where a nested `sub/.git/hooks/…` or an absolute secret path could be written.
+  - **Contract:** every fs error (`EISDIR`/`ENOTDIR`/`EACCES`/…) maps to a typed `{ ok: false, error: 'io_error' }`
+    instead of throwing out of the handler (the "always JSON" contract now holds).
+  - **Atomicity:** a file touched by two hunks is rejected (`duplicate_target`) — no silent lost-update.
+  - **Safety:** Add over an existing file is rejected (`file_exists`); Delete of a missing file is `not_found`.
+  - **Matching:** `*** End of File` edits of the last line now apply (eof anchoring made a hint with a
+    general-search fallback, fixing the phantom-trailing-newline case).
+
 ## 0.20.0
 
 ### Minor Changes

package/dist/index.cjs

@@ -64,8 +64,8 @@ function realpathOfDeepestExisting(path$1) {
   } catch {
   }
   try {
-    const stat2 = fs.lstatSync(path$1);
-    if (stat2.isSymbolicLink()) {
+    const stat3 = fs.lstatSync(path$1);
+    if (stat3.isSymbolicLink()) {
       const target = fs.readlinkSync(path$1);
       const parentReal = realpathOfDeepestExisting(path.dirname(path$1));
       const parentBase = parentReal ?? path.dirname(path$1);
@@ -267,7 +267,14 @@ function matchesAt(lines, pattern, at, eq) {
 function seekSequence(lines, pattern, searchStart, eof) {
   if (pattern.length === 0) return searchStart;
   if (pattern.length > lines.length) return null;
-  const start = eof ? Math.max(searchStart, lines.length - pattern.length) : searchStart;
+  const starts = eof ? [Math.max(searchStart, lines.length - pattern.length), searchStart] : [searchStart];
+  for (const start of starts) {
+    const hit = searchFrom(lines, pattern, start);
+    if (hit !== null) return hit;
+  }
+  return null;
+}
+function searchFrom(lines, pattern, start) {
   for (const eq of LADDER) {
     for (let i = start; i <= lines.length - pattern.length; i++) {
       if (matchesAt(lines, pattern, i, eq)) return i;
@@ -324,12 +331,28 @@ async function applyV4APatch(projectRoot, patch) {
     const detail = err instanceof V4APatchError ? err.message : String(err);
     return JSON.stringify({ ok: false, error: "parse_error", detail });
   }
-  const plan = await buildPlan(projectRoot, hunks);
-  if ("error" in plan) return plan.error;
-  await executePlan(plan.ops);
-  return JSON.stringify({ ok: true, files_patched: plan.patched });
+  try {
+    const plan = await buildPlan(projectRoot, hunks);
+    if ("error" in plan) return plan.error;
+    await executePlan(plan.ops);
+    return JSON.stringify({ ok: true, files_patched: plan.patched });
+  } catch (err) {
+    return JSON.stringify({
+      ok: false,
+      error: "io_error",
+      detail: err instanceof Error ? err.message : String(err)
+    });
+  }
+}
+function hunkTargets(hunk) {
+  if (hunk.kind === "update" && hunk.movePath) return [hunk.path, hunk.movePath];
+  return [hunk.path];
 }
 async function buildPlan(projectRoot, hunks) {
+  const dup = firstDuplicateTarget(hunks);
+  if (dup !== null) {
+    return { error: JSON.stringify({ ok: false, error: "duplicate_target", path: dup }) };
+  }
   const ops = [];
   const patched = [];
   for (const hunk of hunks) {
@@ -340,6 +363,16 @@ async function buildPlan(projectRoot, hunks) {
   }
   return { ops, patched };
 }
+function firstDuplicateTarget(hunks) {
+  const seen = /* @__PURE__ */ new Set();
+  for (const hunk of hunks) {
+    for (const t of hunkTargets(hunk)) {
+      if (seen.has(t)) return t;
+      seen.add(t);
+    }
+  }
+  return null;
+}
 async function executePlan(ops) {
   for (const op of ops) {
     if ("rm" in op) {
@@ -350,11 +383,29 @@ async function executePlan(ops) {
     }
   }
 }
+async function pathExists(abs) {
+  try {
+    await promises.stat(abs);
+    return true;
+  } catch {
+    return false;
+  }
+}
 async function planHunk(projectRoot, hunk) {
   const scope = v4aScope(projectRoot, hunk.path);
   if ("error" in scope) return scope;
-  if (hunk.kind === "add") return { ops: [{ write: { abs: scope.abs, content: hunk.content } }] };
-  if (hunk.kind === "delete") return { ops: [{ rm: scope.abs }] };
+  if (hunk.kind === "add") {
+    if (await pathExists(scope.abs)) {
+      return { error: JSON.stringify({ ok: false, error: "file_exists", path: hunk.path }) };
+    }
+    return { ops: [{ write: { abs: scope.abs, content: hunk.content } }] };
+  }
+  if (hunk.kind === "delete") {
+    if (!await pathExists(scope.abs)) {
+      return { error: JSON.stringify({ ok: false, error: "not_found", path: hunk.path }) };
+    }
+    return { ops: [{ rm: scope.abs }] };
+  }
   return planUpdate(projectRoot, hunk, scope.abs);
 }
 async function planUpdate(projectRoot, hunk, abs) {
@@ -388,20 +439,25 @@ async function planUpdate(projectRoot, hunk, abs) {
   if ("error" in dest) return dest;
   return { ops: [{ write: { abs: dest.abs, content: updated } }, { rm: abs }] };
 }
+var FORBIDDEN_SEGMENTS = /* @__PURE__ */ new Set([".env", ".git", "node_modules", ".theo"]);
+function isForbiddenRel(rel) {
+  return rel.split(/[/\\]/).filter(Boolean).some((s) => s !== ".env.example" && (FORBIDDEN_SEGMENTS.has(s) || /^\.env\./.test(s)));
+}
 function v4aScope(projectRoot, file) {
-  if (isForbiddenPath(file)) {
-    return { error: JSON.stringify({ ok: false, error: "forbidden_path", path: file }) };
-  }
+  let abs;
   try {
-    const abs = safePathJoin(projectRoot, file);
+    abs = safePathJoin(projectRoot, file);
     assertNoSymlinkEscape(abs, projectRoot);
-    return { abs };
   } catch (err) {
     if (err instanceof PathTraversalError || err instanceof ForbiddenPathError) {
       return { error: JSON.stringify({ ok: false, error: "path_traversal", path: file }) };
     }
     throw err;
   }
+  if (isForbiddenPath(file) || isForbiddenRel(path.relative(projectRoot, abs))) {
+    return { error: JSON.stringify({ ok: false, error: "forbidden_path", path: file }) };
+  }
+  return { abs };
 }
 function createSessionArtifactStore(options) {
   const { dir } = options;
@@ -1548,29 +1604,29 @@ function createListDirTool(opts) {
       path: zod.z.string().min(1).describe("Project-relative directory path. Use '.' for root.")
     }),
     handler: async ({ path }, ctx) => {
-      const relative2 = path === "" || path === "." ? "." : path;
-      if (relative2 !== "." && isForbiddenPath(relative2)) {
+      const relative3 = path === "" || path === "." ? "." : path;
+      if (relative3 !== "." && isForbiddenPath(relative3)) {
         return JSON.stringify({ ok: false, error: "forbidden_path", path });
       }
       if (filesystem$1) {
         const backend = await filesystem.resolveFilesystem(filesystem$1, ctx ?? {});
-        return listViaBackend(backend, relative2, path, max);
+        return listViaBackend(backend, relative3, path, max);
       }
-      return listViaLocalFs(projectRoot, relative2, path, max);
+      return listViaLocalFs(projectRoot, relative3, path, max);
     }
   });
 }
-async function listViaLocalFs(projectRoot, relative2, originalPath, max) {
-  const boundary = resolveDirBoundary(relative2, projectRoot, originalPath);
+async function listViaLocalFs(projectRoot, relative3, originalPath, max) {
+  const boundary = resolveDirBoundary(relative3, projectRoot, originalPath);
   if ("error" in boundary) return boundary.error;
   const readResult = await readDirSafe(boundary.absolutePath, originalPath);
   if ("error" in readResult) return readResult.error;
   return formatListing(readResult.dirents, max);
 }
-async function listViaBackend(backend, relative2, originalPath, max) {
+async function listViaBackend(backend, relative3, originalPath, max) {
   let names;
   try {
-    names = await backend.list(relative2);
+    names = await backend.list(relative3);
   } catch (err) {
     if (err instanceof filesystem.FileNotFoundError) {
       return JSON.stringify({ ok: false, error: "not_found", path: originalPath });
@@ -1584,7 +1640,7 @@ async function listViaBackend(backend, relative2, originalPath, max) {
   const windowed = names.slice(0, max);
   const entries = await Promise.all(
     windowed.map(async (name) => {
-      const child = relative2 === "." ? name : `${relative2}/${name}`;
+      const child = relative3 === "." ? name : `${relative3}/${name}`;
       let type = "file";
       try {
         type = (await backend.stat(child)).isDirectory ? "directory" : "file";
@@ -1595,9 +1651,9 @@ async function listViaBackend(backend, relative2, originalPath, max) {
   );
   return JSON.stringify({ ok: true, entries, truncated: totalCount > max, totalCount });
 }
-function resolveDirBoundary(relative2, projectRoot, originalPath) {
+function resolveDirBoundary(relative3, projectRoot, originalPath) {
   try {
-    const absolutePath = relative2 === "." ? projectRoot : safePathJoin(projectRoot, relative2);
+    const absolutePath = relative3 === "." ? projectRoot : safePathJoin(projectRoot, relative3);
     assertNoSymlinkEscape(absolutePath, projectRoot);
     return { absolutePath };
   } catch (err) {
@@ -1819,22 +1875,22 @@ function createReadFileTool(opts) {
 }
 async function readViaBackend(backend, path, view, onRead) {
   try {
-    const stat2 = await backend.stat(path);
-    if (stat2.size > MAX_FILE_SIZE) {
+    const stat3 = await backend.stat(path);
+    if (stat3.size > MAX_FILE_SIZE) {
       return JSON.stringify({
         ok: false,
         error: "too_large",
         path,
-        size: stat2.size,
+        size: stat3.size,
         limit: MAX_FILE_SIZE
       });
     }
     const raw = await backend.readFile(path);
     if (raw.includes("\0")) {
-      return JSON.stringify({ ok: false, error: "binary_file", path, size: stat2.size });
+      return JSON.stringify({ ok: false, error: "binary_file", path, size: stat3.size });
     }
-    onRead?.(stat2.mtimeMs);
-    return JSON.stringify({ ok: true, content: renderView(raw, view), size: stat2.size });
+    onRead?.(stat3.mtimeMs);
+    return JSON.stringify({ ok: true, content: renderView(raw, view), size: stat3.size });
   } catch (err) {
     if (err instanceof filesystem.FileNotFoundError) {
       return JSON.stringify({ ok: false, error: "not_found", path });
@@ -1873,22 +1929,22 @@ async function openHandleSafe(absolutePath, path) {
   }
 }
 async function readContent(handle, path, view, onRead) {
-  const stat2 = await handle.stat();
-  if (stat2.size > MAX_FILE_SIZE) {
+  const stat3 = await handle.stat();
+  if (stat3.size > MAX_FILE_SIZE) {
     return JSON.stringify({
       ok: false,
       error: "too_large",
       path,
-      size: stat2.size,
+      size: stat3.size,
       limit: MAX_FILE_SIZE
     });
   }
-  if (await isBinaryProbe(handle, Number(stat2.size))) {
-    return JSON.stringify({ ok: false, error: "binary_file", path, size: stat2.size });
+  if (await isBinaryProbe(handle, Number(stat3.size))) {
+    return JSON.stringify({ ok: false, error: "binary_file", path, size: stat3.size });
   }
   const raw = await handle.readFile({ encoding: "utf-8" });
-  onRead?.(stat2.mtimeMs);
-  return JSON.stringify({ ok: true, content: renderView(raw, view), size: stat2.size });
+  onRead?.(stat3.mtimeMs);
+  return JSON.stringify({ ok: true, content: renderView(raw, view), size: stat3.size });
 }
 async function isBinaryProbe(handle, size) {
   const probeLen = Math.min(BINARY_PROBE_BYTES, size);
@@ -2804,12 +2860,12 @@ async function writeViaBackend(backend, path, content, guard) {
       if (rbw) return rbw;
       expectedMtime = current ?? void 0;
     }
-    const stat2 = await backend.writeFile(
+    const stat3 = await backend.writeFile(
       path,
       content,
       expectedMtime !== void 0 ? { expectedMtime } : void 0
     );
-    return JSON.stringify({ ok: true, path, bytes: stat2.size });
+    return JSON.stringify({ ok: true, path, bytes: stat3.size });
   } catch (err) {
     return backendErrorToJson(err, path);
   }
@@ -2837,8 +2893,8 @@ async function isBinaryFile(absolutePath) {
     return false;
   }
   try {
-    const stat2 = await handle.stat();
-    const probeLen = Math.min(BINARY_PROBE_BYTES3, Number(stat2.size));
+    const stat3 = await handle.stat();
+    const probeLen = Math.min(BINARY_PROBE_BYTES3, Number(stat3.size));
     if (probeLen <= 0) return false;
     const probe = Buffer.alloc(probeLen);
     const { bytesRead } = await handle.read(probe, 0, probeLen, 0);