@theokit/sdk-tools 0.15.0 → 0.15.1

package/CHANGELOG.md

@@ -1,5 +1,16 @@
 # Changelog
 
+## 0.15.1
+
+### Patch Changes
+
+- 4c5bd35: M15 review fixes (injected fs path only; local path unaffected): (1) the backend directory walk in
+  `glob_files`/`search_text` decides entry type via `stat` (which follows symlinks), so an in-boundary
+  symlink cycle could recurse until PATH_MAX — now depth-capped so it terminates; (2) `edit_file`'s
+  backend read mapped every failure to `not_found` — now only a genuinely missing file (`FileNotFoundError`)
+  maps to `not_found`; any other read error (e.g. a directory, a permission error) propagates (fail-loud),
+  matching the local path's ENOENT-only classification.
+
 ## 0.15.0
 
 ### Minor Changes

package/dist/index.cjs

@@ -381,8 +381,11 @@ async function editViaBackend(filesystem$1, ctx, path, old_string, new_string) {
   let content;
   try {
     content = await backend.readFile(path);
-  } catch {
-    return JSON.stringify({ ok: false, error: "not_found", path });
+  } catch (err) {
+    if (err instanceof filesystem.FileNotFoundError) {
+      return JSON.stringify({ ok: false, error: "not_found", path });
+    }
+    throw err;
   }
   const outcome = computeEdit(content, old_string, new_string);
   if (!outcome.ok) return JSON.stringify({ ok: false, error: "no_match", path });
@@ -656,6 +659,7 @@ function runGitProcess(cwd, args, timeoutMs, maxStdoutBytes) {
   });
 }
 var DEFAULT_EXCLUDES = /* @__PURE__ */ new Set(["node_modules", ".git", "dist", ".theo"]);
+var MAX_BACKEND_WALK_DEPTH = 64;
 function createGlobTool(opts) {
   const { projectRoot, filesystem: filesystem$1 } = opts;
   return sdk.Tool.create({
@@ -673,7 +677,7 @@ function createGlobTool(opts) {
         const backend = await filesystem.resolveFilesystem(filesystem$1, ctx ?? {});
         const searchRel = cwd ?? "";
         const found = [];
-        await walkDirBackend(backend, searchRel, searchRel, regex, found);
+        await walkDirBackend(backend, searchRel, searchRel, regex, found, 0);
         return JSON.stringify({ ok: true, files: found.sort(), count: found.length });
       }
       const searchRoot = cwd ? safePathJoin(projectRoot, cwd) : projectRoot;
@@ -714,7 +718,8 @@ async function walkDir(base, dir, pattern, results) {
     }
   }
 }
-async function walkDirBackend(backend, base, dir, pattern, results) {
+async function walkDirBackend(backend, base, dir, pattern, results, depth) {
+  if (depth > MAX_BACKEND_WALK_DEPTH) return;
   let names;
   try {
     names = await backend.list(dir);
@@ -722,10 +727,10 @@ async function walkDirBackend(backend, base, dir, pattern, results) {
     return;
   }
   for (const name of names) {
-    await walkBackendEntry(backend, base, dir, name, pattern, results);
+    await walkBackendEntry(backend, base, dir, name, pattern, results, depth);
   }
 }
-async function walkBackendEntry(backend, base, dir, name, pattern, results) {
+async function walkBackendEntry(backend, base, dir, name, pattern, results, depth) {
   if (DEFAULT_EXCLUDES.has(name)) return;
   const fullRel = dir === "" ? name : `${dir}/${name}`;
   const relPath = base === "" ? fullRel : path.relative(base, fullRel);
@@ -736,7 +741,7 @@ async function walkBackendEntry(backend, base, dir, name, pattern, results) {
     return;
   }
   if (st.isDirectory) {
-    await walkDirBackend(backend, base, fullRel, pattern, results);
+    await walkDirBackend(backend, base, fullRel, pattern, results, depth + 1);
   } else if (st.isFile && pattern.test(relPath)) {
     results.push(fullRel);
   }
@@ -1808,6 +1813,7 @@ var DEFAULT_MAX_MATCHES = 100;
 var DEFAULT_MAX_FILE_SIZE = 1024 * 1024;
 var BINARY_PROBE_BYTES2 = 8 * 1024;
 var PREVIEW_MAX = 200;
+var MAX_BACKEND_WALK_DEPTH2 = 64;
 function createSearchTextTool(opts) {
   const {
     projectRoot,
@@ -1836,7 +1842,7 @@ function createSearchTextTool(opts) {
         const scopeRel = resolveScopeRel(path, projectRoot);
         if ("error" in scopeRel) return scopeRel.error;
         const backend = await filesystem.resolveFilesystem(filesystem$1, ctx ?? {});
-        await walkBackend(backend, scopeRel.rel, state);
+        await walkBackend(backend, scopeRel.rel, state, 0);
         return JSON.stringify({
           ok: true,
           matches: state.matches,
@@ -1946,8 +1952,9 @@ function resolveScopeRel(path, projectRoot) {
     throw err;
   }
 }
-async function walkBackend(backend, dirRel, state) {
+async function walkBackend(backend, dirRel, state, depth) {
   if (state.truncated) return;
+  if (depth > MAX_BACKEND_WALK_DEPTH2) return;
   let names;
   try {
     names = await backend.list(dirRel);
@@ -1956,10 +1963,10 @@ async function walkBackend(backend, dirRel, state) {
   }
   for (const name of names) {
     if (state.truncated) return;
-    await handleBackendEntry(backend, dirRel, name, state);
+    await handleBackendEntry(backend, dirRel, name, state, depth);
   }
 }
-async function handleBackendEntry(backend, dirRel, name, state) {
+async function handleBackendEntry(backend, dirRel, name, state, depth) {
   const entryRel = dirRel === "" ? name : `${dirRel}/${name}`;
   if (isForbiddenPath(entryRel)) return;
   let st;
@@ -1969,7 +1976,7 @@ async function handleBackendEntry(backend, dirRel, name, state) {
     return;
   }
   if (st.isDirectory) {
-    await walkBackend(backend, entryRel, state);
+    await walkBackend(backend, entryRel, state, depth + 1);
   } else if (st.isFile) {
     await scanFileBackend(backend, entryRel, st.size, state);
   }