@themarioga/grid-editor 8.10.1 → 9.0.0-beta.1

package/package.json

@@ -32,7 +32,7 @@
   "publishConfig": {
     "access": "public"
   },
-  "version": "8.10.1",
+  "version": "9.0.0-beta.1",
   "main": "dist/grideditor.js",
   "module": "dist/grideditor.esm.js",
   "types": "dist/grideditor.d.ts",

package/src/js/grideditor.js

@@ -403,7 +403,7 @@ function build(instance, baseElem, optionsOrMethod) {
             'toolbar_overflow'  : 'menu', // What doesn't fit on one line: 'menu' behind a button, 'wrap' onto another line
             'drawer_overflow'   : 'menu', // The same for the drawers' tools: 'menu' behind a button, 'wrap' onto another line
             'toolbar_groups'    : false, // The add buttons in categories, one shown at a time, picked with tabs
-            'active_target'     : false, // A click in a column makes it where the toolbar's buttons add
+            'active_target'     : false, // A click in a column makes it where the toolbar's buttons add. The 'sidebar' panel turns it on
             'element_tools'     : [], // Host tools on element drawers, same shape as row_tools
             'element_classes'   : [], // Preset class toggles on an element's settings panel
             // content_types, text_tools and text_classes are the text editor
@@ -442,6 +442,16 @@ function build(instance, baseElem, optionsOrMethod) {
             settings[name] = Object.assign({}, NESTED_SETTINGS[name], settings[name]);
         });
 
+        // The sidebar shows what is selected and the toolbar adds to the
+        // target: both follow the node last clicked, so one asks for the other.
+        // Read from what the host gave, as the default is already in settings
+        if (settings.settings_panel === 'sidebar') {
+            if (optionsOrMethod && optionsOrMethod.active_target === false) {
+                throw new TypeError('grid-editor: settings_panel "sidebar" needs active_target; leave it out or set it to true');
+            }
+            settings.active_target = true;
+        }
+
 
         // Elems
         var canvas,

package/types/grideditor.d.ts

@@ -161,7 +161,7 @@ export interface GridEditorOptions {
     drawer_overflow?: 'menu' | 'wrap';
     /** The add buttons in categories - rows, content, and a plugin's own - one shown at a time, chosen with tabs. Default false. */
     toolbar_groups?: boolean;
-    /** A click in a column or a section makes it where the toolbar's buttons add. Default false. */
+    /** A click in a column or a section makes it where the toolbar's buttons add. Default false, and true with settings_panel 'sidebar', which throws if it is given false. */
     active_target?: boolean;
     /** The plugins to use, of any kind; null is every one loaded. */
     plugins?: string[] | null;
@@ -195,7 +195,7 @@ export interface GridEditorOptions {
     locale_strings?: Record<string, string>;
     callbacks?: Partial<GridEditorCallbacks>;
     confirm_delete?: boolean;
-    /** Where a node's settings open. 'sidebar' is a panel that stays on the right while editing, showing the selected node's; one editor per page has it. */
+    /** Where a node's settings open. 'sidebar' is a panel that stays on the right while editing, showing the selected node's; one editor per page has it. It turns active_target on, and the constructor throws a TypeError if active_target is false. */
     settings_panel?: 'offcanvas' | 'popover' | 'modal' | 'inline' | 'sidebar';
     /** The 'sidebar' panel. */
     sidebar?: SidebarSettings;
@@ -487,7 +487,7 @@ export declare class GridEditor {
     /** Take the editor off: the markup stays, everything else goes. */
     destroy(): this;
     changeView(view: View): this;
-    /** The column or region the toolbar adds to, or null. Null without active_target. */
+    /** The column or region the toolbar adds to, or null. Null without active_target, which settings_panel 'sidebar' turns on. */
     getActiveTarget(): HTMLElement | null;
     /** Make a column or region, or the first a selector matches, where the toolbar adds; null for none. */
     setActiveTarget(target: HTMLElement | string | null): this;