@theia/terminal 1.74.0-next.8 → 1.74.0

package/src/browser/terminal-file-uri-link-provider.spec.ts

@@ -0,0 +1,203 @@
+// *****************************************************************************
+// Copyright (C) 2026 JuliaHub, Inc. and others.
+//
+// This program and the accompanying materials are made available under the
+// terms of the Eclipse Public License v. 2.0 which is available at
+// http://www.eclipse.org/legal/epl-2.0.
+//
+// This Source Code may also be made available under the following Secondary
+// Licenses when the conditions for such availability set forth in the Eclipse
+// Public License v. 2.0 are satisfied: GNU General Public License, version 2
+// with the GNU Classpath Exception which is available at
+// https://www.gnu.org/software/classpath/license.html.
+//
+// SPDX-License-Identifier: EPL-2.0 OR GPL-2.0-only WITH Classpath-exception-2.0
+// *****************************************************************************
+
+import { enableJSDOM } from '@theia/core/lib/browser/test/jsdom';
+const disableJSDOM = enableJSDOM();
+// Importing the provider pulls in xterm, which probes a canvas 2d context on load; JSDOM has no
+// canvas backend, so stub it out to keep this spec runnable without the native `canvas` package.
+(HTMLCanvasElement.prototype as unknown as { getContext: () => unknown }).getContext = () => undefined;
+
+import { FrontendApplicationConfigProvider } from '@theia/core/lib/browser/frontend-application-config-provider';
+FrontendApplicationConfigProvider.set({});
+
+import * as chai from 'chai';
+import { ILogger } from '@theia/core';
+import { OpenerService, OpenHandler } from '@theia/core/lib/browser';
+import URI from '@theia/core/lib/common/uri';
+import { FileService } from '@theia/filesystem/lib/browser/file-service';
+import { TerminalWidget } from './base/terminal-widget';
+import { FileUriLinkProvider } from './terminal-file-uri-link-provider';
+
+disableJSDOM();
+
+const expect = chai.expect;
+
+class TestFileUriLinkProvider extends FileUriLinkProvider {
+    readonly loggedErrors: string[] = [];
+    readonly opened: string[] = [];
+    readonly openedOptions: unknown[] = [];
+
+    constructor(existingFiles: string[], directories: string[] = []) {
+        super();
+        const files = new Set(existingFiles);
+        const dirs = new Set(directories.map(uri => new URI(uri).toString()));
+        (this as unknown as { logger: ILogger }).logger = {
+            error: (message: unknown) => { this.loggedErrors.push(String(message)); }
+        } as unknown as ILogger;
+        (this as unknown as { fileService: FileService }).fileService = {
+            resolve: async (uri: URI) => {
+                if (dirs.has(uri.toString())) {
+                    return { isDirectory: true };
+                }
+                if (files.has(uri.toString())) {
+                    return { isDirectory: false };
+                }
+                throw new Error('does not exist');
+            }
+        } as unknown as FileService;
+        const opener: OpenHandler = {
+            id: 'test',
+            canHandle: () => 1,
+            open: async (uri: URI, options?: unknown) => {
+                this.opened.push(uri.toString());
+                this.openedOptions.push(options);
+                return undefined;
+            }
+        };
+        (this as unknown as { openerService: OpenerService }).openerService = {
+            getOpener: async () => opener,
+            getOpeners: async () => [opener]
+        } as unknown as OpenerService;
+    }
+}
+
+const terminal = {} as unknown as TerminalWidget;
+
+describe('FileUriLinkProvider', () => {
+
+    it('should linkify and open a POSIX file:// URL that resolves to a file', async () => {
+        const uri = 'file:///home/user/project/file.ts';
+        const provider = new TestFileUriLinkProvider([uri]);
+        const links = await provider.provideLinks(`open ${uri} now`, terminal);
+        expect(links).to.have.lengthOf(1);
+        expect(links[0].startIndex).to.equal('open '.length);
+        expect(links[0].length).to.equal(uri.length);
+        expect(provider.loggedErrors).to.deep.equal([]);
+        await links[0].handle();
+        expect(provider.opened).to.deep.equal([new URI(uri).toString()]);
+    });
+
+    it('should linkify a Windows drive file:// URL', async () => {
+        const uri = 'file:///C:/Users/dev/file.ts';
+        const provider = new TestFileUriLinkProvider([new URI(uri).toString()]);
+        const links = await provider.provideLinks(`see ${uri}`, terminal);
+        expect(links).to.have.lengthOf(1);
+        expect(provider.loggedErrors).to.deep.equal([]);
+    });
+
+    it('should linkify a UNC file:// URL with an authority', async () => {
+        const uri = 'file://server/share/file.ts';
+        const provider = new TestFileUriLinkProvider([new URI(uri).toString()]);
+        const links = await provider.provideLinks(uri, terminal);
+        expect(links).to.have.lengthOf(1);
+        expect(provider.loggedErrors).to.deep.equal([]);
+    });
+
+    it('should not produce a link for a file:// URL that does not resolve, without throwing or logging', async () => {
+        const provider = new TestFileUriLinkProvider([]);
+        const links = await provider.provideLinks('open file:///home/user/missing.ts now', terminal);
+        expect(links).to.deep.equal([]);
+        expect(provider.loggedErrors).to.deep.equal([]);
+    });
+
+    it('should ignore http(s) URLs', async () => {
+        const provider = new TestFileUriLinkProvider([]);
+        const links = await provider.provideLinks('see https://example.com/path for details', terminal);
+        expect(links).to.deep.equal([]);
+    });
+
+    it('should trim trailing sentence punctuation from the matched URL', async () => {
+        const uri = 'file:///home/user/project/file.ts';
+        const provider = new TestFileUriLinkProvider([uri]);
+        const links = await provider.provideLinks(`the file is ${uri}.`, terminal);
+        expect(links).to.have.lengthOf(1);
+        expect(links[0].length).to.equal(uri.length);
+    });
+
+    it('should open at the given line and column for a file://…:line:column suffix', async () => {
+        const uri = 'file:///home/user/project/file.ts';
+        const provider = new TestFileUriLinkProvider([uri]);
+        const match = `${uri}:10:5`;
+        const links = await provider.provideLinks(`error at ${match}`, terminal);
+        expect(links).to.have.lengthOf(1);
+        // The whole `file://…:10:5` is clickable, but the URI drops the position suffix.
+        expect(links[0].length).to.equal(match.length);
+        await links[0].handle();
+        expect(provider.opened).to.deep.equal([new URI(uri).toString()]);
+        // one-based `10:5` becomes a zero-based editor position.
+        expect(provider.openedOptions).to.deep.equal([{ selection: { start: { line: 9, character: 4 } } }]);
+    });
+
+    it('should open at the given line with a file://…:line suffix (no column)', async () => {
+        const uri = 'file:///home/user/project/file.ts';
+        const provider = new TestFileUriLinkProvider([uri]);
+        const links = await provider.provideLinks(`${uri}:42`, terminal);
+        expect(links).to.have.lengthOf(1);
+        await links[0].handle();
+        expect(provider.opened).to.deep.equal([new URI(uri).toString()]);
+        expect(provider.openedOptions).to.deep.equal([{ selection: { start: { line: 41, character: 0 } } }]);
+    });
+
+    it('should keep the Windows drive colon and still apply a trailing position', async () => {
+        const uri = 'file:///C:/Users/dev/file.ts';
+        const provider = new TestFileUriLinkProvider([new URI(uri).toString()]);
+        const links = await provider.provideLinks(`${uri}:7:3`, terminal);
+        expect(links).to.have.lengthOf(1);
+        await links[0].handle();
+        expect(provider.opened).to.deep.equal([new URI(uri).toString()]);
+        expect(provider.openedOptions).to.deep.equal([{ selection: { start: { line: 6, character: 2 } } }]);
+    });
+
+    it('should clamp a zero line/column to the first position', async () => {
+        const uri = 'file:///home/user/project/file.ts';
+        const provider = new TestFileUriLinkProvider([uri]);
+        const links = await provider.provideLinks(`${uri}:0`, terminal);
+        expect(links).to.have.lengthOf(1);
+        await links[0].handle();
+        expect(provider.openedOptions).to.deep.equal([{ selection: { start: { line: 0, character: 0 } } }]);
+    });
+
+    it('should not produce a link for a file:// URL that resolves to a directory', async () => {
+        const uri = 'file:///home/user/project';
+        const provider = new TestFileUriLinkProvider([], [uri]);
+        const links = await provider.provideLinks(`open ${uri} now`, terminal);
+        expect(links).to.deep.equal([]);
+        expect(provider.loggedErrors).to.deep.equal([]);
+    });
+
+    it('should linkify every file:// URL on a line at the correct offsets', async () => {
+        const a = 'file:///home/user/a.ts';
+        const b = 'file:///home/user/b.ts';
+        const provider = new TestFileUriLinkProvider([a, b]);
+        const line = `first ${a} then ${b}`;
+        const links = await provider.provideLinks(line, terminal);
+        expect(links).to.have.lengthOf(2);
+        expect(links.map(link => link.startIndex)).to.deep.equal([line.indexOf(a), line.indexOf(b)]);
+        expect(links.map(link => line.substr(link.startIndex, link.length))).to.deep.equal([a, b]);
+    });
+
+    it('should not leak regex state across concurrent invocations', async () => {
+        const a = 'file:///home/user/a.ts';
+        const b = 'file:///home/user/b.ts';
+        const provider = new TestFileUriLinkProvider([a, b]);
+        const [linksA, linksB] = await Promise.all([
+            provider.provideLinks(`x ${a}`, terminal),
+            provider.provideLinks(b, terminal)
+        ]);
+        expect(linksA.map(link => link.length)).to.deep.equal([a.length]);
+        expect(linksB.map(link => link.length)).to.deep.equal([b.length]);
+    });
+});

package/src/browser/terminal-file-uri-link-provider.ts

@@ -0,0 +1,91 @@
+// *****************************************************************************
+// Copyright (C) 2026 JuliaHub, Inc. and others.
+//
+// This program and the accompanying materials are made available under the
+// terms of the Eclipse Public License v. 2.0 which is available at
+// http://www.eclipse.org/legal/epl-2.0.
+//
+// This Source Code may also be made available under the following Secondary
+// Licenses when the conditions for such availability set forth in the Eclipse
+// Public License v. 2.0 are satisfied: GNU General Public License, version 2
+// with the GNU Classpath Exception which is available at
+// https://www.gnu.org/software/classpath/license.html.
+//
+// SPDX-License-Identifier: EPL-2.0 OR GPL-2.0-only WITH Classpath-exception-2.0
+// *****************************************************************************
+
+import { ILogger } from '@theia/core';
+import URI from '@theia/core/lib/common/uri';
+import { inject, injectable, named } from '@theia/core/shared/inversify';
+import { Position } from '@theia/editor/lib/browser';
+import { AbstractFileOpeningLinkProvider } from './terminal-file-opening-link-provider';
+import { TerminalWidget } from './base/terminal-widget';
+import { TerminalLink } from './terminal-link-provider';
+
+/**
+ * Linkifies `file://` URLs printed in the terminal and opens the referenced local file in the editor.
+ *
+ * A dedicated provider is needed because `UrlLinkProvider` only matches `http(s)` and
+ * `FileLinkProvider`'s path regex excludes `:`, so neither recognizes the `file:` scheme.
+ */
+@injectable()
+export class FileUriLinkProvider extends AbstractFileOpeningLinkProvider {
+
+    @inject(ILogger) @named('terminal:FileUriLinkProvider')
+    protected readonly logger: ILogger;
+
+    // The optional third slash denotes an empty authority (`file:///path`); the match runs to the first
+    // whitespace or character that commonly delimits a URL in prose.
+    protected readonly fileUriRegExp = /file:\/\/\/?[^\s'"`<>()[\]]+/g;
+
+    async provideLinks(line: string, terminal: TerminalWidget): Promise<TerminalLink[]> {
+        // Collect all matches synchronously before awaiting: the `g`-flag regex is instance-shared, so
+        // yielding mid-iteration would let a concurrent call corrupt its `lastIndex`.
+        const candidates: Array<{ match: string, startIndex: number }> = [];
+        this.fileUriRegExp.lastIndex = 0;
+        let regExpResult: RegExpExecArray | null;
+        while (regExpResult = this.fileUriRegExp.exec(line)) {
+            candidates.push({ match: this.trimTrailingPunctuation(regExpResult[0]), startIndex: regExpResult.index });
+        }
+        const links = await Promise.all(candidates.map(async ({ match, startIndex }) => {
+            const { fileUri, position } = this.splitPosition(match);
+            const uri = this.toURI(fileUri);
+            if (uri && await this.isValidFileURI(uri)) {
+                return { startIndex, length: match.length, handle: () => this.openURI(uri, position) };
+            }
+            return undefined;
+        }));
+        return links.filter((link): link is TerminalLink => link !== undefined);
+    }
+
+    /**
+     * Splits a trailing `:line` or `:line:column` suffix (as in `file:///x.ts:10:5`) off the matched
+     * URL into a one-based editor position. The drive colon of `file:///C:/x.ts` is not affected, as
+     * it is not followed by digits at the end of the string.
+     */
+    protected splitPosition(match: string): { fileUri: string, position?: Position } {
+        const positionMatch = /:(\d+)(?::(\d+))?$/.exec(match);
+        if (!positionMatch) {
+            return { fileUri: match };
+        }
+        const line = Math.max(0, parseInt(positionMatch[1], 10) - 1);
+        const character = positionMatch[2] !== undefined ? Math.max(0, parseInt(positionMatch[2], 10) - 1) : 0;
+        return {
+            fileUri: match.slice(0, positionMatch.index),
+            position: { line, character }
+        };
+    }
+
+    protected toURI(match: string): URI | undefined {
+        try {
+            const uri = new URI(match);
+            return uri.scheme === 'file' ? uri : undefined;
+        } catch {
+            return undefined;
+        }
+    }
+
+    protected trimTrailingPunctuation(match: string): string {
+        return match.replace(/[.,;:]+$/, '');
+    }
+}

package/src/browser/terminal-frontend-contribution.ts

@@ -946,8 +946,13 @@ export class TerminalFrontendContribution implements FrontendApplicationContribu
             keybinding: 'ctrlcmd+k',
             when: 'terminalFocus'
         });
+        // A passthrough binding claims ctrlcmd+v for the terminal (winning over the global
+        // CommonCommands.PASTE binding via the local terminalFocus context) but runs no command,
+        // letting the keystroke reach xterm's native paste event. That avoids the permission-gated
+        // Clipboard API (navigator.clipboard.readText) that the PASTE_TERMINAL command requires, while
+        // preserving bracketed paste. terminal.enablePaste is enforced in TerminalWidgetImpl.customKeyHandler.
         keybindings.registerKeybinding({
-            command: TerminalCommands.PASTE_TERMINAL.id,
+            command: KeybindingRegistry.PASSTHROUGH_PSEUDO_COMMAND,
             keybinding: 'ctrlcmd+v',
             when: 'terminalFocus'
         });

package/src/browser/terminal-frontend-module.ts

@@ -43,6 +43,7 @@ import { QuickAccessContribution } from '@theia/core/lib/browser/quick-input/qui
 import { createXtermLinkFactory, TerminalLinkProvider, TerminalLinkProviderContribution, XtermLinkFactory } from './terminal-link-provider';
 import { UrlLinkProvider } from './terminal-url-link-provider';
 import { FileDiffPostLinkProvider, FileDiffPreLinkProvider, FileLinkProvider, LocalFileLinkProvider } from './terminal-file-link-provider';
+import { FileUriLinkProvider } from './terminal-file-uri-link-provider';
 import {
     ContributedTerminalProfileStore, DefaultProfileStore, DefaultTerminalProfileService,
     TerminalProfileService, TerminalProfileStore, UserTerminalProfileStore
@@ -120,6 +121,8 @@ export default new ContainerModule(bind => {
     // default terminal link provider
     bind(UrlLinkProvider).toSelf().inSingletonScope();
     bind(TerminalLinkProvider).toService(UrlLinkProvider);
+    bind(FileUriLinkProvider).toSelf().inSingletonScope();
+    bind(TerminalLinkProvider).toService(FileUriLinkProvider);
     bind(FileLinkProvider).toSelf().inSingletonScope();
     bind(TerminalLinkProvider).toService(FileLinkProvider);
     bind(FileDiffPreLinkProvider).toSelf().inSingletonScope();

package/src/browser/terminal-widget-impl.ts

@@ -1196,8 +1196,15 @@ export class TerminalWidgetImpl extends TerminalWidget implements StatefulWidget
         if (ctrlCmdCopy && this.enableCopy && this.term.hasSelection()) {
             return false;
         }
-        if (ctrlCmdPaste && this.enablePaste) {
-            return false;
+        if (ctrlCmdPaste) {
+            if (this.enablePaste) {
+                // Defer to the browser's native paste event (see the ctrlcmd+v passthrough keybinding).
+                return false;
+            }
+            // Paste disabled: cancel the native paste so the preference is honored even where xterm
+            // would otherwise let the key through to the browser (e.g. cmd+v on macOS). Non-macOS
+            // ctrl+v still reaches the shell as ^V below.
+            event.preventDefault();
         }
         return true;
     }