@theia/task 1.77.0-next.6 → 1.77.0-next.66

package/src/browser/task-service.spec.ts

@@ -0,0 +1,102 @@
+// *****************************************************************************
+// Copyright (C) 2026 Md. Mehedi Hasan.
+//
+// This program and the accompanying materials are made available under the
+// terms of the Eclipse Public License v. 2.0 which is available at
+// http://www.eclipse.org/legal/epl-2.0.
+//
+// This Source Code may also be made available under the following Secondary
+// Licenses when the conditions for such availability set forth in the Eclipse
+// Public License v. 2.0 are satisfied: GNU General Public License, version 2
+// with the GNU Classpath Exception which is available at
+// https://www.gnu.org/software/classpath/license.html.
+//
+// SPDX-License-Identifier: EPL-2.0 OR GPL-2.0-only WITH Classpath-exception-2.0
+// *****************************************************************************
+
+import { enableJSDOM } from '@theia/core/lib/browser/test/jsdom';
+let disableJSDOM = enableJSDOM();
+
+import { FrontendApplicationConfigProvider } from '@theia/core/lib/browser/frontend-application-config-provider';
+FrontendApplicationConfigProvider.set({});
+
+import * as sinon from 'sinon';
+// TaskService imports xterm, which probes the canvas API during module loading.
+// These tests do not render a terminal, and JSDOM has no canvas backend.
+const canvasContext = sinon.stub(HTMLCanvasElement.prototype, 'getContext');
+
+import { expect } from 'chai';
+import { cancelled } from '@theia/core/lib/common/cancellation';
+import { MockLogger } from '@theia/core/lib/common/test/mock-logger';
+import { RunTaskOption, TaskConfiguration, TaskInfo, TaskScope } from '../common';
+import { TaskResolverRegistry } from './task-contribution';
+import { TaskDefinitionRegistry } from './task-definition-registry';
+import { TaskService } from './task-service';
+
+canvasContext.restore();
+disableJSDOM();
+
+class TestTaskService extends TaskService {
+    override readonly logger = new MockLogger();
+    override readonly taskResolverRegistry = new TaskResolverRegistry();
+    override readonly taskDefinitionRegistry = new TaskDefinitionRegistry();
+    override readonly removeProblemMarkers = sinon.stub<[RunTaskOption?], Promise<void>>().resolves();
+    override readonly runResolvedTask = sinon.stub<[TaskConfiguration, RunTaskOption?], Promise<TaskInfo | undefined>>().resolves();
+
+    resolveAndRun(task: TaskConfiguration): Promise<TaskInfo | undefined> {
+        return this.doRunTask(task);
+    }
+}
+
+describe('TaskService task resolution', () => {
+    let service: TestTaskService;
+    let logError: sinon.SinonStub;
+    const task: TaskConfiguration = { type: 'shell', label: 'input task', _scope: TaskScope.Workspace };
+
+    before(() => {
+        disableJSDOM = enableJSDOM();
+    });
+
+    after(() => {
+        disableJSDOM();
+    });
+
+    beforeEach(() => {
+        service = new TestTaskService();
+        logError = sinon.stub(service.logger, 'error').resolves();
+    });
+
+    for (const stage of ['task', 'execution'] as const) {
+        it(`does not launch a task or log an error when the ${stage} resolver is cancelled`, async () => {
+            const resolver = { resolveTask: sinon.stub().rejects(cancelled()) };
+            if (stage === 'task') {
+                service.taskResolverRegistry.registerTaskResolver('shell', resolver);
+            } else {
+                service.taskResolverRegistry.registerExecutionResolver('shell', resolver);
+            }
+
+            expect(await service.resolveAndRun(task)).to.equal(undefined);
+            sinon.assert.calledOnce(resolver.resolveTask);
+            sinon.assert.notCalled(service.removeProblemMarkers);
+            sinon.assert.notCalled(service.runResolvedTask);
+            sinon.assert.notCalled(logError);
+
+            resolver.resolveTask.resolves(task);
+            await service.resolveAndRun(task);
+            sinon.assert.calledOnce(service.removeProblemMarkers);
+            sinon.assert.calledOnceWithExactly(service.runResolvedTask, task, undefined);
+            sinon.assert.notCalled(logError);
+        });
+    }
+
+    it('still logs unexpected resolver errors without launching the task', async () => {
+        const error = new Error('Unable to resolve task');
+        service.taskResolverRegistry.registerExecutionResolver('shell', {
+            resolveTask: sinon.stub().rejects(error)
+        });
+
+        expect(await service.resolveAndRun(task)).to.equal(undefined);
+        sinon.assert.notCalled(service.runResolvedTask);
+        sinon.assert.calledOnceWithExactly(logError, `Error resolving task '${task.label}': ${error}`);
+    });
+});

package/src/browser/task-service.ts

@@ -16,7 +16,7 @@
 
 import { ApplicationShell, FrontendApplication, QuickPickValue, WidgetManager, WidgetOpenMode } from '@theia/core/lib/browser';
 import { open, OpenerService } from '@theia/core/lib/browser/opener-service';
-import { CommandService, ILogger, nls } from '@theia/core/lib/common';
+import { CommandService, ILogger, isCancelled, nls } from '@theia/core/lib/common';
 import { MessageService } from '@theia/core/lib/common/message-service';
 import { Deferred } from '@theia/core/lib/common/promise-util';
 import { QuickPickItemOrSeparator, QuickPickService } from '@theia/core/lib/common/quick-pick-service';
@@ -383,7 +383,7 @@ export class TaskService implements TaskConfigurationClient {
     async getConfiguredTasks(token: number): Promise<TaskConfiguration[]> {
         const invalidTaskConfig = this.taskConfigurations.getInvalidTaskConfigurations()[0];
         if (invalidTaskConfig) {
-            const widget = <ProblemWidget>await this.widgetManager.getOrCreateWidget(PROBLEMS_WIDGET_ID);
+            const widget = await this.widgetManager.getOrCreateWidget(PROBLEMS_WIDGET_ID) as ProblemWidget;
             const isProblemsWidgetVisible = widget && widget.isVisible;
             const currentEditorUri = this.editorManager.currentEditor && this.editorManager.currentEditor.editor.getResourceUri();
             let isInvalidTaskConfigFileOpen = false;
@@ -862,6 +862,9 @@ export class TaskService implements TaskConfigurationClient {
             await this.removeProblemMarkers(option);
             return this.runResolvedTask(taskToRun, option);
         } catch (error) {
+            if (isCancelled(error)) {
+                return undefined;
+            }
             const errMessage = `Error resolving task '${task.label}': ${error}`;
             this.logger.error(errMessage);
         }
@@ -1083,7 +1086,7 @@ export class TaskService implements TaskConfigurationClient {
         const selectedText: string = this.editorManager.currentEditor.editor.document.getText(selectedRange).trimRight() + '\n';
         let terminal = this.terminalService.lastUsedTerminal;
         if (!terminal || terminal.kind !== 'user' || (await terminal.hasChildProcesses())) {
-            terminal = <TerminalWidget>await this.terminalService.newTerminal(<TerminalWidgetFactoryOptions>{ created: nextTerminalCreationToken() });
+            terminal = await this.terminalService.newTerminal(<TerminalWidgetFactoryOptions>{ created: nextTerminalCreationToken() }) as TerminalWidget;
             await terminal.start();
             this.terminalService.open(terminal);
         }

package/src/node/task-server.slow-spec.ts

@@ -14,7 +14,6 @@
 // SPDX-License-Identifier: EPL-2.0 OR GPL-2.0-only WITH Classpath-exception-2.0
 // *****************************************************************************
 
-// tslint:disable-next-line:no-implicit-dependencies
 import 'reflect-metadata';
 import { createTaskTestContainer } from './test/task-test-container';
 import { BackendApplication } from '@theia/core/lib/node/backend-application';